Re: [racket-dev] internal definitions stepper

2010-10-20 Thread Michael Sperber

Robby Findler ro...@eecs.northwestern.edu writes:

 Number 2 probably changed a while back when signatures were
 introduced, I'd guess. That one is not so easy to roll back.

I specifically fixed this at some point - it may also be related to the
namespace changes.  I'll try to look at it later today, but can't make
any promises - I'm pretty swamped today and tomorrow.

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev


[racket-dev] internal definitions stepper

2010-10-19 Thread Robby Findler
How recently did the change come in that allows internal definitions
all over the place? And how broken did this make the stepper?

(Ie is it feasible to wait for the next release? and should we?)

Robby

On Tue, Oct 19, 2010 at 5:03 AM,  sper...@racket-lang.org wrote:
 sperber has updated `master' from ddca8cd29b to fd5e9d4d63.
  http://git.racket-lang.org/plt/ddca8cd29b..fd5e9d4d63

 =[ 1 Commits ]==

 Directory summary:
  100.0% collects/test-engine/

 ~~

 fd5e9d4 Mike Sperber sper...@deinprogramm.de 2010-10-19 11:56:24 +0200
 :
 | Unbreak the stepper on `check-expect'.
 |
 | All kinds of things expand into (let () ...), so all kinds of things
 | break.
 :
  M collects/test-engine/racket-tests.rkt |    2 +-

 =[ Overall Diff ]===

 collects/test-engine/racket-tests.rkt
 ~
 --- OLD/collects/test-engine/racket-tests.rkt
 +++ NEW/collects/test-engine/racket-tests.rkt
 @@ -106,7 +106,7 @@
                                            #'test-engine
              'stepper-skipto
              (append skipto/third ;; let
 -                     skipto/third skipto/second ;; unless (it expands into a 
 begin)
 +                     skipto/third skipto/third ;; unless (it expands into 
 (if (let-values () ...))
                      skipto/cdr skipto/third ;; application of insert-test
                      '(syntax-e cdr cdr syntax-e car) ;; lambda
                      )))

_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev

Re: [racket-dev] internal definitions stepper

2010-10-19 Thread Michael Sperber

Robby Findler ro...@eecs.northwestern.edu writes:

 How recently did the change come in that allows internal definitions
 all over the place? And how broken did this make the stepper?

Pretty broken: There are now (let () ...)s all over the place.

(I've sent separate e-mail to John and Matthew.)

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla
_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev


Re: [racket-dev] internal definitions stepper

2010-10-19 Thread John Clements

On Oct 19, 2010, at 5:33 AM, Michael Sperber wrote:

 
 Robby Findler ro...@eecs.northwestern.edu writes:
 
 How recently did the change come in that allows internal definitions
 all over the place? And how broken did this make the stepper?
 
 Pretty broken: There are now (let () ...)s all over the place.
 
 (I've sent separate e-mail to John and Matthew.)

? I don't see that e-mail.  That may not be important.

Re: fixing stepper failures: I'm guessing that these failures have been hidden 
by the test-only bug that's prevented the drdr tests from running on the 
stepper for the last week.  I'm hoping that the build that's currently 
preventing me from typing rapidly will also allow me to run the main test suite 
manually and see what's broken.

John



smime.p7s
Description: S/MIME cryptographic signature
_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev

Re: [racket-dev] internal definitions stepper

2010-10-19 Thread John Clements

On Oct 19, 2010, at 8:56 AM, John Clements wrote:

 
 On Oct 19, 2010, at 5:33 AM, Michael Sperber wrote:
 
 
 Robby Findler ro...@eecs.northwestern.edu writes:
 
 How recently did the change come in that allows internal definitions
 all over the place? And how broken did this make the stepper?
 
 Pretty broken: There are now (let () ...)s all over the place.
 
 (I've sent separate e-mail to John and Matthew.)
 
 ? I don't see that e-mail.  That may not be important.
 
 Re: fixing stepper failures: I'm guessing that these failures have been 
 hidden by the test-only bug that's prevented the drdr tests from running on 
 the stepper for the last week.  I'm hoping that the build that's currently 
 preventing me from typing rapidly will also allow me to run the main test 
 suite manually and see what's broken.

Pflug. The two flavors of test suite (command-line and interactive) are broken 
in *different* ways as a result of recent changes to the testing engine.  

In the interest of getting this fixed quickly, I'm going to describe these, 
just in case anyone has suggestions.

1) The command-line tests fail like this:

   given: #(struct:error-result require: namespace mismatch; reference (phase 
0) to a module \/Users/clements/plt/collects/test-engine/racket-tests.rkt\ 
that is not available (phase level 0) in: test)

When I attach the test-engine/racket-tests module to the user's namespace, 
these failures turn into:

   given: #(struct:error-result link: module mismatch, probably from old 
bytecode whose dependencies have changed: variable not provided (directly or 
indirectly) from module: 
\/Users/clements/plt/collects/test-engine/racket-tests.rkt\ accessed from 
module: 'stepper-module-name-762 at source phase level: 0 in: test)

This module does appear to provide a macro called 'test', so ... I'm not sure 
how to interpret this message. It doesn't look like something I can solve by 
re-running raco setup.

(FWIW, for those of you with deja vu, yes: this is the same question I cc:'ed 
to plt-dev before.)

2) The interactive tests fail like this:

   given: #(struct:error-result namespace-variable-value: test~object is not 
defined)

I haven't worked on this one yet... but it looks like this is also something 
that was added this month.

John



smime.p7s
Description: S/MIME cryptographic signature
_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev

Re: [racket-dev] internal definitions stepper

2010-10-19 Thread John Clements

On Oct 19, 2010, at 10:02 AM, John Clements wrote:

 
 2) The interactive tests fail like this:
 
   given: #(struct:error-result namespace-variable-value: test~object is not 
 defined)
 
 I haven't worked on this one yet... but it looks like this is also something 
 that was added this month.

Per a discussion with Robby, it turns out to be *apparently* sufficient to 
define a binding in the 
testing namespace that associates test~object with #f. 

Kathy, can you confirm that the test-engine code is always happy with a value 
of #f for test~object?

John



smime.p7s
Description: S/MIME cryptographic signature
_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev

Re: [racket-dev] internal definitions stepper

2010-10-19 Thread John Clements
Okay, here's what seems to be broken:

1) cond, as Mike observed. This is related to the different expansion of cond.
2) make-foo, where foo is a user-defined structure.  There's a mysterious extra 
false that's showing up.
3) reduction of (cons 1 (cons 2 empty)) in beginner only.
4) local structures.

Apparently, all of this (except for #4) changed in the last week :).

John



smime.p7s
Description: S/MIME cryptographic signature
_
  For list-related administrative tasks:
  http://lists.racket-lang.org/listinfo/dev