Re: Review Request 69677: RANGER-2287: Improve and optimize db_setup.py file code

2019-01-11 Thread Zsombor Gegesy
> On Jan. 8, 2019, 11:48 a.m., Zsombor Gegesy wrote: > > It's great news, that you could delete thousands of lines of repetitive > > code, however you could achieve more, if instead of putting everything into > > one class, and put > > ''' > > if self.XA_DB_FLAVOR == DB_MYSQL: > >... > >

[jira] [Resolved] (RANGER-2319) Remove deprecated phantomjs NPM package

2019-01-11 Thread Zsombor Gegesy (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy resolved RANGER-2319. Resolution: Fixed Fix Version/s: 2.0.0 Thanks for the patch, applied to

[jira] [Updated] (RANGER-2320) Make db schema patches script idempotent for all DB Flavors

2019-01-11 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal updated RANGER-2320: Attachment: 0001-RANGER-2320-Make-db-schema-patches-script-idempotent.patch > Make db

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-11 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740264#comment-16740264 ] Pradeep Agrawal commented on RANGER-2255: - [~Koncz] It will be okay to make JS Tests run

[jira] [Commented] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-11 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740238#comment-16740238 ] Csaba Koncz commented on RANGER-2321: - The attached patch builds on RANGER-2319, which has not been

[jira] [Updated] (RANGER-2321) Docker build fails due to PhantomJS dependency

2019-01-11 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Koncz updated RANGER-2321: Attachment: 0001-RANGER-2321-Docker-build-fails-due-to-PhantomJS-depe.patch > Docker build fails