[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-16 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1672#comment-1672 ] Csaba Koncz commented on RANGER-2255: - RANGER-2321 was merged. However, it does not exactly act as

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-11 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740264#comment-16740264 ] Pradeep Agrawal commented on RANGER-2255: - [~Koncz] It will be okay to make JS Tests run

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-10 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739227#comment-16739227 ] Csaba Koncz commented on RANGER-2255: - Reverted the patch belonging to RANGER-2319 to its original

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-09 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738293#comment-16738293 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal]: updated the review at

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-09 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738135#comment-16738135 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal]: my change does not add any functionality,

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-08 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737854#comment-16737854 ] Pradeep Agrawal commented on RANGER-2255: - [~Koncz] : Can we revert the patch if there are no

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737025#comment-16737025 ] Csaba Koncz commented on RANGER-2255: - [~pradeep.agrawal], I noticed that two Phantomjs versions are

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-08 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736938#comment-16736938 ] Csaba Koncz commented on RANGER-2255: - Sorry [~pradeep.agrawal], I was not aware of the dependency

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2019-01-08 Thread Pradeep Agrawal (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736884#comment-16736884 ] Pradeep Agrawal commented on RANGER-2255: - [~Koncz]/Zsombor Gegesy: Build is failing for me with

[jira] [Commented] (RANGER-2255) Add JavaScript unit tests

2018-10-17 Thread Csaba Koncz (JIRA)
[ https://issues.apache.org/jira/browse/RANGER-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654137#comment-16654137 ] Csaba Koncz commented on RANGER-2255: - Added JavaScript testing infrastructure (Karma, Mocha,