Zsombor Gegesy created RANGER-1991: -------------------------------------- Summary: Fix problems detected by static code analysis Key: RANGER-1991 URL: https://issues.apache.org/jira/browse/RANGER-1991 Project: Ranger Issue Type: Bug Components: admin Affects Versions: 0.7.1 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy
FindBugs/SpotBug detects a couple of problems with the code base: * Incorrect class casting - in XXServiceDef.equals * Unnecessary NPE checks - for variables which is known to be non-null (for example, because in other places a method is called on that object). In ServiceREST.java PublicAPIs.java, ServiceUtil.java and independently in XUserMgr.java * Collection.contains method call which is never true - in ServiceDBStore.validatePolicyItems for policyItem.getAccesses().contains("") - because getAccesses doesn't store String objects * Making public partially initialized objects in HadoopConfigHolder.initResourceMap() * Calling toString on array, which is not too readable -- This message was sent by Atlassian JIRA (v7.6.3#76005)