Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224929 --- Ship it! Ship It! - Madhan Neethiraj On Nov. 29, 2022,

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Nov. 29, 2022, 10:52 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Nov. 18, 2022, 6:02 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/AllRangerUserStoreRetrievers.java > > Lines 59 (patched) > > > > > >

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Nov. 29, 2022, 5 a.m., Madhan Neethiraj wrote: > > Thank you for your comments, as always! > On Nov. 29, 2022, 5 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/AllRangerUserStoreRetrievers.java > > Lines 39

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224914 ---

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Nov. 28, 2022, 9:45 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Nov. 18, 2022, 6:02 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/AllRangerUserStoreRetrievers.java > > Lines 59 (patched) > > > > > >

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224887 ---

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Nov. 18, 2022, 5:45 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 25, 2022, 7:43 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/RangerExternalUserStoreRetriever.java > > Lines 56 (patched) > > > > > >

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Nov. 18, 2022, 12:29 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/AllRangerUserStoreRetrievers.java > > Lines 66 (patched) > > > > > >

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224885 ---

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Nov. 17, 2022, 9:15 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 15, 2022, 4:17 p.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalUserStoreRetrievers/GetBearerToken.java > > Lines 44 (patched) > > > > > > Yes,

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Nov. 3, 2022, 5:36 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Nov. 2, 2022, 8:18 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 25, 2022, 7:43 a.m., Madhan Neethiraj wrote: > > Did you really mean to remove writeToFile() and encodeSecrets() from the project? I understand moving most of the HandleSecrets methods to getFromURL, but don't we want to give folks the tools to easily write to file secrets that

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224827 ---

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/ --- (Updated Oct. 21, 2022, 9:09 p.m.) Review request for ranger and madhan.

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

- Barbara --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224760 --- On Sept. 26, 2022, 7:17 p.m., Barbara Eckman wrote: >

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

- Barbara --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224759 --- On Sept. 26, 2022, 7:17 p.m., Barbara Eckman wrote: >

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 7, 2022, 1:21 a.m., Madhan Neethiraj wrote: > > Thanks a lot, Madhan, for your comments! > On Oct. 7, 2022, 1:21 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalUserStoreRetrievers/GetBearerToken.java > > Lines 48

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 7, 2022, 1:30 a.m., Don Bosco Durai wrote: > > Thanks a lot, Bosco, for your meticulous comments! I did a lot of refactoring, to replace unirest with apache httpclient, and to bubble exceptions upward. I welcome your feedback as always! > On Oct. 7, 2022, 1:30 a.m., Don Bosco

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224797 ---

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 7, 2022, 1:30 a.m., Don Bosco Durai wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalUserStoreRetrievers/GetBearerToken.java > > Lines 44 (patched) > > > > > > Does

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

> On Oct. 7, 2022, 1:21 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalUserStoreRetrievers/GetBearerToken.java > > Lines 19 (patched) > > > > > > By

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224760 ---

Re: Review Request 74142: RangerExternalUserStoreRetriever class Ranger-3855

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74142/#review224759 ---