---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/#review180006
---
Ship it!
Ship It!
- Velmurugan Periasamy
On June 22, 2017,
> On June 13, 2017, 12:20 p.m., Colm O hEigeartaigh wrote:
> > Ship It!
>
> Colm O hEigeartaigh wrote:
> Actually, is it feasible to add some unit tests for this?
Thanks Colm, added unit tests.
- Ankita
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/
---
(Updated June 22, 2017, 1:50 p.m.)
Review request for ranger, Don Bosco Durai,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/
---
(Updated June 13, 2017, 12:06 p.m.)
Review request for ranger, Don Bosco
- Ankita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/#review177725
---
On June 13, 2017, 12:06 p.m., Ankita Sinha wrote:
>
>
> On June 13, 2017, 10:31 a.m., Colm O hEigeartaigh wrote:
> > Instead of calling Pattern.compile for each check, it's better to make the
> > Pattern static + call Pattern.compile once, as the regex itself is static
> > and doesn't change.
Thanks, Updated the review request.
- Ankita
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60043/#review177725
---
Instead of calling Pattern.compile for each check, it's better to
