Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On Oct. 24, 2017, 10:24 a.m., Nitin Galave wrote: > > security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js > > Lines 85 (patched) > > > > > > I think adding individual conditions for the components

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On Oct. 24, 2017, 10:24 a.m., Nitin Galave wrote: > > security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js > > Lines 85 (patched) > > > > > > I think adding individual conditions for the components

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review189038 ---

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On 十月 24, 2017, 8:30 a.m., pengjianhua wrote: > > Please rebuild the patch. > > error: patch failed: > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js:446 > > error: > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js: > > patch does not apply

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/ --- (Updated 十月 24, 2017, 9:02 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review189032 --- Please rebuild the patch. error: patch failed:

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review188933 --- Ship it! Ship It! - pengjianhua On 十月 23, 2017, 9 a.m.,

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review188931 --- Ship it! Ship It! - Colm O hEigeartaigh On Oct. 23, 2017, 9

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On 十月 20, 2017, 3:48 p.m., Colm O hEigeartaigh wrote: > > Looks good thanks. Just three more changes: > > > > a) Add a "hover over" hint for "Sqoop URL" in the Admin Console (e.g. > > should be "http://localhost:12000;) > > b) Remove "password" from the UI as it's not used > > c) Remove

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review188844 --- Looks good thanks. Just three more changes: a) Add a "hover

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/ --- (Updated 十月 20, 2017, 7:16 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On 十月 16, 2017, 12:51 p.m., Colm O hEigeartaigh wrote: > > In addition to comment above, here are some initial remarks: > > > > a) We should update to 1.99.7 as it is the latest version > > b) getLinkList/getJobList are not implemented in SqoopClient. > > c) There is a problem with the Sqoop

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On 十月 12, 2017, 3:33 p.m., Colm O hEigeartaigh wrote: > > I think there is a problem with the installation scripts. The lib and conf > > dirs are defined as: > > > > HCOMPONENT_LIB_DIR=${HCOMPONENT_INSTALL_DIR}/server/webapps/sqoop/WEB-INF/lib > >

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review188127 --- In addition to comment above, here are some initial remarks: a)

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On 十月 2, 2017, 6:13 p.m., Alejandro Fernandez wrote: > > plugin-sqoop/scripts/install.properties > > Lines 39 (patched) > > > > > > Should all of these commented lines be removed? These commented lines should not

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On 十月 2, 2017, 6:46 p.m., Ramesh Mani wrote: > > plugin-sqoop/src/main/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizer.java > > Lines 99 (patched) > > > > > > can privilege be null? Is

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/ --- (Updated 十月 12, 2017, 9:02 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review186865 ---

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

> On Oct. 2, 2017, 6:13 p.m., Alejandro Fernandez wrote: > > Awesome contribution. - Alejandro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review186860

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/#review186860 --- plugin-sqoop/scripts/install.properties Lines 39 (patched)

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/ --- (Updated Sept. 30, 2017, 8:34 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/ --- (Updated Sept. 30, 2017, 8:17 a.m.) Review request for ranger, Ankita Sinha,

Review Request 62710: RANGER-1810:Ranger supports plugin to enable, monitor and manage apache Sqoop2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62710/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh,