Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

2017-12-07 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63575/#review193113 --- Ship it! Ship It! - Velmurugan Periasamy On Nov. 6, 2017,

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

2017-11-08 Thread Zsombor Gegesy
> On Nov. 7, 2017, 9:09 a.m., Mehul Parikh wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java > > Line 198 (original), 185 (patched) > > > > > > @Zsombor : Can you please confirm if you have

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

2017-11-08 Thread Zsombor Gegesy
> On Nov. 7, 2017, 12:06 p.m., Velmurugan Periasamy wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java > > Line 144 (original), 143 (patched) > > > > > > Can you please clarify this assertion

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

2017-11-07 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63575/#review190293 --- kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java

Re: Review Request 63575: RANGER-1873: Fix property handling in RangerKMSDB

2017-11-07 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63575/#review190276 --- kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSDB.java