Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2022-03-07 Thread Sailaja Polavarapu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73677/#review224145 --- ugsync/src/main/java/org/apache/ranger/unixusersync/process/Polic

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-12-10 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73677/ --- (Updated Dec. 10, 2021, 4 p.m.) Review request for ranger. Repository: ranger

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-12-08 Thread Sailaja Polavarapu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73677/#review223819 --- ugsync/src/main/java/org/apache/ranger/unixusersync/process/Polic

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-12-08 Thread Sailaja Polavarapu
> On Nov. 22, 2021, 10:35 p.m., Abhishek Kumar wrote: > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > > Lines 919 (patched) > > > > > > Why is max required here ? >

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-12-03 Thread David Mollitor
> On Nov. 22, 2021, 10:35 p.m., Abhishek Kumar wrote: > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > > Lines 919 (patched) > > > > > > Why is max required here ? >

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-11-22 Thread David Mollitor
> On Nov. 22, 2021, 10:35 p.m., Abhishek Kumar wrote: > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > > Lines 919 (patched) > > > > > > Why is max required here ? He

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-11-22 Thread Abhishek Kumar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73677/#review223761 --- Also, I believe a similar change would be required for getGroups,

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-11-22 Thread David Mollitor
> On Nov. 16, 2021, 5:28 a.m., Abhishek Kumar wrote: > > The jira number tagged in the review does not appear to be associated with > > the code change. > > Please open a new jira and tag the review with it. Hello. My appologies. I have no idea how I managed to do that. I have updated the

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

2021-11-22 Thread David Mollitor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73677/ --- (Updated Nov. 22, 2021, 9:40 p.m.) Review request for ranger. Summary (update