Review Request 56588: There is Page not found (404) error when clicking Admin tab in Audit.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56588/ --- Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-1378 https://issues.apache.org/jira/browse/RANGER-1378 Repository: ranger Description --- There is Page not found (404) error when clicking Admin tab in Audit. Wrong reason: There is no vx_trx_log table in ranger database. Diffs - security-admin/src/main/java/org/apache/ranger/entity/view/VXXTrxLog.java 28d6f03 Diff: https://reviews.apache.org/r/56588/diff/ Testing --- Thanks, Qiang Zhang
Re: Review Request 56567: RANGER-1375: HIVERangerAuthorizerTest UT fails intermittently
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56567/#review165289 --- Ship it! Ship It! - Velmurugan Periasamy On Feb. 11, 2017, 12:42 a.m., Sailaja Polavarapu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56567/ > --- > > (Updated Feb. 11, 2017, 12:42 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan > Periasamy. > > > Bugs: RANGER-1375 > https://issues.apache.org/jira/browse/RANGER-1375 > > > Repository: ranger > > > Description > --- > > Moved hive config to enable ranger authorization after the initial db setup > and table creating is done. This will avoid going through ranger > authorization for initial setup. > > > Diffs > - > > > hive-agent/src/test/java/org/apache/ranger/services/hive/HIVERangerAuthorizerTest.java > 9b22794 > > Diff: https://reviews.apache.org/r/56567/diff/ > > > Testing > --- > > 1. Commented out the authorization config block of code and ran the unit > tests and all the tests failed because of no permissions on hive side. This > is to confirm that hive config can be dynamically updated without restarting > hiveserver. > 2. To confirm that the DB creation in setup method is going through Ranger > authorization – For testing this, keeping the ranger authorization config > block as it is before hiverserver startup, changed the username to “admin1” > instead of “admin” in the connection url for create db statement. With this > the setup failed saying "admin1" has no permissions to create db and the > stack trace shows ranger authorization. > 3. Moving the ranger authorization config block after creating DB and > creating basic tables, the setup was successful even with “admin1” as the > user for creating DB connection url. > > > Thanks, > > Sailaja Polavarapu > >
Re: Review Request 55256: RANGER-1289:Error occured in Ranger KMS function
> On 二月 10, 2017, 10:12 a.m., Colm O hEigeartaigh wrote:
> > As part of this patch, please also change the httpmime version to 4.5.3 for
> > consistency. Also, the httpcore dependency should be changed to 4.4.6, as
> > this is the version that is associated with httpclient 4.5.3.
[~Colm O hEigeartaigh],thanks!
I have done.
- Qiang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55256/#review165093
---
On 二月 13, 2017, 2:23 a.m., Qiang Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55256/
> ---
>
> (Updated 二月 13, 2017, 2:23 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani,
> Selvamohan Neethiraj, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-1289
> https://issues.apache.org/jira/browse/RANGER-1289
>
>
> Repository: ranger
>
>
> Description
> ---
>
> Steps:
> 1.Start ranger-kms service
> 2.Configure KMS Client and restart hdfs
> 3.Create a key named key0 in the Ranger Web UI
> 4.Execute the following command in hadoop environment,create an encrypted zone
> [xhh@zdh41 ~]$hdfs dfs -mkdir /keyZone
> [xhh@zdh41 ~]$hdfs crypto -createZone -keyName key0 -path /keyZone
>
>
> Error message poped out as below:
> ranger-0.7.0-SNAPSHOT-kms/ews/logs/kms.log
>
> 2017-01-04 14:27:13,256 ERROR [webservices-driver] - Servlet.service() for
> servlet [webservices-driver] in context with path [/kms] threw exception
> java.lang.NullPointerException
> at
> org.apache.http.client.utils.URLEncodedUtils.parse(URLEncodedUtils.java:235)
> at
> org.apache.hadoop.security.token.delegation.web.ServletUtils.getParameter(ServletUtils.java:48)
> at
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationHandler.managementOperation(DelegationTokenAuthenticationHandler.java:171)
> at
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:514)
> at
> org.apache.hadoop.crypto.key.kms.server.KMSAuthenticationFilter.doFilter(KMSAuthenticationFilter.java:129)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:956)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436)
> at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078)
> at
> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:625)
> at
> org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
>
> I analyzed the reasons,Ranger-Kms relies on httpclient version 4.5.1, there
> is a bug, as follows:
> org/apache/http/client/utils/URLEncodedUtils.java
> {code:java}
> public static List parse(String s, Charset charset) {
> CharArrayBuffer buffer = new CharArrayBuffer(s.length());
> buffer.append(s);
> return parse(buffer, charset, new char[]{'&', ';'});
> }
> {code}
> When the parameter 's' is null, it will pop out NullPointException.
> And in httpclient version 4.5.3, there is no problem. the new code is as
> follows:
> {code:java}
> public static List parse(final String s, final Charset
> charset) {
> if (s == null) {
> return Collections.emptyList();
> }
> final CharArrayBuffer buffer = new CharArrayBuffer(s.length());
> buffer.append(s);
> return parse(buffer, charset, QP_SEP_A, QP_SEP_S);
> }
> {code}
>
>
> Diffs
> -
>
> pom.xml 19caacd
>
> Diff: https://reviews.apache.org/r/55256/diff/
>
>
>
Re: Review Request 55256: RANGER-1289:Error occured in Ranger KMS function
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55256/
---
(Updated 二月 13, 2017, 2:23 a.m.)
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani,
Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1289
https://issues.apache.org/jira/browse/RANGER-1289
Repository: ranger
Description
---
Steps:
1.Start ranger-kms service
2.Configure KMS Client and restart hdfs
3.Create a key named key0 in the Ranger Web UI
4.Execute the following command in hadoop environment,create an encrypted zone
[xhh@zdh41 ~]$hdfs dfs -mkdir /keyZone
[xhh@zdh41 ~]$hdfs crypto -createZone -keyName key0 -path /keyZone
Error message poped out as below:
ranger-0.7.0-SNAPSHOT-kms/ews/logs/kms.log
2017-01-04 14:27:13,256 ERROR [webservices-driver] - Servlet.service() for
servlet [webservices-driver] in context with path [/kms] threw exception
java.lang.NullPointerException
at
org.apache.http.client.utils.URLEncodedUtils.parse(URLEncodedUtils.java:235)
at
org.apache.hadoop.security.token.delegation.web.ServletUtils.getParameter(ServletUtils.java:48)
at
org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationHandler.managementOperation(DelegationTokenAuthenticationHandler.java:171)
at
org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:514)
at
org.apache.hadoop.crypto.key.kms.server.KMSAuthenticationFilter.doFilter(KMSAuthenticationFilter.java:129)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
at
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
at
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:956)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436)
at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:625)
at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:745)
I analyzed the reasons,Ranger-Kms relies on httpclient version 4.5.1, there is
a bug, as follows:
org/apache/http/client/utils/URLEncodedUtils.java
{code:java}
public static List parse(String s, Charset charset) {
CharArrayBuffer buffer = new CharArrayBuffer(s.length());
buffer.append(s);
return parse(buffer, charset, new char[]{'&', ';'});
}
{code}
When the parameter 's' is null, it will pop out NullPointException.
And in httpclient version 4.5.3, there is no problem. the new code is as
follows:
{code:java}
public static List parse(final String s, final Charset charset) {
if (s == null) {
return Collections.emptyList();
}
final CharArrayBuffer buffer = new CharArrayBuffer(s.length());
buffer.append(s);
return parse(buffer, charset, QP_SEP_A, QP_SEP_S);
}
{code}
Diffs (updated)
-
pom.xml 19caacd
Diff: https://reviews.apache.org/r/55256/diff/
Testing
---
[xhh@zdh41 ~]$ hadoop key list -metadata
17/02/10 16:20:48 WARN util.NativeCodeLoader: Unable to load native-hadoop
library for your platform... using builtin-java classes where applicable
Listing keys for KeyProvider: KMSClientProvider[http://zdh41:9292/kms/v1/]
key0 : cipher: AES/CTR/NoPadding, length: 128, description: , created: Thu Feb
09 09:56:51 CST 2017, version: 1, attributes: [key.acl.name=key0]
Thanks,
Qiang Zhang
[jira] [Updated] (RANGER-1289) Error occured in Ranger KMS function
[
https://issues.apache.org/jira/browse/RANGER-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiang Zhang updated RANGER-1289:
Attachment: (was:
0001-RANGER-1289-Error-occured-in-Ranger-KMS-function.patch)
> Error occured in Ranger KMS function
>
>
> Key: RANGER-1289
> URL: https://issues.apache.org/jira/browse/RANGER-1289
> Project: Ranger
> Issue Type: Bug
> Components: kms
>Affects Versions: 0.7.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Labels: patch
> Attachments:
> 0001-RANGER-1289-Error-occured-in-Ranger-KMS-function.patch
>
>
> Steps:
> 1.Start ranger-kms service
> 2.Configure KMS Client and restart hdfs
> 3.Create a key named key0 in the Ranger Web UI
> 4.Execute the following command in hadoop environment,create an encrypted zone
> {code:java}
> hdfs dfs -mkdir /keyZone
> hdfs crypto -createZone -keyName key0 -path /keyZone
> {code}
> Error message poped out as below:
> ranger-0.7.0-SNAPSHOT-kms/ews/logs/kms.log
> {code:java}
> 2017-01-04 14:27:13,256 ERROR [webservices-driver] - Servlet.service() for
> servlet [webservices-driver] in context with path [/kms] threw exception
> java.lang.NullPointerException
> at
> org.apache.http.client.utils.URLEncodedUtils.parse(URLEncodedUtils.java:235)
> at
> org.apache.hadoop.security.token.delegation.web.ServletUtils.getParameter(ServletUtils.java:48)
> at
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationHandler.managementOperation(DelegationTokenAuthenticationHandler.java:171)
> at
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:514)
> at
> org.apache.hadoop.crypto.key.kms.server.KMSAuthenticationFilter.doFilter(KMSAuthenticationFilter.java:129)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:956)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436)
> at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078)
> at
> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:625)
> at
> org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> I analyzed the reasons,Ranger-Kms relies on httpclient version 4.5.1, there
> is a bug, as follows:
> org/apache/http/client/utils/URLEncodedUtils.java
> {code:java}
> public static List parse(String s, Charset charset) {
> CharArrayBuffer buffer = new CharArrayBuffer(s.length());
> buffer.append(s);
> return parse(buffer, charset, new char[]{'&', ';'});
> }
> {code}
> When the parameter 's' is null, it will pop out NullPointException.
> And in httpclient version 4.5.3, there is no problem. the new code is as
> follows:
> {code:java}
> public static List parse(final String s, final Charset
> charset) {
> if (s == null) {
> return Collections.emptyList();
> }
> final CharArrayBuffer buffer = new CharArrayBuffer(s.length());
> buffer.append(s);
> return parse(buffer, charset, QP_SEP_A, QP_SEP_S);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1289) Error occured in Ranger KMS function
[
https://issues.apache.org/jira/browse/RANGER-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiang Zhang updated RANGER-1289:
Attachment: 0001-RANGER-1289-Error-occured-in-Ranger-KMS-function.patch
> Error occured in Ranger KMS function
>
>
> Key: RANGER-1289
> URL: https://issues.apache.org/jira/browse/RANGER-1289
> Project: Ranger
> Issue Type: Bug
> Components: kms
>Affects Versions: 0.7.0
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
> Labels: patch
> Attachments:
> 0001-RANGER-1289-Error-occured-in-Ranger-KMS-function.patch
>
>
> Steps:
> 1.Start ranger-kms service
> 2.Configure KMS Client and restart hdfs
> 3.Create a key named key0 in the Ranger Web UI
> 4.Execute the following command in hadoop environment,create an encrypted zone
> {code:java}
> hdfs dfs -mkdir /keyZone
> hdfs crypto -createZone -keyName key0 -path /keyZone
> {code}
> Error message poped out as below:
> ranger-0.7.0-SNAPSHOT-kms/ews/logs/kms.log
> {code:java}
> 2017-01-04 14:27:13,256 ERROR [webservices-driver] - Servlet.service() for
> servlet [webservices-driver] in context with path [/kms] threw exception
> java.lang.NullPointerException
> at
> org.apache.http.client.utils.URLEncodedUtils.parse(URLEncodedUtils.java:235)
> at
> org.apache.hadoop.security.token.delegation.web.ServletUtils.getParameter(ServletUtils.java:48)
> at
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationHandler.managementOperation(DelegationTokenAuthenticationHandler.java:171)
> at
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:514)
> at
> org.apache.hadoop.crypto.key.kms.server.KMSAuthenticationFilter.doFilter(KMSAuthenticationFilter.java:129)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
> at
> org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
> at
> org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:956)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:436)
> at
> org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1078)
> at
> org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:625)
> at
> org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:316)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> I analyzed the reasons,Ranger-Kms relies on httpclient version 4.5.1, there
> is a bug, as follows:
> org/apache/http/client/utils/URLEncodedUtils.java
> {code:java}
> public static List parse(String s, Charset charset) {
> CharArrayBuffer buffer = new CharArrayBuffer(s.length());
> buffer.append(s);
> return parse(buffer, charset, new char[]{'&', ';'});
> }
> {code}
> When the parameter 's' is null, it will pop out NullPointException.
> And in httpclient version 4.5.3, there is no problem. the new code is as
> follows:
> {code:java}
> public static List parse(final String s, final Charset
> charset) {
> if (s == null) {
> return Collections.emptyList();
> }
> final CharArrayBuffer buffer = new CharArrayBuffer(s.length());
> buffer.append(s);
> return parse(buffer, charset, QP_SEP_A, QP_SEP_S);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Affects Version/s: 0.7.0
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1377) Improve codestyle, java api usage
[
https://issues.apache.org/jira/browse/RANGER-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zsombor Gegesy updated RANGER-1377:
---
Fix Version/s: 1.0.0
> Improve codestyle, java api usage
> -
>
> Key: RANGER-1377
> URL: https://issues.apache.org/jira/browse/RANGER-1377
> Project: Ranger
> Issue Type: Improvement
> Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Zsombor Gegesy
>Assignee: Zsombor Gegesy
> Labels: code-cleanup
> Fix For: 1.0.0
>
>
> There are several generally considered best practice writing Java code, it is
> better to follow them.
> Instead of:
> * var.equals("somestring") use "somestring".equals(var)
> * collection.size() > 0 use !collection.isEmpty()
> * instead of using a for loop to add items to a collection, use 'addAll'
> * str.indexOf("something") >= 0 use str.contains("something")
> * "" + var use String.valueOf(var)
> * stringBuilder.append("a" + b + "c") use
> stringBuilder.append("a").append(b).append("c")
> * "something "+ a.toString() use "something " + a
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Updated] (RANGER-1376) Several different jersey/jackson library is used
[ https://issues.apache.org/jira/browse/RANGER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zsombor Gegesy updated RANGER-1376: --- Attachment: 0001-RANGER-1376-Upgrade-jersey-to-1.19.3-and-trying-to-r.patch > Several different jersey/jackson library is used > > > Key: RANGER-1376 > URL: https://issues.apache.org/jira/browse/RANGER-1376 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: upgrade > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1376-Upgrade-jersey-to-1.19.3-and-trying-to-r.patch > > > It seems, that ranger currently use several different versions from the > jersey library: > * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) > * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, > sun.jersey.spring.version > * 1.9 - jersey-server.version > * 1.17.1 - jersey-bundle.version > This could cause incompatibilities and confusions - during development and > during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (RANGER-1376) Several different jersey/jackson library is used
[ https://issues.apache.org/jira/browse/RANGER-1376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862792#comment-15862792 ] Zsombor Gegesy commented on RANGER-1376: Review request : https://reviews.apache.org/r/56578/ > Several different jersey/jackson library is used > > > Key: RANGER-1376 > URL: https://issues.apache.org/jira/browse/RANGER-1376 > Project: Ranger > Issue Type: Improvement > Components: Ranger >Affects Versions: 0.7.0 >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy > Labels: upgrade > Fix For: 1.0.0 > > > It seems, that ranger currently use several different versions from the > jersey library: > * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) > * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, > sun.jersey.spring.version > * 1.9 - jersey-server.version > * 1.17.1 - jersey-bundle.version > This could cause incompatibilities and confusions - during development and > during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
Review Request 56578: [RANGER-1376] Upgrade jersey to 1.19.3 and trying to remove version duplication
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56578/ --- Review request for ranger. Bugs: RANGER-1376 https://issues.apache.org/jira/browse/RANGER-1376 Repository: ranger Description --- Pom files are fixed, to not inherit various jersey libraries from hadoop, and consistently use the latest jersey libraries. Diffs - kms/pom.xml 13c0b03a49f7c09a120349c56eff304598b4f62c pom.xml 19caacdcac0ac58e39ef7204fb873672aa15 security-admin/pom.xml 5a63cb95a687bada3bf38065a7a05922c520c29e Diff: https://reviews.apache.org/r/56578/diff/ Testing --- Thanks, Zsombor Gegesy
[jira] [Created] (RANGER-1376) Several different jersey/jackson library is used
Zsombor Gegesy created RANGER-1376: -- Summary: Several different jersey/jackson library is used Key: RANGER-1376 URL: https://issues.apache.org/jira/browse/RANGER-1376 Project: Ranger Issue Type: Improvement Components: Ranger Affects Versions: 0.7.0 Reporter: Zsombor Gegesy Assignee: Zsombor Gegesy Fix For: 1.0.0 It seems, that ranger currently use several different versions from the jersey library: * 1.19 - sun-jersey-bundle.version (also inherited from hadoop-common) * 1.4 - sun.jersey.bundle.version,sun.jersey.core.version, sun.jersey.spring.version * 1.9 - jersey-server.version * 1.17.1 - jersey-bundle.version This could cause incompatibilities and confusions - during development and during build, so it's worth to upgrade jersey, consistently to 1.19.3. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
