[jira] [Updated] (RANGER-1495) Good coding practices recommendation by static code analysis

2017-04-04 Thread Ramesh Mani (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ramesh Mani updated RANGER-1495:

Fix Version/s: master

> Good coding practices recommendation by static code analysis
> 
>
> Key: RANGER-1495
> URL: https://issues.apache.org/jira/browse/RANGER-1495
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.7.1
>Reporter: Ramesh Mani
>Assignee: Ramesh Mani
> Fix For: master, 0.7.1
>
>
> Good coding practices recommendation by static code analysis



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 58184: [RANGER-1497]Improvement of unit test coverage for ranger

2017-04-04 Thread deepak sharma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58184/
---

Review request for ranger, Ankita Sinha and Mehul Parikh.


Bugs: RANGER-1497
https://issues.apache.org/jira/browse/RANGER-1497


Repository: ranger


Description
---

[RANGER-1497]Improvement of unit test coverage for ranger by adding the unit 
tests for org.apache.ranger.rest.AssetREST


Diffs
-

  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/58184/diff/1/


Testing
---

tested the Junit tests added locally.


Thanks,

deepak sharma

Re: Review Request 58165: RANGER-1495: Good coding practices recommendation by static code analysis

2017-04-04 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58165/#review171030
---


Fix it, then Ship it!





hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
Lines 407 (patched)


This patch is not applying on ranger-0.7 (applies on master though)

If you are planning to add this on 0.7.1, please fix and commit.

```
$ git apply --check -v < 
~/Downloads/0001-RANGER-1495-Good-coding-practices-recommedation-by-s.patch
Checking patch 
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java...
error: while searching for:
for (String tbl : tblList) {
try {
List hiveSch = 
hiveClient.getFields(db, tbl);
for (FieldSchema sch : hiveSch) 
{
String columnName = 
sch.getName();
if (colList != null && 
colList.contains(columnName)) {
continue;
}
if 
(columnNameMatchingRegEx == null) {

ret.add(columnName);
}
else if 
(FilenameUtils.wildcardMatch(columnName,columnNameMatchingRegEx)) {

ret.add(columnName);
}
}
} catch (TException e) {

error: patch failed: 
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java:404
error: 
hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java:
 patch does not apply
```


- Velmurugan Periasamy


On April 4, 2017, 1:12 a.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58165/
> ---
> 
> (Updated April 4, 2017, 1:12 a.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-1495
> https://issues.apache.org/jira/browse/RANGER-1495
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> RANGER-1495: Good coding practices recommendation by static code analysis
> 
> 
> Diffs
> -
> 
>   
> hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java
>  6cc62a7 
> 
> 
> Diff: https://reviews.apache.org/r/58165/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done in VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

[jira] [Created] (RANGER-1497) Improvement of unit test coverage for ranger

2017-04-04 Thread Deepak Sharma (JIRA) 
Deepak Sharma created RANGER-1497:
-

 Summary: Improvement of unit test coverage for ranger 
 Key: RANGER-1497
 URL: https://issues.apache.org/jira/browse/RANGER-1497
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Deepak Sharma
 Fix For: master, 0.7.1


Improvement of unit test coverage for ranger  by adding the unit tests for 
org.apache.ranger.rest.AssetREST.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (RANGER-1497) Improvement of unit test coverage for ranger

2017-04-04 Thread Deepak Sharma (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Sharma reassigned RANGER-1497:
-

Assignee: Deepak Sharma

> Improvement of unit test coverage for ranger 
> -
>
> Key: RANGER-1497
> URL: https://issues.apache.org/jira/browse/RANGER-1497
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Deepak Sharma
>Assignee: Deepak Sharma
> Fix For: master, 0.7.1
>
>
> Improvement of unit test coverage for ranger  by adding the unit tests for 
> org.apache.ranger.rest.AssetREST.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1484) RangerUI: Escape of policy condition text entered in the policy form.

2017-04-04 Thread Gautam Borad (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954604#comment-15954604
 ] 

Gautam Borad commented on RANGER-1484:
--

Committed to master: bdf0b61c0f6e109c2f4e0459676dda71f0265aeb
Committed to ranger-0.7 : ba664e1b310ae65b674ff28e0772d208d3b20464

> RangerUI: Escape of policy condition text entered in the policy form.
> -
>
> Key: RANGER-1484
> URL: https://issues.apache.org/jira/browse/RANGER-1484
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.7.0
>Reporter: Madhan Neethiraj
>Assignee: Nitin Galave
> Fix For: 1.0.0, 0.7.1
>
> Attachments: image001.png, image002.png, RANGER-1484.patch
>
>
> The text entered in policy condition UI comes back with escape characters 
> after saving the policy.
> {code}
> For example: 
> 1.create policy with policy condition as “tag.attributes['type']=='ccn'” .
> 2.Now open that policy in edit mode you will see policy condition 
> becomes "tag.attributes[type]==ccn".
> {code}
> Another issue is that UI displays policy conditions that don’t have any 
> value.Only the condition edit popup would list all the conditions; the policy 
> view would only list the conditions that have non-empty value.
> See attachments for more info: image001.png, image002.png.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)