Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values

2017-05-16 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/#review175199
---


Ship it!




Ship It!

- Madhan Neethiraj


On May 16, 2017, 9:17 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59296/
> ---
> 
> (Updated May 16, 2017, 9:17 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1581
> https://issues.apache.org/jira/browse/RANGER-1581
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger plugins interpret tag attributes of type 'date' using an internal 
> Ranger date-format string. Now, in addition to the internal Ranger 
> date-format string ("/MM/dd"), plugins also support a comma-separated 
> list of data-format strings, based on the value of the plugin configuration 
> parameter "ranger.plugin.tag.attr.additional.date.formats". A special value 
> string "ATLAS_DATE_FORMAT" is supported to refer to default date-format used 
> by Atlas.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
>  923c188 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
>  5948a74 
>   
> agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 
> 1c7662d 
> 
> 
> Diff: https://reviews.apache.org/r/59296/diff/2/
> 
> 
> Testing
> ---
> 
> Developed a unit test for testing specification and use of 
> "ranger.plugin.tag.attr.additional.date.formats" configuration variable.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Commented] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration

2017-05-16 Thread Yujie Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012762#comment-16012762
 ] 

Yujie Li commented on RANGER-1584:
--

Ambari is exporting an environment as RANGER_TAGSYNC_LOG_DIR for log dir. 
Ranger should read this first to work with Ambari configuration.

> Allow tagsync to support log directory from Ambari configuration
> 
>
> Key: RANGER-1584
> URL: https://issues.apache.org/jira/browse/RANGER-1584
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync
>Affects Versions: master, 0.7.1
>Reporter: Yujie Li
>Priority: Minor
> Attachments: 
> 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch
>
>
> Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It 
> doesn't support customization setting for log location from Ambari side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration

2017-05-16 Thread Yujie Li (JIRA) 
Yujie Li created RANGER-1584:


 Summary: Allow tagsync to support log directory from Ambari 
configuration
 Key: RANGER-1584
 URL: https://issues.apache.org/jira/browse/RANGER-1584
 Project: Ranger
  Issue Type: Bug
  Components: tagsync
Affects Versions: master, 0.7.1
Reporter: Yujie Li
Priority: Minor


Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It 
doesn't support customization settings for this log location from Ambari side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration

2017-05-16 Thread Yujie Li (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yujie Li updated RANGER-1584:
-
Attachment: 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch

> Allow tagsync to support log directory from Ambari configuration
> 
>
> Key: RANGER-1584
> URL: https://issues.apache.org/jira/browse/RANGER-1584
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync
>Affects Versions: master, 0.7.1
>Reporter: Yujie Li
>Priority: Minor
> Attachments: 
> 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch
>
>
> Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It 
> doesn't support customization setting for log location from Ambari side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1584) Allow tagsync to support log directory from Ambari configuration

2017-05-16 Thread Yujie Li (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yujie Li updated RANGER-1584:
-
Attachment: 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch

> Allow tagsync to support log directory from Ambari configuration
> 
>
> Key: RANGER-1584
> URL: https://issues.apache.org/jira/browse/RANGER-1584
> Project: Ranger
>  Issue Type: Bug
>  Components: tagsync
>Affects Versions: master, 0.7.1
>Reporter: Yujie Li
>Priority: Minor
> Attachments: 
> 0001-RANGER-1584-Allow-tagsync-to-support-log-directory-f.patch
>
>
> Currently Tagsync hardcodes the log directory as /var/log/ranger/tagsync. It 
> doesn't support customization setting for log location from Ambari side.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57868: Permissions tab pages display are not reasonable.https://issues.apache.org/jira/browse/RANGER-1411

2017-05-16 Thread Haihui Xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/
---

(Updated May 16, 2017, 1:47 p.m.)


Review request for ranger.


Bugs: RANGER-1411
https://issues.apache.org/jira/browse/RANGER-1411


Repository: ranger


Description
---

Navigate to Ranger Web UI's Settings Permissions tab, the permissions table 
header is Permissions,Groups,Users,Action. But the first column in the table is 
modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table 
header should be Modules,Groups,Users,Action.


Diffs
-

  security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
7a4b82c 
  
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js
 92c07c7 
  
security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html
 909d2fc 


Diff: https://reviews.apache.org/r/57868/diff/1/


Testing
---

Page Display, test ok.


File Attachments


RANGER-1411.patch
  
https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch


Thanks,

Haihui Xu

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Colm O hEigeartaigh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1411:

Fix Version/s: (was: 0.7.1)

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0
>
> Attachments: RANGER-1411-1.jpg, RANGER-1411.patch
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1572) Provide simple example of running ranger with docker

2017-05-16 Thread Nigel Jones (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012031#comment-16012031
 ] 

Nigel Jones commented on RANGER-1572:
-

the latest example on github will now correctly setup and start ranger to the 
point of being able to login to the admin UI
Continuing 

> Provide simple example of running ranger with docker
> 
>
> Key: RANGER-1572
> URL: https://issues.apache.org/jira/browse/RANGER-1572
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Nigel Jones
>Assignee: Nigel Jones
>
> When experimenting with Ranger it's very useful to be able to quickly run 
> ranger admin/solr/mysql
> Since I needed this for my education/experimentation I thought it might be 
> useful to others. Work in progress and doesn't work yet but raising this JIRA 
> in case anyone else has done the same, or is interested ;-)
> For now the code (just a few scripts) is at 
> https://github.com/planetf1/ranger-docker whilst I try and get this working. 
> Perhaps this could be added as an example down the line, or even used within 
> the build to create an image -- though there's lots of variables in terms of 
> config.
> As above.. not working yet ;-) WIP!



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haihui Xu updated RANGER-1411:
--
Description: 
1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions table  
header is Permissions,Groups,Users,Action. But the first column in the table is 
 modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table 
header should be Modules,Groups,Users,Action.



  was:
1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions table  
header is Permissions,Groups,Users,Action. But the first column in the table is 
 modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the table 
header should be Modules,Groups,Users,Action.
2.Web UI's Settings Permissions tab, click action to edit permission, and the 
page display bellow 'Edit Permission' is 'Policy Details' (0.6.3 version), 
'Module Details'(0.7.0 version ,1.0.0 version). The action is 'edit 
permission',so 'Permission Details' or 'Module Permission Details' may be more 
reasonable.



> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1141-2-0.6.3.jpg, RANGER-1141-2-0.7.0.jpg, 
> RANGER-1411-0.6.3.patch, RANGER-1411-0.7.0.patch, RANGER-1411-1.jpg
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haihui Xu updated RANGER-1411:
--
Attachment: (was: RANGER-1411-0.7.0.patch)

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1141-2-0.6.3.jpg, RANGER-1141-2-0.7.0.jpg, 
> RANGER-1411-0.6.3.patch, RANGER-1411-1.jpg
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011826#comment-16011826
 ] 

Haihui Xu commented on RANGER-1411:
---

Review Board  :https://reviews.apache.org/r/57868/

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1411-1.jpg
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haihui Xu updated RANGER-1411:
--
Attachment: (was: RANGER-1141-2-0.7.0.jpg)

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1411-1.jpg
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haihui Xu updated RANGER-1411:
--
Attachment: (was: RANGER-1411-0.6.3.patch)

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1141-2-0.7.0.jpg, RANGER-1411-1.jpg
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haihui Xu updated RANGER-1411:
--
Attachment: (was: RANGER-1141-2-0.6.3.jpg)

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1141-2-0.7.0.jpg, RANGER-1411-0.6.3.patch, 
> RANGER-1411-1.jpg
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1411) Permissions tab pages display are not reasonable

2017-05-16 Thread Haihui Xu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haihui Xu updated RANGER-1411:
--
Attachment: RANGER-1411.patch

> Permissions tab pages display are not reasonable
> 
>
> Key: RANGER-1411
> URL: https://issues.apache.org/jira/browse/RANGER-1411
> Project: Ranger
>  Issue Type: Bug
>  Components: admin, Ranger
>Affects Versions: 0.6.3
>Reporter: Haihui Xu
>Assignee: Haihui Xu
> Fix For: 1.0.0, 0.7.1
>
> Attachments: RANGER-1411-1.jpg, RANGER-1411.patch
>
>
> 1.Navigate to Ranger  Web UI's Settings Permissions tab, the permissions 
> table  header is Permissions,Groups,Users,Action. But the first column in the 
> table is  modules(Resource Based Policies,Users/Groups,Audits,Reports...). So 
> the table header should be Modules,Groups,Users,Action.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59275: RANGER-1580 - Update Kafka tests to work with 0.10.1.1

2017-05-16 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59275/
---

(Updated May 16, 2017, 12:20 p.m.)


Review request for ranger.


Bugs: RANGER-1580
https://issues.apache.org/jira/browse/RANGER-1580


Repository: ranger


Description
---

Right now, the Ranger Kafka tests hang with 0.10.1.1, as the authorizer needs 
the "describe" policy for the given principal + topic, even when the principal 
is not authorized to read the topic. Merging this update will smooth future 
migration.


Diffs (updated)
-

  plugin-kafka/pom.xml 3ef7eb98 
  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerSASLSSLTest.java
 2b0da34d 
  
plugin-kafka/src/test/java/org/apache/ranger/authorization/kafka/authorizer/KafkaRangerAuthorizerTest.java
 f68a1641 
  plugin-kafka/src/test/resources/kafka-policies.json d1609864 


Diff: https://reviews.apache.org/r/59275/diff/2/

Changes: https://reviews.apache.org/r/59275/diff/1-2/


Testing
---


Thanks,

Colm O hEigeartaigh

[jira] [Updated] (RANGER-1580) Update Kafka tests to work with 0.10.1.1

2017-05-16 Thread Colm O hEigeartaigh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1580:

Attachment: 0001-RANGER-1580-Update-Kafka-tests-to-work-with-0.10.1.1.patch

This patch is a better fix.

> Update Kafka tests to work with 0.10.1.1
> 
>
> Key: RANGER-1580
> URL: https://issues.apache.org/jira/browse/RANGER-1580
> Project: Ranger
>  Issue Type: Test
>  Components: plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
> Attachments: 
> 0001-RANGER-1580-Update-Kafka-tests-to-work-with-0.10.1.1.patch
>
>
> Right now, the Ranger Kafka tests hang with 0.10.1.1, as the authorizer needs 
> the "describe" policy for the given principal + topic, even when the 
> principal is not authorized to read the topic. Merging this update will 
> smooth future migration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1580) Update Kafka tests to work with 0.10.1.1

2017-05-16 Thread Colm O hEigeartaigh (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Colm O hEigeartaigh updated RANGER-1580:

Attachment: (was: 
0001-RANGER-1580-Update-Kafka-tests-to-work-with-0.10.1.1.patch)

> Update Kafka tests to work with 0.10.1.1
> 
>
> Key: RANGER-1580
> URL: https://issues.apache.org/jira/browse/RANGER-1580
> Project: Ranger
>  Issue Type: Test
>  Components: plugins
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 1.0.0
>
>
> Right now, the Ranger Kafka tests hang with 0.10.1.1, as the authorizer needs 
> the "describe" policy for the given principal + topic, even when the 
> principal is not authorized to read the topic. Merging this update will 
> smooth future migration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-05-16 Thread Ankita Sinha (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankita Sinha updated RANGER-1582:
-
Description: 
Actual :
Currently Knox SSO is just supported from Ranger UI through web browser. 

Expected : 
Support KNOX SSO Token based authentication on Ranger REST API calls.

  was:
*Actual : *
Currently Knox SSO is just supported from Ranger UI through web browser. 

*Expected : *
Support KNOX SSO Token based authentication on Ranger REST API calls.


> Support KNOX SSO Token based authentication on Ranger REST API calls
> 
>
> Key: RANGER-1582
> URL: https://issues.apache.org/jira/browse/RANGER-1582
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0
>Reporter: Ankita Sinha
>Assignee: Ankita Sinha
> Fix For: 1.0.0
>
>
> Actual :
> Currently Knox SSO is just supported from Ranger UI through web browser. 
> Expected : 
> Support KNOX SSO Token based authentication on Ranger REST API calls.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

2017-05-16 Thread Gautam Borad 


> On May 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > 
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default 
> > path. So what is the need for an additional variable?
> 
> pengjianhua wrote:
> This function is perfect if user independently use our ranger. 
> There is defect for ranger when they integrate Ranger into the big data 
> platform or business systems to uniform install and run Ranger. These systems 
> require services to support multiple instances, that is, the same service can 
> been run multiple instances in the same node. These systems need to 
> dynamically change the pid file path to avoid conflicts when they run 
> service. They hope that ranger also has the ability to dynamically change the 
> pid path at startup. 
> We should meet this need by minor modifications without affecting the 
> current function and logic.
> 
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of 
> RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or 
> something which would default to "rangeradmin.pid". So if you want to 
> customise it you can change the path via RANGER_PID_DIR_PATH and the filename 
> via RANGER_ADMIN_PID_NAME.

+1 for Colm's suggestions.


- Gautam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
---


On May 13, 2017, 7:14 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> ---
> 
> (Updated May 13, 2017, 7:14 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Some users hope that the pid file of the Ranger Admin can be unified 
> management when they integrate Ranger into the big data platform or business 
> systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. 
> When running ranger, users can set the pid file to meet their own needs.
> 
> We will explicitly document this change in the next release.
> 
> 
> Diffs
> -
> 
>   embeddedwebserver/scripts/ranger-admin-services.sh a81219b 
> 
> 
> Diff: https://reviews.apache.org/r/59255/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 59255: Some users hope that the pid file of the Ranger Admin can be unified management when they integrate Ranger into the big data platform or business systems to uniform install a

2017-05-16 Thread Qiang Zhang 


> On 五月 13, 2017, 1:46 p.m., Velmurugan Periasamy wrote:
> > embeddedwebserver/scripts/ranger-admin-services.sh
> > Lines 71 (patched)
> > 
> >
> > Users can set RANGER_PID_DIR_PATH if they don't want to use default 
> > path. So what is the need for an additional variable?
> 
> pengjianhua wrote:
> This function is perfect if user independently use our ranger. 
> There is defect for ranger when they integrate Ranger into the big data 
> platform or business systems to uniform install and run Ranger. These systems 
> require services to support multiple instances, that is, the same service can 
> been run multiple instances in the same node. These systems need to 
> dynamically change the pid file path to avoid conflicts when they run 
> service. They hope that ranger also has the ability to dynamically change the 
> pid path at startup. 
> We should meet this need by minor modifications without affecting the 
> current function and logic.
> 
> Colm O hEigeartaigh wrote:
> I think it would be better if we kept the functionality of 
> RANGER_PID_DIR_PATH as it is, but instead used RANGER_ADMIN_PID_NAME or 
> something which would default to "rangeradmin.pid". So if you want to 
> customise it you can change the path via RANGER_PID_DIR_PATH and the filename 
> via RANGER_ADMIN_PID_NAME.
> 
> Gautam Borad wrote:
> +1 for Colm's suggestions.

+1 for Colm's suggestions.


- Qiang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59255/#review174894
---


On 五月 13, 2017, 7:14 a.m., pengjianhua wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59255/
> ---
> 
> (Updated 五月 13, 2017, 7:14 a.m.)
> 
> 
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan 
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
> 
> 
> Bugs: RANGER-1575
> https://issues.apache.org/jira/browse/RANGER-1575
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Some users hope that the pid file of the Ranger Admin can be unified 
> management when they integrate Ranger into the big data platform or business 
> systems to uniform install and run Ranger.
> We should support the need in the case of compatibility with existing logic. 
> When running ranger, users can set the pid file to meet their own needs.
> 
> We will explicitly document this change in the next release.
> 
> 
> Diffs
> -
> 
>   embeddedwebserver/scripts/ranger-admin-services.sh a81219b 
> 
> 
> Diff: https://reviews.apache.org/r/59255/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> pengjianhua
> 
>

Re: Review Request 57868: Permissions tab pages display are not reasonable.https://issues.apache.org/jira/browse/RANGER-1411

2017-05-16 Thread Colm O hEigeartaigh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57868/#review175099
---



Please submit a patch for "master" only. Also the latest patch still has the 
"Permissions Details" change in it. 

When you are submitting a patch, please use " git format-patch -n HEAD~" as per:

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244

- Colm O hEigeartaigh


On May 16, 2017, 1:47 p.m., Haihui Xu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57868/
> ---
> 
> (Updated May 16, 2017, 1:47 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1411
> https://issues.apache.org/jira/browse/RANGER-1411
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Navigate to Ranger Web UI's Settings Permissions tab, the permissions table 
> header is Permissions,Groups,Users,Action. But the first column in the table 
> is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the 
> table header should be Modules,Groups,Users,Action.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 
> 7a4b82c 
>   
> security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js
>  92c07c7 
>   
> security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html
>  909d2fc 
> 
> 
> Diff: https://reviews.apache.org/r/57868/diff/1/
> 
> 
> Testing
> ---
> 
> Page Display, test ok.
> 
> 
> File Attachments
> 
> 
> RANGER-1411.patch
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch
> 
> 
> Thanks,
> 
> Haihui Xu
> 
>

Re: Review Request 59296: Ranger plugins need to support additional date formats for tag attribute values

2017-05-16 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59296/#review175128
---




agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
Lines 43 (patched)


USE_DEFAULT_ATLAS_TAG_ATTRIBUTE_DATE_FORMAT ==> 
DEFAULT_ATLAS_TAG_ATTRIBUTE_DATE_FORMAT_NAME



agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
Lines 230 (patched)


Instead of creating a SimpleDateFormat in every call, consider receiving 
SimpleDateFormat as argument to this method. getAsDate(String value) should be 
updated to create a thread-local array of SimpleDateFormat objects and pass 
each to this method.



agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
Lines 233 (patched)


This warn log should be generated only after all formats have been tried, 
in getAsDate(String value). Else this might generate excessive, unnecessary 
warning messages.


- Madhan Neethiraj


On May 15, 2017, 9:25 p.m., Abhay Kulkarni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59296/
> ---
> 
> (Updated May 15, 2017, 9:25 p.m.)
> 
> 
> Review request for ranger and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-1581
> https://issues.apache.org/jira/browse/RANGER-1581
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Ranger plugins interpret tag attributes of type 'date' using an internal 
> Ranger date-format string. Now, in addition to the internal Ranger 
> date-format string ("/MM/dd"), plugins also support a comma-separated 
> list of data-format strings, based on the value of the plugin configuration 
> parameter "ranger.plugin.tag.attr.additional.date.formats". A special value 
> string "ATLAS_DATE_FORMAT" is supported to refer to default date-format used 
> by Atlas.
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java
>  923c188 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
>  5948a74 
>   
> agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json 
> 1c7662d 
> 
> 
> Diff: https://reviews.apache.org/r/59296/diff/1/
> 
> 
> Testing
> ---
> 
> Developed a unit test for testing specification and use of 
> "ranger.plugin.tag.attr.additional.date.formats" configuration variable.
> 
> 
> Thanks,
> 
> Abhay Kulkarni
> 
>

[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-05-16 Thread Ankita Sinha (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankita Sinha updated RANGER-1582:
-
Description: 
*Actual : *
Currently Knox SSO is just supported from Ranger UI through web browser. 

*Expected : *
Support KNOX SSO Token based authentication on Ranger REST API calls.

  was:
**Actual : **
Currently Knox SSO is just supported from Ranger UI through web browser. 

**Expected : **
Support KNOX SSO Token based authentication on Ranger REST API calls.


> Support KNOX SSO Token based authentication on Ranger REST API calls
> 
>
> Key: RANGER-1582
> URL: https://issues.apache.org/jira/browse/RANGER-1582
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0
>Reporter: Ankita Sinha
>Assignee: Ankita Sinha
> Fix For: 1.0.0
>
>
> *Actual : *
> Currently Knox SSO is just supported from Ranger UI through web browser. 
> *Expected : *
> Support KNOX SSO Token based authentication on Ranger REST API calls.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-05-16 Thread Ankita Sinha (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankita Sinha updated RANGER-1582:
-
Description: 
*Actual* :
Currently Knox SSO is just supported from Ranger UI through web browser. 

*Expected* : 
Support KNOX SSO Token based authentication on Ranger REST API calls.

  was:
Actual :
Currently Knox SSO is just supported from Ranger UI through web browser. 

Expected : 
Support KNOX SSO Token based authentication on Ranger REST API calls.


> Support KNOX SSO Token based authentication on Ranger REST API calls
> 
>
> Key: RANGER-1582
> URL: https://issues.apache.org/jira/browse/RANGER-1582
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0
>Reporter: Ankita Sinha
>Assignee: Ankita Sinha
> Fix For: 1.0.0
>
>
> *Actual* :
> Currently Knox SSO is just supported from Ranger UI through web browser. 
> *Expected* : 
> Support KNOX SSO Token based authentication on Ranger REST API calls.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1582) Support KNOX SSO Token based authentication on Ranger REST API calls

2017-05-16 Thread Ankita Sinha (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ankita Sinha updated RANGER-1582:
-
Attachment: RANGER-1582.patch

> Support KNOX SSO Token based authentication on Ranger REST API calls
> 
>
> Key: RANGER-1582
> URL: https://issues.apache.org/jira/browse/RANGER-1582
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 1.0.0
>Reporter: Ankita Sinha
>Assignee: Ankita Sinha
> Fix For: 1.0.0
>
> Attachments: RANGER-1582.patch
>
>
> *Actual* :
> Currently Knox SSO is just supported from Ranger UI through web browser. 
> *Expected* : 
> Support KNOX SSO Token based authentication on Ranger REST API calls.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (RANGER-1585) Do some code improvement for the error logs in RangerBasePlugin.java

2017-05-16 Thread Qiang Zhang (JIRA) 
Qiang Zhang created RANGER-1585:
---

 Summary: Do some code improvement for the error logs in 
RangerBasePlugin.java
 Key: RANGER-1585
 URL: https://issues.apache.org/jira/browse/RANGER-1585
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Qiang Zhang
Assignee: Qiang Zhang
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (RANGER-1585) Do some code improvement for the error logs in RangerBasePlugin.java

2017-05-16 Thread Qiang Zhang (JIRA) 

 [ 
https://issues.apache.org/jira/browse/RANGER-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Qiang Zhang updated RANGER-1585:

Attachment: 0001-RANGER-1585-Do-some-code-improvement-for-the-error-l.patch

> Do some code improvement for the error logs in RangerBasePlugin.java
> 
>
> Key: RANGER-1585
> URL: https://issues.apache.org/jira/browse/RANGER-1585
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Qiang Zhang
>Assignee: Qiang Zhang
>Priority: Minor
>  Labels: patch
> Attachments: 
> 0001-RANGER-1585-Do-some-code-improvement-for-the-error-l.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)