[jira] [Updated] (RANGER-1952) Allow user's email Address to be blank on emailchange API as per RANGER-978

2018-01-11 Thread Pradeep Agrawal (JIRA)

 [ 
https://issues.apache.org/jira/browse/RANGER-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pradeep Agrawal updated RANGER-1952:

Attachment: RANGER-1952-1.patch

> Allow user's email Address to be blank on emailchange API as per RANGER-978
> ---
>
> Key: RANGER-1952
> URL: https://issues.apache.org/jira/browse/RANGER-1952
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Affects Versions: 0.6.0, 0.7.0
>Reporter: Pradeep Agrawal
>Assignee: Pradeep Agrawal
>Priority: Minor
> Fix For: 1.0.0, 0.7.2
>
> Attachments: RANGER-1952-1.patch
>
>
> According to RANGER-978, User's email address is not a mandatory field so if 
> a user wants to change his email address to blank then API should allow that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


Review Request 65119: RANGER-1952: Allow user's email Address to be blank on emailchange API as per RANGER-978

2018-01-11 Thread Pradeep Agrawal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65119/
---

Review request for ranger, Ankita Sinha, deepak sharma, Gautam Borad, Mehul 
Parikh, suja s, and Velmurugan Periasamy.


Bugs: RANGER-1952
https://issues.apache.org/jira/browse/RANGER-1952


Repository: ranger


Description
---

**Problem Statement:** User's email address is not a mandatory field so if a 
user wants to change his email address to blank then API should allow that.

**Proposed Solution:** By Removing blank email check restriction from 
UserMgr.changeEmailAddress() method this issue can be fixed.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 5f85066 
  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 9614184 


Diff: https://reviews.apache.org/r/65119/diff/1/


Testing
---

Steps performed(with patch) :
1. Installed and started Ranger admin.
2. Created a user with valid email address.
3. Tried to set user's email address to blank:

Sample Request after encoding: curl -u inuser1:user1234 --header 
"Accept:application/json" -H "Content-Type:application/json"  -X POST 
"http://localhost:6080/service/users/20/emailchange; -d 
'{"loginId":"inuser1","emailAddress":""}'

4. Visited user tab from user/group menu to see the updated email address.


**Expected Behaviour:** User 'inuser1' email should reset to blank.
**Actual Behaviour:** User 'inuser1' email was reset to blank.


Thanks,

Pradeep Agrawal



[jira] [Created] (RANGER-1952) Allow user's email Address to be blank on emailchange API as per RANGER-978

2018-01-11 Thread Pradeep Agrawal (JIRA)
Pradeep Agrawal created RANGER-1952:
---

 Summary: Allow user's email Address to be blank on emailchange API 
as per RANGER-978
 Key: RANGER-1952
 URL: https://issues.apache.org/jira/browse/RANGER-1952
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Affects Versions: 0.7.0, 0.6.0
Reporter: Pradeep Agrawal
Assignee: Pradeep Agrawal
Priority: Minor
 Fix For: 1.0.0, 0.7.2


According to RANGER-978, User's email address is not a mandatory field so if a 
user wants to change his email address to blank then API should allow that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)