Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/#review191824 --- @Colm : Can you please also confirm audit to solr& audit to hdfs logs are writing properly? - bhavik patel On Nov. 23, 2017, 12:02 p.m., Colm O hEigeartaigh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63919/ > --- > > (Updated Nov. 23, 2017, 12:02 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1895 > https://issues.apache.org/jira/browse/RANGER-1895 > > > Repository: ranger > > > Description > --- > > This task is to simplify the Apache Storm dependencies for Ranger. We are > shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid > explicitly listing some of the dependencies, as they get pulled in via other > dependencies. > > > Diffs > - > > ranger-storm-plugin-shim/pom.xml de1972d4 > src/main/assembly/storm-agent.xml 64224ec7 > storm-agent/pom.xml 6e74e5b3 > > > Diff: https://reviews.apache.org/r/63919/diff/2/ > > > Testing > --- > > Tested the plugin works OK with Apache Storm 1.1.1. The only change in the > distribution is that it doesn't include the Hadoop HDFS jar. > > > Thanks, > > Colm O hEigeartaigh > >
Review Request 64057: RANGER-1907:The solr-solrj jar is not need for hive-agent. So it should be removed from the pom.xml file of the hive-agent
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64057/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. Bugs: RANGER-1907 https://issues.apache.org/jira/browse/RANGER-1907 Repository: ranger Description --- The solr-solrj jar is not need for hive-agent. So it should be removed from the pom.xml file of the hive-agent Diffs - hive-agent/pom.xml a2b4aa8 Diff: https://reviews.apache.org/r/64057/diff/1/ Testing --- I had carefully tested the ranger + hive-agent after modified the issue. Thanks, pengjianhua
[jira] [Updated] (RANGER-1907) The solr-solrj jar is not need for hive-agent. So it should be removed from the pom.xml file of the hive-agent
[ https://issues.apache.org/jira/browse/RANGER-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua updated RANGER-1907: - Attachment: 0001-RANGER-1907-The-solr-solrj-jar-is-not-need-for-hive-.patch > The solr-solrj jar is not need for hive-agent. So it should be removed from > the pom.xml file of the hive-agent > -- > > Key: RANGER-1907 > URL: https://issues.apache.org/jira/browse/RANGER-1907 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: master > > Attachments: > 0001-RANGER-1907-The-solr-solrj-jar-is-not-need-for-hive-.patch > > > The solr-solrj jar is not need for hive-agent. So it should be removed from > the pom.xml file of the hive-agent. > I had carefully tested the ranger + hive-agent after modified the issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1907) The solr-solrj jar is not need for hive-agent. So it should be removed from the pom.xml file of the hive-agent
peng.jianhua created RANGER-1907: Summary: The solr-solrj jar is not need for hive-agent. So it should be removed from the pom.xml file of the hive-agent Key: RANGER-1907 URL: https://issues.apache.org/jira/browse/RANGER-1907 Project: Ranger Issue Type: Improvement Components: plugins Affects Versions: master Reporter: peng.jianhua Assignee: peng.jianhua Priority: Minor Fix For: master The solr-solrj jar is not need for hive-agent. So it should be removed from the pom.xml file of the hive-agent. I had carefully tested the ranger + hive-agent after modified the issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (RANGER-1901) Similar to RANGER-1846, the JAVA_VERSION_REQUIRED configuration item is invalid in kms installer, we should enable it to control the necessary java version.
[ https://issues.apache.org/jira/browse/RANGER-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qiang Zhang resolved RANGER-1901. - Resolution: Fixed Fix Version/s: master 1.0.0 > Similar to RANGER-1846, the JAVA_VERSION_REQUIRED configuration item is > invalid in kms installer, we should enable it to control the necessary java > version. > > > Key: RANGER-1901 > URL: https://issues.apache.org/jira/browse/RANGER-1901 > Project: Ranger > Issue Type: Bug > Components: kms >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Labels: patch > Fix For: 1.0.0, master > > Attachments: > 0001-RANGER-1901-Similar-to-RANGER-1846-the-JAVA_VERSION_.patch > > > The java version must be equal to or more than 1.8 when we set db_ssl_enabled > equal to true. > This JAVA_VERSION_REQUIRED configuration item is invalid in kms installer, we > should enable it to control the necessary java version. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (RANGER-1903) Simplify the maven dependency management of the Hdfs plugin for Ranger.
[ https://issues.apache.org/jira/browse/RANGER-1903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] peng.jianhua resolved RANGER-1903. -- Resolution: Fixed Fix Version/s: 1.0.0 > Simplify the maven dependency management of the Hdfs plugin for Ranger. > --- > > Key: RANGER-1903 > URL: https://issues.apache.org/jira/browse/RANGER-1903 > Project: Ranger > Issue Type: Bug > Components: plugins >Affects Versions: master >Reporter: peng.jianhua >Assignee: peng.jianhua >Priority: Minor > Fix For: 1.0.0, master > > Attachments: > 0001-RANGER-1903-Simplify-hdfs-agent-dependency-managemen.patch > > > The hdfs-agent need not dependency the hbase-server ,hive-common and > hive-service jar. So they should be removed from the pom.xml file of the > hdfs-agent. > I had carefully tested the hdfs plugin, hive plugin and hbase plugin after > modified the issue. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Review Request 64051: RANGER-1906 - Simplify Atlas plugin dependency management
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64051/ --- Review request for ranger. Bugs: RANGER-1906 https://issues.apache.org/jira/browse/RANGER-1906 Repository: ranger Description --- This task is to simplify the dependency management for the Atlas plugin. In particular, the hadoop/solr dependencies should just be imported via the ranger-plugin-commons dependency. No changes are made to the resulting jars for the Atlas distribution. Diffs - plugin-atlas/pom.xml 957b4ce3 ranger-atlas-plugin-shim/pom.xml a207d16b src/main/assembly/plugin-atlas.xml fd988116 Diff: https://reviews.apache.org/r/64051/diff/1/ Testing --- Thanks, Colm O hEigeartaigh
[jira] [Updated] (RANGER-1906) Simplify Atlas plugin dependency management
[ https://issues.apache.org/jira/browse/RANGER-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1906: Attachment: 0001-RANGER-1906-Simplify-Atlas-plugin-dependency-managem.patch > Simplify Atlas plugin dependency management > --- > > Key: RANGER-1906 > URL: https://issues.apache.org/jira/browse/RANGER-1906 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Minor > Fix For: 1.0.0 > > Attachments: > 0001-RANGER-1906-Simplify-Atlas-plugin-dependency-managem.patch > > > This task is to simplify the dependency management for the Atlas plugin. In > particular, the hadoop/solr dependencies should just be imported via the > ranger-plugin-commons dependency. > No changes are made to the resulting jars for the Atlas distribution. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (RANGER-1906) Simplify Atlas plugin dependency management
Colm O hEigeartaigh created RANGER-1906: --- Summary: Simplify Atlas plugin dependency management Key: RANGER-1906 URL: https://issues.apache.org/jira/browse/RANGER-1906 Project: Ranger Issue Type: Improvement Components: plugins Reporter: Colm O hEigeartaigh Assignee: Colm O hEigeartaigh Priority: Minor Fix For: 1.0.0 This task is to simplify the dependency management for the Atlas plugin. In particular, the hadoop/solr dependencies should just be imported via the ranger-plugin-commons dependency. No changes are made to the resulting jars for the Atlas distribution. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1895) Simplify Storm dependencies
[ https://issues.apache.org/jira/browse/RANGER-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1895: Attachment: (was: 0001-RANGER-1895-Simplify-Storm-dependencies.patch) > Simplify Storm dependencies > --- > > Key: RANGER-1895 > URL: https://issues.apache.org/jira/browse/RANGER-1895 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Minor > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1895-Simplify-Storm-dependencies.patch > > > This task is to simplify the Apache Storm dependencies for Ranger. We are > shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid > explicitly listing some of the dependencies, as they get pulled in via other > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (RANGER-1895) Simplify Storm dependencies
[ https://issues.apache.org/jira/browse/RANGER-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colm O hEigeartaigh updated RANGER-1895: Attachment: 0001-RANGER-1895-Simplify-Storm-dependencies.patch Also removing unused deps from the shim > Simplify Storm dependencies > --- > > Key: RANGER-1895 > URL: https://issues.apache.org/jira/browse/RANGER-1895 > Project: Ranger > Issue Type: Improvement > Components: plugins >Reporter: Colm O hEigeartaigh >Assignee: Colm O hEigeartaigh >Priority: Minor > Fix For: 1.0.0 > > Attachments: 0001-RANGER-1895-Simplify-Storm-dependencies.patch > > > This task is to simplify the Apache Storm dependencies for Ranger. We are > shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid > explicitly listing some of the dependencies, as they get pulled in via other > dependencies. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: Review Request 63919: RANGER-1895 - Simplify Storm dependencies
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63919/ --- (Updated Nov. 23, 2017, 12:02 p.m.) Review request for ranger. Bugs: RANGER-1895 https://issues.apache.org/jira/browse/RANGER-1895 Repository: ranger Description --- This task is to simplify the Apache Storm dependencies for Ranger. We are shipping the hadoop-hdfs jar, which is not required. Secondly, we can avoid explicitly listing some of the dependencies, as they get pulled in via other dependencies. Diffs (updated) - ranger-storm-plugin-shim/pom.xml de1972d4 src/main/assembly/storm-agent.xml 64224ec7 storm-agent/pom.xml 6e74e5b3 Diff: https://reviews.apache.org/r/63919/diff/2/ Changes: https://reviews.apache.org/r/63919/diff/1-2/ Testing --- Tested the plugin works OK with Apache Storm 1.1.1. The only change in the distribution is that it doesn't include the Hadoop HDFS jar. Thanks, Colm O hEigeartaigh
Re: Review Request 63987: RANGER-1905 : fix maven assembly creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63987/#review191793 --- How can I reproduce the error as reported on the JIRA? I unzipped the Ranger admin + installed and started it without any errors in the logs. - Colm O hEigeartaigh On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63987/ > --- > > (Updated Nov. 22, 2017, 12:23 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1905 > https://issues.apache.org/jira/browse/RANGER-1905 > > > Repository: ranger > > > Description > --- > > As ranger-plugins-audit doesn't exclude guava from hadoop common, an older > guava > is leaked into embeddedwebserver classpath, which somehow filtered out by the > assembly plugin. > If we explicitly exclude the old guava, and include the new (17.0) guava in > ranger-plugins-audit module, the generated tar.gz/zip distributions will > contain the necessary guava-17.0.jar in ews/lib path. > > > Diffs > - > > agents-audit/pom.xml c8bd1d8f3 > src/main/assembly/plugin-atlas.xml fd988116d > > > Diff: https://reviews.apache.org/r/63987/diff/2/ > > > Testing > --- > > Tested with executing: > > mvn -DskipTests package assembly:assembly; > unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt > > And comparing the results with different versions. With the patch, the guava > jar appears correctly. > > > Thanks, > > Zsombor Gegesy > >
Re: Review Request 63981: RANGER-1903:Simplify the maven dependency management of the Hdfs plugin for Ranger.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63981/#review191791 --- Ship it! Ship It! - Colm O hEigeartaigh On Nov. 23, 2017, 3:19 a.m., pengjianhua wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63981/ > --- > > (Updated Nov. 23, 2017, 3:19 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1903 > https://issues.apache.org/jira/browse/RANGER-1903 > > > Repository: ranger > > > Description > --- > > The hdfs-agent need not dependency the hbase-server ,hive-common and > hive-service jar. So they should be removed from the pom.xml file of the > hdfs-agent. > > > Diffs > - > > hdfs-agent/pom.xml 9f62060 > > > Diff: https://reviews.apache.org/r/63981/diff/2/ > > > Testing > --- > > I had carefully tested the hdfs plugin, hive plugin and hbase plugin after > modified the issue. > > > Thanks, > > pengjianhua > >
Re: Review Request 64042: RANGER-1897: tagsync update to replace Atlas V1 API usage with Atlas V2 API for tag-download using REST
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64042/ --- (Updated Nov. 23, 2017, 8:38 a.m.) Review request for ranger and Abhay Kulkarni. Changes --- updated for review comments Bugs: RANGER-1897 https://issues.apache.org/jira/browse/RANGER-1897 Repository: ranger Description --- Updated tag-sync to use Atlas V2 REST APIs to download tags, instead of using V1 APIs. This significantly reduces the number of REST API calls from tag-sync to Atlas and will result in a better performance. Diffs (updated) - pom.xml 80de97e8 src/main/assembly/tagsync.xml 0b17151b tagsync/pom.xml 42e9d2ff tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasEntityWithTraits.java 77dee01e tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHbaseResourceMapper.java 8b36a318 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHdfsResourceMapper.java 06bff906 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasHiveResourceMapper.java a3596223 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java 9f1fc2db tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java 922317e8 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapper.java 8ececdf7 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasResourceMapperUtil.java f9f0eafd tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java 12b02d94 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java 4e0ae908 tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTUtil.java 00a101e7 Diff: https://reviews.apache.org/r/64042/diff/2/ Changes: https://reviews.apache.org/r/64042/diff/1-2/ Testing --- Verified that tags successfully download with Atlas V2 REST APIs. Thanks, Madhan Neethiraj
