Re: Review Request 70424: RANGER-2399:User's listing page hits users API call twice from UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70424/#review214520 --- Ship it! Ship It! - Pradeep Agrawal On April 8, 2019, 10:58 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70424/ > --- > > (Updated April 8, 2019, 10:58 a.m.) > > > Review request for ranger, Mehul Parikh, Nikhil P, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2399 > https://issues.apache.org/jira/browse/RANGER-2399 > > > Repository: ranger > > > Description > --- > > #issue 1 > Steps: Login and go to users/group tab > 1. Click on username name link and open user update page > 2. And go back to user's listing page. > See user API call hit twice. The unnecessary call needs to be removed from UI > > #issue 2 > 2. Zonename title placement on zone listing page to be checked when zone name > is long > > > Diffs > - > > security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 > security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js > a1e9716 > security-admin/src/main/webapp/scripts/views/users/GroupCreate.js a764387 > security-admin/src/main/webapp/scripts/views/users/UserCreate.js e1afff1 > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > 94afd75 > security-admin/src/main/webapp/styles/xa.css f90f21b > security-admin/src/main/webapp/templates/common/breadcrumbs.html 8de0ad3 > > security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html > f0b2572 > > > Diff: https://reviews.apache.org/r/70424/diff/1/ > > > Testing > --- > > 1. Verified that multiple API Call does not get generated for single request. > e.g. On creation/edit/cancel of User/Group. > 2. Zone name title displays properly in case of having long zone name, > Verified on Zone listing page, Zone name header, Zone breadcrumb. > > > Thanks, > > Nitin Galave > >
Re: Review Request 70435: RANGER-2401: Ranger Secuity Zone needs to be added in audit type filter in admin audit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70435/#review214519 --- Ship it! Ship It! - Pradeep Agrawal On April 9, 2019, 12:53 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70435/ > --- > > (Updated April 9, 2019, 12:53 p.m.) > > > Review request for ranger, deepak sharma, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2401 > https://issues.apache.org/jira/browse/RANGER-2401 > > > Repository: ranger > > > Description > --- > > 1. Ranger Security Zone is missing in audit type filter in the admin audit > log. > > 2. Also, Include "User Profile" in the audit type filter for admin audits > When a user is deleted, admin audit entries are generated for user deletion > and user profile deletion with audit types as "Ranger User" and "User > Profile". > "Ranger User" option is available in the audit type search filter, "User > Profile" is not. Suggestion is to include "User Profile" option also in audit > type filter > > > Diffs > - > > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js e7b45d9 > > > Diff: https://reviews.apache.org/r/70435/diff/1/ > > > Testing > --- > > 1. Verified that System display "Ranger Security Zone" filter in Audit>>Admin > tab with Audit Type filter option. > 2. Verified that,System display "User Profile" filter in Audit>>Admin tab > with Audit Type filter option. > > > Thanks, > > Nitin Galave > >
Re: Review Request 70376: RANGER-2392: Create / Update zone to have provision to associate Tag based service with zone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70376/#review214518 --- Ship it! Ship It! - Mehul Parikh On April 9, 2019, 12:38 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70376/ > --- > > (Updated April 9, 2019, 12:38 p.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Nikhil P, Pradeep > Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2392 > https://issues.apache.org/jira/browse/RANGER-2392 > > > Repository: ranger > > > Description > --- > > Currently, Resource-based services are associated with the zone as part of > zone creation. > Need to add a feature to only associate Tag based service as part of zone. > No need to add resources with tag-based service association. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerSecurityZone.java > 547e2d2 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 2eaffcc > security-admin/db/mysql/patches/037-create-security-zone-schema.sql aff9786 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 5ca1e36 > security-admin/db/oracle/patches/037-create-security-zone-schema.sql > aae31dc > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 51f4999 > security-admin/db/postgres/patches/037-create-security-zone-schema.sql > 4a94d26 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 5f64a2d > security-admin/db/sqlanywhere/patches/037-create-security-zone-schema.sql > 5b7dade > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > fc21cec > security-admin/db/sqlserver/patches/037-create-security-zone-schema.sql > e621b43 > > security-admin/src/main/java/org/apache/ranger/biz/SecurityZoneRefUpdater.java > 2b0c462 > security-admin/src/main/java/org/apache/ranger/common/RangerConstants.java > cdb5e11 > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManagerBase.java > 3599cf3 > > security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/entity/XXSecurityZoneRefTagService.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java > b8b8c1b > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneService.java > 04003f4 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e702c1 > security-admin/src/main/webapp/scripts/models/RangerZone.js 4f99c83 > security-admin/src/main/webapp/scripts/utils/XAUtils.js b14f4b9 > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > d3eb026 > security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js > a1e9716 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js > 63fafb4 > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreate.js > dd34605 > security-admin/src/main/webapp/styles/xa.css f90f21b > > security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html > f0b2572 > > security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html > 89acb10 > > security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html > fdcb821 > > > Diff: https://reviews.apache.org/r/70376/diff/2/ > > > Testing > --- > > 1. Verified that new field "Zone Tag Services" is available on Zone form > (create/update page). > 2. Verified that multiple Tag services can be mapped to zone using newly > added field i.e "Zone Tag Services". > 3. Verified that Same Tag services can be mapped to multiple zones. > 4. Zone detail page display tag services associated with that zone. > 5. Verified that When tag based services is not mapped to any zone, It > displays message "No tag based services are associated with this zone" on > Zone listing page. > 6. Verified that Audit>>Admin logs gets generated for zone tag services field > in zone form > > > Thanks, > > Nitin Galave > >
Re: Review Request 70435: RANGER-2401: Ranger Secuity Zone needs to be added in audit type filter in admin audit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70435/#review214517 --- Ship it! Ship It! - Mehul Parikh On April 9, 2019, 12:53 p.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70435/ > --- > > (Updated April 9, 2019, 12:53 p.m.) > > > Review request for ranger, deepak sharma, Mehul Parikh, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2401 > https://issues.apache.org/jira/browse/RANGER-2401 > > > Repository: ranger > > > Description > --- > > 1. Ranger Security Zone is missing in audit type filter in the admin audit > log. > > 2. Also, Include "User Profile" in the audit type filter for admin audits > When a user is deleted, admin audit entries are generated for user deletion > and user profile deletion with audit types as "Ranger User" and "User > Profile". > "Ranger User" option is available in the audit type search filter, "User > Profile" is not. Suggestion is to include "User Profile" option also in audit > type filter > > > Diffs > - > > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js e7b45d9 > > > Diff: https://reviews.apache.org/r/70435/diff/1/ > > > Testing > --- > > 1. Verified that System display "Ranger Security Zone" filter in Audit>>Admin > tab with Audit Type filter option. > 2. Verified that,System display "User Profile" filter in Audit>>Admin tab > with Audit Type filter option. > > > Thanks, > > Nitin Galave > >
Review Request 70435: RANGER-2401: Ranger Secuity Zone needs to be added in audit type filter in admin audit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70435/ --- Review request for ranger, deepak sharma, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. Bugs: RANGER-2401 https://issues.apache.org/jira/browse/RANGER-2401 Repository: ranger Description --- 1. Ranger Security Zone is missing in audit type filter in the admin audit log. 2. Also, Include "User Profile" in the audit type filter for admin audits When a user is deleted, admin audit entries are generated for user deletion and user profile deletion with audit types as "Ranger User" and "User Profile". "Ranger User" option is available in the audit type search filter, "User Profile" is not. Suggestion is to include "User Profile" option also in audit type filter Diffs - security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js e7b45d9 Diff: https://reviews.apache.org/r/70435/diff/1/ Testing --- 1. Verified that System display "Ranger Security Zone" filter in Audit>>Admin tab with Audit Type filter option. 2. Verified that,System display "User Profile" filter in Audit>>Admin tab with Audit Type filter option. Thanks, Nitin Galave
[jira] [Updated] (RANGER-2401) Ranger Secuity Zone needs to be added in audit type filter in admin audit
[ https://issues.apache.org/jira/browse/RANGER-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitin Galave updated RANGER-2401: - Attachment: RANGER-2401.patch > Ranger Secuity Zone needs to be added in audit type filter in admin audit > - > > Key: RANGER-2401 > URL: https://issues.apache.org/jira/browse/RANGER-2401 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Nitin Galave >Assignee: Nitin Galave >Priority: Major > Fix For: master > > Attachments: RANGER-2401.patch > > > *1. Ranger Security Zone* is missing in audit type filter in the admin audit > log. > 2. Also, Include "User Profile" in the audit type filter for admin audits > When a user is deleted, admin audit entries are generated for user deletion > and user profile deletion with audit types as "Ranger User" and "User > Profile". > "Ranger User" option is available in the audit type search filter, "User > Profile" is not. Suggestion is to include "User Profile" option also in audit > type filter -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (RANGER-2401) Ranger Secuity Zone needs to be added in audit type filter in admin audit
[ https://issues.apache.org/jira/browse/RANGER-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitin Galave updated RANGER-2401: - Description: *1. Ranger Security Zone* is missing in audit type filter in the admin audit log. 2. Also, Include "User Profile" in the audit type filter for admin audits When a user is deleted, admin audit entries are generated for user deletion and user profile deletion with audit types as "Ranger User" and "User Profile". "Ranger User" option is available in the audit type search filter, "User Profile" is not. Suggestion is to include "User Profile" option also in audit type filter was:*Ranger Secuity Zone* is missing in audit type filter in admin audit log. > Ranger Secuity Zone needs to be added in audit type filter in admin audit > - > > Key: RANGER-2401 > URL: https://issues.apache.org/jira/browse/RANGER-2401 > Project: Ranger > Issue Type: Bug > Components: Ranger >Reporter: Nitin Galave >Assignee: Nitin Galave >Priority: Major > Fix For: master > > > *1. Ranger Security Zone* is missing in audit type filter in the admin audit > log. > 2. Also, Include "User Profile" in the audit type filter for admin audits > When a user is deleted, admin audit entries are generated for user deletion > and user profile deletion with audit types as "Ranger User" and "User > Profile". > "Ranger User" option is available in the audit type search filter, "User > Profile" is not. Suggestion is to include "User Profile" option also in audit > type filter -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Review Request 70432: RANGER-2387 : add public api v2 for security zones
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70432/ --- Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-2387 https://issues.apache.org/jira/browse/RANGER-2387 Repository: ranger Description --- add public api v2 for security zones Diffs - security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 073404e Diff: https://reviews.apache.org/r/70432/diff/1/ Testing --- 1.Tested Curl response of Public api v2 are correct. 2.validated response result for public API matches with SecurityZoneREST Thanks, Nikhil P
[jira] [Updated] (RANGER-2387) add public api v2 for security zones
[ https://issues.apache.org/jira/browse/RANGER-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Purbhe updated RANGER-2387: -- Attachment: RANGER-2387-add-public-api-v2-for-security-zones.patch > add public api v2 for security zones > > > Key: RANGER-2387 > URL: https://issues.apache.org/jira/browse/RANGER-2387 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: master >Reporter: Deepak Sharma >Assignee: Nikhil Purbhe >Priority: Major > Fix For: master > > Attachments: RANGER-2387-add-public-api-v2-for-security-zones.patch > > > add public api v2 for security zones -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Review Request 70424: RANGER-2399:User's listing page hits users API call twice from UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70424/#review214494 --- Ship it! Ship It! - Mehul Parikh On April 8, 2019, 10:58 a.m., Nitin Galave wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70424/ > --- > > (Updated April 8, 2019, 10:58 a.m.) > > > Review request for ranger, Mehul Parikh, Nikhil P, Pradeep Agrawal, and > Velmurugan Periasamy. > > > Bugs: RANGER-2399 > https://issues.apache.org/jira/browse/RANGER-2399 > > > Repository: ranger > > > Description > --- > > #issue 1 > Steps: Login and go to users/group tab > 1. Click on username name link and open user update page > 2. And go back to user's listing page. > See user API call hit twice. The unnecessary call needs to be removed from UI > > #issue 2 > 2. Zonename title placement on zone listing page to be checked when zone name > is long > > > Diffs > - > > security-admin/src/main/webapp/scripts/controllers/Controller.js 934a1a2 > security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js > a1e9716 > security-admin/src/main/webapp/scripts/views/users/GroupCreate.js a764387 > security-admin/src/main/webapp/scripts/views/users/UserCreate.js e1afff1 > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > 94afd75 > security-admin/src/main/webapp/styles/xa.css f90f21b > security-admin/src/main/webapp/templates/common/breadcrumbs.html 8de0ad3 > > security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html > f0b2572 > > > Diff: https://reviews.apache.org/r/70424/diff/1/ > > > Testing > --- > > 1. Verified that multiple API Call does not get generated for single request. > e.g. On creation/edit/cancel of User/Group. > 2. Zone name title displays properly in case of having long zone name, > Verified on Zone listing page, Zone name header, Zone breadcrumb. > > > Thanks, > > Nitin Galave > >
[jira] [Assigned] (RANGER-2387) add public api v2 for security zones
[ https://issues.apache.org/jira/browse/RANGER-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Purbhe reassigned RANGER-2387: - Assignee: Nikhil Purbhe > add public api v2 for security zones > > > Key: RANGER-2387 > URL: https://issues.apache.org/jira/browse/RANGER-2387 > Project: Ranger > Issue Type: Bug > Components: Ranger >Affects Versions: master >Reporter: Deepak Sharma >Assignee: Nikhil Purbhe >Priority: Major > Fix For: master > > > add public api v2 for security zones -- This message was sent by Atlassian JIRA (v7.6.3#76005)
