Re: Review Request 71774: RANGER-2639 XUserService has duplicate db query in when populateViewBean for XXUser

2019-12-12 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71774/#review219024 --- Ship it! Ship It! - Mehul Parikh On Nov. 18, 2019, 3:36

Re: Review Request 71746: RANGER-2643: Use JPA/JDBC batching during policy creation

2019-12-12 Thread Mehul Parikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71746/#review219023 --- Ship it! Ship It! - Mehul Parikh On Nov. 16, 2019, 10:46

[jira] [Commented] (RANGER-2667) Running the disable-presto-plugin.sh script will always get stuck

2019-12-12 Thread Jiayi Liu (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995334#comment-16995334 ] Jiayi Liu commented on RANGER-2667: --- I create a review request in https://reviews.apache.org/r/71911/

Re: Review Request 71910: Unlink core-site.xml in usersync conf before chown and chmod

2019-12-12 Thread Jiayi Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71910/ --- (Updated 十二月 13, 2019, 3:51 a.m.) Review request for ranger and Ramesh Mani.

Review Request 71911: Set controlName to allow-all when disable presto plugin

2019-12-12 Thread Jiayi Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71911/ --- Review request for ranger. Repository: ranger Description --- Running

[jira] [Comment Edited] (RANGER-2671) Running the setup.sh in usersync a second time will change the permissions and owner of hadoop core-site.xml

2019-12-12 Thread Jiayi Liu (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995330#comment-16995330 ] Jiayi Liu edited comment on RANGER-2671 at 12/13/19 3:43 AM: - Hi, [~rmani].

[jira] [Commented] (RANGER-2671) Running the setup.sh in usersync a second time will change the permissions and owner of hadoop core-site.xml

2019-12-12 Thread Jiayi Liu (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16995330#comment-16995330 ] Jiayi Liu commented on RANGER-2671: --- [~rmani]Thank you for your reply, I create a review request in

Review Request 71910: fix the bug that running the setup.sh in usersync a second time will change the permissions and owner of hadoop core-site.xml

2019-12-12 Thread Jiayi Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71910/ --- Review request for ranger and Ramesh Mani. Repository: ranger Description

Re: Review Request 71894: RANGER-2669: Blacklist for Ranger Audits

2019-12-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71894/#review219018 --- Fix it, then Ship it!

Re: Review Request 71894: RANGER-2669: Blacklist for Ranger Audits

2019-12-12 Thread Pradeep Agrawal
> On Dec. 11, 2019, 7:31 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > > Lines 88 (patched) > > > > > > - consider moving > >

Re: Review Request 71894: RANGER-2669: Blacklist for Ranger Audits

2019-12-12 Thread Pradeep Agrawal
> On Dec. 11, 2019, 7:31 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java > > Lines 299 (patched) > > > > > > is it necessary to call trimToEmpty()?

Re: Review Request 71894: RANGER-2669: Blacklist for Ranger Audits

2019-12-12 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71894/ --- (Updated Dec. 12, 2019, 7:28 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 71893: RANGER-2668 : Remove tag service linking for any service created in Ranger KMS

2019-12-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71893/#review219014 ---

[jira] [Commented] (RANGER-2565) Remove duplicate error messages when test connection fails

2019-12-12 Thread peng.jianhua (Jira)
[ https://issues.apache.org/jira/browse/RANGER-2565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16994573#comment-16994573 ] peng.jianhua commented on RANGER-2565: -- Committed to master. > Remove duplicate error messages

Re: Review Request 71467: RANGER-2565 Remove duplicate error messages when test connection fails

2019-12-12 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71467/#review219012 --- Ship it! Ship It! - pengjianhua On 九月 11, 2019, 9:50 a.m.,