Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-01-19 Thread bhavik patel
> On Jan. 19, 2022, 7:56 a.m., bhavik patel wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java > > Lines 26 (patched) > > > > > > please use slf4j logger factory > > Kirby Zhou

[jira] [Resolved] (RANGER-3589) Ranger java patches failing due to admin privilege checks.

2022-01-19 Thread Pradeep Agrawal (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pradeep Agrawal resolved RANGER-3589. - Fix Version/s: 3.0.0 Resolution: Fixed

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-01-19 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73807/ --- (Updated 一月 20, 2022, 3:29 a.m.) Review request for ranger, Dhaval Shah,

[jira] [Commented] (RANGER-3557) Upgrade to use log4j 2.17.0+ version to ensure that we are using supported version of log4j

2022-01-19 Thread Brahma Reddy Battula (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478718#comment-17478718 ] Brahma Reddy Battula commented on RANGER-3557: -- {quote}2.17.1 {quote}

Re: Review Request 73805: RANGER-3589 : Ranger java patches failing due to admin privilege checks.

2022-01-19 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73805/#review223974 --- Ship it! Ship It! - Abhay Kulkarni On Jan. 19, 2022, 11:49

[jira] [Commented] (RANGER-3580) Support Ranger KMS integration with TencentKMS

2022-01-19 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478703#comment-17478703 ] Dhaval Shah commented on RANGER-3580: - Hi [~kirbyzhou], Thanks for creating the review request. I

Re: Review Request 73805: RANGER-3589 : Ranger java patches failing due to admin privilege checks.

2022-01-19 Thread Mateen Mansoori
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73805/ --- (Updated Jan. 19, 2022, 11:49 a.m.) Review request for ranger, Dhaval Shah,

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-01-19 Thread Kirby Zhou
> On 一月 19, 2022, 7:56 a.m., bhavik patel wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyVaultKeyGenerator.java > > Line 36 (original), 37 (patched) > > > > > > is it better option to upadate the

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-01-19 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73807/ --- (Updated 一月 19, 2022, 10:40 a.m.) Review request for ranger, Dhaval Shah,

[jira] [Commented] (RANGER-217) Add LDAPS support / fix incorrectly returning Bad Credentials for connection problem

2022-01-19 Thread Yuktaa Tiwari (Jira)
[ https://issues.apache.org/jira/browse/RANGER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478510#comment-17478510 ] Yuktaa Tiwari commented on RANGER-217: -- Hi, could you please provide the required documentation

[jira] [Comment Edited] (RANGER-217) Add LDAPS support / fix incorrectly returning Bad Credentials for connection problem

2022-01-19 Thread Yuktaa Tiwari (Jira)
[ https://issues.apache.org/jira/browse/RANGER-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478510#comment-17478510 ] Yuktaa Tiwari edited comment on RANGER-217 at 1/19/22, 9:57 AM: Could you

Re: Review Request 73806: RANGER-3498: replaced use of org.apache.log4j and org.apache.commons.logging with org.slf4j

2022-01-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73806/ --- (Updated Jan. 19, 2022, 8:09 a.m.) Review request for ranger, Ankita Sinha,