Review Request 74734: RANGER-4525: Upgrade spotbugs plugin to 4.7.3.5

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74734/
---

Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor 
Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, and Vishal Suvagia.


Bugs: RANGER-4525
https://issues.apache.org/jira/browse/RANGER-4525


Repository: ranger


Description
---

Upgrade spotbugs plugin to 4.7.3.5 as current version download the 
commons-text-1.9 dependency and which is vulnerable.


Diffs
-

  pom.xml 6f3094c48 


Diff: https://reviews.apache.org/r/74734/diff/1/


Testing
---

1. commons-text-1.9 jar is not download in m2 repo.
2. No additional spotbug findings.


Thanks,

bhavik patel

[jira] [Updated] (RANGER-4525) Upgrade spotbugs plugin to 4.7.3.5

[Bhavik Patel (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhavik Patel updated RANGER-4525:
-
Attachment: 0001-RANGER-4525-Upgrade-spotbugs-plugin-to-4.7.3.5.patch

> Upgrade spotbugs plugin to 4.7.3.5
> --
>
> Key: RANGER-4525
> URL: https://issues.apache.org/jira/browse/RANGER-4525
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Bhavik Patel
>Assignee: Bhavik Patel
>Priority: Major
> Attachments: 0001-RANGER-4525-Upgrade-spotbugs-plugin-to-4.7.3.5.patch
>
>
> Upgrade spotbugs plugin to 4.7.3.5 as current version download the 
> commons-text-1.9 dependency and which is vulnerable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4525) Upgrade spotbugs plugin to 4.7.3.5

[Bhavik Patel (Jira)]

Bhavik Patel created RANGER-4525:


 Summary: Upgrade spotbugs plugin to 4.7.3.5
 Key: RANGER-4525
 URL: https://issues.apache.org/jira/browse/RANGER-4525
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Affects Versions: 2.4.0, 3.0.0
Reporter: Bhavik Patel
Assignee: Bhavik Patel


Upgrade spotbugs plugin to 4.7.3.5 as current version download the 
commons-text-1.9 dependency and which is vulnerable.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74733: RANGER-4441 : Upgrade maven compiler plugin to 3.5

[bhavik patel]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74733/
---

Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor 
Gollapalliwar, Madhan Neethiraj, Pradeep Agrawal, and Vishal Suvagia.


Bugs: RANGER-4441
https://issues.apache.org/jira/browse/RANGER-4441


Repository: ranger


Description
---

Upgrade maven compiler plugin to 3.5 and current version 3.3 tried to download 
log4j-1.2 jar.


Diffs
-

  plugin-nestedstructure/pom.xml 0e208f99c 
  pom.xml 6f3094c48 


Diff: https://reviews.apache.org/r/74733/diff/1/


Testing
---

1. Compile and build the package.
2. Installed Ranger admin, usersync, tagsync and KMS service are installed and 
started.
3. log4j-1.2 jar is not download in m2 repo.


Thanks,

bhavik patel

[jira] [Updated] (RANGER-4441) Upgrade maven compiler plugin to 3.5

[Bhavik Patel (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhavik Patel updated RANGER-4441:
-
Attachment: 0001-RANGER-4441-Upgrade-maven-compiler-plugin-to-3.5.patch

> Upgrade maven compiler plugin to 3.5
> 
>
> Key: RANGER-4441
> URL: https://issues.apache.org/jira/browse/RANGER-4441
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0, 2.4.0
>Reporter: Bhavik Patel
>Assignee: Bhavik Patel
>Priority: Major
> Attachments: 
> 0001-RANGER-4441-Upgrade-maven-compiler-plugin-to-3.5.patch
>
>
> Upgrade maven compiler plugin to 3.5 and current version 3.3 tried to 
> download log4j-1.2 jar. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4524) FIx TestRangerMetricsContainerSource class UT

[Bhavik Patel (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhavik Patel updated RANGER-4524:
-
Description: 
Steps to reproduce:

1. clean .m2 repo and trigger the test-cases.


{code:java}
java.lang.NoClassDefFoundError: org/apache/log4j/Level at 
org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)
 Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level at 
org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46){code}

  was:java.lang.NoClassDefFoundError: org/apache/log4j/Level at 
org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)
 Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level at 
org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)


> FIx TestRangerMetricsContainerSource class UT
> -
>
> Key: RANGER-4524
> URL: https://issues.apache.org/jira/browse/RANGER-4524
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Bhavik Patel
>Assignee: Bhavik Patel
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 
> 0001-RANGER-4524-Fix-TestRangerMetricsContainerSource-cla.patch
>
>
> Steps to reproduce:
> 1. clean .m2 repo and trigger the test-cases.
> {code:java}
> java.lang.NoClassDefFoundError: org/apache/log4j/Level at 
> org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)
>  Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level at 
> org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46){code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4524) FIx TestRangerMetricsContainerSource class UT

[Bhavik Patel (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhavik Patel updated RANGER-4524:
-
Attachment: 0001-RANGER-4524-Fix-TestRangerMetricsContainerSource-cla.patch

> FIx TestRangerMetricsContainerSource class UT
> -
>
> Key: RANGER-4524
> URL: https://issues.apache.org/jira/browse/RANGER-4524
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Affects Versions: 3.0.0
>Reporter: Bhavik Patel
>Assignee: Bhavik Patel
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 
> 0001-RANGER-4524-Fix-TestRangerMetricsContainerSource-cla.patch
>
>
> java.lang.NoClassDefFoundError: org/apache/log4j/Level at 
> org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)
>  Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level at 
> org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] RANGER-2128: Implementation of Ranger Spark SQL plugin [ranger]

[via GitHub]

yaooqinn closed pull request #26: RANGER-2128: Implementation of Ranger Spark 
SQL plugin
URL: https://github.com/apache/ranger/pull/26


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] RANGER-2128: Implementation of Ranger Spark SQL plugin [ranger]

[via GitHub]

yaooqinn commented on PR #26:
URL: https://github.com/apache/ranger/pull/26#issuecomment-1805178170

   I am going to close this in favor of the kyuubi spark authz plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (RANGER-4524) FIx TestRangerMetricsContainerSource class UT

[Bhavik Patel (Jira)]

Bhavik Patel created RANGER-4524:


 Summary: FIx TestRangerMetricsContainerSource class UT
 Key: RANGER-4524
 URL: https://issues.apache.org/jira/browse/RANGER-4524
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Affects Versions: 3.0.0
Reporter: Bhavik Patel
Assignee: Bhavik Patel
 Fix For: 3.0.0


java.lang.NoClassDefFoundError: org/apache/log4j/Level at 
org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)
 Caused by: java.lang.ClassNotFoundException: org.apache.log4j.Level at 
org.apache.ranger.metrics.source.TestRangerMetricsContainerSource.init(TestRangerMetricsContainerSource.java:46)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4523) Suggestion on improving logs from AtlasNotificationMapper

[suja s (Jira)]

suja s created RANGER-4523:
--

 Summary: Suggestion on improving logs from AtlasNotificationMapper
 Key: RANGER-4523
 URL: https://issues.apache.org/jira/browse/RANGER-4523
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: suja s


STEPS TO REPRODUCE:
Create hive db/table so that hive entities are created on atlas side
Create classifications
Create a tag policy and verify tag policy enforcement
Inspect tagsync logs

CURRENT BEHAVIOUR:
Since hive_process entity-type notifications are not handled by tagsync, there 
is a WARN message indicating this.
There are lot of log messages related to this
{noformat}
2023-10-09 08:14:02,300 WARN  
org.apache.ranger.tagsync.source.atlas.AtlasNotificationMapper: [Thread-19]: 
Tag-sync is not enabled to handle notifications for Entity-type:[hive_process]
2023-10-09 08:14:02,300 WARN  
org.apache.ranger.tagsync.source.atlas.AtlasNotificationMapper: [Thread-19]: 
Dropped process entity notification for Atlas-Entity [{typeName=hive_process, 
guid=41cffa4b-be0e-42ca-aa16-688e1b00526e, attributes={ name=qualifiedName, 
value=rgrtestdb.rgrtblctas@cm:1696835704000 name=clusterName, value=cm 
name=name, value=rgrtestdb.rgrtblctas@cm:1696835704000}]
{noformat}

Suggestion:
The logs related to dropping of notifications for hive_process can be logged as 
DEBUG/INFO rather than WARN



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74678: RANGER:4397:API to get DataShare id, name, description List

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74678/#review225959
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 18, 2023, 8:53 a.m., Prashant Satam wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74678/
> ---
> 
> (Updated Oct. 18, 2023, 8:53 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, 
> Monika Kachhadiya, and Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4397
> https://issues.apache.org/jira/browse/RANGER-4397
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Dataset Details >> Add a Datashare >> List Datashares pop up,
> Need a GET API to get all datashares, based on LIST ACL for current user
> Exclude existing one for which request is is available GRANTED, ACTIVE, 
> REQUESTED states 
> Response: id, Name, Descrption
> Request: datasetId, excludeExistingDataShare
> Filter: partial search on datashare name, Pagination
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java 
> 93bd7f73d 
>   security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java 
> 10986823d 
>   security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java 
> 719d8a900 
>   
> security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareInDatasetDao.java
>  7637b275d 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 547913488 
> 
> 
> Diff: https://reviews.apache.org/r/74678/diff/3/
> 
> 
> Testing
> ---
> 
> 1)Create 1 dataset
> 2)create multiple dataShares
> 3)Link datasets to dataShares with status as ACITVE as well as DENIED
> 4)Get dataShares by GET-API(/service/gds/datashare/) using query param 
> excludeDatasetId=true
> 5)You will only get dataShares which are not mapped to any dataset and 
> existing mapped datashares having status(DENIED,NONE)
> 
> Request-> 
> (/service/gds/datashare/?excludeDatasetId=true=1=RangerDataShare11)
> Response>
> {
> "startIndex": 0,
> "pageSize": 200,
> "totalCount": 1,
> "resultSize": 1,
> "sortType": "dataShareId",
> "sortBy": "asc",
> "queryTimeMS": 1697525773619,
> "list": [
> {
> "id": 3,
> "guid": "cb7a8d8e-b082-4c4c-98c7-25b204e8b83c",
> "isEnabled": true,
> "createdBy": "Admin",
> "updatedBy": "Admin",
> "createTime": 1697525717000,
> "updateTime": 1697525717000,
> "version": 1,
> "name": "RangerDataShare11",
> "description":"This is dataShare DESCRIPTION",
> "acl": {
> "users": {
> "admin": "ADMIN"
> }
> },
> "service": "Ranger_hive",
> "zone": " "
> }
> ],
> "listSize": 1
> }
> 
> 
> Thanks,
> 
> Prashant Satam
> 
>

Re: Review Request 74603: RANGER-4373: Deleting a role which is already present in policy is giving incorrect message.

[Ramesh Mani]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74603/#review225958
---


Ship it!




Ship It!

- Ramesh Mani


On Sept. 14, 2023, 11:46 a.m., sanket shelar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74603/
> ---
> 
> (Updated Sept. 14, 2023, 11:46 a.m.)
> 
> 
> Review request for ranger, dinesh  akhand, Kishor Gollapalliwar, Abhay 
> Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4373
> https://issues.apache.org/jira/browse/RANGER-4373
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> In case if a role is already present in policy and we try to delete the role 
> then we are getting message as "data not found" instead of "Role  can not be 
> deleted as it is referenced in one or more policies
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 4bfaa862c 
>   security-admin/src/test/java/org/apache/ranger/rest/TestRoleREST.java 
> 2da72a1ea 
> 
> 
> Diff: https://reviews.apache.org/r/74603/diff/1/
> 
> 
> Testing
> ---
> 
> Tested for role delete scenarios.
> 
> 
> Thanks,
> 
> sanket shelar
> 
>

[jira] [Updated] (RANGER-4270) Policy engine enhancements to evaluate GDS policies

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4270:
-
Description: Policy engine currently evaluates both resource-based policies 
and tag-based policies. This should be enhanced to support GDS policies as 
well.  (was: Policy engine currently evaluates both resource-based policies and 
tag-based policies. This should be enhanced to support GDS policies as well - 
for access, masking and row-filtering.)
Summary: Policy engine enhancements to evaluate GDS policies  (was: 
Policy engine enhancements to evaluate GDS policies for 
access/masking/row-filtering)

> Policy engine enhancements to evaluate GDS policies
> ---
>
> Key: RANGER-4270
> URL: https://issues.apache.org/jira/browse/RANGER-4270
> Project: Ranger
>  Issue Type: Sub-task
>  Components: plugins
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Policy engine currently evaluates both resource-based policies and tag-based 
> policies. This should be enhanced to support GDS policies as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (RANGER-4270) Policy engine enhancements to evaluate GDS policies

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj resolved RANGER-4270.
--
Fix Version/s: 3.0.0
   Resolution: Fixed

Enhancements included in RANGER-4269.

> Policy engine enhancements to evaluate GDS policies
> ---
>
> Key: RANGER-4270
> URL: https://issues.apache.org/jira/browse/RANGER-4270
> Project: Ranger
>  Issue Type: Sub-task
>  Components: plugins
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
>
> Policy engine currently evaluates both resource-based policies and tag-based 
> policies. This should be enhanced to support GDS policies as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74699: RANGER-4497: updated service-defs to assign category to access-type-defs

[Madhan Neethiraj]

> On Oct. 28, 2023, 6:58 a.m., Subhrat Chaudhary wrote:
> > agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json
> > Lines 182 (patched)
> > 
> >
> > should the category be UPDATE or MANAGE here? Same for Alter in 
> > ranger-servicedef-kudu.json and ranger-servicedef-presto.json.

ALTER is a metadata operation, hence categoriezed as CREATE.


- Madhan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74699/#review225900
---


On Oct. 26, 2023, 8:49 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74699/
> ---
> 
> (Updated Oct. 26, 2023, 8:49 a.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Mugdha Varadkar, Prashant Satam, Ramesh Mani, 
> Subhrat Chaudhary, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-4497
> https://issues.apache.org/jira/browse/RANGER-4497
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> - updated all service-defs to assign category to access-types
> 
> 
> Diffs
> -
> 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-abfs.json 
> 879df6b9f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json 
> 960f10123 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-elasticsearch.json
>  da621c748 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json 
> f94e73a5e 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json 
> bc021a0dd 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 
> ab8ca5c92 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json 
> a131ed08b 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kms.json 
> abd28f034 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json 
> ee44687b4 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kudu.json 
> 51fd9f8a2 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json 
> 70566dfd6 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-nestedstructure.json
>  dc6b1d32d 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json
>  3db268bb8 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-nifi.json 
> 30680083f 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json 
> 13915130c 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json 
> b16b02a7b 
>   
> agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json
>  bdebf406d 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json 
> 50545f744 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-sqoop.json 
> 544276e9a 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json 
> 4db4a7431 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-trino.json 
> 88a57e1f0 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-wasb.json 
> fd30c51d8 
>   agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json 
> b102641ee 
> 
> 
> Diff: https://reviews.apache.org/r/74699/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that assigned categories are persisted in the database
> - verified that implied-grants of markerAccessTypes are populated with 
> access-types having respective category
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 74731: RANGER-4522: fixed NPE in RangerGdsInfoRefresher.run()

[Abhay Kulkarni]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74731/#review225956
---


Ship it!




Ship It!

- Abhay Kulkarni


On Nov. 9, 2023, 6:46 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74731/
> ---
> 
> (Updated Nov. 9, 2023, 6:46 p.m.)
> 
> 
> Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
> Parikh, Monika Kachhadiya, Prashant Satam, Ramesh Mani, Siddhesh Phatak, and 
> Subhrat Chaudhary.
> 
> 
> Bugs: RANGER-4522
> https://issues.apache.org/jira/browse/RANGER-4522
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> updated to start the refresher thread after initialization is done
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java
>  8a7936766 
> 
> 
> Diff: https://reviews.apache.org/r/74731/diff/1/
> 
> 
> Testing
> ---
> 
> - verified in Hive plugin that GDS refresher doesn't hit NPE
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 74731: RANGER-4522: fixed NPE in RangerGdsInfoRefresher.run()

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74731/
---

Review request for ranger, Anand Nadar, Ankita Sinha, Abhay Kulkarni, Mehul 
Parikh, Monika Kachhadiya, Prashant Satam, Ramesh Mani, Siddhesh Phatak, and 
Subhrat Chaudhary.


Bugs: RANGER-4522
https://issues.apache.org/jira/browse/RANGER-4522


Repository: ranger


Description
---

updated to start the refresher thread after initialization is done


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java
 8a7936766 


Diff: https://reviews.apache.org/r/74731/diff/1/


Testing
---

- verified in Hive plugin that GDS refresher doesn't hit NPE


Thanks,

Madhan Neethiraj

[jira] [Created] (RANGER-4522) NPE in RangerGdsInfoRefresher.run()

[Madhan Neethiraj (Jira)]

Madhan Neethiraj created RANGER-4522:


 Summary: NPE in RangerGdsInfoRefresher.run()
 Key: RANGER-4522
 URL: https://issues.apache.org/jira/browse/RANGER-4522
 Project: Ranger
  Issue Type: Sub-task
  Components: plugins
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Following exception is logged from RangerGdsInfoRefresher.run():
{code:java}
2023-11-09T16:37:27,450 ERROR [RangerGdsInfoRefresher] 
contextenricher.RangerGdsEnricher: 
RangerGdsInfoRefresher(serviceName=dev_hive).run() failed to download gdsInfo. 
Will retry again
java.lang.NullPointerException: null
at 
org.apache.ranger.plugin.contextenricher.RangerGdsEnricher$RangerGdsInfoRefresher.run(RangerGdsEnricher.java:265)
 ~[ranger-plugins-common-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
{code}
Note that the refresher recovers from this error once its initialization is 
complete, and it successfully download GDS info from Ranger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4522) NPE in RangerGdsInfoRefresher.run()

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated RANGER-4522:
-
Reporter: Subhrat Chaudhary  (was: Madhan Neethiraj)

> NPE in RangerGdsInfoRefresher.run()
> ---
>
> Key: RANGER-4522
> URL: https://issues.apache.org/jira/browse/RANGER-4522
> Project: Ranger
>  Issue Type: Sub-task
>  Components: plugins
>Reporter: Subhrat Chaudhary
>Assignee: Madhan Neethiraj
>Priority: Major
>
> Following exception is logged from RangerGdsInfoRefresher.run():
> {code:java}
> 2023-11-09T16:37:27,450 ERROR [RangerGdsInfoRefresher] 
> contextenricher.RangerGdsEnricher: 
> RangerGdsInfoRefresher(serviceName=dev_hive).run() failed to download 
> gdsInfo. Will retry again
> java.lang.NullPointerException: null
> at 
> org.apache.ranger.plugin.contextenricher.RangerGdsEnricher$RangerGdsInfoRefresher.run(RangerGdsEnricher.java:265)
>  ~[ranger-plugins-common-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
> {code}
> Note that the refresher recovers from this error once its initialization is 
> complete, and it successfully download GDS info from Ranger.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (RANGER-4283) UI for GDS: dashboard, datasets, projects, data-shares

[Madhan Neethiraj (Jira)]

[ 
https://issues.apache.org/jira/browse/RANGER-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784549#comment-17784549
 ] 

Madhan Neethiraj commented on RANGER-4283:
--

{noformat}
commit c71e57fd62587033c389ebfaf58c4984474c3cd4 (HEAD -> RANGER-3923, 
origin/RANGER-3923)
Author: Anand Nadar 
Date:   Thu Nov 9 07:45:43 2023 -0800

RANGER-4283: [WIP] UI for GDS: shared resource design fix, CSS. bug fixes

Signed-off-by: Madhan Neethiraj 
{noformat}

> UI for GDS: dashboard, datasets, projects, data-shares
> --
>
> Key: RANGER-4283
> URL: https://issues.apache.org/jira/browse/RANGER-4283
> Project: Ranger
>  Issue Type: Sub-task
>  Components: admin
>Reporter: Madhan Neethiraj
>Assignee: Anand Nadar
>Priority: Major
>
> New tab: Governed Data Sharing with the following:
>  * My Datasets
>  ** List of datasets created/owned by current user
>  *** For each dataset: name, status, created time, last updated time, 
> data-share counts (active/pending), shared-with counts 
> (users/groups/roles/projects), View/Edit/Delete buttons
>  ** Create a new dataset
>  * My Projects
>  ** List of projects created/owned by current user
>  *** For each project: name, status, created time, last updated time, dataset 
> counts (active/pending), shared-with counts (users/groups/roles), 
> View/Edit/Delete buttons
>  ** Create a new project
>  * My Data Shares
>  ** List of data-shares created/owned by current user
>  *** For each data-share: name, service, zone, status, created time, last 
> updated time, resource counts, dataset counts (active/pending), 
> View/Edit/Delete buttons
>  ** Create a new data-share
>  * My Requests
>  ** List of share requests created by me/my-groups/my-roles
>  *** For each request: data-share name, status, created time, last updated 
> time, created-by, approved-by, View/Edit/Delete buttons
>  ** Create a new request to:
>  *** add a data-share to your dataset/project
>  * Shared with me: Datasets
>  * Shared with me: Projects
>  * Dataset Details: view or edit
>  ** name, description, status, created time, last update time, owners, 
> terms-of-use, edit history
>  ** List of data-shares in the dataset
>  *** For each data-share: name, service, zone, share-status (link to 
> share-request), created time, last updated time, resource counts, 
> View/Edit/Remove buttons
>  ** Button to request a data-share
>  ** Shared with:
>  *** List of users/groups/roles with whom this dataset is shared
>  *** List of projects that include this dataset
>   For each project: name, share-status (link to share-request), created 
> time, last updated time, View/Edit/Remove buttons
>  
> CC: [~ni3galave], [~ankita], [~Dhaval.Rajpara], [~mugdha], [~vel], [~abhay] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74730: RANGER-4283: [WIP] UI for GDS: shared resource design fix, CSS. bug fixes

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74730/#review225953
---


Ship it!




Ship It!

- Madhan Neethiraj


On Nov. 9, 2023, 1:03 p.m., Anand Nadar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74730/
> ---
> 
> (Updated Nov. 9, 2023, 1:03 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, 
> Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/RANGER-4283
> 
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> UI for GDS: shared resource design fix, CSS. bug fixes
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/webapp/react-webapp/src/images/view-request.svg 
> PRE-CREATION 
>   security-admin/src/main/webapp/react-webapp/src/styles/style.css e00450bf0 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx
>  4a6b7c402 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx
>  43d023caa 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx
>  5616fca6f 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx
>  e0b9a19f9 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/PrinciplePermissionComp.jsx
>  c39201941 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx
>  483b89ea0 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx
>  eb489535c 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx
>  4c777286d 
>   
> security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/MyDatashareListing.jsx
>  eb877a04b 
>   
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx
>  e2ef63188 
> 
> 
> Diff: https://reviews.apache.org/r/74730/diff/1/
> 
> 
> Testing
> ---
> 
> Validated create/update/delete for shared resource with new design
> Validated Save & Close, Save & Add another functionality for shared resource 
> creation.
> Validated edit of dataset and datashare names.
> CSS for access grant page.
> 
> 
> Thanks,
> 
> Anand Nadar
> 
>

Review Request 74730: RANGER-4283: [WIP] UI for GDS: shared resource design fix, CSS. bug fixes

[Anand Nadar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74730/
---

Review request for ranger, Ankita Sinha, Brijesh Bhalala, Dhaval Rajpara, 
Madhan Neethiraj, Mugdha Varadkar, Prashant Satam, and Subhrat Chaudhary.


Bugs: https://issues.apache.org/jira/browse/RANGER-4283

https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283


Repository: ranger


Description
---

UI for GDS: shared resource design fix, CSS. bug fixes


Diffs
-

  security-admin/src/main/webapp/react-webapp/src/images/view-request.svg 
PRE-CREATION 
  security-admin/src/main/webapp/react-webapp/src/styles/style.css e00450bf0 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx
 4a6b7c402 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx
 43d023caa 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatashareInDatasetListComp.jsx
 5616fca6f 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/MyDatasetListing.jsx
 e0b9a19f9 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/PrinciplePermissionComp.jsx
 c39201941 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddDatashareView.jsx
 483b89ea0 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx
 eb489535c 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx
 4c777286d 
  
security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/MyDatashareListing.jsx
 eb877a04b 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx
 e2ef63188 


Diff: https://reviews.apache.org/r/74730/diff/1/


Testing
---

Validated create/update/delete for shared resource with new design
Validated Save & Close, Save & Add another functionality for shared resource 
creation.
Validated edit of dataset and datashare names.
CSS for access grant page.


Thanks,

Anand Nadar

[jira] [Assigned] (RANGER-4521) All records not displayed on Admin Audits UI when filtered using session ID

[Mugdha Varadkar (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mugdha Varadkar reassigned RANGER-4521:
---

Assignee: Rakesh Gupta

> All records not displayed on Admin Audits UI when filtered using session ID
> ---
>
> Key: RANGER-4521
> URL: https://issues.apache.org/jira/browse/RANGER-4521
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: suja s
>Assignee: Rakesh Gupta
>Priority: Major
>
> STEPS TO REPRODUCE:
> Login as keyadmin user to Ranger Admin UI.
> Add a ranger kms policy by doing a json import.
> Navigate to Admin Audits on UI
> Click on the session ID corresponding to policy import and select "Show 
> Actions" so that audits related to specific sessionID are displayed
> CURRENT BEHAVIOUR:
> Some audit entries are missing when filtered using sessionID
> (Audots for import and export are shown, audit corresponding to policy create 
> is missing)
> EXPECTED BEHAVIOUR:
> All audits corresponding to filtered sessionID should be displayed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4521) All records not displayed on Admin Audits UI when filtered using session ID

[suja s (Jira)]

suja s created RANGER-4521:
--

 Summary: All records not displayed on Admin Audits UI when 
filtered using session ID
 Key: RANGER-4521
 URL: https://issues.apache.org/jira/browse/RANGER-4521
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: suja s


STEPS TO REPRODUCE:
Login as keyadmin user to Ranger Admin UI.
Add a ranger kms policy by doing a json import.
Navigate to Admin Audits on UI
Click on the session ID corresponding to policy import and select "Show 
Actions" so that audits related to specific sessionID are displayed

CURRENT BEHAVIOUR:
Some audit entries are missing when filtered using sessionID
(Audots for import and export are shown, audit corresponding to policy create 
is missing)

EXPECTED BEHAVIOUR:
All audits corresponding to filtered sessionID should be displayed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (RANGER-4491) Need new API for DataShare in Dataset Summary

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam resolved RANGER-4491.

Resolution: Duplicate

> Need new API for DataShare in Dataset Summary 
> --
>
> Key: RANGER-4491
> URL: https://issues.apache.org/jira/browse/RANGER-4491
> Project: Ranger
>  Issue Type: Sub-task
>  Components: Ranger
>Reporter: Prashant Satam
>Priority: Major
>  Labels: invald
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (RANGER-4489) Need new API for DataShare in Dataset Summary

[Prashant Satam (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashant Satam resolved RANGER-4489.

Resolution: Duplicate

> Need new API for DataShare in Dataset Summary 
> --
>
> Key: RANGER-4489
> URL: https://issues.apache.org/jira/browse/RANGER-4489
> Project: Ranger
>  Issue Type: Task
>  Components: Ranger
>Reporter: Prashant Satam
>Assignee: Prashant Satam
>Priority: Major
>
> Get dataShareInDataset Summary objects with
> FIELDS 
> (datasetId,datasetName,dataShareId,dataShareName,serviceId,serviceName,zoneId,resoueceCount(based
>  on dataShare),zoneName,shareStatus,)
> Supported Query Params
> linkedServiceId,linkedServiceName,linkedServiceNamePartial,linkedZoneId,linkedZoneName,linkedZoneNamePartial,linkedProjectId,linkedProjectName,linkedProjectNamePartial
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (RANGER-4520) Both usersync/tagsync instances becoming active and syncing users/tags

[Sanket Shelar (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sanket Shelar reassigned RANGER-4520:
-

Assignee: Sanket Shelar

> Both usersync/tagsync instances becoming active and syncing users/tags
> --
>
> Key: RANGER-4520
> URL: https://issues.apache.org/jira/browse/RANGER-4520
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: suja s
>Assignee: Sanket Shelar
>Priority: Major
>
> Both usersync/tagsync instances becoming active and syncing users/tags in the 
> following scenario
> Scenario:
> Bring up 2 instances of UserSync so that one is active and other is passive
> Cluster has 3 zk instances, stop 2 zk servers so that there is no quorum
> Both usersync instances fail to establish Zk connection
> Start both zk servers
> Both usersync instances have transitioned to active and started performing 
> usersync
> Same issue exists for tagsync also
> Test:
> Add user u1 to host1
> Add user u2 to host2
> Both users are synced and available on ranger admin side.
> Usersync audits show details of both users synced
> EXPECTED BEHAVIOUR:
> In case of usersync/tagsync running in HA mode, there should be only 1 
> instance active at any point of time
> CURRENT BEHAVIOUR:
> After zk goes down and is back functional, more than 1 usersync/tagsync 
> instance becoming active



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4520) Both usersync/tagsync instances becoming active and syncing users/tags

[suja s (Jira)]

suja s created RANGER-4520:
--

 Summary: Both usersync/tagsync instances becoming active and 
syncing users/tags
 Key: RANGER-4520
 URL: https://issues.apache.org/jira/browse/RANGER-4520
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: suja s


Both usersync/tagsync instances becoming active and syncing users/tags in the 
following scenario
Scenario:
Bring up 2 instances of UserSync so that one is active and other is passive
Cluster has 3 zk instances, stop 2 zk servers so that there is no quorum
Both usersync instances fail to establish Zk connection
Start both zk servers
Both usersync instances have transitioned to active and started performing 
usersync
Same issue exists for tagsync also
Test:
Add user u1 to host1
Add user u2 to host2
Both users are synced and available on ranger admin side.
Usersync audits show details of both users synced

EXPECTED BEHAVIOUR:
In case of usersync/tagsync running in HA mode, there should be only 1 instance 
active at any point of time
CURRENT BEHAVIOUR:
After zk goes down and is back functional, more than 1 usersync/tagsync 
instance becoming active





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: Review Request 74696: RANGER-4360 : Error page 'Go back' button not redirecting to the right page.

[Dhaval Rajpara]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74696/
---

(Updated Nov. 9, 2023, 9:57 a.m.)


Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, 
Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Pradeep 
Agrawal, and Velmurugan Periasamy.


Bugs: RANGER-4360
https://issues.apache.org/jira/browse/RANGER-4360


Repository: ranger


Description
---

On error page Go back button not work properly


Diffs (updated)
-

  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 93629855c 
  security-admin/src/main/webapp/react-webapp/src/utils/fetchAPI.js fbdd91737 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 
c189c0a1b 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx 
6575dae24 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AuditLayout.jsx
 0537496f3 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx
 28d2bdb3e 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx
 cf4727514 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx 
55caa90bd 
  security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx 
0abe30017 
  
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx 
98ea88280 
  security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx 9e99e5077 
  security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086 
  security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx 49edc2861 
  
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx
 730d40103 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx
 90595f1b8 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx
 c1752c252 
  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx
 44d9f1da9 
  
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx
 e3d09c51e 
  
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx
 d97dcf041 
  
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx
 e672611dd 
  
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx
 0b2f46bec 
  
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx
 2df0c4d63 
  security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx 
e0ad55d59 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/UserGroupRoleListing.jsx
 bd829636e 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx
 332a3940d 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx
 8caecf058 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx
 dee4b196d 


Diff: https://reviews.apache.org/r/74696/diff/2/

Changes: https://reviews.apache.org/r/74696/diff/1-2/


Testing
---

Testing is in progress.


Thanks,

Dhaval Rajpara

[jira] [Updated] (RANGER-4513) Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.

[Brijesh Bhalala (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4513:

Attachment: 0001-RANGER-4513.patch

> Policy listing page experiences an  reset to Access tab when attempting to 
> filter the service and zone dropdown options. 
> -
>
> Key: RANGER-4513
> URL: https://issues.apache.org/jira/browse/RANGER-4513
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
> Attachments: 0001-RANGER-4513.patch
>
>
> The policy listing page experiences an unexpected reset when attempting to 
> filter the service and zone dropdown options. 
> *Steps to Reproduce:*
>  # Navigate to the "hive" policy listing page.
>  # Goto  Masking tab 
>  # Select the "Service" dropdown to filter policies based on a specific 
> service.
>  # Select the "Zone" dropdown to filter policies based on  specific zone.
>  # Observe that the page resets to the default "Access" tab
> *Expected Behavior:*
> The page should retain the selected tab when filtering the service and zone 
> dropdown.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74728: RANGER-4513: Policy listing page experiences an reset to Access tab when attempting to filter the service and zone dropdown options.

[Brijesh Bhalala]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74728/
---

Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.


Bugs: RANGER-4513
https://issues.apache.org/jira/browse/RANGER-4513


Repository: ranger


Description
---

The policy listing page experiences an unexpected reset when attempting to 
filter the service and zone dropdown options. 

Steps to Reproduce:
 1)Navigate to the "hive" policy listing page.
 2)Goto  Masking tab 
 3)Select the "Service" dropdown to filter policies based on a specific service.
 4)Select the "Zone" dropdown to filter policies based on  specific zone.
 5)Observe that the page resets to the default "Access" tab

Expected Behavior:

The page should retain the selected tab when filtering the service and zone 
dropdown.


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx
 44d9f1da9 
  security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 
d4dbc57d1 


Diff: https://reviews.apache.org/r/74728/diff/1/


Testing
---

Testing is in progress


Thanks,

Brijesh Bhalala

[jira] [Updated] (RANGER-4519) Update ServiceDef icons in service manager page

[Brijesh Bhalala (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4519:

Fix Version/s: 3.0.0

> Update ServiceDef icons in service manager page
> ---
>
> Key: RANGER-4519
> URL: https://issues.apache.org/jira/browse/RANGER-4519
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
> Fix For: 3.0.0
>
>
> Update ServiceDef icons in service manager page.
> The service manager page currently uses a  folder icon for displaying 
> ServiceDefs.
> We should update this to show a real logo or icon that is specific to each 
> ServiceDef.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4519) Update ServiceDef icons in service manager page

[Brijesh Bhalala (Jira)]

Brijesh Bhalala created RANGER-4519:
---

 Summary: Update ServiceDef icons in service manager page
 Key: RANGER-4519
 URL: https://issues.apache.org/jira/browse/RANGER-4519
 Project: Ranger
  Issue Type: Improvement
  Components: Ranger
Reporter: Brijesh Bhalala
Assignee: Brijesh Bhalala


Update ServiceDef icons in service manager page.

The service manager page currently uses a  folder icon for displaying 
ServiceDefs.
We should update this to show a real logo or icon that is specific to each 
ServiceDef.




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (RANGER-4519) Update ServiceDef icons in service manager page

[Brijesh Bhalala (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brijesh Bhalala updated RANGER-4519:

Labels: ranger-react  (was: )

> Update ServiceDef icons in service manager page
> ---
>
> Key: RANGER-4519
> URL: https://issues.apache.org/jira/browse/RANGER-4519
> Project: Ranger
>  Issue Type: Improvement
>  Components: Ranger
>Reporter: Brijesh Bhalala
>Assignee: Brijesh Bhalala
>Priority: Major
>  Labels: ranger-react
>
> Update ServiceDef icons in service manager page.
> The service manager page currently uses a  folder icon for displaying 
> ServiceDefs.
> We should update this to show a real logo or icon that is specific to each 
> ServiceDef.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (RANGER-4518) Improvement in state management for search filter parameters in Ranger React

[Mugdha Varadkar (Jira)]

Mugdha Varadkar created RANGER-4518:
---

 Summary: Improvement in state management for search filter 
parameters in Ranger React
 Key: RANGER-4518
 URL: https://issues.apache.org/jira/browse/RANGER-4518
 Project: Ranger
  Issue Type: Bug
  Components: Ranger
Reporter: Mugdha Varadkar
Assignee: Mugdha Varadkar


Need to improve, existing state management used for search filter parameter in 
Audit tab pages.





--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Review Request 74727: RANGER-4187: Not able to search using multiple user filter in access audit tab

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74727/
---

Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, and Nikunj 
Pansuriya.


Bugs: RANGER-4187
https://issues.apache.org/jira/browse/RANGER-4187


Repository: ranger


Description
---

This review request is providing a fix to support multiple user search filter 
in Ranger React structured filter.

Steps to reproduce the issue :
1. Go to access audit tab
2. Search with one user
3. Try selecting user filter again
At step 3 user filter is option is not available in the filter


Diffs
-

  
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/index.js
 82f73024ad63edc12cac70e47e0d86b9c85ed7df 
  security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 
93629855c45689e8e795117fef9620ce92c3ede6 
  
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 
c189c0a1b5d9e7810b028596021856fd12c803ff 


Diff: https://reviews.apache.org/r/74727/diff/1/


Testing
---

Testing is in progress


Thanks,

Mugdha Varadkar

[jira] [Updated] (RANGER-4187) Not able to search using multiple user filter in access audit tab

[Mugdha Varadkar (Jira)]

 [ 
https://issues.apache.org/jira/browse/RANGER-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mugdha Varadkar updated RANGER-4187:

Attachment: 0001-RANGER-4187.patch

> Not able to search using multiple user filter in access audit tab
> -
>
> Key: RANGER-4187
> URL: https://issues.apache.org/jira/browse/RANGER-4187
> Project: Ranger
>  Issue Type: Bug
>  Components: Ranger
>Reporter: Harshal Chavan
>Assignee: Mugdha Varadkar
>Priority: Major
>  Labels: ranger-react
> Attachments: 0001-RANGER-4187.patch
>
>
> Steps
> 1. Go to access audit tab
> 2. Search with one user 
> 3. Try selecting user filter again 
> Note -  we dont see user filter in 3 step



--
This message was sent by Atlassian Jira
(v8.20.10#820010)