Review Request 61555: RANGER-1726 : Users are not getting deleted when Knox proxy is Enabled.

2017-08-10 Thread Nikhil P
re getting deleted when knox proxy is enabled. 2.Verified if multiple users are getting deleted at once. 3.Verified if users are getting deleted when knox proxy is disabled. Thanks, Nikhil P

Re: Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-21 Thread Nikhil P
/ Testing --- 1)Verified if same resource does not get duplicated during create and update policy. 2)Verified if resource duplication does not happen through public API and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Re: Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-21 Thread Nikhil P
/ Testing --- 1)Verified if same resource does not get duplicated during create and update policy. 2)Verified if resource duplication does not happen through public API and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-20 Thread Nikhil P
. 2)Verified if resource duplication does not happen through public API and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-20 Thread Nikhil P
. 2)Verified if resource duplication does not happen through public API and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Re: Review Request 62882: Good coding practice-add additional headers in ranger

2017-10-17 Thread Nikhil P
ranger. Thanks, Nikhil P

Review Request 62078: Update NiFi service def and handle upgrade scenario.

2017-09-08 Thread Nikhil P
to check that exclude toggle is not visible on create/update policy page. 3)In ugrade scenario,checked if existing exclude polcies gets read only after upgrade. Thanks, Nikhil P

Review Request 62080: Update NiFi service def and handle upgrade scenario.

2017-09-08 Thread Nikhil P
to check that exclude toggle is not visible on create/update policy page. 3)In ugrade scenario,checked if existing exclude polcies gets read only after upgrade. Thanks, Nikhil P

Re: Review Request 62029: In Nifi default policy is getting created with policyitem without any user/group but permission is set for the same

2017-09-11 Thread Nikhil P
/diff/2/ Changes: https://reviews.apache.org/r/62029/diff/1-2/ Testing --- 1)tested that during service creation if default policy does not have valid policyItem then policy wont be created. 2)tested Nifi policy and service CRUD works properly. Thanks, Nikhil P

Re: Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-26 Thread Nikhil P
and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Re: Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-26 Thread Nikhil P
and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Re: Review Request 62436: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-27 Thread Nikhil P
and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Re: Review Request 62437: RANGER-1779 : last resource gets duplicated during update policy if policy is created through public api rest call

2017-09-27 Thread Nikhil P
and Public APIv2 as well. 3)Verified if policies are getting created with multiple distinct resource. Thanks, Nikhil P

Re: Review Request 61555: RANGER-1726 : Users are not getting deleted when Knox proxy is Enabled.

2017-08-22 Thread Nikhil P
d if users are getting deleted when knox proxy is disabled. Thanks, Nikhil P

Review Request 62029: In Nifi default policy is getting created with policyitem without any user/group but permission is set for the same

2017-09-01 Thread Nikhil P
service creation if default policy does not have valid policyItem then policy wont be created. 2)tested Nifi policy and service CRUD works properly. Thanks, Nikhil P

Re: Review Request 61990: RANGER-1754: correcting group deletion message

2017-08-30 Thread Nikhil P
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61990/#review184145 --- Ship it! Ship It! - Nikhil P On Aug. 30, 2017, 11:28 a.m

Review Request 62882: Good coding practice-add additional headers in ranger

2017-10-12 Thread Nikhil P
if response contains additional headers on kerberized ranger. 3)Verified if response contains additional headers on SSL ranger(https). 4)Verified if response contains additional headers on kerberized+SSL ranger. Thanks, Nikhil P

Review Request 64641: Improvement on Ranger-usersync log configuration

2017-12-18 Thread Nikhil P
- unixauthservice/scripts/ranger-usersync-services.sh 18dbc9a unixauthservice/scripts/setup.py 5f659d7 Diff: https://reviews.apache.org/r/64641/diff/1/ Testing --- 1)Tested on manual ranger-usersync install. 2)verified if logs are generating properly. Thanks, Nikhil P

Review Request 63461: Good coding practice in Ranger recommended by static code analysis

2017-11-01 Thread Nikhil P
of services,policies,users. Verified if ranger plugins are communating properly. Thanks, Nikhil P

Re: Review Request 67084: RANGER-2076 : Handle proxy users for Kerberos based authentication

2018-05-14 Thread Nikhil P
://reviews.apache.org/r/67084/diff/2/ Changes: https://reviews.apache.org/r/67084/diff/1-2/ Testing --- Validated on simple as well as kerberised environment. Thanks, Nikhil P

Review Request 67052: RANGER Admin UI login through knox proxy fails with 404

2018-05-10 Thread Nikhil P
- security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js c8b0c49 Diff: https://reviews.apache.org/r/67052/diff/1/ Testing --- 1)Tested on knox proxy environment. 2)Validated if ranger admin UI logs in successfully through knox proxy. Thanks, Nikhil P

Review Request 67084: Handle proxy users for Kerberos based authentication.

2018-05-11 Thread Nikhil P
://reviews.apache.org/r/67084/diff/1/ Testing --- Validated on simple as well as kerberised environment. Thanks, Nikhil P

Review Request 66946: Good coding practice for ranger response codes

2018-05-04 Thread Nikhil P
, Nikhil P

Review Request 67151: User is not able to see revoke audits for HBASE.

2018-05-16 Thread Nikhil P
. validated if user is able to see grant/revoke audits for hive. Thanks, Nikhil P

Review Request 67507: Improve ranger coverage of unit tests for REST layer.

2018-06-08 Thread Nikhil P
- security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java df0a927 Diff: https://reviews.apache.org/r/67507/diff/1/ Testing --- Checked if unit tests run properly. Thanks, Nikhil P

Review Request 67545: Good coding practices for REST classes and unit tests

2018-06-12 Thread Nikhil P
/67545/diff/1/ Testing --- tested on local machine. Thanks, Nikhil P

Review Request 67599: Ranger UserSync port (ie 5151) supports TLSv1.0

2018-06-15 Thread Nikhil P
if no property specified , default protocols should be supported. Thanks, Nikhil P

Re: Review Request 67507: Improve ranger coverage of unit tests for REST layer.

2018-06-11 Thread Nikhil P
, Nikhil P

Re: Review Request 67347: RANGER-2115: Atlas service-def creation failing during Ranger installation

2018-05-29 Thread Nikhil P
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67347/#review203971 --- Ship it! Ship It! - Nikhil P On May 29, 2018, 11:13 a.m

Review Request 67804: Improve ranger coverage of unit tests for REST layer.

2018-07-03 Thread Nikhil P
- security-admin/src/test/java/org/apache/ranger/rest/TestServiceTagProcessor.java PRE-CREATION Diff: https://reviews.apache.org/r/67804/diff/1/ Testing --- 1.Tested on local machine Thanks, Nikhil P

Review Request 65259: improvement on user-group page listing

2018-01-21 Thread Nikhil P
/biz/TestXUserMgr.java cdd581b Diff: https://reviews.apache.org/r/65259/diff/1/ Testing --- 1.Verified if user listing page is getting updated with new groupnames, once groupname is updated. 2.Verified If other ranger pages are also getting updated with new groupname. Thanks, Nikhil P

Re: Review Request 65525: Show actual hive query on ranger audit UI

2018-02-12 Thread Nikhil P
/ Testing --- 1.Verified various hive queries gets displayed on UI. 2.checked grant/revoke queries gets reflected correctly on UI. 3.verified if configurable hive query visibility property works properly. Thanks, Nikhil P

Review Request 65525: Show actual hive query on ranger audit UI

2018-02-05 Thread Nikhil P
visibility property works properly. Thanks, Nikhil P

Re: Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

2018-07-27 Thread Nikhil P
/ranger/rest/TestXUserREST.java e564e28 Diff: https://reviews.apache.org/r/68042/diff/2/ Changes: https://reviews.apache.org/r/68042/diff/1-2/ Testing --- Tested if email id filter & user roles along with other filters are working properly. Thanks, Nikhil P

Review Request 68062: Ranger to add default altlas policy for rangertagsync user.

2018-07-26 Thread Nikhil P
if rangertagsync user is getting access to read entity. 2.Validated if rangertagsync user is getting added in atlas entity policy. Thanks, Nikhil P

Re: Review Request 68228: Unit Test cases to cover policy operations from service admin user

2018-08-07 Thread Nikhil P
, Nikhil P

Review Request 68228: Unit Test cases to cover policy operations from service admin user

2018-08-06 Thread Nikhil P
(RANGER-2168) Diffs - security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java b0b0110 Diff: https://reviews.apache.org/r/68228/diff/1/ Testing --- Tested if unit test cases are running fine on local. Thanks, Nikhil P

Review Request 68042: 'Email Address' search is not working properly along with other filter in user listing page, userRoles filters also needs to be improved.

2018-07-25 Thread Nikhil P
: https://reviews.apache.org/r/68042/diff/1/ Testing --- Tested if email id filter & user roles along with other filters are working properly. Thanks, Nikhil P

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Nikhil P
nt = result = buildClient(); } } } return result; } - Nikhil --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-12 Thread Nikhil P
2018/03/12/3f7133ab-72f9-413e-997c-4d9265f88cdc__0003-RANGER-2010-Ranger-Tagsync-should-use-cookie-based-a.patch Thanks, Nikhil P

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-14 Thread Nikhil P
er-Tagsync-should-use-cookie-based-a.patch Thanks, Nikhil P

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-09 Thread Nikhil P
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/65920/#review198707 ------- On March 6, 2018, 4:46 p.m., Nikhil P wrote: > > --- > This is an au

Re: Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-09 Thread Nikhil P
works as expected. 2)verified if tagsync is not re-login for every notification if "ranger.tagsync.cookie.enabled" is set as true. Thanks, Nikhil P

Review Request 65920: Ranger Tagsync should use cookie based authentication for subsequent requests to Ranger admin

2018-03-06 Thread Nikhil P
if "ranger.tagsync.cookie.enabled" is set as true. Thanks, Nikhil P

Review Request 66448: Good coding practices for KMS and unixauth

2018-04-05 Thread Nikhil P
Diff: https://reviews.apache.org/r/66448/diff/1/ Testing --- 1)verified if Ranger KMS is working properly. 2)verified if unix authentication,pam authentication works properly. Thanks, Nikhil P

Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

2018-04-12 Thread Nikhil P
. Thanks, Nikhil P

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

2018-04-18 Thread Nikhil P
is not flooding table. 2)Validated if cookie is used by usersync client for subsequent requests to ranger-admin. Thanks, Nikhil P

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

2018-04-17 Thread Nikhil P
is not flooding table. 2)Validated if cookie is used by usersync client for subsequent requests to ranger-admin. Thanks, Nikhil P

Re: Review Request 66584: Ranger Usersync should use cookie based authentication for subsequent requests to Ranger admin

2018-04-16 Thread Nikhil P
is not flooding table. 2)Validated if cookie is used by usersync client for subsequent requests to ranger-admin. Thanks, Nikhil P

Re: Review Request 66245: Ranger Kafka default policy creation improvement

2018-04-03 Thread Nikhil P
/ Changes: https://reviews.apache.org/r/66245/diff/2-3/ Testing --- 1) Tested if required policies are getting created when required service configs are given. Thanks, Nikhil P

Review Request 66245: Ranger Kafka default policy creation improvement

2018-03-23 Thread Nikhil P
. Diffs - plugin-kafka/src/main/java/org/apache/ranger/services/kafka/RangerServiceKafka.java b7bbe98 Diff: https://reviews.apache.org/r/66245/diff/1/ Testing --- 1) Tested if required policies are getting created when required service configs are given. Thanks, Nikhil P

Review Request 65925: HDFS resource delegation improvement

2018-03-06 Thread Nikhil P
- agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java 78a3b8a Diff: https://reviews.apache.org/r/65925/diff/1/ Testing --- Tested for various HDFS resources such as wildcard, non wildcard resources. Thanks, Nikhil P

Review Request 69189: Implement best coding practices for validating user input

2018-10-26 Thread Nikhil P
input Diffs - security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 60c25fa Diff: https://reviews.apache.org/r/69189/diff/1/ Testing --- 1.Tested on local Thanks, Nikhil P

Review Request 69228: Allow service admin and delegated admin user to view list of users and groups though they have 'USER' role

2018-11-01 Thread Nikhil P
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 4a6a769 security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 2b996b0 Diff: https://reviews.apache.org/r/69228/diff/1/ Testing --- 1.tested on local VM. Thanks, Nikhil P

Re: Review Request 69228: Allow service admin and delegated admin user to view list of users and groups though they have 'USER' role

2018-11-02 Thread Nikhil P
2b996b0e1 security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js d5bad70df Diff: https://reviews.apache.org/r/69228/diff/3/ Changes: https://reviews.apache.org/r/69228/diff/2-3/ Testing --- 1.tested on local VM. Thanks, Nikhil P

Re: Review Request 68881: RANGER-2203: Review and update database schema for ranger policies to minimize database queries/updates

2018-10-09 Thread Nikhil P
/PolicyRefUpdater.java Lines 88 (patched) <https://reviews.apache.org/r/68881/#comment293743> null check is needed for policyItem.getGroups() as well as policyItem.getUsers() - Nikhil P On Oct. 9, 2018, 5:37 a.m., Abhay Kulkarni

Review Request 69565: Improve group search on policy edit page

2018-12-13 Thread Nikhil P
/org/apache/ranger/biz/XUserMgr.java e1a6b58 Diff: https://reviews.apache.org/r/69565/diff/1/ Testing --- Tested If partial/exact group-search/user-search on policy edit page & reports page works properly. Thanks, Nikhil P

Re: Review Request 70340: RANGER-2382 : Improvement to Access Audit page-Add ‘agentHostname’ column to audit log table, which records IP-address/hostname of the plugin

2019-04-02 Thread Nikhil P
)verified if ‘agentHostname’ is getting added in solr and also getting displayed on Ranger UI -access audit page. 2)verified agentHostName shows destination of agents. Thanks, Nikhil P

Re: Review Request 70340: RANGER-2382 : Improvement to Access Audit page-Add ‘agentHostname’ column to audit log table, which records IP-address/hostname of the plugin

2019-04-03 Thread Nikhil P
agentHostName shows destination of agents. Thanks, Nikhil P

Review Request 70340: RANGER-2382 : Improvement to Access Audit page-Add ‘agentHostname’ column to audit log table, which records IP-address/hostname of the plugin

2019-04-01 Thread Nikhil P
ef149d5 Diff: https://reviews.apache.org/r/70340/diff/1/ Testing --- 1)verified if ‘agentHostname’ is getting added in solr and also getting displayed on Ranger UI -access audit page. 2)verified agentHostName shows destination of agents. Thanks, Nikhil P

Review Request 70254: User creation POST and PUT response not showing groupIdList and groupNameList with expected data

2019-03-20 Thread Nikhil P
list of group Id / group Name. 1.Tested CRUD for users. 2.Tested CRUD for groups. 3.Checked adding users to group. 4.Checked users are getting deleted when groups are assigned to it. Thanks, Nikhil P

Review Request 70192: Improvement on getServices API to get plugin services based on its associated tag service

2019-03-12 Thread Nikhil P
on local machine. Thanks, Nikhil P

Re: Review Request 70254: RANGER-2373 : User creation POST and PUT response not showing groupIdList and groupNameList with expected data

2019-03-22 Thread Nikhil P
/files/2019/03/22/f1f0b2d5-68d1-4413-b5f7-f8836b2dc2a8__RANGER-2373-2.patch Thanks, Nikhil P

Review Request 69917: Audits: filter out service audit logs and additional users logs from user audit logs

2019-02-11 Thread Nikhil P
filtered out after setting those users list in property(ranger.accesslogs.exclude.users.list) and sending UI flag(Exclude service user) as true on access audits page. Thanks, Nikhil P

Review Request 70455: RANGER-2383 : Incorrect response when trying to delete user attached to a security zone

2019-04-11 Thread Nikhil P
23d3568 Diff: https://reviews.apache.org/r/70455/diff/1/ Testing --- 1)Verified if User delete is not allowed if that user is present in zone as a zone admin/zone auditor. 2)Verified if Proper error message is shown if user is present in zone. Thanks, Nikhil P

Re: Review Request 70432: RANGER-2387 : add public api v2 for security zones

2019-04-11 Thread Nikhil P
To reply, visit: https://reviews.apache.org/r/70432/#review214539 ------- On April 11, 2019, 6:24 p.m., Nikhil P wrote: > > --- > This is an automatically generated e

Re: Review Request 70432: RANGER-2387 : add public api v2 for security zones

2019-04-11 Thread Nikhil P
-zones.patch Thanks, Nikhil P

Re: Review Request 70340: RANGER-2382 : Improvement to Access Audit page-Add ‘agentHostname’ column to audit log table, which records IP-address/hostname of the plugin

2019-04-15 Thread Nikhil P
To reply, visit: https://reviews.apache.org/r/70340/#review214298 ------- On April 12, 2019, 7:41 p.m., Nikhil P wrote: > > --- > This is an automatically generated e

Re: Review Request 70340: RANGER-2382 : Improvement to Access Audit page-Add ‘agentHostname’ column to audit log table, which records IP-address/hostname of the plugin

2019-04-12 Thread Nikhil P
UI -access audit page. 2)verified agentHostName shows destination of agents. Thanks, Nikhil P

Re: Review Request 70493: RANGER-2351 : Implement Import / Export of Policies by Zone

2019-04-18 Thread Nikhil P
pped to the services at destination. File Attachments (updated) RANGER-2351-Implement-Import-Export-of-Policies-by-Z.patch https://reviews.apache.org/media/uploaded/files/2019/04/18/beb14579-4600-4950-af31-2a758b5dfca5__RANGER-2351-Implement-Import-Export-of-Policies-by-Z.patch Thanks, Nikhil P

Review Request 70501: RANGER-2403 : proper error should be thrown when service part of zone being deleted

2019-04-18 Thread Nikhil P
://reviews.apache.org/r/70501/diff/1/ Testing --- 1.Validated If proper response comes If user tries to delete service which is present in any zone. Thanks, Nikhil P

Re: Review Request 70658: RANGER-2436 - Custom condition: Access from cluster

2019-05-17 Thread Nikhil P
is not present in condition then access is denied. 3.Tested for hive plugin Thanks, Nikhil P

Review Request 70729: RANGER-2449 : if service part of zone is not present then null pointer exception is thrown

2019-05-28 Thread Nikhil P
- security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java ce3ffc853 Diff: https://reviews.apache.org/r/70729/diff/1/ Testing --- 1.Verified If proper error response is thrown if Service is not present in ranger. Thanks, Nikhil P

Review Request 70776: RANGER-2454 : Remove the trailing slash in Ranger URL in RangerAdminJersey2RESTClient

2019-06-03 Thread Nikhil P
- knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java b04de1d06 Diff: https://reviews.apache.org/r/70776/diff/1/ Testing --- 1.Tested If Slash is getting removed in Ranger URL. Thanks, Nikhil P

Re: Review Request 70821: Improvement in setting cluster Name in RangerAccessRequest

2019-06-19 Thread Nikhil P
://reviews.apache.org/r/70821/diff/4-5/ Testing --- 1.Tested for hive plugin, whether clusterName is getting set properly in RangerAccessRequest. Thanks, Nikhil P

Re: Review Request 70781: RANGER-2458 : Cluster property name changes in Ranger Plugin code

2019-06-12 Thread Nikhil P
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70781/#review215868 --- Ship it! Ship It! - Nikhil P On June 12, 2019, 5:30 p.m

Review Request 70703: RANGER-2445 : Import of Tagservice for zone

2019-05-23 Thread Nikhil P
are getting imported correctly based to mapping provided. Thanks, Nikhil P

Re: Review Request 70658: RANGER-2436 - Custom condition: Access from cluster

2019-05-21 Thread Nikhil P
in condition then access is denied. 3.Tested for hive plugin Thanks, Nikhil P

Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-04-29 Thread Nikhil P
. Thanks, Nikhil P

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-05 Thread Nikhil P
/70565/diff/2-3/ Testing --- Tested if Admin user is not able to create zone for KMS service. Thanks, Nikhil P

Re: Review Request 70565: RANGER-2411 : Restrict Admin role user to create Zone for KMS service

2019-05-03 Thread Nikhil P
/diff/1-2/ Testing --- Tested if Admin user is not able to create zone for KMS service. Thanks, Nikhil P

Re: Review Request 70493: RANGER-2351 : Implement Import / Export of Policies by Zone

2019-04-22 Thread Nikhil P
ANGER-2351-Implement-Import-Export-of-Policies-by-Z.patch Thanks, Nikhil P

Review Request 70447: RANGER-2384 : Get All Zones API is returning response in raw format, proper response object is required.

2019-04-10 Thread Nikhil P
/TestSecurityZoneDBStore.java 3d7c3ef security-admin/src/test/java/org/apache/ranger/rest/TestSecurityZoneREST.java e4b5a1b Diff: https://reviews.apache.org/r/70447/diff/1/ Testing --- 1)Verified If proper response is coming in get All zones. 2)Tested on local VM. Thanks, Nikhil P

Review Request 70432: RANGER-2387 : add public api v2 for security zones

2019-04-09 Thread Nikhil P
/apache/ranger/rest/PublicAPIsv2.java 073404e Diff: https://reviews.apache.org/r/70432/diff/1/ Testing --- 1.Tested Curl response of Public api v2 are correct. 2.validated response result for public API matches with SecurityZoneREST Thanks, Nikhil P

Re: Review Request 70493: RANGER-2351 : Implement Import / Export of Policies by Zone

2019-04-25 Thread Nikhil P
14579-4600-4950-af31-2a758b5dfca5__RANGER-2351-Implement-Import-Export-of-Policies-by-Z.patch Thanks, Nikhil P

Review Request 70493: RANGER-2351 : Implement Import / Export of Policies by Zone

2019-04-17 Thread Nikhil P
ly and policies gets imported to destination zone , provided correct mapping is given and zones are already mapped to the services at destination. Thanks, Nikhil P

Review Request 71216: Ranger Admin debug config improvement

2019-07-31 Thread Nikhil P
-admin-services.sh 8f148a773 security-admin/src/main/webapp/WEB-INF/web.xml 806a066ae Diff: https://reviews.apache.org/r/71216/diff/1/ Testing --- 1.Validated If specified log4j file configuration in ranger-admin-services.sh is getting used for logging. Thanks, Nikhil P

Re: Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-20 Thread Nikhil P
gt; There is already a deletePolicy(RangerPolicy policy, RangerService > > service) method there. Possibly you can use that by passing the service > > object value as null. > > Nikhil P wrote: > we are not adding a new method but changing existing method in order to

Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-14 Thread Nikhil P
/ranger/biz/TestServiceDBStore.java 2be371892 Diff: https://reviews.apache.org/r/71217/diff/1/ Testing --- 1.Tested If data is getting stored and retrieved properly in data history table i.e. x_data_hist. Thanks, Nikhil P

Re: Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-19 Thread Nikhil P
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71217/#review217241 ------- On Aug. 19, 2019, 3:21 p.m., Nikhil P wrote: > > --

Re: Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-19 Thread Nikhil P
i.e. x_data_hist. Thanks, Nikhil P

Re: Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-20 Thread Nikhil P
gt; There is already a deletePolicy(RangerPolicy policy, RangerService > > service) method there. Possibly you can use that by passing the service > > object value as null. > > Nikhil P wrote: > we are not adding a new method but changing existing method in order to

Re: Review Request 71217: RANGER-2535 : Good coding practices for storing and retrieving data history in ranger

2019-08-21 Thread Nikhil P
i.e. x_data_hist. Thanks, Nikhil P

Re: Review Request 71446: RANGER-2561 : add functionality in ranger to get default policy groups list from service config while creation of service and add that group to policies in that service

2019-09-09 Thread Nikhil P
://reviews.apache.org/r/71446/diff/1-2/ Testing --- Tested on local vm. Thanks, Nikhil P

Review Request 71505: Ranger is failing to start in kerberize mode with java-11

2019-09-18 Thread Nikhil P
-common/src/main/java/org/apache/hadoop/security/SecureClientLogin.java 05d23fd05 storm-agent/src/main/java/org/apache/ranger/services/storm/client/StormClient.java 363a6561c Diff: https://reviews.apache.org/r/71505/diff/1/ Testing --- Tested on local vm. Thanks, Nikhil P

Review Request 71446: RANGER-2561 : add functionality in ranger to get default policy groups list from service config while creation of service and add that group to policies in that service

2019-09-06 Thread Nikhil P
while creation of service and add that group to policies in that service Diffs - agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBaseService.java 8d4e16fc4 Diff: https://reviews.apache.org/r/71446/diff/1/ Testing --- Tested on local vm. Thanks, Nikhil P

Review Request 71162: RANGER-2508 : Good coding practices for concurrent policy label creation

2019-07-25 Thread Nikhil P
curl with the same labels in it. 2.Validated if labels are created properly. Thanks, Nikhil P

Re: Review Request 71155: RANGER-2516 Update Ranger default policies to provide entity-read access to public group

2019-07-25 Thread Nikhil P
://reviews.apache.org/r/71155/diff/2/ Changes: https://reviews.apache.org/r/71155/diff/1-2/ Testing --- Tested on local if additional policy is getting created for required resources. Thanks, Nikhil P

Re: Review Request 71155: RANGER-2516 Update Ranger default policies to provide entity-read access to public group

2019-07-26 Thread Nikhil P
on local if additional policy is getting created for required resources. Thanks, Nikhil P

Review Request 71169: RANGER-2406 : rangerusersync open too many session for ldap sync

2019-07-26 Thread Nikhil P
is true(default:true). 2.Validated if Ranger Login sessions are not overloaded with usersync sessions. Thanks, Nikhil P

  1   2   >