Re: Review Request 72696: RANGER-2919 : Source policies gets deleted after importing policy with deleteifexists parameter

2020-07-22 Thread Pradeep Agrawal
please share. also update the problem statement with an example. - Pradeep Agrawal On July 22, 2020, 3:06 p.m., Dineshkumar Yadav wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 72621: RANGER-2821 :- Update ranger authorizer for Atlas to add admin-purge and Java patch to handle upgrade.

2020-07-06 Thread Pradeep Agrawal
J10034. - Pradeep Agrawal On June 26, 2020, 10:55 a.m., Nixon Rodrigues wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 72946: RANGER-3032:The log4j properties of rangeradmin cannot take effect dynamically

2020-11-21 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72946/#review23 --- Ship it! Ship It! - Pradeep Agrawal On Oct. 15, 2020, 1:49

Review Request 73067: RANGER-3100: Upgrade httpclient version from 4.5.6 to 4.5.13

2020-12-04 Thread Pradeep Agrawal
0 pom.xml 6f7114c68 ranger-elasticsearch-plugin-shim/pom.xml c40c4b81d security-admin/pom.xml 865a42eb4 Diff: https://reviews.apache.org/r/73067/diff/1/ Testing --- Thanks, Pradeep Agrawal

Re: Review Request 73048: RANGER-3092: KMS fails to start with NullPointerException in catalina.out logs

2020-12-04 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73048/#review89 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 2, 2020, 7:58

Re: Review Request 72947: RANGER-3033:Ranger hive authorizer should impl 'getRoleGrantInfoForPrincipal' interface

2020-12-04 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72947/#review88 --- Ship it! Ship It! - Pradeep Agrawal On Oct. 15, 2020, 1:49

Re: Review Request 73053: RANGER-3095: not able to list the keys with a user whose id contains non latin character

2020-12-04 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73053/#review90 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 2, 2020, 8 a.m

Re: Review Request 72965: RANGER-3040:There is no read permission for lookupuser on presto/storm/es by default

2020-11-13 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72965/#review08 --- Ship it! Ship It! - Pradeep Agrawal On Oct. 15, 2020, 3:41

Re: Review Request 72967: RANGER-3042:some log issues should be fixed

2020-11-13 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72967/#review07 --- Ship it! Ship It! - Pradeep Agrawal On Oct. 16, 2020, 9 a.m

Re: Review Request 72951: RANGER-3035:Ranger Presto Plugin: Machine-Machine user can not access presto with right permission

2020-11-13 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72951/#review09 --- Ship it! Ship It! - Pradeep Agrawal On Oct. 15, 2020, 1:52

Re: Review Request 72967: RANGER-3042:some log issues should be fixed

2020-11-13 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72967/#review06 --- Ship it! Ship It! - Pradeep Agrawal On Oct. 16, 2020, 9 a.m

Re: Review Request 73153: Upgrade Ranger Tomcat to 8.5 or 9.0

2021-01-21 Thread Pradeep Agrawal
. For example whether tomcat 7.0 version created log file shall be reused or not, ssl testing, kerberos testing. - Pradeep Agrawal On Jan. 21, 2021, 10:22 a.m., Mateen Mansoori wrote: > > --- > This is an automatically generat

Re: Review Request 73110: RANGER-3135:Ranger always ponit out "User does not have permission for this operation" when user try to query a none-exist role

2021-01-02 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73110/#review222400 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 29, 2020, 1:15

Re: Review Request 73111: RANGER-3136:NullPointException found when import policies form web side and "isOverride" is selected

2021-01-02 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73111/#review222401 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 29, 2020, 1:21

Re: Review Request 73425: RANGER-3320: ranger tags are not added for when tagging identically named database/tables in two different Ranger services

2021-06-15 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73425/#review223157 --- Ship it! Ship It! - Pradeep Agrawal On June 15, 2021, 10:48

Re: Review Request 73425: RANGER-3320: ranger tags are not added for when tagging identically named database/tables in two different Ranger services

2021-06-16 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73425/#review223165 --- Ship it! Ship It! - Pradeep Agrawal On June 16, 2021, 2:27

Re: Review Request 73407: RANGER-3309: Support batch upload of tags to Ranger

2021-06-08 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73407/#review223120 --- Ship it! Ship It! - Pradeep Agrawal On June 8, 2021, 2:40

Re: Review Request 73406: RANGER-3306 : Allow comma in policy resource text field.

2021-06-07 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73406/#review223117 --- Ship it! Ship It! - Pradeep Agrawal On June 7, 2021, 1:21

Re: Review Request 73397: RANGER-3301: [UI] in admin audit log tables not formated correctly for lone string value for resources.

2021-06-07 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73397/#review223118 --- Ship it! Ship It! - Pradeep Agrawal On June 7, 2021, 1:40

Re: Review Request 73411: RANGER-3103 : Ranger KMS should log full UGI principal

2021-06-08 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73411/#review223123 --- Ship it! Ship It! - Pradeep Agrawal On June 8, 2021, 7:09

Re: Review Request 73425: RANGER-3320: ranger tags are not added for when tagging identically named database/tables in two different Ranger services

2021-06-22 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73425/#review223177 --- Ship it! Ship It! - Pradeep Agrawal On June 22, 2021, 2:01

Re: Review Request 71899: RANGER-2640:Implement SHOW ROLE GRANT in Hive ranger plugin

2021-06-15 Thread Pradeep Agrawal
st run for loop on principalRoles and refer the created hashmap to compare and populate ret object. This may increase space requirement but shall reduce no. of cpu cycles. Please review. - Pradeep Agrawal On June 5, 2021, 7:48 a.m., Ramesh Mani

Review Request 73398: RANGER-3304: Create solr audit conf zip archive

2021-06-02 Thread Pradeep Agrawal
--- Run the ranger build with proposed changes and able to get ranger-3.0.0-SNAPSHOT-solr_audit_conf.zip file in target location after the successful build. Thanks, Pradeep Agrawal

Re: Review Request 73434: RANGER-3322: remove grant of public synonym privileges for oracle db flavor

2021-06-30 Thread Pradeep Agrawal
upgrade case from 2.1 to 3.0 for oracle DB flavor. Thanks, Pradeep Agrawal

Review Request 73437: RANGER-3324: Best Practices: Make optimised db schema script idempotent for all DB Flavors.

2021-06-30 Thread Pradeep Agrawal
/ranger_core_db_sqlserver.sql 4535b68b7 Diff: https://reviews.apache.org/r/73437/diff/1/ Testing --- Tested fresh installation of ranger with all DB flavors(except sql-anywhere) Thanks, Pradeep Agrawal

Review Request 73438: RANGER-3325: Roles information not present in the Excel and CSV files which are downloaded from Reports page

2021-06-30 Thread Pradeep Agrawal
for each policy in the downloaded Excel and CSV file. Thanks, Pradeep Agrawal

Review Request 73436: RANGER-2950: Upgrade Spring framework and Spring Security libraries.

2021-06-29 Thread Pradeep Agrawal
and group. **Testing Pending**: Ranger KMS and unix/ldap usersync Thanks, Pradeep Agrawal

Re: Review Request 73273: Ranger upgrade fails for oracle db.

2021-04-08 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73273/#review222789 --- Please mention the oracle version details also. - Pradeep

Re: Review Request 73531: RANGER-3374: Syncing 300K+ user group mappings to ranger is causing ranger to go out of memory

2021-08-20 Thread Pradeep Agrawal
/XGroupUserService.java Lines 168 (patched) <https://reviews.apache.org/r/73531/#comment312436> Please replace message "XUserMgr.createOrDeleteXGroupUsers" with "XGroupUserService.createOrUpdateXGroupUsers" - Pradeep Agrawal On Aug. 20, 2021, 5:26 a.m.

Review Request 73535: RANGER-3376: Add policy_guid column in x_policy_change_log table

2021-08-23 Thread Pradeep Agrawal
in the x_policy_change_log table. Thanks, Pradeep Agrawal

Re: Review Request 73556: RANGER-3385: Duplicate SQL prefix should not be allowed

2021-08-30 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73556/#review223429 --- Ship it! Ship It! - Pradeep Agrawal On Aug. 29, 2021, 10:35

Re: Review Request 73556: RANGER-3385: Duplicate SQL prefix should not be allowed

2021-08-30 Thread Pradeep Agrawal
. Is it possible to add the similar check for java patches ? - Pradeep Agrawal On Aug. 29, 2021, 10:35 a.m., Kishor Gollapalliwar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [DRAFT] [REPORT] Apache Ranger - Aug-2021

2021-08-13 Thread PradeeP AgrawaL
+1 On Sat, 14 Aug 2021 at 07:32, Bhavik Patel wrote: > +1 > > On Sat, Aug 14, 2021, 4:19 AM Sailaja Polavarapu > wrote: > > > +1 > > > > On Wed, Aug 11, 2021 at 9:29 PM Abhay Kulkarni > > wrote: > > > > > +1 > > > > > > On Wed, Aug 11, 2021 at 4:35 PM Madhan Neethiraj > > > wrote: > > > > >

Re: Review Request 73354: RANGER-3285: Introduce new column Sync Source

2021-08-23 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73354/#review223375 --- Ship it! Ship It! - Pradeep Agrawal On Aug. 19, 2021, 4:24

Re: Review Request 73563: RANGER-3393: Stop using deprecated MySQL driver class

2021-09-09 Thread Pradeep Agrawal
constraints ? - Pradeep Agrawal On Sept. 1, 2021, 11:46 p.m., Tsung-Ju Lii wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 73564: RANGER-3394: Too much `varchar(4000)` causes table to exceed ROW SIZE limit in MySQL

2021-09-09 Thread Pradeep Agrawal
the issue. - Pradeep Agrawal On Sept. 8, 2021, 6:57 p.m., Tsung-Ju Lii wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 73579: RANGER-3371: Addendum patch to fix json parsing issue related to CreateTime and UpdateTime fields

2021-09-13 Thread Pradeep Agrawal
by replacing the respective class/jar files in the existing env and restarted ranger-admin. Parsing is working fine and result was returned as expected. Thanks, Pradeep Agrawal

Re: Review Request 73579: RANGER-3371: Addendum patch to fix json parsing issue related to CreateTime and UpdateTime fields

2021-09-13 Thread Pradeep Agrawal
Diff: https://reviews.apache.org/r/73579/diff/2/ Changes: https://reviews.apache.org/r/73579/diff/1-2/ Testing --- Tested the updated patch by replacing the respective class/jar files in the existing env and restarted ranger-admin. Parsing is working fine and result was returned as expected. Thanks, Pradeep Agrawal

Re: Review Request 73579: RANGER-3371: Addendum patch to fix json parsing issue related to CreateTime and UpdateTime fields

2021-09-13 Thread Pradeep Agrawal
reply, visit: https://reviews.apache.org/r/73579/#review223480 ----------- On Sept. 13, 2021, 3:18 p.m., Pradeep Agrawal wrote: > > --- > This is an automatically

Re: Review Request 73545: RANGER-3371: Addendum patch to add serviceType in policy json

2021-09-15 Thread Pradeep Agrawal
ed patch is already committed i will address your suggestion in a separate jira. - Pradeep --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73545/#review223488 --------

Re: Review Request 73545: RANGER-3371: Addendum patch to add serviceType in policy json

2021-09-14 Thread Pradeep Agrawal
policy and validation is passing. Thanks, Pradeep Agrawal

Review Request 73545: RANGER-3371: Addendum patch to add serviceType in policy json

2021-09-14 Thread Pradeep Agrawal
--- With patch, tested policy creation and serviceType field and its value is added in the policy text for the respective policy. Further checked the delta policy and validation is passing. Thanks, Pradeep Agrawal

Review Request 73587: RANGER-2341: compressDeltas method returns two ranger policy entries for policy create+update case when provided lastKnownVersion is previous to create call

2021-09-17 Thread Pradeep Agrawal
. Thanks, Pradeep Agrawal

Re: Review Request 73496: RANGER-3359: Upgrade json-smart and nimbus-jose-jwt libraries

2021-09-14 Thread Pradeep Agrawal
admin login and UI. CRUD operation are working fine. unable to see any json-smart 2.3.0 jar inside of any tar lib , only 2.3.1 is being shipped. Thanks, Pradeep Agrawal

Re: Review Request 73564: RANGER-3394: Too much `varchar(4000)` causes table to exceed ROW SIZE limit in MySQL

2021-09-09 Thread Pradeep Agrawal
> On Sept. 9, 2021, 1:18 p.m., Pradeep Agrawal wrote: > > Please propose changes only for the column you are facing the issue. > > Tsung-Ju Lii wrote: > My issue was that the `varchar(4000)`s in the code made deployment > impossible due to MySQL complaining about r

Re: Review Request 73563: RANGER-3393: Stop using deprecated MySQL driver class

2021-09-09 Thread Pradeep Agrawal
> On Sept. 9, 2021, 1:08 p.m., Pradeep Agrawal wrote: > > What if somebody want to use old jar due to environemnt constraints ? > > Tsung-Ju Lii wrote: > It is probably fine, this is going to affect only the master branch, i.e. > the branch that's supp

Re: Review Request 73568: RANGER-3398: Duplicate JAVA patch suffix should not be allowed

2021-09-07 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73568/#review223446 --- Ship it! Ship It! - Pradeep Agrawal On Sept. 6, 2021, 7:44

Review Request 73496: RANGER-3359: Upgrade json-smart and nimbus-jose-jwt libraries

2021-08-02 Thread Pradeep Agrawal
embeddedwebserver/pom.xml 2d14f3abd kms/pom.xml b65b0b2b2 pom.xml 8d81988d4 security-admin/pom.xml f64e74781 Diff: https://reviews.apache.org/r/73496/diff/1/ Testing --- Thanks, Pradeep Agrawal

Re: Review Request 73497: RANGER-3360: Best Practice: Use updated policy object after pruning the policy object

2021-08-02 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73497/#review223300 --- Ship it! Ship It! - Pradeep Agrawal On Aug. 2, 2021, 8:13

Re: Review Request 73601: RANGER-3439: REST api to get or delete ranger policy based on guid and service name

2021-09-23 Thread Pradeep Agrawal
this can be handled some others ways. - Pradeep --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73601/#review223515 ----------- O

Review Request 73652: RANGER-3480: Policy version in access audit is not matching with the policy version seen in policy view

2021-10-13 Thread Pradeep Agrawal
, Pradeep Agrawal

Re: [VOTE] Release Apache Ranger version 2.2.0 - rc1

2021-10-18 Thread PradeeP AgrawaL
+1 for Apache Ranger 2.2.0 rc1 release. - Verified the build On Mon, 18 Oct 2021 at 11:12, Mehul Parikh wrote: > Hi All, > > +1 for Apache Ranger 2.2.0 rc1 release. > >- Verified the build >- Verified signatures. > > > On Thu, Oct 14, 2021 at 2:42 AM Ramesh Mani wrote: > > > Dear

Review Request 73618: RANGER-3458: Add rest api to get policy delta for given resource

2021-09-29 Thread Pradeep Agrawal
TA-INF/jpa_named_queries.xml ab2d9cd0d Diff: https://reviews.apache.org/r/73618/diff/1/ Testing --- Tested the API with various resource combinations and lastKnownVersion. Thanks, Pradeep Agrawal

Review Request 73601: RANGER-3439: REST api to get or delete ranger policy based on guid and service name

2021-09-22 Thread Pradeep Agrawal
. Thanks, Pradeep Agrawal

Review Request 73594: RANGER-3435: Add unique index on guid and service id column of x_policy table

2021-09-21 Thread Pradeep Agrawal
-CREATION Diff: https://reviews.apache.org/r/73594/diff/1/ Testing --- Tested the patch for MySQL, Oracle, Postgres and MSSQL. unique constraint is being created in x_policy table for a fresh installation and upgrade case as well. Thanks, Pradeep Agrawal

Re: Review Request 73496: RANGER-3359: Upgrade json-smart and nimbus-jose-jwt libraries

2021-10-05 Thread Pradeep Agrawal
/3-4/ Testing --- Tested ranger admin login and UI. CRUD operation are working fine. unable to see any json-smart 2.3.0 jar inside of any tar lib , only 2.3.1 is being shipped. Thanks, Pradeep Agrawal

Re: Review Request 73496: RANGER-3359: Upgrade json-smart and nimbus-jose-jwt libraries

2021-10-05 Thread Pradeep Agrawal
://reviews.apache.org/r/73496/diff/1-2/ Testing --- Tested ranger admin login and UI. CRUD operation are working fine. unable to see any json-smart 2.3.0 jar inside of any tar lib , only 2.3.1 is being shipped. Thanks, Pradeep Agrawal

Re: Review Request 73496: RANGER-3359: Upgrade json-smart and nimbus-jose-jwt libraries

2021-10-05 Thread Pradeep Agrawal
/diff/2-3/ Testing --- Tested ranger admin login and UI. CRUD operation are working fine. unable to see any json-smart 2.3.0 jar inside of any tar lib , only 2.3.1 is being shipped. Thanks, Pradeep Agrawal

Re: Planning for Apache Ranger 2.2.0 release

2021-09-22 Thread PradeeP AgrawaL
+1 for the release initiative and efforts. On Wed, 22 Sept 2021 at 11:51, Nixon Rodrigues wrote: > +1 for 2.2 release. > > Thanks Ramesh for giving 2.2 release heads up and acting as release manager > for 2.2. > > Regards > Nixon Rodrigues > > On Wed, 22 Sept 2021 at 11:42, Vipin Rathor wrote:

Re: Review Request 73738: RANGER 3290 - ArrayIndexOutOfBoundsException if solr is down

2021-12-03 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73738/#review223803 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 3, 2021, 2:48

Review Request 73767: RANGER-3553: Unit test coverage for UserMgr class

2021-12-17 Thread Pradeep Agrawal
://reviews.apache.org/r/73767/diff/1/ Testing --- All testcases are running fine and build was successful. Thanks, Pradeep Agrawal

Review Request 73771: RANGER-3557: Upgrade to use log4j 2.17.0+ version to ensure that we are using supported version of log4j

2021-12-19 Thread Pradeep Agrawal
, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-3557 https://issues.apache.org/jira/browse/RANGER-3557 Repository: ranger Description --- RANGER-3557: Upgrade to use log4j 2.17.0+ version to ensure that we

Re: Review Request 73771: RANGER-3557: Upgrade to use log4j 2.17.0+ version to ensure that we are using supported version of log4j

2021-12-19 Thread Pradeep Agrawal
(RANGER-3558). Hence i am not doing the suggested change in this patch. - Pradeep --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73771/#review223876 ---------

Re: Review Request 73768: RANGER-3551: Analyze & optimize module permissions related API (Part-1)

2021-12-20 Thread Pradeep Agrawal
/VXModulePermission.java Lines 69 (patched) <https://reviews.apache.org/r/73768/#comment312930> "userNameList" should be groupNameList - Pradeep Agrawal On Dec. 20, 2021, 2:42 p.m., Mahesh Bandal wrote: > > --- > This is a

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-20 Thread Pradeep Agrawal
ecurity-admin/src/main/resources/conf.dist/ranger-admin-site.xml d32a324ec > storm-agent/conf/ranger-storm-audit-changes.cfg 52c715ef5 > storm-agent/scripts/install.properties d219abf59 > > > Diff: https://reviews.apache.org/r/73756/diff/3/ > > > Testing > --- > > Tested by creating IAM user in AWS and provided required configuration in the > install.properties. > > **Note:** AWS region name, access key and secret key should be provided in > the environment. > > > Thanks, > > Pradeep Agrawal > >

Review Request 73775: RANGER-3560: Upgrade kylin version to 2.6.6

2021-12-22 Thread Pradeep Agrawal
successfully with this patch. Thanks, Pradeep Agrawal

Review Request 73776: RANGER-3561: Upgrade Storm version to 1.2.4

2021-12-22 Thread Pradeep Agrawal
- pom.xml f9c46f669 Diff: https://reviews.apache.org/r/73776/diff/1/ Testing --- Able to build and run ranger succesfully. Thanks, Pradeep Agrawal

Re: Review Request 73755: RANGER-3539: Add jacoco-maven-plugin for code coverage

2022-01-04 Thread Pradeep Agrawal
/xmlreport.xml > -Dsonar.projectKey=ranger_public -Dsonar.projectName=Ranger_AdminServer > > > References: > > https://www.baeldung.com/jacoco > https://www.baeldung.com/sonarqube-jacoco-code-coverage > https://mkyong.com/maven/maven-jacoco-code-coverage-example/ > https://medium.com/backend-habit/generate-codecoverage-report-with-jacoco-and-sonarqube-ed15c4045885 > > > Thanks, > > Pradeep Agrawal > >

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-22 Thread Pradeep Agrawal
zonaws/services/logs/model/FilterLogEventsRequest.html#setLogStreamNamePrefix-java.lang.String-) > > > > ``` > > logStreamName = PropertiesUtil.getProperty(CONFIG_PREFIX + "." + > > "log_stream"); > > ``` > > Pradeep Agrawal wrote: > I tri

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-22 Thread Pradeep Agrawal
/ Testing --- Tested by creating IAM user in AWS and provided required configuration in the install.properties. **Note:** AWS region name, access key and secret key should be provided in the environment. Thanks, Pradeep Agrawal

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-23 Thread Pradeep Agrawal
/73756/#review223901 --- On Dec. 23, 2021, 6:56 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.o

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-23 Thread Pradeep Agrawal
user in AWS and provided required configuration in the install.properties. **Note:** AWS region name, access key and secret key should be provided in the environment. Thanks, Pradeep Agrawal

Re: Review Request 73779: RANGER-3564: fixed failure in installation of Ranger plugin for HDFS

2021-12-30 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73779/#review223908 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 30, 2021, 9:42

Re: Review Request 73778: RANGER-3563: fixed plugin installation failure in docker due to recent changes in RANGER-3540

2021-12-30 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73778/#review223907 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 30, 2021, 8:59

Re: Review Request 73781: RANGER-3566: updated version in pom.xml to 2.3.0-SNAPSHOT

2022-01-03 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73781/#review223913 --- Ship it! Ship It! - Pradeep Agrawal On Jan. 2, 2022, 8:05

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-21 Thread Pradeep Agrawal
(logStreamNames) + .withLogStreamNamePrefix(logStreamName) .withStartTime(fromDate.getTime()) .withEndTime(toDate.getTime()) .withFilterPattern(filterPattern.toString()); - Pradeep --

Re: Review Request 73756: RANGER-3540: Add support to read audit logs from Amazon CloudWatch

2021-12-21 Thread Pradeep Agrawal
zonaws/services/logs/model/FilterLogEventsRequest.html#setLogStreamNamePrefix-java.lang.String-) > > > > ``` > > logStreamName = PropertiesUtil.getProperty(CONFIG_PREFIX + "." + > > "log_stream"); > > ``` > > Pradeep Agrawal wrote: > I tri

Re: Review Request 73741: RANGER-3533 : Provide sorting on columns throughout the audits result set and policy listing page

2021-12-22 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73741/#review223896 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 16, 2021, 7:36

Re: Review Request 73724: RANGER-3522: Improve Tagsync authentication error reporting

2021-11-22 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73724/#review223764 --- Ship it! Ship It! - Pradeep Agrawal On Nov. 22, 2021, 7:51

Re: Review Request 73685: RANGER-3505: Ranger usersync fails to sync users when a duplicate user exists in ranger

2021-11-10 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73685/#review223721 --- Ship it! Ship It! - Pradeep Agrawal On Nov. 3, 2021, 10:59

Re: Review Request 73698: RANGER-3510 : Ranger upgrade spring framework version to 5.3.12

2021-11-11 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73698/#review223728 --- Ship it! Ship It! - Pradeep Agrawal On Nov. 9, 2021, 10:24

Re: Review Request 73719: RANGER-3435: Add unique index on guid, service and zone_id column of x_policy table

2021-11-24 Thread Pradeep Agrawal
and MSSQL. unique constraint is being created in x_policy table for a fresh installation and upgrade case as well. Thanks, Pradeep Agrawal

Re: Review Request 73336: RANGER-3276 Remove duplicate code from buildks.java

2021-11-29 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73336/#review223775 --- Ship it! Ship It! - Pradeep Agrawal On May 5, 2021, 6:24

Re: Review Request 73717: RANGER-3518: Limit the query size stored in Audit logs

2021-11-24 Thread Pradeep Agrawal
/authorizer/RangerHiveAuditHandler.java Lines 45 (patched) <https://reviews.apache.org/r/73717/#comment312853> Can you improve this to work for elasticsearch as well. - Pradeep Agrawal On Nov. 19, 2021, 1:53 p.m., Mahesh Bandal

Review Request 73719: RANGER-3435: Add unique index on guid, service and zone_id column of x_policy table

2021-11-22 Thread Pradeep Agrawal
-table-guid-service-column.sql 3037988e2 Diff: https://reviews.apache.org/r/73719/diff/1/ Testing --- Tested the patch for MySQL, Oracle, Postgres and MSSQL. unique constraint is being created in x_policy table for a fresh installation and upgrade case as well. Thanks, Pradeep Agrawal

Review Request 73720: RANGER-3439: REST api to get or delete ranger policy based on guid, service name and zone name

2021-11-22 Thread Pradeep Agrawal
hive' curl -u admin:Ranger1234 -H "Accept: application/json" -H "Content-Type: application/json" -X DELETE 'http://localhost:6080/service/plugins/policies/guid/ad88dd6f-1d85-4a67-8e84-813809c83da0?serviceName=cm_hive=zone1' Thanks, Pradeep Agrawal

Re: Review Request 73707: RANGER-3511:Create Java patch to update policy resource-signature to unique value.

2021-11-16 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73707/#review223745 --- Ship it! Ship It! - Pradeep Agrawal On Nov. 16, 2021, 2:59

Re: Review Request 73706: RANGER-3504 : Create framework to execute DB patch dependent on Java patch.

2021-11-16 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73706/#review223746 --- Ship it! Ship It! - Pradeep Agrawal On Nov. 16, 2021, 1:39

Re: Review Request 73618: RANGER-3458: Add rest api to get policy delta for given resource

2021-10-27 Thread Pradeep Agrawal
.org/r/73618/diff/2/ Changes: https://reviews.apache.org/r/73618/diff/1-2/ Testing --- Tested the API with various resource combinations and lastKnownVersion. Thanks, Pradeep Agrawal

Re: Review Request 73720: RANGER-3439: REST api to get or delete ranger policy based on guid, service name and zone name

2021-12-02 Thread Pradeep Agrawal
To reply, visit: https://reviews.apache.org/r/73720/#review223794 ------- On Nov. 22, 2021, 10:22 a.m., Pradeep Agrawal wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 72800: [RANGER-2967] Add support for Amazon CloudWatch Logs as an Audit Store

2021-12-07 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72800/#review223815 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 8, 2021, 12:58

Re: Review Request 73723: RANGER-3520: Upgrade Netty version

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73723/#review223838 --- Please correct the patch details (#author name) - Pradeep

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/#review223836 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 8, 2021, 8:03

Re: Review Request 73701: RANGER-3427: Null Dereference in PublicApis.java

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73701/#review223828 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 9, 2021, 10:01

Re: Review Request 73701: RANGER-3427: Null Dereference in PublicApis.java

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73701/#review223837 --- Please correct the patch details. - Pradeep Agrawal On Dec. 9

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread Pradeep Agrawal
> On Dec. 10, 2021, 4:20 a.m., Pradeep Agrawal wrote: > > What if we keep both ? > > bhavik patel wrote: > Spotbugs is developed on top Findbugs so keeping both it's not good idea. That i know, I wanted to know that whether anything has been removed/deprecated f

Re: Review Request 72941: RANGER-3030 : Replace Findbugs with Spotbugs maven plugin

2021-12-09 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72941/#review223830 --- What if we keep both ? - Pradeep Agrawal On Dec. 8, 2021, 8:03

Review Request 73755: RANGER-3539: Add jacoco-maven-plugin for code coverage

2021-12-10 Thread Pradeep Agrawal
Thanks, Pradeep Agrawal

Re: Review Request 73741: RANGER-3533 : Provide sorting on columns throughout the audits result set and policy listing page

2021-12-15 Thread Pradeep Agrawal
r/rest/ServiceREST.java Lines 3901 (patched) <https://reviews.apache.org/r/73741/#comment312904> can you reverse this like : SearchFilter.POLICY_ID.equalsIgnoreCase(sortBy) Please make the similar changes in other places also. - Pradeep Agrawal On Dec. 16, 2021, 5:25 a.m., Mat

Re: Review Request 73644: RANGER-3443 : "X-Permitted-Cross-Domain-Policies" header not set by Ranger UI.

2021-12-16 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73644/#review223868 --- Ship it! Ship It! - Pradeep Agrawal On Dec. 7, 2021, 1:31

<    1   2   3   4   5   6   7   8   9   10   >