Re: Review Request 74958: RANGER-4775 : Ranger Kms is failing with oracle23 Database

2024-04-18 Thread Dhaval Shah
Flavor Thanks, Dhaval Shah

Review Request 74958: RANGER-4775 : Ranger Kms is failing with oracle23 Database

2024-04-17 Thread Dhaval Shah
DB Flavor Thanks, Dhaval Shah

[jira] [Updated] (RANGER-4775) Ranger Kms is failing with oracle23 Database

2024-04-17 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Shah updated RANGER-4775: Description: Ranger KMS is failing with Oracle 23 database with below error. {code:java} 2024-04

[jira] [Created] (RANGER-4775) Ranger Kms is failing with oracle23 Database

2024-04-16 Thread Dhaval Shah (Jira)
Dhaval Shah created RANGER-4775: --- Summary: Ranger Kms is failing with oracle23 Database Key: RANGER-4775 URL: https://issues.apache.org/jira/browse/RANGER-4775 Project: Ranger Issue Type

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

2024-04-09 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74259/#review226383 --- Ship it! Ship It! - Dhaval Shah On March 23, 2024, 2:20 a.m

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

2024-04-03 Thread Dhaval Shah
the documentation link for this feature. Thanks - Dhaval Shah On March 23, 2024, 2:20 a.m., Kirby Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

2024-03-27 Thread Dhaval Shah
g/r/74259/#comment314594> Initialize the version - Dhaval Shah On March 23, 2024, 2:20 a.m., Kirby Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

2024-03-27 Thread Dhaval Shah
(patched) <https://reviews.apache.org/r/74259/#comment314593> Do we need tencent KMS dependency for AWS KMS? - Dhaval Shah On March 23, 2024, 2:20 a.m., Kirby Zhou wrote: > > --- > This is an automatically generated e-mail.

[jira] [Commented] (RANGER-3998) Support Ranger KMS integration with AWS KMS

2024-03-27 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831198#comment-17831198 ] Dhaval Shah commented on RANGER-3998: - Hi [~kirbyzhou], Can you please share the documentation link

[jira] [Commented] (RANGER-3998) Support Ranger KMS integration with AWS KMS

2024-03-22 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829816#comment-17829816 ] Dhaval Shah commented on RANGER-3998: - Hi [~kirbyzhou], RangerAWSKMSProvider class is missing

Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS

2024-03-22 Thread Dhaval Shah
/RangerKeyStoreProvider.java Lines 173 (patched) <https://reviews.apache.org/r/74259/#comment314588> RangerAWSKMSProvider class is missing in last uploaded patch. Can you please update the patch with RangerAWSKMSProvider.java - Dhaval Shah On March 21, 2024, 9:21 a.m., Kirby Zhou

Re: Review Request 74923: RANGER-4730: Migrate Ranger modules to junit5 - phase 2

2024-03-11 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74923/#review226314 --- Ship it! Ship It! - Dhaval Shah On March 4, 2024, 6:05 a.m

[jira] [Commented] (RANGER-4720) Ranger Admin server gives empty response when user with user-role tries to update lastname or email address

2024-02-29 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822437#comment-17822437 ] Dhaval Shah commented on RANGER-4720: - Committed in apache master : https://github.com/apache

[jira] [Commented] (RANGER-4698) [Ranger React UI] Audit UI improvements with respect to values overflowing into other columns

2024-02-29 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822436#comment-17822436 ] Dhaval Shah commented on RANGER-4698: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4699) Update the execution of setServiceDef call in App.jsx

2024-02-29 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822435#comment-17822435 ] Dhaval Shah commented on RANGER-4699: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4700) Audit logs for Masking policy is missing data mask type entry

2024-02-28 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821718#comment-17821718 ] Dhaval Shah commented on RANGER-4700: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4718) Skip showing 'Page not found' page for INVALID_INPUT_DATA validation in User Profile

2024-02-28 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821715#comment-17821715 ] Dhaval Shah commented on RANGER-4718: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4717) Skip showing 'Page not found' for wrong value is provided to a api parameter in Login Session Tab

2024-02-28 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821716#comment-17821716 ] Dhaval Shah commented on RANGER-4717: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4687) Updating the "Something went wrong" page in Ranger React UI

2024-02-28 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821714#comment-17821714 ] Dhaval Shah commented on RANGER-4687: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4680) Inconsistent resource lookup behaviour with newly created service

2024-02-28 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821713#comment-17821713 ] Dhaval Shah commented on RANGER-4680: - Committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4668) Need to have new local storage item for column show hide functionality in plugin status table

2024-02-05 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814295#comment-17814295 ] Dhaval Shah commented on RANGER-4668: - Committed in apache master branch https://github.com/apache

Re: Review Request 74853: RANGER-4668: Need to have new local storage item for column show hide functionality in plugin status table

2024-02-05 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74853/#review226201 --- Ship it! Ship It! - Dhaval Shah On Feb. 5, 2024, 6:37 a.m

[jira] [Commented] (RANGER-4675) Checkbox  selection issue when clicking on permission label  in tag-based permissions policy

2024-02-01 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813193#comment-17813193 ] Dhaval Shah commented on RANGER-4675: - Hi, Committed in apache master branch : https://github.com

Re: Review Request 74732: RANGER-4524: Fix TestRangerMetricsContainerSource class UT

2023-11-21 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74732/#review225988 --- Ship it! Ship It! - Dhaval Shah On Nov. 10, 2023, 6:52 a.m

[jira] [Commented] (RANGER-4493) Keep the UI behaviour for tag based and resource based services filtering for zone without any service

2023-11-21 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788335#comment-17788335 ] Dhaval Shah commented on RANGER-4493: - committed in apache master : https://github.com/apache/ranger

[jira] [Commented] (RANGER-4187) Not able to search using multiple user filter in access audit tab

2023-11-21 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788334#comment-17788334 ] Dhaval Shah commented on RANGER-4187: - Committed in apache master: https://github.com/apache/ranger

[jira] [Commented] (RANGER-4376) Need to show Tag Policies for user when it has permission in "Tag Based Policies" module

2023-11-21 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788332#comment-17788332 ] Dhaval Shah commented on RANGER-4376: - Committed in apache master : https://github.com/apache/ranger

[jira] (RANGER-4524) FIx TestRangerMetricsContainerSource class UT

2023-11-20 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4524 ] Dhaval Shah deleted comment on RANGER-4524: - was (Author: dhavalshah9131): Hi [~bpatel], Please share the Review Request link. Thanks > FIx TestRangerMetricsContainerSource class

[jira] [Commented] (RANGER-4524) FIx TestRangerMetricsContainerSource class UT

2023-11-20 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788262#comment-17788262 ] Dhaval Shah commented on RANGER-4524: - Hi [~bpatel], Please share the Review Request link. Thanks

[jira] [Commented] (RANGER-4525) Upgrade spotbugs plugin to 4.7.3.5

2023-11-17 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787185#comment-17787185 ] Dhaval Shah commented on RANGER-4525: - Hi, Committed in apache master : https://github.com/apache

[jira] [Commented] (RANGER-4360) Error page 'Go back' button not redirecting to the right page

2023-11-17 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787122#comment-17787122 ] Dhaval Shah commented on RANGER-4360: - Hi, Committed in apsche master branch : https://github.com

[jira] [Commented] (RANGER-4369) [Ranger React UI] Options for permissions pop up for knox policies are not the same in Backbone UI and React JS

2023-10-05 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17772102#comment-17772102 ] Dhaval Shah commented on RANGER-4369: - Committed in Apache Master : https://github.com/apache

[jira] [Commented] (RANGER-4407) Add server side validation for service audit filter

2023-09-25 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768719#comment-17768719 ] Dhaval Shah commented on RANGER-4407: - Hi , Committed in master branch : https://github.com/apache

[jira] [Commented] (RANGER-4358) Keep the usersync details popup names same as the backbone js names

2023-09-25 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768720#comment-17768720 ] Dhaval Shah commented on RANGER-4358: - Hi, Committed in master branch : https://github.com/apache

[jira] [Commented] (RANGER-4381) [Ranger React UI] Difference in user lookup API request in permissions module page between React UI and BackBone UI

2023-09-25 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768718#comment-17768718 ] Dhaval Shah commented on RANGER-4381: - Hi, Committed in master branch : https://github.com/apache

[jira] [Commented] (RANGER-4383) In Audit, Plugin Status tab if the record of respective service is in second page then Service Type filter for that service would show no result

2023-09-25 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17768717#comment-17768717 ] Dhaval Shah commented on RANGER-4383: - Hi , Committted in master branch : https://github.com

[jira] [Commented] (RANGER-4304) Update swagger version in Ranger

2023-09-11 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17763643#comment-17763643 ] Dhaval Shah commented on RANGER-4304: - Hi , Merged in Apache Master : https://github.com/apache

Re: Review Request 74577: RANGER-4304: Update swagger version in Ranger

2023-09-11 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74577/#review225727 --- Ship it! Ship It! - Dhaval Shah On Sept. 5, 2023, 12:34 p.m

[jira] [Commented] (RANGER-4196) Tomcat metrics collection

2023-08-25 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759138#comment-17759138 ] Dhaval Shah commented on RANGER-4196: - Hi [~vikkumar], Committed your patch in master branch. https

Re: Review Request 74557: RANGER-4196- Tomcat runtime metrics collection

2023-08-25 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74557/#review225686 --- Ship it! Ship It! - Dhaval Shah On Aug. 24, 2023, 11:30 a.m

Re: Review Request 74506: RANGER-4308: Upgrade netty to 4.1.94-final

2023-07-11 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74506/#review225601 --- Ship it! Ship It! - Dhaval Shah On July 6, 2023, 7:15 a.m

[jira] [Commented] (RANGER-4263) LookupResource give blank response in new react UI

2023-06-29 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738377#comment-17738377 ] Dhaval Shah commented on RANGER-4263: - Patch committed in apache master : https://github.com/apache

[jira] [Commented] (RANGER-4295) [Ranger UI] [React JS] Option might require to clear all filter at once for resource policy side bars

2023-06-29 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738376#comment-17738376 ] Dhaval Shah commented on RANGER-4295: - Patch committed in apache master : https://github.com/apache

[jira] [Commented] (RANGER-4047) Ranger KMS health metrics

2023-04-27 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17717240#comment-17717240 ] Dhaval Shah commented on RANGER-4047: - Push the change is apache master branch : https://github.com

Re: Review Request 74194: RANGER-3962: Add preload directive to HSTS header

2022-11-20 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74194/#review224892 --- Ship it! Ship It! - Dhaval Shah On Nov. 8, 2022, 11:37 a.m

Re: Review Request 74192: RANGER-3961: AuditFileSpool logs out all events that were not audited successfully

2022-11-20 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74192/#review224891 --- Ship it! Ship It! - Dhaval Shah On Nov. 8, 2022, 11:37 a.m

[jira] [Created] (RANGER-3927) Ranger KMS generates master key on every restart before inserting into DB

2022-09-21 Thread Dhaval Shah (Jira)
Dhaval Shah created RANGER-3927: --- Summary: Ranger KMS generates master key on every restart before inserting into DB Key: RANGER-3927 URL: https://issues.apache.org/jira/browse/RANGER-3927 Project

Review Request 74108: RANGER-3906 : Ranger KMS unable to start with Oracle 19 database

2022-09-09 Thread Dhaval Shah
for Oracle 19 Thanks, Dhaval Shah

[jira] [Created] (RANGER-3906) Ranger KMS unable to start with Oracle 19 database

2022-09-08 Thread Dhaval Shah (Jira)
Dhaval Shah created RANGER-3906: --- Summary: Ranger KMS unable to start with Oracle 19 database Key: RANGER-3906 URL: https://issues.apache.org/jira/browse/RANGER-3906 Project: Ranger Issue Type

[jira] [Created] (RANGER-3817) Incorrect client ip detail with Resource (Name / Type) column blank for Ranger KMS INVALIDATE_CACHE operation.

2022-07-04 Thread Dhaval Shah (Jira)
Dhaval Shah created RANGER-3817: --- Summary: Incorrect client ip detail with Resource (Name / Type) column blank for Ranger KMS INVALIDATE_CACHE operation. Key: RANGER-3817 URL: https://issues.apache.org/jira/browse

Re: Review Request 74033: RANGER-3798 : Ranger API Resource Metrics REST "Up time of JVM" does not update.

2022-06-23 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74033/#review224523 --- Ship it! Ship It! - Dhaval Shah On June 21, 2022, 2:14 p.m

Re: Review Request 73954: RANGER-3725 : Update atlas default audit filter to filter Atlas entity-read events by Nifi user.

2022-04-28 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73954/#review224386 --- Ship it! Ship It! - Dhaval Shah On April 21, 2022, 11:53

[jira] [Commented] (RANGER-3299) Upgrading the bouncycastle version for bcprov-jdk15on

2022-04-22 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17526411#comment-17526411 ] Dhaval Shah commented on RANGER-3299: - Thanks [~bpatel], ranger-2.3 branch : https://github.com

Re: Review Request 72024: RANGER-2704 : Support browser login using kerberized authentication.

2022-04-11 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72024/#review224293 --- Ship it! Ship It! - Dhaval Shah On April 5, 2022, 12:24 p.m

[jira] [Commented] (RANGER-3442) Ranger KMS DAO memory issues when many new keys are created

2022-04-05 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17517315#comment-17517315 ] Dhaval Shah commented on RANGER-3442: - Hi, Apache master commit : https://github.com/apache/ranger

Re: Review Request 73621: RANGER-3442: Fix Ranger KMS DAO memory issues when creating many new keys

2022-04-05 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73621/#review224247 --- Ship it! Ship It! - Dhaval Shah On Sept. 30, 2021, 8:18 p.m

Re: Review Request 73915: RANGER-3678: Update Test-Cases

2022-03-25 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73915/#review224210 --- Ship it! Ship It! - Dhaval Shah On March 25, 2022, 7:28 a.m

[jira] [Commented] (RANGER-3673) Need to enable cipher configuration for Usersync

2022-03-22 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17510476#comment-17510476 ] Dhaval Shah commented on RANGER-3673: - Hi, Apache master commit : https://github.com/apache/ranger

[jira] [Updated] (RANGER-3615) Issue with exported audit json builder while writing events to log4j

2022-02-23 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Shah updated RANGER-3615: Fix Version/s: 3.0.0 > Issue with exported audit json builder while writing events to lo

[jira] [Commented] (RANGER-3615) Issue with exported audit json builder while writing events to log4j

2022-02-23 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17496636#comment-17496636 ] Dhaval Shah commented on RANGER-3615: - Commits: master : https://github.com/apache/ranger/commit

Re: Review Request 73859: RANGER-3634: Remove duplicate entries from usersync distribution file

2022-02-23 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73859/#review224090 --- Ship it! Ship It! - Dhaval Shah On Feb. 21, 2022, 10:25 a.m

Re: Review Request 73847: RANGER-3624: Update-Ranger-services-Password-Policy

2022-02-23 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73847/#review224089 --- Ship it! Ship It! - Dhaval Shah On Feb. 21, 2022, 6:58 a.m

[jira] [Updated] (RANGER-3615) Issue with exported audit json builder while writing events to log4j

2022-02-22 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Shah updated RANGER-3615: Description: Ref Doc: https://blog.cloudera.com/auditing-to-external-systems-in-cdp-private

Review Request 73860: RANGER-3615 : Issue with exported audit json builder while writing events to log4j

2022-02-22 Thread Dhaval Shah
e are basically missing a '}' at the end of addition_info. Code Ref: https://github.com/apache/ranger/blob/master/agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java#L270 Diffs - agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java 838cfada3 hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java 8940f36c0 Diff: https://reviews.apache.org/r/73860/diff/1/ Testing --- 1.) Build Succeeded with test cases. 2.) Validataed audit JSON for hdfs , hive services. Thanks, Dhaval Shah

[jira] [Commented] (RANGER-3613) RANGER KMS : Check if master key with the given alias exists or not if LUNA HSM is enabled.

2022-02-22 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17495979#comment-17495979 ] Dhaval Shah commented on RANGER-3613: - Master Commit: https://github.com/apache/ranger/commit

[jira] [Commented] (RANGER-3580) Support Ranger KMS integration with TencentKMS

2022-02-17 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17493933#comment-17493933 ] Dhaval Shah commented on RANGER-3580: - Apache Master Commit: https://github.com/apache/ranger/commit

Re: Review Request 73842: RANGER-3620 : Ranger - Upgrade tomcat to 8.5.75

2022-02-17 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73842/#review224071 --- Ship it! Ship It! - Dhaval Shah On Feb. 14, 2022, 1:21 p.m

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-02-16 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73807/#review224060 --- Still the same issue with pom.xml - Dhaval Shah On Feb. 16

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-02-16 Thread Dhaval Shah
-TencentKMS-as-MasterKeyProvider.patch --check error: patch failed: pom.xml:181 error: pom.xml: patch does not apply - Dhaval Shah On Feb. 15, 2022, 8:48 a.m., Kirby Zhou wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-02-15 Thread Dhaval Shah
unused private fields such as 'AZURE_KEYVAULT_CERTIFICATE_PASSWORD'.. Request ypu please upload the patch after successful build using command "mvn clean install" - Dhaval Shah On Feb. 15, 2022, 8:48 a.m., Kirby

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-02-14 Thread Dhaval Shah
applying patch. git apply ~/Downloads/0001-add-TencentKMS-as-MasterKeyProvider.patch --check error: patch failed: pom.xml:181 error: pom.xml: patch does not apply Can you please check and update accordingly. Further I will merge the patch in master branch. Thanks - Dhaval Shah On Jan. 29, 2022, 9:53

[jira] [Created] (RANGER-3615) Issue with exported audit json builder while writing events to log4j

2022-02-10 Thread Dhaval Shah (Jira)
Dhaval Shah created RANGER-3615: --- Summary: Issue with exported audit json builder while writing events to log4j Key: RANGER-3615 URL: https://issues.apache.org/jira/browse/RANGER-3615 Project: Ranger

Re: Review Request 73838: RANGER-3613 : RANGER KMS - KeyStore will not be initialized when HSM(Luna) is enabled

2022-02-10 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73838/#review224032 --- Ship it! Ship It! - Dhaval Shah On Feb. 10, 2022, 8:06 a.m

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-02-08 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73807/#review224026 --- Ship it! Ship It! - Dhaval Shah On Jan. 29, 2022, 9:53 a.m

[jira] [Commented] (RANGER-3580) Support Ranger KMS integration with TencentKMS

2022-02-08 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17489296#comment-17489296 ] Dhaval Shah commented on RANGER-3580: - Hi [~kirbyzhou], Can you please share the doc explaining

Re: Review Request 73807: Support Ranger KMS integration with TencentKMS

2022-02-08 Thread Dhaval Shah
--- On Jan. 29, 2022, 9:53 a.m., Kirby Zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73807/ > ------- > > (Updated Jan. 29, 2022, 9:53 a.m.) >

[jira] [Commented] (RANGER-3580) Support Ranger KMS integration with TencentKMS

2022-01-19 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17478703#comment-17478703 ] Dhaval Shah commented on RANGER-3580: - Hi [~kirbyzhou], Thanks for creating the review request. I

[jira] [Commented] (RANGER-3580) Support Ranger KMS integration with TencentKMS

2022-01-18 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477794#comment-17477794 ] Dhaval Shah commented on RANGER-3580: - Hi [~kirbyzhou], Thanks for contributing towards Ranger KMS

[jira] [Commented] (RANGER-3577) RANGER : Upgrade POI version to 5.1.0

2022-01-18 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1749#comment-1749 ] Dhaval Shah commented on RANGER-3577: - Hi, Committed in apache master : https://github.com/apache

[jira] [Commented] (RANGER-3569) Support Ranger KMS integration with Google cloud HSM

2022-01-17 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477164#comment-17477164 ] Dhaval Shah commented on RANGER-3569: - Commited in master branch : https://github.com/apache

Re: Review Request 73789: RANGER-3577 : RANGER : Upgrade POI version to 5.1.0

2022-01-16 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73789/#review223966 --- Ship it! Ship It! - Dhaval Shah On Jan. 6, 2022, 3:23 p.m

Re: Review Request 73783: RANGER-3569 : Support Ranger KMS integration with Google cloud HSM

2022-01-06 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73783/#review223941 --- Ship it! Ship It! - Dhaval Shah On Jan. 5, 2022, 11:42 a.m

Re: Review Request 73783: RANGER-3569 : Support Ranger KMS integration with Google cloud HSM

2022-01-05 Thread Dhaval Shah
roduct will be resposible for any loss to HDFS encryption zone. Migration utlity is always recommneded to be executed by keeping Ranger KMS down. - Dhaval Shah On Jan. 4, 2022, 11:20 a.m., Mateen Mansoori

Re: Review Request 73745: RANGER-3487 : Update underscorejs with latest version.

2022-01-04 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73745/#review223930 --- Ship it! Ship It! - Dhaval Shah On Dec. 7, 2021, 1:36 p.m

Re: Review Request 73774: RANGER-3559 : RANGER KMS - Metric details for kms are not getting collected

2021-12-23 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73774/#review223904 --- Ship it! Ship It! - Dhaval Shah On Dec. 22, 2021, 9:34 a.m

[jira] [Comment Edited] (RANGER-3521) Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797

2021-12-09 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456440#comment-17456440 ] Dhaval Shah edited comment on RANGER-3521 at 12/9/21, 1:27 PM: --- Commited

[jira] [Updated] (RANGER-3521) Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797

2021-12-09 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dhaval Shah updated RANGER-3521: Fix Version/s: 2.3.0 > Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6

[jira] [Commented] (RANGER-3521) Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797

2021-12-09 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17456440#comment-17456440 ] Dhaval Shah commented on RANGER-3521: - Commited in Apache Master branch : https://github.com/apache

Review Request 73730: RANGER-3521 : Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797

2021-11-28 Thread Dhaval Shah
tag in Reponse Header for Ranger KMS CURL response for GET, CREATE, ROLLOVER, DELETE, GET METADATA key. E.G. : < Strict-Transport-Security: max-age=31536000; includeSubDomains Strict-Transport-Security: max-age=31536000; includeSubDomains Thanks, Dhaval Shah

Review Request 73730: RANGER-3521 : Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797

2021-11-28 Thread Dhaval Shah
tag in Reponse Header for Ranger KMS CURL response for GET, CREATE, ROLLOVER, DELETE, GET METADATA key. E.G. : < Strict-Transport-Security: max-age=31536000; includeSubDomains Strict-Transport-Security: max-age=31536000; includeSubDomains Thanks, Dhaval Shah

[jira] [Created] (RANGER-3521) Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797

2021-11-22 Thread Dhaval Shah (Jira)
Dhaval Shah created RANGER-3521: --- Summary: Ranger KMS IS NOT ENFORCING HSTS ON SSL PORT DEFINED BY RFC 6797 Key: RANGER-3521 URL: https://issues.apache.org/jira/browse/RANGER-3521 Project: Ranger

Re: Review Request 73680: RANGER-3499 : Upgrade tomcat to 8.5.72

2021-11-15 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73680/#review223733 --- Ship it! Ship It! - Dhaval Shah On Nov. 2, 2021, 10:04 a.m

[jira] [Commented] (RANGER-3442) Ranger KMS DAO memory issues when many new keys are created

2021-11-11 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17442257#comment-17442257 ] Dhaval Shah commented on RANGER-3442: - Hi [~pavitheran], Thanks for the improvement. Can you please

Re: [VOTE] Release Apache Ranger version 2.2.0 - rc1

2021-10-19 Thread Dhaval Shah
Hi All, +1 for Apache Ranger 2.2.0 rc1 release from my side. Thanks. Regards, Dhaval Shah On Tue, Oct 19, 2021 at 11:23 AM Ramesh Mani wrote: > Dear Rangers, > > Apache Ranger community has reported an issue with Apache Ranger Kafka > plugin in Release 2.2.0-rc1 and raised the

Re: Review Request 73634: RANGER-3463 : Use apt logger to log messages

2021-10-07 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73634/#review223586 --- Ship it! Ship It! - Dhaval Shah On Oct. 7, 2021, 7:30 a.m

Re: Review Request 73281: Fix compilation problems for Java 8 and Java 11.

2021-09-23 Thread Dhaval Shah
. - Dhaval Shah On Sept. 21, 2021, 7:18 a.m., Martin Grigorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Commented] (RANGER-3384) Metric Get API add input validation

2021-09-20 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17417466#comment-17417466 ] Dhaval Shah commented on RANGER-3384: - Apacher Master Commit : https://github.com/apache/ranger

Re: Review Request 73554: RANGER-3384: Metric Get API add input validation

2021-09-16 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73554/#review223493 --- Ship it! Ship It! - Dhaval Shah On Aug. 28, 2021, 1:27 a.m

[jira] [Commented] (RANGER-3339) Make Ranger Solr audit collection storage configurable

2021-09-09 Thread Dhaval Shah (Jira)
[ https://issues.apache.org/jira/browse/RANGER-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412480#comment-17412480 ] Dhaval Shah commented on RANGER-3339: - Apache master commit : https://github.com/apache/ranger

Re: Review Request 73521: RANGER-3358 : Upgrade Tomcat to 8.5.69

2021-09-06 Thread Dhaval Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73521/#review223444 --- Ship it! Ship It! - Dhaval Shah On Aug. 16, 2021, 9:25 a.m

  1   2   >