[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125256#comment-17125256 ] Palash Das commented on RANGER-2754: [~tooptoop4] - surprisingly, the server got started, without caring whether the plugins are loaded properly or not. > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Fix For: 2.1.0 > > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125055#comment-17125055 ] Palash Das commented on RANGER-2754: [~bolke] The current master is broken with presto. I confirm the following things (BREAKING) : # If presto-ranger plugin is built for target *java11/java8* and presto332 with *java11* is used then, RangerPluginClassLoader.class is not getting loaded. Following lines are creating trouble [https://github.com/apache/ranger/blob/cd2165f4b81eff0f29edf30fe73c31d24d9f1d78/ranger-plugin-classloader/src/main/java/org/apache/ranger/plugin/classloader/RangerPluginClassLoader.java#L283-L292] # If presto-ranger plugin is built for target *java8* and presto332 with *java8* is used then, then any regex based masking is not working. Basic access and row filtering is working fine. > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Fix For: 2.1.0 > > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123637#comment-17123637 ] Palash Das commented on RANGER-2317: This will do the trick, {code:java} provider = (Provider) Class.forName("sun.security.pkcs11.SunPKCS11") .getConstructor(String.class) .newInstance(pkcs11CfgFilePath); {code} [~zsombor] , [~pradeep] Test it and confirm me, I'll do the PR. Patch: [^0001-RANGER-2317-Use-reflection-to-invoke-constructor-to-.patch] > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-RANGER-2317-Use-reflection-to-invoke-constructor-to-.patch, > RANGER-2317-2.patch, RANGER-2317-3.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Palash Das updated RANGER-2317: --- Attachment: 0001-RANGER-2317-Use-reflection-to-invoke-constructor-to-.patch > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-RANGER-2317-Use-reflection-to-invoke-constructor-to-.patch, > RANGER-2317-2.patch, RANGER-2317-3.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123574#comment-17123574 ] Palash Das edited comment on RANGER-2317 at 6/2/20, 9:46 AM: - The problem still exists, instead of direct use, we should use reflection to invoke the constructor. was (Author: ppanda-beta): The problem still exists, instead of direct use, we should use reflection to nvoke the constructor. > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: 2.0.0 > > Attachments: RANGER-2317-2.patch, RANGER-2317-3.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2317) Enable compilation on JDK11
[ https://issues.apache.org/jira/browse/RANGER-2317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123574#comment-17123574 ] Palash Das commented on RANGER-2317: The problem still exists, instead of direct use, we should use reflection to nvoke the constructor. > Enable compilation on JDK11 > --- > > Key: RANGER-2317 > URL: https://issues.apache.org/jira/browse/RANGER-2317 > Project: Ranger > Issue Type: Improvement > Components: admin, plugins >Reporter: Zsombor Gegesy >Assignee: Zsombor Gegesy >Priority: Major > Fix For: 2.0.0 > > Attachments: RANGER-2317-2.patch, RANGER-2317-3.patch > > > Currently, Ranger can be compiled only with JDK 8, however JDK 11 is the > current LTS release for Java, it is essential to support it. As a first step, > we need to ensure that Ranger can be compiled on JDK 11. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109963#comment-17109963 ] Palash Das commented on RANGER-2754: [~toopt4] This is bad news, does this mean that we have to stick to prestosql 331? > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Fix For: 2.1.0 > > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088600#comment-17088600 ] Palash Das commented on RANGER-2754: Thanks a lot [~bolke] What are the changes ? > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088563#comment-17088563 ] Palash Das commented on RANGER-2754: [~bolke] , In my case I just used "*" (only the character * from UI), it still picked up *CaseInsensitiveStringMatcher,* This is not the case when I'm using normal access policies. In case of data masking and row filtering it is happening. > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088367#comment-17088367 ] Palash Das commented on RANGER-2754: Hi [~bolke], I've tested the following features (only basic round of testing), and those are working fine. # Presto, resource based policy without any data masking. (No more NPE) # Presto, resource based policy without any row filtering. (No more NPE) # Presto, column masking with MASK_SHOW_LAST_4 on a field of type varchar(255) # Presto, row filtering based on a field of type integer Appreciate your quick help. (y) The only challenge remaining is *CaseInsensitiveWildcardMatcher* is not used for "( * )" marked resource matchers. It is still using *CaseInsensitiveStringMatcher* :( > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087814#comment-17087814 ] Palash Das commented on RANGER-2754: Please, convert that Optional.of() to Optional.ofNullable() also, otherwise I've to maintain another patch file with just two lines of changes... > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087794#comment-17087794 ] Palash Das commented on RANGER-2754: {color:#ff}Two more problems detected{color} : h3. 1. Default mask expressions are missing type casting : At *ranger-servicedef-presto.json*, we can find the masking expression for _MASK_SHOW_LAST_4_ as {code:sql} regexp_replace({col}, '(.*)(.{4}$)', x -> regexp_replace(x[1], '.', 'X') || x[2]) {code} Which eventually breaks if the field type is varchar(255 [or any size]). As per presto [https://github.com/prestosql/presto/blob/1b55b866f344b59404c77dd1da0bd3b31fed5f3f/presto-main/src/main/java/io/prestosql/sql/analyzer/StatementAnalyzer.java#L2501] It throws error like : Expected column mask for '..' to be of type varchar(255), but was varchar A quick workaround could be `*CAST( regexp_replace(\{col}, '(.*)(.\{4}$)', x -> regexp_replace(x[1], '.', 'X') || x[2]) as varchar(255))*` , but the actual field type varchar(255) must be detected programmatically. h3. 2. Resources do not match with wildcards, e.g. ( * ), this is happening because CaseInsensitiveStringMatcher is used to match string values with wildcards. {code:java} //RangerDefaultResourceMatcher.java ... resourceMatcher.isMatch(strValue, evalContext) {code} *CaseInsensitiveWildcardMatcher* is the correct one to use here... > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087698#comment-17087698 ] Palash Das commented on RANGER-2754: Yes I did, I'm debugging on a full setup. I have ranger <-> presto <-> postgres. You can write some unit tests also, to verify. Here is the javadoc {code:java} /** * Returns an {@code Optional} with the specified present non-null value. * * @param the class of the value * @param value the value to be present, which must be non-null * @return an {@code Optional} with the value present * @throws NullPointerException if value is null */ public static Optional of(T value) { return new Optional<>(value); } {code} > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087625#comment-17087625 ] Palash Das commented on RANGER-2754: Same for row filtering as well... {code:java} ViewExpression viewExpression = null; if (isRowFilterEnabled(result)) { //... } return Optional.of(viewExpression); // <<<-- Again Optional.of() does not take null values {code} > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087607#comment-17087607 ] Palash Das commented on RANGER-2754: Another problem on your code [~bolke] {code:java} ViewExpression viewExpression = null; if (isDataMaskEnabled(result)) { //.. } return Optional.of(viewExpression); // <<<-- Wrong, it should be Optional.ofNullable(viewExpression), otherwise it throws NPE } {code} > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087544#comment-17087544 ] Palash Das commented on RANGER-2754: I think these two lines are protecting the api from breaking [https://github.com/apache/ranger/blob/6d93ba7158dbc366457613f29b71b25ee6790484/agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java#L407-L409] And [https://github.com/apache/ranger/blob/6d93ba7158dbc366457613f29b71b25ee6790484/agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java#L415-L417] In the constructor they are calling setters, in the setter they are putting default values... > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (RANGER-2754) Update presto dependency and implement row/column level security
[ https://issues.apache.org/jira/browse/RANGER-2754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087536#comment-17087536 ] Palash Das commented on RANGER-2754: Hey, I found my mistake, although I had created a fresh service it still did not worked. I think the plugin definitions are also somehow stored on db now a days on ranger. To fix the problem, I deleted the entire database, and re setup ranger. it worked fine. > Update presto dependency and implement row/column level security > > > Key: RANGER-2754 > URL: https://issues.apache.org/jira/browse/RANGER-2754 > Project: Ranger > Issue Type: Improvement > Components: plugins >Affects Versions: master >Reporter: Bolke de Bruin >Assignee: Bolke de Bruin >Priority: Major > Attachments: > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > 0001-RANGER-2754-Upgrade-presto-dependency-and-improve-lo.patch, > RANGER-2754-v2.patch, RANGER-2754.patch > > > 1. PrestoSql has changed its Security API hence the Ranger plugin has stopped > working for versions > ~321. > 2. Presto master now has row/column level security support -- This message was sent by Atlassian Jira (v8.3.4#803005)