Re: Review Request 64723: Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64723/#review194289 --- Ship it! Ship It! - pengjianhua On 十二月 19, 2017, 9:07 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64723/ > --- > > (Updated 十二月 19, 2017, 9:07 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1937 > https://issues.apache.org/jira/browse/RANGER-1937 > > > Repository: ranger > > > Description > --- > > Currently Ranger tagsync ignores ENTITY_CREATE notifications from Atlas, as > no tags would be associated with the newly created entity. However, when an > entity is created in Atlas via import, tags could be associated with the > entity. To not miss the tags associated with the entities, Ranger tagsync > should be updated to process ENTITY_CREATE notifications as well. > > > Diffs > - > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > f42c908 > > > Diff: https://reviews.apache.org/r/64723/diff/1/ > > > Testing > --- > > Unit test run successful > > > Thanks, > > Abhay Kulkarni > >
Re: Review Request 64723: Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64723/#review194286 --- Ship it! Ship It! - Madhan Neethiraj On Dec. 19, 2017, 9:07 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64723/ > --- > > (Updated Dec. 19, 2017, 9:07 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1937 > https://issues.apache.org/jira/browse/RANGER-1937 > > > Repository: ranger > > > Description > --- > > Currently Ranger tagsync ignores ENTITY_CREATE notifications from Atlas, as > no tags would be associated with the newly created entity. However, when an > entity is created in Atlas via import, tags could be associated with the > entity. To not miss the tags associated with the entities, Ranger tagsync > should be updated to process ENTITY_CREATE notifications as well. > > > Diffs > - > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > f42c908 > > > Diff: https://reviews.apache.org/r/64723/diff/1/ > > > Testing > --- > > Unit test run successful > > > Thanks, > > Abhay Kulkarni > >
Review Request 64723: Ranger tagsync should process ENTITY_CREATE notification, to support Atlas import feature
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64723/ --- Review request for ranger and Madhan Neethiraj. Bugs: RANGER-1937 https://issues.apache.org/jira/browse/RANGER-1937 Repository: ranger Description --- Currently Ranger tagsync ignores ENTITY_CREATE notifications from Atlas, as no tags would be associated with the newly created entity. However, when an entity is created in Atlas via import, tags could be associated with the entity. To not miss the tags associated with the entities, Ranger tagsync should be updated to process ENTITY_CREATE notifications as well. Diffs - tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java f42c908 Diff: https://reviews.apache.org/r/64723/diff/1/ Testing --- Unit test run successful Thanks, Abhay Kulkarni
