Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-23 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/ --- (Updated Feb. 23, 2017, 9:56 p.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-23 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/#review166573 --- Fix it, then Ship it! security-admin/src/main/java/org/apache/

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-22 Thread Abhay Kulkarni
> On Feb. 22, 2017, 2:16 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java, > > line 115 > > > > > > "ret" is not populated for non-p

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-22 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/ --- (Updated Feb. 22, 2017, 11:37 p.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-21 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/#review166287 --- agents-common/src/main/java/org/apache/ranger/plugin/model/valida

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-21 Thread Abhay Kulkarni
> On Feb. 20, 2017, 4:35 a.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java, > > line 51 > > > > > > Consider renaming: "getServiceDefF

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-21 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/ --- (Updated Feb. 21, 2017, 10:11 p.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-19 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/#review166043 --- agents-common/src/main/java/org/apache/ranger/plugin/model/valida

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-16 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/ --- (Updated Feb. 16, 2017, 10:45 p.m.) Review request for ranger, Madhan Neethiraj

Re: Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-15 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/ --- (Updated Feb. 16, 2017, 12:16 a.m.) Review request for ranger, Madhan Neethiraj

Review Request 56640: Support for using resource-matcher for filtering policies within a service if service-resource is provided in the filter

2017-02-13 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56640/ --- Review request for ranger, Madhan Neethiraj and Velmurugan Periasamy. Bugs: RAN