Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-03-01 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/#review167343 --- Ship it! Ship It! - Ramesh Mani On March 1, 2017, 8:52 a.m.,

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-03-01 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/#review167288 --- Ship it! Ship It! - Abhay Kulkarni On March 1, 2017, 8:52 a.

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-03-01 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/ --- (Updated March 1, 2017, 8:52 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-03-01 Thread Pradeep Agrawal
> On March 1, 2017, 6:58 a.m., Ramesh Mani wrote: > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java > > Lines 266 (patched) > > > > > > !"null".equalsIgnoreCase(oldValue) is the che

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-02-28 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/#review167213 --- security-admin/src/main/java/org/apache/ranger/service/RangerServ

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-02-28 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/ --- (Updated March 1, 2017, 6:24 a.m.) Review request for ranger, Ankita Sinha, Don

Re: Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-02-28 Thread Abhay Kulkarni
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/#review167156 --- In addition to changes in this patch, Consider moving line 1491 in

Review Request 57123: RANGER-1407 : Service update transaction log is not generated in some cases

2017-02-27 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57123/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Ku