Re: Review Request 58331: RANGER-1507 Do some code improvement in UserSync

2017-04-14 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58331/#review171989 --- It looks like "groupName" can be set in "findBasicUserProperties"

Re: Review Request 58331: RANGER-1507 Do some code improvement in UserSync

2017-04-13 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58331/ --- (Updated 四月 14, 2017, 2:25 a.m.) Review request for ranger, Alok Lal, Ankita

Re: Review Request 58331: RANGER-1507 Do some code improvement in UserSync

2017-04-11 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58331/#review171571 --- There is one whitespace error with the patch. - Colm O

Review Request 58331: RANGER-1507 Do some code improvement in UserSync

2017-04-10 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58331/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O