Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-20 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/#review194284 --- Ship it! Ship It! - Qiang Zhang On Dec. 20, 2017, 5:54

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-20 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/#review194272 --- Ship it! Ship It! - Ramesh Mani On Dec. 20, 2017, 5:54

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-20 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/#review194223 --- Ship it! Ship It! - Colm O hEigeartaigh On Dec. 20, 2017,

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-19 Thread pengjianhua
> On 十二月 19, 2017, 11:53 a.m., Colm O hEigeartaigh wrote: > > Better to have "!tokens.isEmpty()" than "tokens.size() > 0". Also, the > > indentation inside the if statement is wrong "if (providerName == null) {". Hi, I has updated the patch .thanks. - pengjianhua

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-19 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/ --- (Updated 十二月 20, 2017, 5:54 a.m.) Review request for ranger, Alok Lal, Ankita

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-19 Thread Colm O hEigeartaigh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/#review194136 --- Better to have "!tokens.isEmpty()" than "tokens.size() > 0".

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-18 Thread pengjianhua
> On 十二月 19, 2017, 12:55 a.m., Qiang Zhang wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > > Lines 93 (patched) > > > > > > Please modify tokens.size() > 1 to

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-18 Thread pengjianhua
> On 十二月 18, 2017, 10:05 a.m., Qiang Zhang wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > > Lines 95-99 (original), 96-100 (patched) > > > > > > They should not be

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-18 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/#review194105 ---

Re: Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-18 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/#review194054 ---

Review Request 64677: RANGER-1934:Optimize the init method in BaseAuditHandler class to avoid ArrayIndexOutOfBoundsException

2017-12-17 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64677/ --- Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O