Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-04-03 Thread Qiang Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66301/#review200421
---


Ship it!




Ship It!

- Qiang Zhang


On April 3, 2018, 5:23 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66301/
> ---
> 
> (Updated April 3, 2018, 5:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2040
> https://issues.apache.org/jira/browse/RANGER-2040
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvement in Analytics Metric of Ranger Admin and Ranger Kms for 
> Users/groups metric collection for Auditor Role.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 
> f1e18e5 
>   
> security-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java
>  345465d 
> 
> 
> Diff: https://reviews.apache.org/r/66301/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that in user/groups metric collection we are getting Auditor role 
> users.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-04-03 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66301/#review200367
---


Ship it!




Ship It!

- Velmurugan Periasamy


On April 3, 2018, 5:23 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66301/
> ---
> 
> (Updated April 3, 2018, 5:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2040
> https://issues.apache.org/jira/browse/RANGER-2040
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvement in Analytics Metric of Ranger Admin and Ranger Kms for 
> Users/groups metric collection for Auditor Role.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 
> f1e18e5 
>   
> security-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java
>  345465d 
> 
> 
> Diff: https://reviews.apache.org/r/66301/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that in user/groups metric collection we are getting Auditor role 
> users.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-04-03 Thread Mehul Parikh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66301/#review200348
---


Ship it!




Ship It!

- Mehul Parikh


On April 3, 2018, 5:23 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66301/
> ---
> 
> (Updated April 3, 2018, 5:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2040
> https://issues.apache.org/jira/browse/RANGER-2040
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvement in Analytics Metric of Ranger Admin and Ranger Kms for 
> Users/groups metric collection for Auditor Role.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 
> f1e18e5 
>   
> security-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java
>  345465d 
> 
> 
> Diff: https://reviews.apache.org/r/66301/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that in user/groups metric collection we are getting Auditor role 
> users.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-04-02 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66301/
---

(Updated April 3, 2018, 5:23 a.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
Sailaja Polavarapu.


Bugs: RANGER-2040
https://issues.apache.org/jira/browse/RANGER-2040


Repository: ranger


Description
---

Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups 
metric collection for Auditor Role.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 
f1e18e5 
  
security-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java 
345465d 


Diff: https://reviews.apache.org/r/66301/diff/1/


Testing
---

Tested that in user/groups metric collection we are getting Auditor role users.


Thanks,

Fatima Khan

Re: Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-04-02 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66301/#review200317
---


Ship it!





security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java
Line 148 (original), 148 (patched)


Update the branch info to be master.


- Velmurugan Periasamy


On March 27, 2018, 9:23 a.m., Fatima Khan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66301/
> ---
> 
> (Updated March 27, 2018, 9:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, and 
> Sailaja Polavarapu.
> 
> 
> Bugs: RANGER-2040
> https://issues.apache.org/jira/browse/RANGER-2040
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Improvement in Analytics Metric of Ranger Admin and Ranger Kms for 
> Users/groups metric collection for Auditor Role.
> 
> 
> Diffs
> -
> 
>   
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 
> f1e18e5 
>   
> security-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java
>  345465d 
> 
> 
> Diff: https://reviews.apache.org/r/66301/diff/1/
> 
> 
> Testing
> ---
> 
> Tested that in user/groups metric collection we are getting Auditor role 
> users.
> 
> 
> Thanks,
> 
> Fatima Khan
> 
>

Review Request 66301: RANGER-2040 : Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups metric collection for Auditor Role.

2018-03-27 Thread Fatima Khan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66301/
---

Review request for ranger.


Bugs: RANGER-2040
https://issues.apache.org/jira/browse/RANGER-2040


Repository: ranger


Description
---

Improvement in Analytics Metric of Ranger Admin and Ranger Kms for Users/groups 
metric collection for Auditor Role.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 
f1e18e5 
  
security-admin/src/main/java/org/apache/ranger/view/VXMetricUserGroupCount.java 
345465d 


Diff: https://reviews.apache.org/r/66301/diff/1/


Testing
---

Tested that in user/groups metric collection we are getting Auditor role users.


Thanks,

Fatima Khan