Re: Review Request 66448: Good coding practices for KMS and unixauth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66448/#review200697 --- Ship it! Ship It! - Mehul Parikh On April 5, 2018, 11 a.m., Nikhil P wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66448/ > --- > > (Updated April 5, 2018, 11 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2056 > https://issues.apache.org/jira/browse/RANGER-2056 > > > Repository: ranger > > > Description > --- > > Good coding practices for KMS and unixauth > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java 9f43740 > kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ad85245 > kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java b330a01 > kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java 13833cb > kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java f7c3e6d > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java > 803e3e8 > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java > 40cc51e > > > Diff: https://reviews.apache.org/r/66448/diff/1/ > > > Testing > --- > > 1)verified if Ranger KMS is working properly. > 2)verified if unix authentication,pam authentication works properly. > > > Thanks, > > Nikhil P > >
Re: Review Request 66448: Good coding practices for KMS and unixauth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66448/#review200639 --- Ship it! Ship It! - Velmurugan Periasamy On April 5, 2018, 11 a.m., Nikhil P wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66448/ > --- > > (Updated April 5, 2018, 11 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan > Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2056 > https://issues.apache.org/jira/browse/RANGER-2056 > > > Repository: ranger > > > Description > --- > > Good coding practices for KMS and unixauth > > > Diffs > - > > kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java 9f43740 > kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ad85245 > kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java b330a01 > kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java 13833cb > kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java f7c3e6d > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java > 803e3e8 > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java > 40cc51e > > > Diff: https://reviews.apache.org/r/66448/diff/1/ > > > Testing > --- > > 1)verified if Ranger KMS is working properly. > 2)verified if unix authentication,pam authentication works properly. > > > Thanks, > > Nikhil P > >
Review Request 66448: Good coding practices for KMS and unixauth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66448/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-2056 https://issues.apache.org/jira/browse/RANGER-2056 Repository: ranger Description --- Good coding practices for KMS and unixauth Diffs - kms/src/main/java/org/apache/hadoop/crypto/key/ConsoleUtil.java 9f43740 kms/src/main/java/org/apache/hadoop/crypto/key/DB2HSMMKUtil.java ad85245 kms/src/main/java/org/apache/hadoop/crypto/key/HSM2DBMKUtil.java b330a01 kms/src/main/java/org/apache/hadoop/crypto/key/JKS2RangerUtil.java 13833cb kms/src/main/java/org/apache/hadoop/crypto/key/Ranger2JKSUtil.java f7c3e6d unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/PamLoginModule.java 803e3e8 unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java 40cc51e Diff: https://reviews.apache.org/r/66448/diff/1/ Testing --- 1)verified if Ranger KMS is working properly. 2)verified if unix authentication,pam authentication works properly. Thanks, Nikhil P