Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-18 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201394 --- Ship it! Ship It! - Ramesh Mani On April 18, 2018, 6:05

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-18 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201391 --- Ship it! Ship It! - Qiang Zhang On April 18, 2018, 6:05

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-18 Thread pengjianhua
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201392 --- Ship it! Ship It! - pengjianhua On 四月 18, 2018, 6:05 a.m.,

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-18 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/ --- (Updated April 18, 2018, 6:05 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/ --- (Updated April 18, 2018, 5:50 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201388 --- These warning still exist. You should update the error patch.

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/ --- (Updated April 18, 2018, 4:06 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201376 --- Please fix warning message. Applying: RANGER-2043 : Ranger KMS

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-17 Thread Velmurugan Periasamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201328 --- Ship it! Ship It! - Velmurugan Periasamy On April 16, 2018,

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-15 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/ --- (Updated April 16, 2018, 5:57 a.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-13 Thread Ramesh Mani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201089 ---

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-13 Thread Qiang Zhang
> On April 13, 2018, 5:28 a.m., Qiang Zhang wrote: > > Added logs will reduce program performance. > > bhavik patel wrote: > Currently if we get any error message then it will be very difficult to > debug so it will be helpful to debug the code at the time of any error.

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread bhavik patel
> On April 13, 2018, 5:28 a.m., Qiang Zhang wrote: > > Added logs will reduce program performance. Currently if we get any error message then it will be very difficult to debug so it will be helpful to debug the code at the time of any error. - bhavik

Re: Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread Qiang Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/#review201086 --- Added logs will reduce program performance. - Qiang Zhang On

Review Request 66598: RANGER-2043 : Ranger KMS KeyProvider and HSM KeyProvider should have more debug logs

2018-04-12 Thread bhavik patel
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66598/ --- Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay