Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206969 --- Ship it! Ship It! - Mehul Parikh On Aug. 7, 2018, 1:21

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206968 --- Ship it! Ship It! - Abhay Kulkarni On Aug. 7, 2018, 1:21

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

> On Aug. 6, 2018, 8:16 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > > Lines 43 (patched) > > > > > > Do we really need a hash

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/ --- (Updated Aug. 7, 2018, 1:21 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206901 ---

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/ --- (Updated Aug. 6, 2018, 3:14 p.m.) Review request for ranger, Ankita Sinha,

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

> On Aug. 3, 2018, 8:41 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceValidator.java > > Line 40 (original), 40 (patched) > > > > > > Does the

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206850 ---

Re: Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/#review206848 --- Fix it and ship it.

Review Request 68186: RANGER-2181 : Code Improvement To Follow Best Practices

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68186/ --- Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan