Re: Review Request 70616: RANGER-2347 : Restrict capabilities of security zone administrator and auditor

2019-05-10 Thread Pradeep Agrawal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70616/#review215181
---


Ship it!




Ship It!

- Pradeep Agrawal


On May 10, 2019, 9:35 a.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70616/
> ---
> 
> (Updated May 10, 2019, 9:35 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, 
> Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2347
> https://issues.apache.org/jira/browse/RANGER-2347
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Zone Admin and zone auditor can see their own zone specific audit access logs.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 41b42ca 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 429c450 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 703d30b 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> f0909ab 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> c4ccee9 
>   
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
>  9be2ef4 
>   security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
> 1f73709 
> 
> 
> Diff: https://reviews.apache.org/r/70616/diff/2/
> 
> 
> Testing
> ---
> 
> Zone admin and zone auditor will only be able to see thier zone associated 
> logs.
> Functioanlity will be same as before for rest of all users.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>



Re: Review Request 70616: RANGER-2347 : Restrict capabilities of security zone administrator and auditor

2019-05-10 Thread bhavik patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70616/
---

(Updated May 10, 2019, 9:35 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, 
Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
---

Updated patch contains test case fixes.


Bugs: RANGER-2347
https://issues.apache.org/jira/browse/RANGER-2347


Repository: ranger


Description
---

Zone Admin and zone auditor can see their own zone specific audit access logs.


Diffs (updated)
-

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 41b42ca 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 429c450 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 703d30b 
  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
f0909ab 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c4ccee9 
  
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
 9be2ef4 
  security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java 
1f73709 


Diff: https://reviews.apache.org/r/70616/diff/2/

Changes: https://reviews.apache.org/r/70616/diff/1-2/


Testing
---

Zone admin and zone auditor will only be able to see thier zone associated logs.
Functioanlity will be same as before for rest of all users.


Thanks,

bhavik patel



Re: Review Request 70616: RANGER-2347 : Restrict capabilities of security zone administrator and auditor

2019-05-09 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70616/#review215173
---


Ship it!




Ship It!

- Abhay Kulkarni


On May 9, 2019, 12:52 p.m., bhavik patel wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70616/
> ---
> 
> (Updated May 9, 2019, 12:52 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
> Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, 
> Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2347
> https://issues.apache.org/jira/browse/RANGER-2347
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Zone Admin and zone auditor can see their own zone specific audit access logs.
> 
> 
> Diffs
> -
> 
>   security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 41b42ca 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 429c450 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 703d30b 
>   security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
> f0909ab 
>   security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
> c4ccee9 
>   
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
>  9be2ef4 
> 
> 
> Diff: https://reviews.apache.org/r/70616/diff/1/
> 
> 
> Testing
> ---
> 
> Zone admin and zone auditor will only be able to see thier zone associated 
> logs.
> Functioanlity will be same as before for rest of all users.
> 
> 
> Thanks,
> 
> bhavik patel
> 
>



Review Request 70616: RANGER-2347 : Restrict capabilities of security zone administrator and auditor

2019-05-09 Thread bhavik patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70616/
---

Review request for ranger, Ankita Sinha, Don Bosco Durai, Gautam Borad, Abhay 
Kulkarni, Madhan Neethiraj, Oliver Szabo, Pradeep Agrawal, Ramesh Mani, 
Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2347
https://issues.apache.org/jira/browse/RANGER-2347


Repository: ranger


Description
---

Zone Admin and zone auditor can see their own zone specific audit access logs.


Diffs
-

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 41b42ca 
  security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 429c450 
  security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 703d30b 
  security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java 
f0909ab 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java c4ccee9 
  
security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
 9be2ef4 


Diff: https://reviews.apache.org/r/70616/diff/1/


Testing
---

Zone admin and zone auditor will only be able to see thier zone associated logs.
Functioanlity will be same as before for rest of all users.


Thanks,

bhavik patel