Re: Review Request 72500: RANGER-2823: RangerResouceTrie.copySubTree() does not set up TrieNode's child nodes correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72500/#review220815 --- Ship it! Ship It! - Madhan Neethiraj On May 12, 2020, 4:51 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72500/ > --- > > (Updated May 12, 2020, 4:51 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2823 > https://issues.apache.org/jira/browse/RANGER-2823 > > > Repository: ranger > > > Description > --- > > Ranger uses Trie object (instance of RangerResourceTrie class) to index > policies, tags and zones for efficient searching. The API to deep-copy Trie > object does not work correctly, as the information about the child nodes in a > TrieNode is not replicated correctly. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > e7d913c54 > > > Diff: https://reviews.apache.org/r/72500/diff/1/ > > > Testing > --- > > Tested by exercising copying existing Trie object and asserting that copy > contains the same TrieNode hierarchy as original Trie. > > > Thanks, > > Abhay Kulkarni > >
Re: Review Request 72500: RANGER-2823: RangerResouceTrie.copySubTree() does not set up TrieNode's child nodes correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72500/#review220813 --- Ship it! Ship It! - bhavik patel On May 12, 2020, 4:51 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72500/ > --- > > (Updated May 12, 2020, 4:51 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2823 > https://issues.apache.org/jira/browse/RANGER-2823 > > > Repository: ranger > > > Description > --- > > Ranger uses Trie object (instance of RangerResourceTrie class) to index > policies, tags and zones for efficient searching. The API to deep-copy Trie > object does not work correctly, as the information about the child nodes in a > TrieNode is not replicated correctly. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > e7d913c54 > > > Diff: https://reviews.apache.org/r/72500/diff/1/ > > > Testing > --- > > Tested by exercising copying existing Trie object and asserting that copy > contains the same TrieNode hierarchy as original Trie. > > > Thanks, > > Abhay Kulkarni > >
Re: Review Request 72500: RANGER-2823: RangerResouceTrie.copySubTree() does not set up TrieNode's child nodes correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72500/#review220800 --- Ship it! Ship It! - Pradeep Agrawal On May 12, 2020, 4:51 p.m., Abhay Kulkarni wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72500/ > --- > > (Updated May 12, 2020, 4:51 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2823 > https://issues.apache.org/jira/browse/RANGER-2823 > > > Repository: ranger > > > Description > --- > > Ranger uses Trie object (instance of RangerResourceTrie class) to index > policies, tags and zones for efficient searching. The API to deep-copy Trie > object does not work correctly, as the information about the child nodes in a > TrieNode is not replicated correctly. > > > Diffs > - > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java > e7d913c54 > > > Diff: https://reviews.apache.org/r/72500/diff/1/ > > > Testing > --- > > Tested by exercising copying existing Trie object and asserting that copy > contains the same TrieNode hierarchy as original Trie. > > > Thanks, > > Abhay Kulkarni > >
Review Request 72500: RANGER-2823: RangerResouceTrie.copySubTree() does not set up TrieNode's child nodes correctly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72500/ --- Review request for ranger and Madhan Neethiraj. Bugs: RANGER-2823 https://issues.apache.org/jira/browse/RANGER-2823 Repository: ranger Description --- Ranger uses Trie object (instance of RangerResourceTrie class) to index policies, tags and zones for efficient searching. The API to deep-copy Trie object does not work correctly, as the information about the child nodes in a TrieNode is not replicated correctly. Diffs - agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerResourceTrie.java e7d913c54 Diff: https://reviews.apache.org/r/72500/diff/1/ Testing --- Tested by exercising copying existing Trie object and asserting that copy contains the same TrieNode hierarchy as original Trie. Thanks, Abhay Kulkarni
