Re: Review Request 72520: RANGER-2829: plugins to support super-users/groups, and audit-exclude-users/groups/roles via configurations

2020-05-25 Thread Pradeep Agrawal

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72520/#review220861
---



Since Patch is already committed in apache ranger master branch therefore, it 
will be helpful(for tracking) if you can please change the RR status to 
"submitted".

- Pradeep Agrawal


On May 17, 2020, 8:16 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72520/
> ---
> 
> (Updated May 17, 2020, 8:16 p.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2829
> https://issues.apache.org/jira/browse/RANGER-2829
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated RangerBasePlugins to read super-users/groups and 
> audit-exclude-users/groups/roles from plugin config
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
>  89a31ccf6 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  41b24920d 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
>  2567edb29 
> 
> 
> Diff: https://reviews.apache.org/r/72520/diff/1/
> 
> 
> Testing
> ---
> 
> - verified manually by using updated agents-common library
> - updated unit tests to read super-users/groups, 
> audit-exclude-users/groups/roles from plugin-config
> - verified that unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 72520: RANGER-2829: plugins to support super-users/groups, and audit-exclude-users/groups/roles via configurations

2020-05-18 Thread bhavik patel

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72520/#review220814
---


Ship it!




Ship It!

- bhavik patel


On May 17, 2020, 8:16 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72520/
> ---
> 
> (Updated May 17, 2020, 8:16 p.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2829
> https://issues.apache.org/jira/browse/RANGER-2829
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated RangerBasePlugins to read super-users/groups and 
> audit-exclude-users/groups/roles from plugin config
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
>  89a31ccf6 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  41b24920d 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
>  2567edb29 
> 
> 
> Diff: https://reviews.apache.org/r/72520/diff/1/
> 
> 
> Testing
> ---
> 
> - verified manually by using updated agents-common library
> - updated unit tests to read super-users/groups, 
> audit-exclude-users/groups/roles from plugin-config
> - verified that unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 72520: RANGER-2829: plugins to support super-users/groups, and audit-exclude-users/groups/roles via configurations

2020-05-17 Thread Abhay Kulkarni

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72520/#review220797
---


Ship it!




Ship It!

- Abhay Kulkarni


On May 17, 2020, 8:16 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72520/
> ---
> 
> (Updated May 17, 2020, 8:16 p.m.)
> 
> 
> Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul 
> Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2829
> https://issues.apache.org/jira/browse/RANGER-2829
> 
> 
> Repository: ranger
> 
> 
> Description
> ---
> 
> Updated RangerBasePlugins to read super-users/groups and 
> audit-exclude-users/groups/roles from plugin config
> 
> 
> Diffs
> -
> 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
>  89a31ccf6 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  41b24920d 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
>  2567edb29 
> 
> 
> Diff: https://reviews.apache.org/r/72520/diff/1/
> 
> 
> Testing
> ---
> 
> - verified manually by using updated agents-common library
> - updated unit tests to read super-users/groups, 
> audit-exclude-users/groups/roles from plugin-config
> - verified that unit tests pass
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Review Request 72520: RANGER-2829: plugins to support super-users/groups, and audit-exclude-users/groups/roles via configurations

2020-05-17 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72520/
---

Review request for ranger, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, 
Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2829
https://issues.apache.org/jira/browse/RANGER-2829


Repository: ranger


Description
---

Updated RangerBasePlugins to read super-users/groups and 
audit-exclude-users/groups/roles from plugin config


Diffs
-

  
agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
 89a31ccf6 
  
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
 41b24920d 
  
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
 2567edb29 


Diff: https://reviews.apache.org/r/72520/diff/1/


Testing
---

- verified manually by using updated agents-common library
- updated unit tests to read super-users/groups, 
audit-exclude-users/groups/roles from plugin-config
- verified that unit tests pass


Thanks,

Madhan Neethiraj