----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32596/ -----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, dilli dorai, Gautam Borad, Abhay Kulkarni, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. Bugs: RANGER-346 https://issues.apache.org/jira/browse/RANGER-346 Repository: ranger Description ------- RANGER-346: updated service-def files to use JSON map for *Option fields, instead of custom-formatted string. Diffs ----- agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerSimpleMatcher.java e0bcefc agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAbstractContextEnricher.java 3229bd8 agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java e7d1a1c agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java d5332b2 agents-common/src/main/java/org/apache/ranger/plugin/resourcematcher/RangerPathResourceMatcher.java f372294 agents-common/src/main/resources/service-defs/ranger-servicedef-hbase.json 0376189 agents-common/src/main/resources/service-defs/ranger-servicedef-hdfs.json 925cc77 agents-common/src/main/resources/service-defs/ranger-servicedef-hive.json 704ae60 agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json 947b109 agents-common/src/main/resources/service-defs/ranger-servicedef-storm.json 506c9d3 agents-common/src/main/resources/service-defs/ranger-servicedef-yarn.json a28ea50 agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerSimpleMatcherTest.java 4bd2a43 agents-common/src/test/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluatorTest.java 9efbcaf agents-common/src/test/resources/policyengine/test_policyengine_hbase.json 35768cb agents-common/src/test/resources/policyengine/test_policyengine_hdfs.json 2acf868 agents-common/src/test/resources/policyengine/test_policyengine_hive.json 2ac90ae security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefServiceBase.java afaf2cb Diff: https://reviews.apache.org/r/32596/diff/ Testing ------- Verified that the updated fields are persisted/read correctly into/from the database; and the plugins work correctly with the updated *option fields. Thanks, Madhan Neethiraj