[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-31 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r214448422 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogName.java --- @@ -0,0 +1,48 @@ +package

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-30 Thread ss77892
Github user ss77892 commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r214160302 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogService.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r213797305 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r213797238 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/RecordListener.java --- @@ -0,0 +1,19 @@ +package

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r213797086 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogReader.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-29 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r213795159 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/ArchivedLog.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-23 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212458341 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-23 Thread VladRodionov
Github user VladRodionov commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212385674 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogReader.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-23 Thread ss77892
Github user ss77892 commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212202468 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogService.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-23 Thread ss77892
Github user ss77892 commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212197492 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogReader.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the Apache

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread VladRodionov
Github user VladRodionov commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212154446 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread VladRodionov
Github user VladRodionov commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212086396 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/AsyncLogReader.java --- @@ -0,0 +1,54 @@ +/** + * Licensed to

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread VladRodionov
Github user VladRodionov commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212086058 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/ArchivedLog.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212083394 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/ArchivedLog.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212077861 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/AsyncLogReader.java --- @@ -0,0 +1,54 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212074817 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212009732 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-22 Thread joshelser
Github user joshelser commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r212009110 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/AsyncLogReader.java --- @@ -0,0 +1,54 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-21 Thread VladRodionov
Github user VladRodionov commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211684885 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogReader.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-21 Thread VladRodionov
Github user VladRodionov commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211684524 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogName.java --- @@ -0,0 +1,28 @@ +package

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064459 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064158 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogService.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064553 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/AsyncLogReader.java --- @@ -0,0 +1,54 @@ +/** + * Licensed to

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064260 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogWriter.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064684 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogService.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r21106 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogStream.java --- @@ -0,0 +1,109 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064777 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/ArchivedLog.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-17 Thread ankitsinghal
Github user ankitsinghal commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r211064058 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogReader.java --- @@ -0,0 +1,53 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-16 Thread chrajeshbabu
Github user chrajeshbabu commented on a diff in the pull request: https://github.com/apache/incubator-ratis/pull/4#discussion_r210808962 --- Diff: ratis-logservice/src/main/java/org/apache/ratis/logservice/api/LogWriter.java --- @@ -0,0 +1,43 @@ +/** + * Licensed to the

[GitHub] incubator-ratis pull request #4: RATIS-272 logservice api

2018-08-16 Thread joshelser
GitHub user joshelser opened a pull request: https://github.com/apache/incubator-ratis/pull/4 RATIS-272 logservice api WIP. Based on Rajeshbabu's first API suggestions. Also adds: * LogStream and LogService interfaces * LogName to uniquely identify a LogStream in a