Re: Next steps after 2.2.1 release

2013-04-08 Thread Dan Creswell
Peter, I shall remind you of your statement elsewhere about behaviour in public. Dude, I know you're a much better person that the below suggests. Perhaps you wrote it in anger or frustration or fatigue or some combination. Nevertheless it doesn't come off well and would point at you needing to

Re: Next steps after 2.2.1 release

2013-04-08 Thread Gregg Wonderly
On 4/7/2013 7:03 PM, Greg Trasuk wrote: I'm honestly and truly not passing judgement on the quality of the code. I honestly don't know if it's good or bad. I have to confess that, given that Jini was written as a top-level project at Sun, sponsored by Bill Joy, when Sun was at the top of its

Re: Next Release

2013-04-08 Thread Mark Brouwer
On 4/7/13 4:25 AM, Greg Trasuk wrote: The 2.2 branch is very clean. It starts from release in 2011. Since then, Dennis applied RIVER-417, added poms for listing at Maven Central, and applied the Levels fix. I've applied RIVER-149, and that's it. Probably to Dennis. I noticed that what was

Re: Next steps after 2.2.1 release

2013-04-08 Thread Dan Creswell
This is an important issue to address. I know a lot of people here probably don't participate on the Concurrency-interest mailing list that has a wide range of discussion about the JLS vs the JMM and what the JIT compilers actually do to code these days. ... I used to be a concurrency

Re: What is wrong with TaskManager?

2013-04-08 Thread Patricia Shanahan
On 4/8/2013 6:52 AM, Mark Brouwer wrote: ... Therefore I spent some time in analyzing the 4 tasks (ServiceDiscoveryManager and JoinManager) that didn't return 'false', but I concluded it wouldn't be easy to rewrite those, it requires an intimate knowledge of these implementations and I didn't

Re: Next steps after 2.2.1 release

2013-04-08 Thread Peter
Thanks Gregg, You've hit the nail on the head, this is exactly the issue I'm having. So I've been fixing safe publication in constructors by making fields final or volatile and ensuring this doesn't escape, fixing synchronisation on collections etc during method calls. To fix deadlock, I

Re: Next steps after 2.2.1 release

2013-04-08 Thread Greg Trasuk
On Mon, 2013-04-08 at 15:59, Peter wrote: Greg, I apologise again for my outburst, I was wrong about your leadership skills. I couldn't help but notice the number of test failures, did they have an error message like the number of services started != number of services wanted? If