Re: Example Gradle Buuild

2020-07-11 Thread Peter Firmstone
Hi Dennis, Yes definitely, if you're ok with that. The qa test suite could potentially be modularized as well, I'm guessing it would be easier to run these tests with a gradle build. Cheers, Peter. On 7/11/2020 11:12 PM, Dennis Reedy wrote: Hi Peter, We could just fold what you’ve done in

Re: Example Gradle Buuild

2020-07-11 Thread Phillip Rhodes
On Sat, Jul 11, 2020 at 9:12 AM Dennis Reedy wrote: > > Hi Peter, > > We could just fold what you’ve done into the project. I merged the modules > for expediency. I’ll spend some > time next week doing that if we’d like to move it forward. Yeah, it would be nice to see the merged result of this

Re: Example Gradle Buuild

2020-07-11 Thread Dennis Reedy
Hi Zsolt, There are a few tests in there, most are in the qa directory in the main svn repository. I think it would be great if we could find a way to merge them into the modules and follow conventions. As far as the gradle version, did gradlew not work for you? Regards Dennis > On Jul 11,

Re: Example Gradle Buuild

2020-07-11 Thread Dennis Reedy
Hi Peter, We could just fold what you’ve done into the project. I merged the modules for expediency. I’ll spend some time next week doing that if we’d like to move it forward. Regards Dennis > On Jul 11, 2020, at 5:04 AM, Peter Firmstone > wrote: > > HI Dennis, > > Had a quick look just

Re: svn commit: r1879695 - in /river/jtsk/modules/modularize/apache-river: ./ browser/ dist/ extra/ phoenix-activation/phoenix-common/ phoenix-activation/phoenix-dl/ phoenix-activation/phoenix-group/

2020-07-11 Thread Peter Firmstone
Thanks Phil, Definitely a bonus, I guess now we need to get the qa suite of tests running against the new module jar's. There will be a lot of test failures due to security policy file changes that will be required, this usually happens with every major Java version change in any case. The

Re: Example Gradle Buuild

2020-07-11 Thread Peter Firmstone
HI Dennis, Had a quick look just now, I can see why gradle is attractive. I'm not a big fan of the larger modules, but you have demonstrated it can work. I guess it's a trade off between maintainability and avoiding the need to untangle the circular links. Have you had a look at the code c

Re: Example Gradle Buuild

2020-07-11 Thread Zsolt Kúti
Hi Dennis, Checked this out and gave it a try. Had to tell my gradle via my IDE(A) config to use JDK 8 ( I used Adopt) and then it compiled fine. Apart from a few warnings everything went smoothly. Out of curiosity run tests and have seen none. Are they held separately? Beyond that I did nothing e