Re: Next steps after 2.2.1 release

2013-04-11 Thread Peter Firmstone
Gregg, Thanks again for your support. I refactored LookupDiscovery and tidied up LookupLocatorDiscovery. If you get some time, I could use a hand with other classes you've already fixed. I'm working on MailboxImpl presently, there's some very dubious code, Threads being started from inside

Re: Next steps after 2.2.1 release

2013-04-10 Thread Gregg Wonderly
I just want to extend this conversation a bit by saying that nearly everything about River is concurrently accessed. There are, of course several places, where work is done by one thread, at a time, but new threads are created to do that work, and that means that visibility has to be

Re: Next steps after 2.2.1 release

2013-04-09 Thread Peter Firmstone
I've never experienced the issue locally (I see it on Jenkins quite a lot), but I suspect a stale registrar process left from another test may be stopping the socket from closing. Not that registrars are also simulated for discovery tests, so it may not necessarily be Reggie. The code is

Re: Next steps after 2.2.1 release

2013-04-08 Thread Dan Creswell
Peter, I shall remind you of your statement elsewhere about behaviour in public. Dude, I know you're a much better person that the below suggests. Perhaps you wrote it in anger or frustration or fatigue or some combination. Nevertheless it doesn't come off well and would point at you needing to

Re: Next steps after 2.2.1 release

2013-04-08 Thread Gregg Wonderly
On 4/7/2013 7:03 PM, Greg Trasuk wrote: I'm honestly and truly not passing judgement on the quality of the code. I honestly don't know if it's good or bad. I have to confess that, given that Jini was written as a top-level project at Sun, sponsored by Bill Joy, when Sun was at the top of its

Re: Next steps after 2.2.1 release

2013-04-08 Thread Dan Creswell
This is an important issue to address. I know a lot of people here probably don't participate on the Concurrency-interest mailing list that has a wide range of discussion about the JLS vs the JMM and what the JIT compilers actually do to code these days. ... I used to be a concurrency

Re: Next steps after 2.2.1 release

2013-04-08 Thread Peter
Thanks Gregg, You've hit the nail on the head, this is exactly the issue I'm having. So I've been fixing safe publication in constructors by making fields final or volatile and ensuring this doesn't escape, fixing synchronisation on collections etc during method calls. To fix deadlock, I

Re: Next steps after 2.2.1 release

2013-04-08 Thread Greg Trasuk
On Mon, 2013-04-08 at 15:59, Peter wrote: Greg, I apologise again for my outburst, I was wrong about your leadership skills. I couldn't help but notice the number of test failures, did they have an error message like the number of services started != number of services wanted? If

Re: Next steps after 2.2.1 release

2013-04-07 Thread Peter Firmstone
Greg, You need to spend some more time figuring out why those tests are failing, that isn't normal, when 280 tests fail, there's usually something wrong with configuration. The qa test suite just isn't that brittle ;) The tests that fail due to concurrency errors don't fail often, we're

Re: Next steps after 2.2.1 release

2013-04-07 Thread Dan Creswell
On 7 April 2013 05:24, Patricia Shanahan p...@acm.org wrote: On 4/6/2013 7:26 PM, Greg Trasuk wrote: ... Once we have a stable set of regression tests, then OK, we could think about improving performance or using Maven repositories as the codebase server. ... I think there is something

Re: Next steps after 2.2.1 release

2013-04-07 Thread Dan Creswell
True, for a definition of micro-benchmark you have decided for yourself rather than asked me to clarify On 7 April 2013 09:37, Patricia Shanahan p...@acm.org wrote: On 4/7/2013 1:04 AM, Dan Creswell wrote: On 7 April 2013 05:24, Patricia Shanahan p...@acm.org wrote: On 4/6/2013 7:26

Re: Next steps after 2.2.1 release

2013-04-07 Thread Greg Trasuk
On Sun, 2013-04-07 at 06:34, Peter Firmstone wrote: Oh, hang on, are you developing on Windows? If so, it's not supported in 2.2.0. OSX 10.8 in this case, although I also plan to run the test suite on Windows XP32 and Win7-64. Possibly also Solaris 10. As I recall the Windows not

Re: Next steps after 2.2.1 release

2013-04-07 Thread Dan Creswell
On 7 April 2013 15:18, Dennis Reedy dennis.re...@gmail.com wrote: On Apr 6, 2013, at 1026PM, Greg Trasuk wrote: Proposal 1 - Release version 2.2.1 from the 2.2 branch. +1 for this, we really need to get this done, and get this done before the end of the month. 2 -

Next steps after 2.2.1 release

2013-04-07 Thread Greg Trasuk
OK, so in my last message I talked about how (speaking only for myself) I'm a little nervous about the state of the trunk. So what now? Problems we need to avoid in this discussion: - - Conflation of source tree structure issues

Re: Next steps after 2.2.1 release

2013-04-07 Thread Greg Trasuk
On Sun, 2013-04-07 at 10:18, Dennis Reedy wrote: On Apr 6, 2013, at 1026PM, Greg Trasuk wrote: Proposal 1 - Release version 2.2.1 from the 2.2 branch. +1 for this, we really need to get this done, and get this done before the end of the month. Agreed. I was

Re: Next steps after 2.2.1 release

2013-04-07 Thread Peter
Greg, why have you repeated this message? I think this is a deliberate attack on the project because you haven't been following development in trunk and now you're scared because you see changes you don't understand. I've been following your developments in surrogates, an impressive amount of

Re: Next steps after 2.2.1 release

2013-04-07 Thread Greg Trasuk
On Sun, 2013-04-07 at 17:54, Peter wrote: Greg, why have you repeated this message? First time I sent it was from the wrong email address, so it got hung up in moderation. I sent it again from my subscribed address. I'm guessing someone just moderated the original through. Anyway, let's

Re: Next steps after 2.2.1 release

2013-04-07 Thread Patricia Shanahan
On 4/7/2013 5:03 PM, Greg Trasuk wrote: ... I'm honestly and truly not passing judgement on the quality of the code. I honestly don't know if it's good or bad. I have to confess that, given that Jini was written as a top-level project at Sun, sponsored by Bill Joy, when Sun was at the top of

Re: Next steps after 2.2.1 release

2013-04-06 Thread Patricia Shanahan
On 4/6/2013 7:26 PM, Greg Trasuk wrote: ... Once we have a stable set of regression tests, then OK, we could think about improving performance or using Maven repositories as the codebase server. ... I think there is something else you need before it would be a good idea to release any changes