Re: QA Test suite refactoring.

2012-12-31 Thread Peter Firmstone
The second stage of refactoring included separating out concerns from base test classes into new objects, and using object construction visibility guarantees to reduce mutable state. I've also fixed a number of occurrences of insufficient synchronization. The tests will be complete tomorrow,

Re: QA Test suite refactoring.

2012-12-24 Thread Peter Firmstone
First stage of refactoring complete. [java] - [java] [java] # of tests started = 1412 [java] # of tests completed = 1412 [java] # of tests skipped = 46 [java] # of tests passed= 1412 [java] # of tests failed= 0 [j

Re: QA Test suite refactoring.

2012-12-23 Thread Peter Firmstone
I propose a minor change in semantics for TestFactory. TestDescription includes the following: /** * The TestDescription is an object which describes a test; * it is a factory for the test object and provides support facilities * for setting up and executing the test. * * The description conta

Re: QA Test suite refactoring.

2012-12-23 Thread Peter Firmstone
I've completed the first phase of refactoring, separating out the environment setup and test run into separate interfaces as per appended. This should allow the setup and teardown and execution of the tests to remain separate concerns. At present all tests implement both interfaces, so nothi

Re: QA Test suite refactoring.

2012-12-02 Thread Dan Creswell
Well that's less crap than my suggestions! :) On 2 December 2012 10:33, Gregg Wonderly wrote: > How about something like initTest? > > Gregg Wonderly > > On Dec 2, 2012, at 12:07 PM, Dan Creswell wrote: > >> On 1 December 2012 03:24, Peter Firmstone wrote: >>> Presently most tests have a lot o

Re: QA Test suite refactoring.

2012-12-02 Thread Gregg Wonderly
How about something like initTest? Gregg Wonderly On Dec 2, 2012, at 12:07 PM, Dan Creswell wrote: > On 1 December 2012 03:24, Peter Firmstone wrote: >> Presently most tests have a lot of shared mutable state. >> >> This isn't helped by the setup(QAConfig) mutator method in the Test >> interf

Re: QA Test suite refactoring.

2012-12-02 Thread Dan Creswell
On 1 December 2012 03:24, Peter Firmstone wrote: > Presently most tests have a lot of shared mutable state. > > This isn't helped by the setup(QAConfig) mutator method in the Test > interface appended. > > An alternative might be: > > public Test setup(QAConfig config) throws Exception; > > This w

QA Test suite refactoring.

2012-12-01 Thread Peter Firmstone
Presently most tests have a lot of shared mutable state. This isn't helped by the setup(QAConfig) mutator method in the Test interface appended. An alternative might be: public Test setup(QAConfig config) throws Exception; This would allow the test to return another Test object, fully const