[GitHub] coveralls edited a comment on issue #519: [ISSUE#403]Implement the acl strandard for rocketmq

2018-11-07 Thread GitBox
coveralls edited a comment on issue #519: [ISSUE#403]Implement the acl strandard for rocketmq URL: https://github.com/apache/rocketmq/pull/519#issuecomment-435334578 [![Coverage Status](https://coveralls.io/builds/19977923/badge)](https://coveralls.io/builds/19977923) Coverage

Re: [VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread 厉启鹏
+1

Re:[VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread Shannon
+1 At 2018-11-07 13:04:09, "heng du" wrote: >Hello RocketMQ Community, > >This is the vote for 4.3.2 of Apache RocketMQ. > >This release enhanced some of original features and fixed some bugs, >further improved the stability of RocketMQ. > > >The artifacts:

[GitHub] ymwneu commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
ymwneu commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436886309 My mistake, i am not sure SendMessageHook will be deprecated. I think

[GitHub] ymwneu commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
ymwneu commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436885679 I have seen your PR, i think it will cause a response send twice.

[GitHub] lemonzone2010 edited a comment on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
lemonzone2010 edited a comment on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436883706 @ymwneu - The method doResponse doesn't affect the

[GitHub] lemonzone2010 commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
lemonzone2010 commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436883706 > I checked the code, found > `if (sendOK) {` > ` //xx`

[GitHub] ymwneu edited a comment on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
ymwneu edited a comment on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436878483 I checked the code, found `if (sendOK) {` `

[GitHub] ymwneu commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
ymwneu commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436878483 I checked the code, found `if (sendOK) { //xx

[GitHub] vongosling commented on issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING.

2018-11-07 Thread GitBox
vongosling commented on issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING. URL: https://github.com/apache/rocketmq/issues/534#issuecomment-436863137 If you could be careful of the code of the RocketMQ parts - how to create a

[GitHub] zhangdp-taozi commented on issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING.

2018-11-07 Thread GitBox
zhangdp-taozi commented on issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING. URL: https://github.com/apache/rocketmq/issues/534#issuecomment-436860894 but If I open vpn, the two instance consumers have different customerid, how

[GitHub] coveralls edited a comment on issue #532: ISSUE530

2018-11-07 Thread GitBox
coveralls edited a comment on issue #532: ISSUE530 URL: https://github.com/apache/rocketmq/pull/532#issuecomment-436565038 [![Coverage Status](https://coveralls.io/builds/19975442/badge)](https://coveralls.io/builds/19975442) Coverage decreased (-0.04%) to 43.17% when pulling

[GitHub] lemonzone2010 commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter

2018-11-07 Thread GitBox
lemonzone2010 commented on issue #531: can't get code and errorMsg in SendMessageContext when running SendMessageProcessor.executeSendMessageHookAfter URL: https://github.com/apache/rocketmq/issues/531#issuecomment-436859508 [PR #533 ](https://github.com/apache/rocketmq/pull/533)

[GitHub] coveralls edited a comment on issue #532: ISSUE530

2018-11-07 Thread GitBox
coveralls edited a comment on issue #532: ISSUE530 URL: https://github.com/apache/rocketmq/pull/532#issuecomment-436565038 [![Coverage Status](https://coveralls.io/builds/19974955/badge)](https://coveralls.io/builds/19974955) Coverage decreased (-0.08%) to 43.126% when pulling

[GitHub] vongosling closed issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING.

2018-11-07 Thread GitBox
vongosling closed issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING. URL: https://github.com/apache/rocketmq/issues/534 This is an automated message from the Apache

[GitHub] vongosling commented on issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING.

2018-11-07 Thread GitBox
vongosling commented on issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING. URL: https://github.com/apache/rocketmq/issues/534#issuecomment-436848708 This is normal behavior if you use the same consumer id @zhangdp-taozi please

[GitHub] vongosling commented on issue #528: QuickStart Document needs to add Min Disc Space Prerequisite

2018-11-07 Thread GitBox
vongosling commented on issue #528: QuickStart Document needs to add Min Disc Space Prerequisite URL: https://github.com/apache/rocketmq/issues/528#issuecomment-436847627 @walking98 Thanks for your suggestion,Prerequisite need to be elaborate for a user to quick start.

[GitHub] vongosling closed issue #405: Master power off may cause consumeQueue diff from commitLog

2018-11-07 Thread GitBox
vongosling closed issue #405: Master power off may cause consumeQueue diff from commitLog URL: https://github.com/apache/rocketmq/issues/405 This is an automated message from the Apache Git Service. To respond to the

[GitHub] vongosling commented on issue #507: 4.1.0-incubating rocket-client rocketmq_client.log can't be delete in otherdsays

2018-11-07 Thread GitBox
vongosling commented on issue #507: 4.1.0-incubating rocket-client rocketmq_client.log can't be delete in otherdsays URL: https://github.com/apache/rocketmq/issues/507#issuecomment-436844632 @superheizai any followup? This

[GitHub] zhangdp-taozi opened a new issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING.

2018-11-07 Thread GitBox
zhangdp-taozi opened a new issue #534: Two instance consumers in the same machine will both consume message in the mode of CLUSTERING. URL: https://github.com/apache/rocketmq/issues/534 There is a consumer in my application, I start this application twice with different ports, then there

[GitHub] coveralls commented on issue #532: ISSUE530

2018-11-07 Thread GitBox
coveralls commented on issue #532: ISSUE530 URL: https://github.com/apache/rocketmq/pull/532#issuecomment-436565038 [![Coverage Status](https://coveralls.io/builds/19955504/badge)](https://coveralls.io/builds/19955504) Coverage decreased (-0.09%) to 43.116% when pulling

Re: [VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread Gosling Von
+1 there is still some polish works todo in the download page. Lack of compatibility description and too messy download links. Von Gosling > 在 2018年11月7日,下午1:04,heng du 写道: > > Hello RocketMQ Community, > > This is the vote for 4.3.2 of Apache RocketMQ. > > This release enhanced some of

Re:回复:[VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread Tian YiSong
+1 congratulation Sent from my Huawei Mobile Original Message Subject: 回复:[VOTE]: Release Apache RocketMQ 4.3.2 RC1 From: 李维军 To: dev CC: +1 Congratulations! -- 发件人:heng du 发送时间:2018年11月7日(星期三) 13:04 收件人:dev 主 

[GitHub] lemonzone2010 opened a new pull request #533: [ISSUE#531]return response in handlePutMessageResult

2018-11-07 Thread GitBox
lemonzone2010 opened a new pull request #533: [ISSUE#531]return response in handlePutMessageResult URL: https://github.com/apache/rocketmq/pull/533 ## What is the purpose of the change [Related issue#531](https://github.com/apache/rocketmq/issues/531) ## Brief changelog

回复:[VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread 李维军
+1 Congratulations! -- 发件人:heng du 发送时间:2018年11月7日(星期三) 13:04 收件人:dev 主 题:[VOTE]: Release Apache RocketMQ 4.3.2 RC1 Hello RocketMQ Community, This is the vote for 4.3.2 of Apache RocketMQ. This release enhanced some of original

Re: [VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread Kevin Wang
+1 make it perfect! > 在 2018年11月7日,下午4:40,yukon 写道: > > +1 binding > > On Wed, Nov 7, 2018 at 1:37 PM 魏欢 wrote: > >> +1 >> glad to hear the new release! >> >> >> -- Original -- >> From: "dongeforever"; >> Date: Wed, Nov 7, 2018 01:26 PM >> To: "dev"; >>

[GitHub] coveralls edited a comment on issue #519: [ISSUE#403]Implement the acl strandard for rocketmq

2018-11-07 Thread GitBox
coveralls edited a comment on issue #519: [ISSUE#403]Implement the acl strandard for rocketmq URL: https://github.com/apache/rocketmq/pull/519#issuecomment-435334578 [![Coverage Status](https://coveralls.io/builds/19954684/badge)](https://coveralls.io/builds/19954684) Coverage

Re: [VOTE]: Release Apache RocketMQ 4.3.2 RC1

2018-11-07 Thread yukon
+1 binding On Wed, Nov 7, 2018 at 1:37 PM 魏欢 wrote: > +1 > glad to hear the new release! > > > -- Original -- > From: "dongeforever"; > Date: Wed, Nov 7, 2018 01:26 PM > To: "dev"; > > Subject: Re: [VOTE]: Release Apache RocketMQ 4.3.2 RC1 > > > +1 binding >

[GitHub] Black-Mamba24 commented on issue #530: Admin Command issues

2018-11-07 Thread GitBox
Black-Mamba24 commented on issue #530: Admin Command issues URL: https://github.com/apache/rocketmq/issues/530#issuecomment-436547239 @ymwneu you are right, my version is 4.2.0 This is an automated message from the Apache Git

[GitHub] Black-Mamba24 opened a new pull request #532: ISSUE530

2018-11-07 Thread GitBox
Black-Mamba24 opened a new pull request #532: ISSUE530 URL: https://github.com/apache/rocketmq/pull/532 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your