[GitHub] [rocketmq-client-go] 0daypwn commented on issue #947: still consumption blocked after issue #944

2022-10-16 Thread GitBox
0daypwn commented on issue #947: URL: https://github.com/apache/rocketmq-client-go/issues/947#issuecomment-1280160363 see #927 #928, you can try it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] mxsm commented on a diff in pull request #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-16 Thread GitBox
mxsm commented on code in PR #5325: URL: https://github.com/apache/rocketmq/pull/5325#discussion_r996551579 ## test/src/main/java/org/apache/rocketmq/test/util/MQAdminTestUtils.java: ## @@ -17,10 +17,15 @@ package org.apache.rocketmq.test.util; +import java.util.HashMap;

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability

2022-10-16 Thread GitBox
lizhanhui commented on code in PR #5323: URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996550415 ## common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java: ## @@ -78,6 +78,9 @@ public class NamesrvConfig { */ private boolean

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5323: [ISSUE #5322] improving SDK topic route availability

2022-10-16 Thread GitBox
lizhanhui commented on code in PR #5323: URL: https://github.com/apache/rocketmq/pull/5323#discussion_r996550415 ## common/src/main/java/org/apache/rocketmq/common/namesrv/NamesrvConfig.java: ## @@ -78,6 +78,9 @@ public class NamesrvConfig { */ private boolean

[GitHub] [rocketmq] mxsm commented on a diff in pull request #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-16 Thread GitBox
mxsm commented on code in PR #5325: URL: https://github.com/apache/rocketmq/pull/5325#discussion_r996550057 ## tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java: ## @@ -49,7 +49,7 @@ public void testExecute() { // Note:

[GitHub] [rocketmq] RongtongJin commented on issue #5329: When introducing Rockemq Dledger on the official website, there is no explanation of the difference between "rapid deployment and cluster depl

2022-10-16 Thread GitBox
RongtongJin commented on issue #5329: URL: https://github.com/apache/rocketmq/issues/5329#issuecomment-1280154267 @wps123456 Good idea. Could you submit a PR to [this repo](https://github.com/apache/rocketmq-site) to fix the issue? -- This is an automated message from the Apache Git

[GitHub] [rocketmq-operator] zongtanghu commented on pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard

2022-10-16 Thread GitBox
zongtanghu commented on PR #132: URL: https://github.com/apache/rocketmq-operator/pull/132#issuecomment-1280148054 Please, put forward your commit codes for optimizing codes as soon as possible! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-16 Thread GitBox
lizhanhui commented on code in PR #5325: URL: https://github.com/apache/rocketmq/pull/5325#discussion_r996547510 ## tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java: ## @@ -49,7 +49,7 @@ public void testExecute() { //

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-16 Thread GitBox
lizhanhui commented on code in PR #5325: URL: https://github.com/apache/rocketmq/pull/5325#discussion_r996547141 ## tools/src/test/java/org/apache/rocketmq/tools/command/acl/UpdateAccessConfigSubCommandTest.java: ## @@ -49,7 +49,7 @@ public void testExecute() { //

[GitHub] [rocketmq] Oliverwqcwrw commented on a diff in pull request #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-16 Thread GitBox
Oliverwqcwrw commented on code in PR #5325: URL: https://github.com/apache/rocketmq/pull/5325#discussion_r996538288 ## test/src/main/java/org/apache/rocketmq/test/util/MQAdminTestUtils.java: ## @@ -17,10 +17,15 @@ package org.apache.rocketmq.test.util; +import

[GitHub] [rocketmq-site] yijianhoan opened a new pull request, #340: [#339] Fix issue #339 with a correct file spelling

2022-10-16 Thread GitBox
yijianhoan opened a new pull request, #340: URL: https://github.com/apache/rocketmq-site/pull/340 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change close #339 ## Brief changelog XX ## Verifying this

[GitHub] [rocketmq-connect] odbozhou opened a new pull request, #355: [ISSUE #354] bug fix

2022-10-16 Thread GitBox
odbozhou opened a new pull request, #355: URL: https://github.com/apache/rocketmq-connect/pull/355 fixd: oom risk sink reblance null point ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq-connect] odbozhou opened a new issue, #354: bug fix

2022-10-16 Thread GitBox
odbozhou opened a new issue, #354: URL: https://github.com/apache/rocketmq-connect/issues/354 **BUG REPORT** oom risk sink reblance null point 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? - What is expected to see?

[GitHub] [rocketmq-site] yijianhoan opened a new issue, #339: a spelling mistake

2022-10-16 Thread GitBox
yijianhoan opened a new issue, #339: URL: https://github.com/apache/rocketmq-site/issues/339 a spelling mistake ![image](https://user-images.githubusercontent.com/77136538/196040275-37cf119a-4066-45d9-8522-838c93d0d556.png) -- This is an automated message from the Apache Git

[GitHub] [rocketmq] wps123456 commented on issue #5330: How to use Rocketmq Ledger cluster mode for spring boot?

2022-10-16 Thread GitBox
wps123456 commented on issue #5330: URL: https://github.com/apache/rocketmq/issues/5330#issuecomment-1279974981 the spring boot configure: server: port: 8080 rocketmq: name-server: 1:9876;2:9876;3:9876; producer: group: group1 access-key:

[GitHub] [rocketmq] wps123456 commented on issue #5330: How to use Rocketmq Ledger cluster mode for spring boot?

2022-10-16 Thread GitBox
wps123456 commented on issue #5330: URL: https://github.com/apache/rocketmq/issues/5330#issuecomment-1279974236 The rocketmq version is 4.8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] wps123456 opened a new issue, #5330: How to use Rocketmq Ledger cluster mode for spring boot?

2022-10-16 Thread GitBox
wps123456 opened a new issue, #5330: URL: https://github.com/apache/rocketmq/issues/5330 Rocketmq Ledger is a highly available cluster. When the master node fails, the slave node will become the master. I want to know when the Rocketmq Ledger cluster has been set up. How to configure the

[GitHub] [rocketmq] duhenglucky merged pull request #5316: [5315]disable commit offset if not enable autocommit

2022-10-16 Thread GitBox
duhenglucky merged PR #5316: URL: https://github.com/apache/rocketmq/pull/5316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] wps123456 opened a new issue, #5329: When introducing Rockemq Dledger on the official website, there is no explanation of the difference between "rapid deployment and cluster deplo

2022-10-16 Thread GitBox
wps123456 opened a new issue, #5329: URL: https://github.com/apache/rocketmq/issues/5329 When introducing Rockemq Dledger on the official website, there is no explanation of the difference between "rapid deployment and cluster deployment", which is easy to misunderstand **1:For my

[GitHub] [rocketmq-spring] HildaM commented on issue #491: How to dynamically configure consumerGroup in @RocketMQMessageListener

2022-10-16 Thread GitBox
HildaM commented on issue #491: URL: https://github.com/apache/rocketmq-spring/issues/491#issuecomment-1279956262 thank you very much | | Quan ***@***.*** | 回复的原邮件 | 发件人 | ***@***.***> | | 日期 | 2022年10月16日 19:57 | | 收件人 |

[GitHub] [rocketmq-spring] kosmosr commented on issue #491: How to dynamically configure consumerGroup in @RocketMQMessageListener

2022-10-16 Thread GitBox
kosmosr commented on issue #491: URL: https://github.com/apache/rocketmq-spring/issues/491#issuecomment-1279954574 > Could you give me some references about this feature please? | | Quan ***@***.*** | > […](#) > 回复的原邮件 | 发件人 | ***@***.***> | | 日期 | 2022年10月16日 19:26 | | 收件人

[GitHub] [rocketmq-spring] HildaM commented on issue #491: How to dynamically configure consumerGroup in @RocketMQMessageListener

2022-10-16 Thread GitBox
HildaM commented on issue #491: URL: https://github.com/apache/rocketmq-spring/issues/491#issuecomment-1279953026 Could you give me some references about this feature please? | | Quan ***@***.*** | 回复的原邮件 | 发件人 | ***@***.***> | | 日期

[GitHub] [rocketmq-spring] kosmosr commented on issue #491: How to dynamically configure consumerGroup in @RocketMQMessageListener

2022-10-16 Thread GitBox
kosmosr commented on issue #491: URL: https://github.com/apache/rocketmq-spring/issues/491#issuecomment-1279950087 I've code done this future in master branch, and it works the same way in kafka -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq-exporter] bangbangzheng opened a new issue, #115: Build Binary have error

2022-10-16 Thread GitBox
bangbangzheng opened a new issue, #115: URL: https://github.com/apache/rocketmq-exporter/issues/115 branch master; after mvn clean install , run jar java -jar target/rocketmq-exporter-0.0.2-SNAPSHOT.jar, have error.

[GitHub] [rocketmq] codecov-commenter commented on pull request #5328: [ISSUE #5327] Remove duplicate code in TimerFlushService

2022-10-16 Thread GitBox
codecov-commenter commented on PR #5328: URL: https://github.com/apache/rocketmq/pull/5328#issuecomment-1279926978 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5328?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] zhiliatom opened a new pull request, #5328: [ISSUE #5327] Remove duplicate code in TimerFlushService

2022-10-16 Thread GitBox
zhiliatom opened a new pull request, #5328: URL: https://github.com/apache/rocketmq/pull/5328 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5327 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] zhiliatom opened a new issue, #5327: Duplicate code in TimerFlushService

2022-10-16 Thread GitBox
zhiliatom opened a new issue, #5327: URL: https://github.com/apache/rocketmq/issues/5327 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid

[GitHub] [rocketmq] nowinkeyy commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

2022-10-16 Thread GitBox
nowinkeyy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1279911644 > Maybe a better way is to make the dispatch method asynchronous. I get your idea. It seems like a good idea.  The ReptMessageService thread can process futures to get

[GitHub] [rocketmq] complone commented on issue #5322: improving SDK topic route availability, when namsrv restart

2022-10-16 Thread GitBox
complone commented on issue #5322: URL: https://github.com/apache/rocketmq/issues/5322#issuecomment-1279908055 > > Can you give the relevant log error information? > > you can get TOPIC_NOT_EXIST response code and error msg is:No topic route info in name server for the topic

[GitHub] [rocketmq] ShadowySpirits commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

2022-10-16 Thread GitBox
ShadowySpirits commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1279906207 > The core of this optimization is to process dispatchRequest concurrently Maybe a better way is to make the dispatch method asynchronous. ```java public

[GitHub] [rocketmq] nowinkeyy commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

2022-10-16 Thread GitBox
nowinkeyy commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1279902519 Hi @ShadowySpirits , thank you very much for your reply! > Under normal circumstances, the messages of same queue are ordered in the commitLog. So your improvement is just

[GitHub] [rocketmq] nowinkeyy commented on issue #5307: Whether the if statement is redundant?

2022-10-15 Thread GitBox
nowinkeyy commented on issue #5307: URL: https://github.com/apache/rocketmq/issues/5307#issuecomment-1279891645 Hi @complone , thank you for your reply. I know what you mean. IMO, it is sufficient to run ```getConfirmOffset()``` directly because it includes ```isDuplicationEnable()```

[GitHub] [rocketmq] complone commented on issue #5307: Whether the if statement is redundant?

2022-10-15 Thread GitBox
complone commented on issue #5307: URL: https://github.com/apache/rocketmq/issues/5307#issuecomment-1279884285 Hello, I think it is necessary to enable the configuration here. The scenario used by this configuration is that when the message is written, the system has a thread that can do

[GitHub] [rocketmq] ShadowySpirits commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

2022-10-15 Thread GitBox
ShadowySpirits commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1279880378 Hi @nowinkeyy, I read your proposal and have some questions. 1. Under normal circumstances, the messages of same queue are ordered in the commitLog. So your

[GitHub] [rocketmq] nowinkeyy commented on issue #5326: Optimize write CommitLog speed with concurrency

2022-10-15 Thread GitBox
nowinkeyy commented on issue #5326: URL: https://github.com/apache/rocketmq/issues/5326#issuecomment-1279870599 @byj520-lang cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq] nowinkeyy opened a new issue, #5326: Optimize write CommitLog speed with concurrency

2022-10-15 Thread GitBox
nowinkeyy opened a new issue, #5326: URL: https://github.com/apache/rocketmq/issues/5326 we are preparing for RIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq-clients] github-actions[bot] commented on pull request #235: feat: Make each 'Client' have an independent 'ClientManager'

2022-10-15 Thread GitBox
github-actions[bot] commented on PR #235: URL: https://github.com/apache/rocketmq-clients/pull/235#issuecomment-1279858940 This PR is stale because it has been open for 30 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale,

[GitHub] [rocketmq] github-actions[bot] commented on issue #2267: [NEW FEATURE REQ] Skip some message of messageQueue

2022-10-15 Thread GitBox
github-actions[bot] commented on issue #2267: URL: https://github.com/apache/rocketmq/issues/2267#issuecomment-1279856404 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [rocketmq] github-actions[bot] closed issue #2267: [NEW FEATURE REQ] Skip some message of messageQueue

2022-10-15 Thread GitBox
github-actions[bot] closed issue #2267: [NEW FEATURE REQ] Skip some message of messageQueue URL: https://github.com/apache/rocketmq/issues/2267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] github-actions[bot] closed issue #2738: sendHeartbeatToAllBroker may execute before pull request after rebalance

2022-10-15 Thread GitBox
github-actions[bot] closed issue #2738: sendHeartbeatToAllBroker may execute before pull request after rebalance URL: https://github.com/apache/rocketmq/issues/2738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [rocketmq] github-actions[bot] commented on issue #2738: sendHeartbeatToAllBroker may execute before pull request after rebalance

2022-10-15 Thread GitBox
github-actions[bot] commented on issue #2738: URL: https://github.com/apache/rocketmq/issues/2738#issuecomment-1279856396 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [rocketmq] github-actions[bot] closed issue #3398: Log print closeChannel frequently

2022-10-15 Thread GitBox
github-actions[bot] closed issue #3398: Log print closeChannel frequently URL: https://github.com/apache/rocketmq/issues/3398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq] github-actions[bot] commented on issue #3398: Log print closeChannel frequently

2022-10-15 Thread GitBox
github-actions[bot] commented on issue #3398: URL: https://github.com/apache/rocketmq/issues/3398#issuecomment-1279856389 This issue was closed because it has been inactive for 3 days since being marked as stale. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [rocketmq] mxsm opened a new pull request, #5325: [ISSUE #5324]Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-15 Thread GitBox
mxsm opened a new pull request, #5325: URL: https://github.com/apache/rocketmq/pull/5325 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5324 ## Brief changelog - Replace deprecated class PosixParser with DefaultParser

[GitHub] [rocketmq] mxsm opened a new issue, #5324: Replace deprecated class PosixParser with DefaultParser for CLI

2022-10-15 Thread GitBox
mxsm opened a new issue, #5324: URL: https://github.com/apache/rocketmq/issues/5324 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid

[GitHub] [rocketmq] chris-joys commented on issue #453: 配置tls时,出现错误,请问有文档吗?

2022-10-15 Thread GitBox
chris-joys commented on issue #453: URL: https://github.com/apache/rocketmq/issues/453#issuecomment-127962 > > @tjq857 I would create a wiki page, configuring TLS step by step. > > That's will be very useful! Hi did you get any error or exception when you configure it

[GitHub] [rocketmq] fuyou001 commented on issue #5322: improving SDK topic route availability, when namsrv restart

2022-10-14 Thread GitBox
fuyou001 commented on issue #5322: URL: https://github.com/apache/rocketmq/issues/5322#issuecomment-1279643423 > Can you give the relevant log error information? you can get TOPIC_NOT_EXIST response code and error msg is:No topic route info in name server for the topic -- This is

[GitHub] [rocketmq] fuyou001 opened a new pull request, #5323: [ISSUE #5322] improving SDK topic route availability

2022-10-14 Thread GitBox
fuyou001 opened a new pull request, #5323: URL: https://github.com/apache/rocketmq/pull/5323 **Make sure set the target branch to `develop`** ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] github-actions[bot] commented on issue #3407: AutoCreate topic or new consumerGroup with auto create %RETRY% topic force register all topicInfo to namesrv, may cause namesrv fullgc

2022-10-14 Thread GitBox
github-actions[bot] commented on issue #3407: URL: https://github.com/apache/rocketmq/issues/3407#issuecomment-1279605786 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GitHub] [rocketmq] github-actions[bot] commented on issue #3409: Consume Count far greater than Produce Count

2022-10-14 Thread GitBox
github-actions[bot] commented on issue #3409: URL: https://github.com/apache/rocketmq/issues/3409#issuecomment-1279605773 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GitHub] [rocketmq] github-actions[bot] commented on issue #3411: Request Merge

2022-10-14 Thread GitBox
github-actions[bot] commented on issue #3411: URL: https://github.com/apache/rocketmq/issues/3411#issuecomment-1279605756 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GitHub] [rocketmq] complone commented on issue #5322: improving SDK topic route availability, when namsrv restart

2022-10-14 Thread GitBox
complone commented on issue #5322: URL: https://github.com/apache/rocketmq/issues/5322#issuecomment-1279594753 Can you give the relevant log error information? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [rocketmq-client-go] hxzqlh opened a new issue, #947: still consumption blocked after issue #944

2022-10-14 Thread GitBox
hxzqlh opened a new issue, #947: URL: https://github.com/apache/rocketmq-client-go/issues/947 I use the commit: [f3349bd](https://github.com/apache/rocketmq-client-go/commit/f3349bdbb4dbcf9a7481563cb0fc3dd3d3ce3985) which says it fixed the push consuner blocked issue

[GitHub] [rocketmq] fuyou001 opened a new issue, #5322: improving SDK topic route availability, when namsrv restart

2022-10-14 Thread GitBox
fuyou001 opened a new issue, #5322: URL: https://github.com/apache/rocketmq/issues/5322 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid

[GitHub] [rocketmq-site] mxsm opened a new pull request, #338: [ISSUE #337] Modify 03wathis en document Chinese worlds to english worlds in 4.x version

2022-10-14 Thread GitBox
mxsm opened a new pull request, #338: URL: https://github.com/apache/rocketmq-site/pull/338 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change close #337 ## Brief changelog - Modify 03wathis en document

[GitHub] [rocketmq-operator] zongtanghu commented on pull request #83: add pod anti affinity for broker

2022-10-14 Thread GitBox
zongtanghu commented on PR #83: URL: https://github.com/apache/rocketmq-operator/pull/83#issuecomment-1278897386 Hi,this pr has some codes conflicts, can you resolve it in your local enviroments? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq-client-go] hxzqlh commented on pull request #944: [ISSUE #945]init crCh after topic with namespace to avoid consumption blocked.

2022-10-14 Thread GitBox
hxzqlh commented on PR #944: URL: https://github.com/apache/rocketmq-client-go/pull/944#issuecomment-1278818883 I use the commit: [f3349bd](https://github.com/apache/rocketmq-client-go/commit/f3349bdbb4dbcf9a7481563cb0fc3dd3d3ce3985) which says it fix the push consuner blocked issued.

[GitHub] [rocketmq-client-go] yangjian102621 commented on issue #946: Orderly message does not work

2022-10-14 Thread GitBox
yangjian102621 commented on issue #946: URL: https://github.com/apache/rocketmq-client-go/issues/946#issuecomment-1278808542 I had find the reason. i should have specify a QueueSelector for the producer. ```go type MyQueueSelector struct{} func (q MyQueueSelector)

[GitHub] [rocketmq] sinrimin commented on issue #5310: Admin tool queryMessage signature check failed

2022-10-14 Thread GitBox
sinrimin commented on issue #5310: URL: https://github.com/apache/rocketmq/issues/5310#issuecomment-1278801166 @zhangjidi2016 Removing that line may cause the `rocketmq-tools version<=4.9.3` signature check to fail.:joy_cat: -- This is an automated message from the Apache Git Service. To

[GitHub] [rocketmq-connect] Oliverwqcwrw opened a new pull request, #353: [ISSUE #220] Add unit test

2022-10-14 Thread GitBox
Oliverwqcwrw opened a new pull request, #353: URL: https://github.com/apache/rocketmq-connect/pull/353 ## What is the purpose of the change Follow #220 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate

[GitHub] [rocketmq] GOODBOY008 commented on pull request #5253: Fix error core-concept url.

2022-10-14 Thread GitBox
GOODBOY008 commented on PR #5253: URL: https://github.com/apache/rocketmq/pull/5253#issuecomment-1278794406 Branch had be updated.Pls cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] lizhanhui commented on pull request #5321: [5318]defaultlitepullconsumer support resetoffset

2022-10-14 Thread GitBox
lizhanhui commented on PR #5321: URL: https://github.com/apache/rocketmq/pull/5321#issuecomment-1278779659 @lizhimins Please help look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [rocketmq] lizhanhui commented on pull request #5321: [5318]defaultlitepullconsumer support resetoffset

2022-10-14 Thread GitBox
lizhanhui commented on PR #5321: URL: https://github.com/apache/rocketmq/pull/5321#issuecomment-127886 [Server side reset-offset](https://github.com/apache/rocketmq/pull/5293) has already merged. Is this pull request still making sense? -- This is an automated message from the Apache

[GitHub] [rocketmq] lizhiboo opened a new pull request, #5321: [5318]defaultlitepullconsumer support resetoffset

2022-10-14 Thread GitBox
lizhiboo opened a new pull request, #5321: URL: https://github.com/apache/rocketmq/pull/5321 **Make sure set the target branch to `develop`** ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow

[GitHub] [rocketmq] echooymxq commented on issue #5310: Admin tool queryMessage signature check failed

2022-10-14 Thread GitBox
echooymxq commented on issue #5310: URL: https://github.com/apache/rocketmq/issues/5310#issuecomment-1278765681 @zhangjidi2016 I got it. Thank your answer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [rocketmq-flink] GOODBOY008 opened a new issue, #65: Documentation does not match reality about RocketMQSink.

2022-10-14 Thread GitBox
GOODBOY008 opened a new issue, #65: URL: https://github.com/apache/rocketmq-flink/issues/65 Documentation does not match reality about RocketMQSink. https://user-images.githubusercontent.com/13617900/195816700-16ef39b7-fc0b-4cf6-8eb6-db0ba76de278.png;> -- This is an automated

[GitHub] [rocketmq] codecov-commenter commented on pull request #5295: [ISSUE #5294]fix ClassLoad path optimization

2022-10-14 Thread GitBox
codecov-commenter commented on PR #5295: URL: https://github.com/apache/rocketmq/pull/5295#issuecomment-1278745415 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5295?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] Focus-rth opened a new pull request, #5320: [RIP-50]RocketMQ Transaction Message Improvement Of Batch OP Message

2022-10-14 Thread GitBox
Focus-rth opened a new pull request, #5320: URL: https://github.com/apache/rocketmq/pull/5320 **Make sure set the target branch to `develop`** ## What is the purpose of the change RocketMQ Transaction Message Improvement Of Batch OP Message

[GitHub] [rocketmq] zhangjidi2016 opened a new pull request, #5319: [ISSUE #5310]Admin tool queryMessage signature check failed

2022-10-14 Thread GitBox
zhangjidi2016 opened a new pull request, #5319: URL: https://github.com/apache/rocketmq/pull/5319 **Make sure set the target branch to `develop`** ## What is the purpose of the change #5310 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] lizhiboo opened a new issue, #5318: Support DefaultLitePullConsumerImpl resetOffset

2022-10-14 Thread GitBox
lizhiboo opened a new issue, #5318: URL: https://github.com/apache/rocketmq/issues/5318 mqadmin resetOffsetByTime command have no effect to DefaultLitePullConsumer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [rocketmq] RongtongJin closed pull request #5317: [RIP-50]RocketMQ Transaction Message Improvement Of Batch OP Message

2022-10-14 Thread GitBox
RongtongJin closed pull request #5317: [RIP-50]RocketMQ Transaction Message Improvement Of Batch OP Message URL: https://github.com/apache/rocketmq/pull/5317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [rocketmq] lizhanhui commented on issue #5184: Read Commitlogs concurrently to speed up generation of the consumeQueue

2022-10-14 Thread GitBox
lizhanhui commented on issue #5184: URL: https://github.com/apache/rocketmq/issues/5184#issuecomment-1278721439 @nowinkeyy Could you check if sending pull-request to https://github.com/apache/rocketmq.wiki.git works or not? You may, alternatively, send the patch to me and I would add it to

[GitHub] [rocketmq] zhangjidi2016 commented on issue #5310: Admin tool queryMessage signature check failed

2022-10-14 Thread GitBox
zhangjidi2016 commented on issue #5310: URL: https://github.com/apache/rocketmq/issues/5310#issuecomment-1278719100 ![image](https://user-images.githubusercontent.com/18254437/195806785-b37e0809-b2e0-4b3c-8e0b-5278c4ac7fe8.png) Before this patch

[GitHub] [rocketmq] RapperCL commented on issue #5294: ClassLoad path optimization

2022-10-14 Thread GitBox
RapperCL commented on issue #5294: URL: https://github.com/apache/rocketmq/issues/5294#issuecomment-1278712009 @lizhimins hi,I have restored the original loading method so that it doesn't affect other places where the method is called. Do you think this change will solve your concern?

[GitHub] [rocketmq] Focus-rth opened a new pull request, #5317: [RIP-50]RocketMQ Transaction Message Improvement Of Batch OP Message

2022-10-14 Thread GitBox
Focus-rth opened a new pull request, #5317: URL: https://github.com/apache/rocketmq/pull/5317 **Make sure set the target branch to `develop`** ## What is the purpose of the change doc:https://github.com/apache/rocketmq/wiki/RIP-50-RocketMQ-Transaction-Message-Improvement

[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block

2022-10-14 Thread GitBox
0daypwn commented on PR #934: URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1278705755 The purpose of these two is the same. but the pc.crCh Map may be read and written concurrently in two places - Subscribe - consumeMessageCurrently it may cause

[GitHub] [rocketmq] lizhanhui merged pull request #5275: [ISSUE #5313] Optimize ReceiptHandleProcessor and GrpcChannelManager

2022-10-14 Thread GitBox
lizhanhui merged PR #5275: URL: https://github.com/apache/rocketmq/pull/5275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhiboo opened a new pull request, #5316: [5315]disable commit offset if not enable autocommit

2022-10-14 Thread GitBox
lizhiboo opened a new pull request, #5316: URL: https://github.com/apache/rocketmq/pull/5316 **Make sure set the target branch to `develop`** ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow

[GitHub] [rocketmq] codecov-commenter commented on pull request #5314: [ISSUE #5307] Remove redundant if statements

2022-10-14 Thread GitBox
codecov-commenter commented on PR #5314: URL: https://github.com/apache/rocketmq/pull/5314#issuecomment-1278695055 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5314?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] lizhiboo opened a new issue, #5315: DefaultLitePullConsumerImpl's persistConsumeOffset method should not be called by MQClientInstance if DefaultLitePullConsumerImpl disable autoCo

2022-10-14 Thread GitBox
lizhiboo opened a new issue, #5315: URL: https://github.com/apache/rocketmq/issues/5315 ```java @Override public void persistConsumerOffset() { try { checkServiceState(); Set mqs = new HashSet(); if (this.subscriptionType ==

[GitHub] [rocketmq-client-go] ShannonDing closed issue #935: push consumer set wrong options did't stop and pull consumer did't check config

2022-10-14 Thread GitBox
ShannonDing closed issue #935: push consumer set wrong options did't stop and pull consumer did't check config URL: https://github.com/apache/rocketmq-client-go/issues/935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #936: [ISSUE #935]fix consumer option validate

2022-10-14 Thread GitBox
ShannonDing merged PR #936: URL: https://github.com/apache/rocketmq-client-go/pull/936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-client-go] ShannonDing commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block

2022-10-14 Thread GitBox
ShannonDing commented on PR #934: URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1278669814 @0daypwn , hi, it seems have conflicts after PR #944 merged, could you pls fix it and and have a test after the crCh initialized? -- This is an automated message from the

[GitHub] [rocketmq] nowinkeyy opened a new pull request, #5314: [ISSUE #5307] Remove redundant if statements

2022-10-14 Thread GitBox
nowinkeyy opened a new pull request, #5314: URL: https://github.com/apache/rocketmq/pull/5314 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5307 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq-operator] shendongsd closed pull request #75: [ISSUE 38] Add nodeAffinity for nameService pod

2022-10-14 Thread GitBox
shendongsd closed pull request #75: [ISSUE 38] Add nodeAffinity for nameService pod URL: https://github.com/apache/rocketmq-operator/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq-client-go] yangjian102621 opened a new issue, #946: Orderly message does not work

2022-10-14 Thread GitBox
yangjian102621 opened a new issue, #946: URL: https://github.com/apache/rocketmq-client-go/issues/946 **BUG REPORT** When i send some orderly message with producer, there are not in ordered when the consumer pull the message. **ENV** - OS: Ubuntu22.04

[GitHub] [rocketmq] drpmma opened a new issue, #5313: Optimize ReceiptHandleProcessor and GrpcChannelManager

2022-10-14 Thread GitBox
drpmma opened a new issue, #5313: URL: https://github.com/apache/rocketmq/issues/5313 1. Please describe the feature you are requesting. Optimize proxy module ReceiptHandleProcessor and GrpcChannelManager methods 2. Provide any additional detail on your proposed use case for

[GitHub] [rocketmq] echooymxq commented on issue #5310: Admin tool queryMessage signature check failed

2022-10-14 Thread GitBox
echooymxq commented on issue #5310: URL: https://github.com/apache/rocketmq/issues/5310#issuecomment-1278614328 In fact, I don't know why need to exclude the `UNIQUE_MSG_QUERY_FLAG `, about this https://github.com/apache/rocketmq/pull/1756 ? @zhangjidi2016 -- This is an automated

[GitHub] [rocketmq] weihubeats opened a new issue, #5312: How to upgrade to 5.0

2022-10-14 Thread GitBox
weihubeats opened a new issue, #5312: URL: https://github.com/apache/rocketmq/issues/5312 Is there a guide to upgrade from 4.x to 5.x, and can 4.x producers use 5.x client consumption? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [rocketmq] lizhanhui closed issue #3799: [RIP-30] Support Compaction topic

2022-10-14 Thread GitBox
lizhanhui closed issue #3799: [RIP-30] Support Compaction topic URL: https://github.com/apache/rocketmq/issues/3799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq] lizhanhui merged pull request #5260: [ISSUE 3799] add compaction delete policy

2022-10-14 Thread GitBox
lizhanhui merged PR #5260: URL: https://github.com/apache/rocketmq/pull/5260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui closed issue #5311: Expose an API to facilitate graceful shutdown of proxy

2022-10-14 Thread GitBox
lizhanhui closed issue #5311: Expose an API to facilitate graceful shutdown of proxy URL: https://github.com/apache/rocketmq/issues/5311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq] lizhanhui merged pull request #5194: [ISSUE #5311] Add preShutdown for grace shutdown

2022-10-14 Thread GitBox
lizhanhui merged PR #5194: URL: https://github.com/apache/rocketmq/pull/5194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] drpmma commented on pull request #5194: [ISSUE #5311] Add preShutdown for grace shutdown

2022-10-14 Thread GitBox
drpmma commented on PR #5194: URL: https://github.com/apache/rocketmq/pull/5194#issuecomment-1278597770 > Shutdown process will shutdown the netty server first, but the proxy need do some graceful shutdown logic before the netty server is closed. So preshutdown is introduced. --

[GitHub] [rocketmq] lizhanhui commented on pull request #5194: [ISSUE #5311] Add preShutdown for grace shutdown

2022-10-14 Thread GitBox
lizhanhui commented on PR #5194: URL: https://github.com/apache/rocketmq/pull/5194#issuecomment-1278596052 > Hello @drpmma , could you please create an issue and link it? Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [rocketmq] lizhanhui opened a new issue, #5311: Expose an API to facilitate graceful shutdown of proxy

2022-10-14 Thread GitBox
lizhanhui opened a new issue, #5311: URL: https://github.com/apache/rocketmq/issues/5311 To implement a graceful shutdown of the proxy, reverse destruction of resources does not suffice. An dedicated API, similar to Kubernetes [container lifecycle

[GitHub] [rocketmq] RongtongJin closed issue #5288: Implementation of AccessValidator cannot be replaced with SPI mechanism

2022-10-14 Thread GitBox
RongtongJin closed issue #5288: Implementation of AccessValidator cannot be replaced with SPI mechanism URL: https://github.com/apache/rocketmq/issues/5288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [rocketmq] RongtongJin merged pull request #5289: [ISSUE #5288] Fix default loading mechanism of AccessValidator

2022-10-14 Thread GitBox
RongtongJin merged PR #5289: URL: https://github.com/apache/rocketmq/pull/5289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-client-go] ShannonDing closed issue #939: Pull or poll message support msgtrace

2022-10-14 Thread GitBox
ShannonDing closed issue #939: Pull or poll message support msgtrace URL: https://github.com/apache/rocketmq-client-go/issues/939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq-client-go] ShannonDing merged pull request #940: [ISSUE #939]Pull or poll message support message trace

2022-10-14 Thread GitBox
ShannonDing merged PR #940: URL: https://github.com/apache/rocketmq-client-go/pull/940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3   4   5   6   7   8   9   10   >