[GitHub] [rocketmq] ShannonDing merged pull request #5249: add a label for hacktoberfest

2022-10-11 Thread GitBox
ShannonDing merged PR #5249: URL: https://github.com/apache/rocketmq/pull/5249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] caigy opened a new pull request, #5289: [ISSUE #5288] Fix default loading mechanism of AccessValidator

2022-10-11 Thread GitBox
caigy opened a new pull request, #5289: URL: https://github.com/apache/rocketmq/pull/5289 **Make sure set the target branch to `develop`** ## What is the purpose of the change fix #5288 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] caigy opened a new issue, #5288: Implementation of AccessValidator cannot be replaced with SPI mechanism

2022-10-11 Thread GitBox
caigy opened a new issue, #5288: URL: https://github.com/apache/rocketmq/issues/5288 **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? 1. Import `rocketmq-broker` as jar dependency. 2. Define my implementation

[GitHub] [rocketmq-mqtt] pingww closed pull request #91: [ISSUE #88] fix the bug of wrong future completed condition

2022-10-11 Thread GitBox
pingww closed pull request #91: [ISSUE #88] fix the bug of wrong future completed condition URL: https://github.com/apache/rocketmq-mqtt/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq-client-go] ShannonDing commented on issue #937: Offset - ConsumeFromWhere does not take effect

2022-10-11 Thread GitBox
ShannonDing commented on issue #937: URL: https://github.com/apache/rocketmq-client-go/issues/937#issuecomment-1275484122 This parameter takes effect only for the first-time CounsumerGroup. If the current ConsumerGroup has been used and then restarted, the configuration of this parameter

[GitHub] [rocketmq] chenzlalvin commented on issue #5287: RocketMQ support two consumergroup with one client consume same topic?

2022-10-11 Thread GitBox
chenzlalvin commented on issue #5287: URL: https://github.com/apache/rocketmq/issues/5287#issuecomment-1275477184 Please refer to the doc https://rocketmq.apache.org/zh/docs/%E9%A2%86%E5%9F%9F%E6%A8%A1%E5%9E%8B/09subscription -- This is an automated message from the Apache Git Service.

[GitHub] [rocketmq-site] ShannonDing closed issue #315: Remove Repeat the words

2022-10-11 Thread GitBox
ShannonDing closed issue #315: Remove Repeat the words URL: https://github.com/apache/rocketmq-site/issues/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [rocketmq-site] ShannonDing merged pull request #316: [ISSUE #315]Remove Repeat the words

2022-10-11 Thread GitBox
ShannonDing merged PR #316: URL: https://github.com/apache/rocketmq-site/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-site] ShannonDing closed issue #313: Keep the context in the same format

2022-10-11 Thread GitBox
ShannonDing closed issue #313: Keep the context in the same format URL: https://github.com/apache/rocketmq-site/issues/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq-site] ShannonDing merged pull request #314: [ISSUE #313] Keep the context in the same format

2022-10-11 Thread GitBox
ShannonDing merged PR #314: URL: https://github.com/apache/rocketmq-site/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] github-actions[bot] commented on issue #2267: [NEW FEATURE REQ] Skip some message of messageQueue

2022-10-11 Thread GitBox
github-actions[bot] commented on issue #2267: URL: https://github.com/apache/rocketmq/issues/2267#issuecomment-1275424219 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GitHub] [rocketmq] github-actions[bot] commented on issue #2738: sendHeartbeatToAllBroker may execute before pull request after rebalance

2022-10-11 Thread GitBox
github-actions[bot] commented on issue #2738: URL: https://github.com/apache/rocketmq/issues/2738#issuecomment-1275424208 This issue is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. -- This is an automated message

[GitHub] [rocketmq] j2gg0s opened a new issue, #5287: RocketMQ support two consumergroup with one client consume same topic?

2022-10-11 Thread GitBox
j2gg0s opened a new issue, #5287: URL: https://github.com/apache/rocketmq/issues/5287 RocketMQ support two consumergroup with one client consume same topic? Will there be any side effect? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [rocketmq] codecov-commenter commented on pull request #5286: [ISSUE #5285] Support vm arguments to set useTLS value.

2022-10-11 Thread GitBox
codecov-commenter commented on PR #5286: URL: https://github.com/apache/rocketmq/pull/5286#issuecomment-1275042090 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/5286?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation)

[GitHub] [rocketmq] echooymxq opened a new pull request, #5286: [ISSUE #5285] Support vm arguments to set useTLS value.

2022-10-11 Thread GitBox
echooymxq opened a new pull request, #5286: URL: https://github.com/apache/rocketmq/pull/5286 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5285 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] echooymxq opened a new issue, #5285: Add vm arguments to set useTLS for all server.

2022-10-11 Thread GitBox
echooymxq opened a new issue, #5285: URL: https://github.com/apache/rocketmq/issues/5285 When a server needs to call other services as a client, it may be need to set the useTLS value. So we can use the vm arguments for all server (broker, controller in namesrv, controller) . -- This is

[GitHub] [rocketmq] echooymxq commented on issue #453: 配置tls时,出现错误,请问有文档吗?

2022-10-11 Thread GitBox
echooymxq commented on issue #453: URL: https://github.com/apache/rocketmq/issues/453#issuecomment-1274909649 > Here is the [Work-In-Progress Guide](https://github.com/apache/rocketmq/wiki/How-to-Configure-TLS) The

[GitHub] [rocketmq] llb520 commented on issue #1192: duplicate message id?

2022-10-11 Thread GitBox
llb520 commented on issue #1192: URL: https://github.com/apache/rocketmq/issues/1192#issuecomment-1274723606 Why does this happen and how to fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq-connect] Oliverwqcwrw opened a new pull request, #347: [ISSUE #346] Add elasticsearch source connector

2022-10-11 Thread GitBox
Oliverwqcwrw opened a new pull request, #347: URL: https://github.com/apache/rocketmq-connect/pull/347 ## What is the purpose of the change Close #346 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate

[GitHub] [rocketmq-connect] Oliverwqcwrw opened a new issue, #346: Add elasticsearch source connector

2022-10-11 Thread GitBox
Oliverwqcwrw opened a new issue, #346: URL: https://github.com/apache/rocketmq-connect/issues/346 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Add elasticsearch source connector 3. Provide any additional detail on your proposed use case for

[GitHub] [rocketmq-flink] GOODBOY008 commented on issue #64: Support RocketMQ as LogStore for Flink Table Store

2022-10-11 Thread GitBox
GOODBOY008 commented on issue #64: URL: https://github.com/apache/rocketmq-flink/issues/64#issuecomment-1274647080 I'm willing to take this feature. please assign to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [rocketmq-flink] SteNicholas opened a new issue, #64: Support RocketMQ as LogStore for Flink Table Store

2022-10-11 Thread GitBox
SteNicholas opened a new issue, #64: URL: https://github.com/apache/rocketmq-flink/issues/64 Flink Table Store supports Kafka as its Logstore type at present. RocketMQ Flink could support RocketMQ as LogStore for Flink Table Store. -- This is an automated message from the Apache Git

[GitHub] [rocketmq] mxsm opened a new pull request, #5284: [ISSUE #5278]Modify MessageStoreConfig#isTransientStorePoolEnable method comment document

2022-10-11 Thread GitBox
mxsm opened a new pull request, #5284: URL: https://github.com/apache/rocketmq/pull/5284 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5278 ## Brief changelog - Modify MessageStoreConfig#isTransientStorePoolEnable

[GitHub] [rocketmq] tjq857 commented on issue #4527: Some questions about TLS enable in Configuration_TLS.md

2022-10-11 Thread GitBox
tjq857 commented on issue #4527: URL: https://github.com/apache/rocketmq/issues/4527#issuecomment-1274540881 > tls.enable=true 所以这个流程是可以走通的么? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq-operator] zongtanghu commented on issue #133: RocketMQ-Operator support the rocketmq-5.0 proxy node.

2022-10-11 Thread GitBox
zongtanghu commented on issue #133: URL: https://github.com/apache/rocketmq-operator/issues/133#issuecomment-1274538872 Yes, of cause, it's yours! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] zhangjidi2016 opened a new pull request, #5283: [ISSUE #5281]Unify the command line input parameters in all pressure testing programs

2022-10-11 Thread GitBox
zhangjidi2016 opened a new pull request, #5283: URL: https://github.com/apache/rocketmq/pull/5283 **Make sure set the target branch to `develop`** ## What is the purpose of the change #5281 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] zhangjidi2016 opened a new pull request, #5282: [ISSUE #5281]Optimize the output of pressure results

2022-10-11 Thread GitBox
zhangjidi2016 opened a new pull request, #5282: URL: https://github.com/apache/rocketmq/pull/5282 **Make sure set the target branch to `develop`** ## What is the purpose of the change #5281

[GitHub] [rocketmq] zhangjidi2016 opened a new issue, #5281: Optimize the rocketmq benchmark

2022-10-11 Thread GitBox
zhangjidi2016 opened a new issue, #5281: URL: https://github.com/apache/rocketmq/issues/5281 **1、The parameters in the pressure test results are not separated, and the display is not very friendly**

[GitHub] [rocketmq] lizhanhui opened a new pull request, #5280: [ISSUE #5276] Use OS pick-up port

2022-10-11 Thread GitBox
lizhanhui opened a new pull request, #5280: URL: https://github.com/apache/rocketmq/pull/5280 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix https://github.com/apache/rocketmq/issues/5276 ## Brief changelog XX ##

[GitHub] [rocketmq] lizhanhui commented on pull request #5279: [ISSUE #5276] Use OS pick-up available port

2022-10-11 Thread GitBox
lizhanhui commented on PR #5279: URL: https://github.com/apache/rocketmq/pull/5279#issuecomment-1274522770 Close due to wrong branch name -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] lizhanhui closed pull request #5279: [ISSUE #5276] Use OS pick-up available port

2022-10-11 Thread GitBox
lizhanhui closed pull request #5279: [ISSUE #5276] Use OS pick-up available port URL: https://github.com/apache/rocketmq/pull/5279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [rocketmq] lizhanhui opened a new pull request, #5279: [ISSUE #5276] Use OS pick-up available port

2022-10-11 Thread GitBox
lizhanhui opened a new pull request, #5279: URL: https://github.com/apache/rocketmq/pull/5279 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix https://github.com/apache/rocketmq/issues/5276 ## Brief changelog XX ##

[GitHub] [rocketmq] lizhanhui closed issue #5274: AutoSwitchRoleIntegrationTest is still flaky

2022-10-11 Thread GitBox
lizhanhui closed issue #5274: AutoSwitchRoleIntegrationTest is still flaky URL: https://github.com/apache/rocketmq/issues/5274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [rocketmq] lizhanhui closed issue #5270: mqshudown will produce "Illegal number" when there is no process to shutdown

2022-10-11 Thread GitBox
lizhanhui closed issue #5270: mqshudown will produce "Illegal number" when there is no process to shutdown URL: https://github.com/apache/rocketmq/issues/5270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [rocketmq] lizhanhui merged pull request #5271: [ISSUE #5270] exit with 1 when there is no process to shutdown

2022-10-11 Thread GitBox
lizhanhui merged PR #5271: URL: https://github.com/apache/rocketmq/pull/5271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui merged pull request #5277: [ISSUE #5274] Fix the issue that AutoSwitchRoleIntegrationTest is flaky

2022-10-11 Thread GitBox
lizhanhui merged PR #5277: URL: https://github.com/apache/rocketmq/pull/5277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui commented on issue #5276: AddWritePermSubCommandTest uses fixed port that may not be available

2022-10-11 Thread GitBox
lizhanhui commented on issue #5276: URL: https://github.com/apache/rocketmq/issues/5276#issuecomment-1274483658 For test cases, best to use OS pick-up available port. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [rocketmq] echooymxq commented on issue #5276: AddWritePermSubCommandTest uses fixed port that may not be available

2022-10-11 Thread GitBox
echooymxq commented on issue #5276: URL: https://github.com/apache/rocketmq/issues/5276#issuecomment-1274481063 @lizhanhui In RocketMQ, There are others tests also use fixed port. Has the community considered using [testcontainer](https://github.com/testcontainers/testcontainers-java) to

[GitHub] [rocketmq] echooymxq commented on issue #5256: tool.sh's function find_java_home sometimes failed

2022-10-11 Thread GitBox
echooymxq commented on issue #5256: URL: https://github.com/apache/rocketmq/issues/5256#issuecomment-1274454258 It can be replaced by `which java`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] mxsm opened a new issue, #5278: Modify MessageStoreConfig#isTransientStorePoolEnable method comment doc

2022-10-11 Thread GitBox
mxsm opened a new issue, #5278: URL: https://github.com/apache/rocketmq/issues/5278 The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid

[GitHub] [rocketmq] RongtongJin opened a new pull request, #5277: [ISSUE #5274] Fix the issue that AutoSwitchRoleIntegrationTest is flaky

2022-10-11 Thread GitBox
RongtongJin opened a new pull request, #5277: URL: https://github.com/apache/rocketmq/pull/5277 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix the issue that AutoSwitchRoleIntegrationTest is flaky Close #5274 ## Brief

[GitHub] [rocketmq] lizhanhui commented on issue #5276: AddWritePermSubCommandTest uses fixed port that may not be available

2022-10-11 Thread GitBox
lizhanhui commented on issue #5276: URL: https://github.com/apache/rocketmq/issues/5276#issuecomment-1274420725 Observed in https://github.com/apache/rocketmq/actions/runs/3224766162/jobs/5278048038 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [rocketmq] lizhanhui opened a new issue, #5276: AddWritePermSubCommandTest uses fixed port that may not be available

2022-10-11 Thread GitBox
lizhanhui opened a new issue, #5276: URL: https://github.com/apache/rocketmq/issues/5276 Tests in error: org.apache.rocketmq.tools.command.namesrv.AddWritePermSubCommandTest.testExecute(org.apache.rocketmq.tools.command.namesrv.AddWritePermSubCommandTest) Run 1:

[GitHub] [rocketmq-flink] zhouxinyu commented on a diff in pull request #46: [#35] Use `LitePullConsumer` model instead of default pull consumer

2022-10-11 Thread GitBox
zhouxinyu commented on code in PR #46: URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r992088138 ## src/main/java/org/apache/rocketmq/flink/legacy/RocketMQSourceFunction.java: ## @@ -404,8 +380,7 @@ private long getMessageQueueOffset(MessageQueue mq) throws

[GitHub] [rocketmq] lizhanhui commented on issue #5250: Whether it is necessary to add a hook to handle the failure of rpc processing?

2022-10-11 Thread GitBox
lizhanhui commented on issue #5250: URL: https://github.com/apache/rocketmq/issues/5250#issuecomment-1274411437 `Boolean remoteTimeout` is not general enough...How about changing it to a `Context` which includes original failure/exception and other potential additional info? -- This is

[GitHub] [rocketmq-flink] zhouxinyu commented on pull request #46: [#35] Use `LitePullConsumer` model instead of default pull consumer

2022-10-11 Thread GitBox
zhouxinyu commented on PR #46: URL: https://github.com/apache/rocketmq-flink/pull/46#issuecomment-1274399313 Thanks, @yiduwangkai for your contributions. I left some comments, but I'm not familiar with rocketmq-flink, so please @SteNicholas help have a look. -- This is an automated

[GitHub] [rocketmq] lizhanhui closed issue #5272: NPE raised when CI runs tests

2022-10-11 Thread GitBox
lizhanhui closed issue #5272: NPE raised when CI runs tests URL: https://github.com/apache/rocketmq/issues/5272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [rocketmq] lizhanhui merged pull request #5273: [ISSUE #5272]Fix NPE in CI

2022-10-11 Thread GitBox
lizhanhui merged PR #5273: URL: https://github.com/apache/rocketmq/pull/5273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-flink] zhouxinyu commented on a diff in pull request #46: [#35] Use `LitePullConsumer` model instead of default pull consumer

2022-10-11 Thread GitBox
zhouxinyu commented on code in PR #46: URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r992074796 ## src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java: ## @@ -173,25 +177,28 @@ public RecordsWithSplitIds> fetch() throws

[GitHub] [rocketmq-flink] zhouxinyu commented on a diff in pull request #46: [#35] Use `LitePullConsumer` model instead of default pull consumer

2022-10-11 Thread GitBox
zhouxinyu commented on code in PR #46: URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r992071000 ## src/main/java/org/apache/rocketmq/flink/source/reader/RocketMQPartitionSplitReader.java: ## @@ -120,9 +119,14 @@ public RocketMQPartitionSplitReader(

[GitHub] [rocketmq-operator] shendongsd commented on issue #133: RocketMQ-Operator support the rocketmq-5.0 proxy node.

2022-10-11 Thread GitBox
shendongsd commented on issue #133: URL: https://github.com/apache/rocketmq-operator/issues/133#issuecomment-1274386004 > **FEATURE REQUEST** > > 1. Please describe the feature you are requesting. >RocketMQ-Operator support the rocketmq-5.0 proxy node to deploy the

[GitHub] [rocketmq] lizhanhui commented on issue #5274: AutoSwitchRoleIntegrationTest is still flaky

2022-10-11 Thread GitBox
lizhanhui commented on issue #5274: URL: https://github.com/apache/rocketmq/issues/5274#issuecomment-1274375811 Reproduced in this pull request https://github.com/apache/rocketmq/pull/5271 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [rocketmq] lizhanhui commented on pull request #5271: [ISSUE #5270] exit with 1 when there is no process to shutdown

2022-10-11 Thread GitBox
lizhanhui commented on PR #5271: URL: https://github.com/apache/rocketmq/pull/5271#issuecomment-1274371508 > @lizhanhui https://github.com/apache/rocketmq/actions/runs/3224766162/jobs/5276261376

[GitHub] [rocketmq-flink] zhouxinyu commented on a diff in pull request #46: [#35] Use `LitePullConsumer` model instead of default pull consumer

2022-10-11 Thread GitBox
zhouxinyu commented on code in PR #46: URL: https://github.com/apache/rocketmq-flink/pull/46#discussion_r992057758 ## src/main/java/org/apache/rocketmq/flink/source/enumerator/RocketMQSourceEnumerator.java: ## @@ -337,16 +339,16 @@ private long

[GitHub] [rocketmq-operator] zongtanghu opened a new issue, #133: RocketMQ-Operator support the rocketmq-5.0 proxy node.

2022-10-11 Thread GitBox
zongtanghu opened a new issue, #133: URL: https://github.com/apache/rocketmq-operator/issues/133 **FEATURE REQUEST** 1. Please describe the feature you are requesting. RocketMQ-Operator support the rocketmq-5.0 proxy node to deploy the rocketmq-5.0 cluster. 2. Provide

[GitHub] [rocketmq-spring] MartinDai opened a new pull request, #492: [ISSUE #488]Support RocketMQ 5.0.0

2022-10-11 Thread GitBox
MartinDai opened a new pull request, #492: URL: https://github.com/apache/rocketmq-spring/pull/492 ## What is the purpose of the change Support RocketMQ 5.0.0 ## Brief changelog Support RocketMQ 5.0.0 ## Verifying this change done Follow this

[GitHub] [rocketmq] zhangjidi2016 commented on pull request #5019: [ISSUE #5018]Some responseCode values are duplicated

2022-10-11 Thread GitBox
zhangjidi2016 commented on PR #5019: URL: https://github.com/apache/rocketmq/pull/5019#issuecomment-1274343071 Please help to review this patch again. @lizhanhui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [rocketmq] echooymxq commented on issue #5250: Whether it is necessary to add a hook to handle the failure of rpc processing?

2022-10-11 Thread GitBox
echooymxq commented on issue #5250: URL: https://github.com/apache/rocketmq/issues/5250#issuecomment-1274342345 Mabye be can add it, sometimes it useful, but the third method arg should be the original exception?樂️ -- This is an automated message from the Apache Git Service. To respond

[GitHub] [rocketmq] homeguess commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
homeguess commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274342034 > > If non-POP patterns . It means is PULL pattern . PULL pattern is one consumer match one queue . One-on-one . I think it can avoid that issue. > > Even though a consumer

[GitHub] [rocketmq-clients] zhouxinyu commented on pull request #242: Packaging binary release

2022-10-11 Thread GitBox
zhouxinyu commented on PR #242: URL: https://github.com/apache/rocketmq-clients/pull/242#issuecomment-1274340140 License checker failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] nowinkeyy commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
nowinkeyy commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274335156 > If non-POP patterns . It means is PULL pattern . PULL pattern is one consumer match one queue . One-on-one . I think it can avoid that issue. Even though a consumer match

[GitHub] [rocketmq-clients] zhouxinyu merged pull request #249: golang: remove redundant configuration

2022-10-11 Thread GitBox
zhouxinyu merged PR #249: URL: https://github.com/apache/rocketmq-clients/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] homeguess commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
homeguess commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274325245 > It should work, could you please do more practice on this feature? > > So far, there is a known issue about the pop orderly: it doesn't support changeInvisiableTime, and

[GitHub] [rocketmq] homeguess commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
homeguess commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274322284 > > Yes .It will lock the queue when you inquire the meesage from queue . But it will release the lock at finally part . So how to ensure Client B is consume later than Client A

[GitHub] [rocketmq] homeguess commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
homeguess commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274319306 > If is non-POP pattern . Pull patten is one consumer comsume one queue . One-on-one . I think it can avoided that issue -- This is an automated message from the

[GitHub] [rocketmq] drpmma opened a new pull request, #5275: Optimize ReceiptHandleProcessor and GrpcChannelManager

2022-10-11 Thread GitBox
drpmma opened a new pull request, #5275: URL: https://github.com/apache/rocketmq/pull/5275 ## What is the purpose of the change Optimize ReceiptHandleProcessor and GrpcChannelManager ## Brief changelog * Add preShutdown for StartAndShutdown * Use channel to manage

[GitHub] [rocketmq] nowinkeyy commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
nowinkeyy commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274289343 > Yes .It will lock the queue when you inquire the meesage from queue . But it will release the lock at finally part . So how to ensure Client B is consume later than Client A

[GitHub] [rocketmq] lizhanhui commented on issue #5274: AutoSwitchRoleIntegrationTest is still flaky

2022-10-11 Thread GitBox
lizhanhui commented on issue #5274: URL: https://github.com/apache/rocketmq/issues/5274#issuecomment-1274285910 @lizhimins Do you have the working bandwidth to investigate this issue? The HA feature merged in 5.0.0 looks pretty buggy. -- This is an automated message from the Apache Git

[GitHub] [rocketmq] lizhanhui opened a new issue, #5274: AutoSwitchRoleIntegrationTest is still flaky

2022-10-11 Thread GitBox
lizhanhui opened a new issue, #5274: URL: https://github.com/apache/rocketmq/issues/5274 testChangeMaster(org.apache.rocketmq.test.autoswitchrole.AutoSwitchRoleIntegrationTest) Time elapsed: 29.741 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at

[GitHub] [rocketmq] lizhanhui opened a new pull request, #5273: [ISSUE #5272]Fix NPE in CI

2022-10-11 Thread GitBox
lizhanhui opened a new pull request, #5273: URL: https://github.com/apache/rocketmq/pull/5273 **Make sure set the target branch to `develop`** ## What is the purpose of the change Fix issue https://github.com/apache/rocketmq/issues/5272 ## Brief changelog XX

[GitHub] [rocketmq] lizhanhui opened a new issue, #5272: NPE raised when CI runs tests

2022-10-11 Thread GitBox
lizhanhui opened a new issue, #5272: URL: https://github.com/apache/rocketmq/issues/5272 java.lang.NullPointerException: null at org.apache.rocketmq.test.lmq.benchmark.BenchLmqStore.lambda$doSend$1(BenchLmqStore.java:176) at

[GitHub] [rocketmq] xdkxlk commented on pull request #5271: [ISSUE #5270] exit with 1 when there is no process to shutdown

2022-10-11 Thread GitBox
xdkxlk commented on PR #5271: URL: https://github.com/apache/rocketmq/pull/5271#issuecomment-1274245259 @lizhanhui https://github.com/apache/rocketmq/actions/runs/3224766162/jobs/5276261376

[GitHub] [rocketmq-client-go] 0daypwn commented on pull request #934: [ISSUE #933] fix retry topic and namespace topic block

2022-10-11 Thread GitBox
0daypwn commented on PR #934: URL: https://github.com/apache/rocketmq-client-go/pull/934#issuecomment-1274242283 map is not thread safe, so should add RWMutex. The design is too complicated. Maybe there's a better way? -- This is an automated message from the Apache Git Service. To

[GitHub] [rocketmq] homeguess commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
homeguess commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274236837 > @homeguess I know what you mean. The following diagram seems to mean that the queue is locked until the ack returns or times out. (I don't know about the source code part) >

[GitHub] [rocketmq-client-cpp] yuntong613 opened a new issue, #445: vs2019 compile error

2022-10-11 Thread GitBox
yuntong613 opened a new issue, #445: URL: https://github.com/apache/rocketmq-client-cpp/issues/445 Environment: Windows 10,vs2019,vcpkg and rocketmq master branch. Error Info : There is no "setenv" method in vs2019,but _putenv or _putenv_s -- This is an automated message from the

[GitHub] [rocketmq] zhouxinyu commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
zhouxinyu commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274227612 It should work, could you please do more practice on this feature? So far, there is a known issue about the pop orderly: it doesn't support changeInvisiableTime, and we

[GitHub] [rocketmq] nowinkeyy commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
nowinkeyy commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274211171 @homeguess I know what you mean. The following diagram seems to mean that the queue is locked until the ack returns or times out. (I don't know about the source code part)

[GitHub] [rocketmq] ni-ze commented on issue #4154: maybe there is a Thread Safe problem when send a message in the 'MQFaultStrategy#selectOneMessageQueue' code

2022-10-11 Thread GitBox
ni-ze commented on issue #4154: URL: https://github.com/apache/rocketmq/issues/4154#issuecomment-1274193768 seems like does not matter. sunhangda ***@***.***>于2022年4月13日 周三11:20写道: > I do not think so. > > tpInfo.getSendWhichQueue().incrementAndGet() > > the index

[GitHub] [rocketmq] lizhanhui merged pull request #5264: fix(sec): upgrade org.yaml:snakeyaml to 1.32

2022-10-11 Thread GitBox
lizhanhui merged PR #5264: URL: https://github.com/apache/rocketmq/pull/5264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui merged pull request #5269: [ISSUE #5267] fix command line arguments parse error in mqbroker

2022-10-11 Thread GitBox
lizhanhui merged PR #5269: URL: https://github.com/apache/rocketmq/pull/5269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] lizhanhui closed issue #5267: Start Broker failed to load the configuration file broker.conf

2022-10-11 Thread GitBox
lizhanhui closed issue #5267: Start Broker failed to load the configuration file broker.conf URL: https://github.com/apache/rocketmq/issues/5267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [rocketmq] xdkxlk opened a new pull request, #5271: [ISSUE #5270] exit with 1 when there is no process to shutdown

2022-10-11 Thread GitBox
xdkxlk opened a new pull request, #5271: URL: https://github.com/apache/rocketmq/pull/5271 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5270 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq] xdkxlk opened a new issue, #5270: mqshudown will produce "Illegal number" when there is no process to shutdown

2022-10-11 Thread GitBox
xdkxlk opened a new issue, #5270: URL: https://github.com/apache/rocketmq/issues/5270 Environment: Ubuntu 20.04 ![image](https://user-images.githubusercontent.com/10397306/195016218-33ed00c9-7423-4f31-9dba-906cf36c6fe3.png)

[GitHub] [rocketmq] macdreaming commented on issue #5267: Start Broker failed to load the configuration file broker.conf

2022-10-11 Thread GitBox
macdreaming commented on issue #5267: URL: https://github.com/apache/rocketmq/issues/5267#issuecomment-1274153563 > I have submitted a PR to fix this. Could you please review my PR? Thank you so much. I have modified the mqbroker execution script to: while [$# - gt 0]; now the

[GitHub] [rocketmq] tianshimoyi closed issue #5261: Rocketmq version 5.0.0 When I create a topic, which parameter of mqadmin updateTopic specifies the message type?

2022-10-11 Thread GitBox
tianshimoyi closed issue #5261: Rocketmq version 5.0.0 When I create a topic, which parameter of mqadmin updateTopic specifies the message type? URL: https://github.com/apache/rocketmq/issues/5261 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [rocketmq-connect] odbozhou merged pull request #325: add doris sink connector

2022-10-11 Thread GitBox
odbozhou merged PR #325: URL: https://github.com/apache/rocketmq-connect/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq] xdkxlk commented on issue #5261: Rocketmq version 5.0.0 When I create a topic, which parameter of mqadmin updateTopic specifies the message type?

2022-10-11 Thread GitBox
xdkxlk commented on issue #5261: URL: https://github.com/apache/rocketmq/issues/5261#issuecomment-1274146910 You can use `-a ` to add the `message.type` attribute when updateTopic For example: `mqadmin updatetopic -n {NameSrvAddr} -t {YourTopic} -c {YourCluster} -a

[GitHub] [rocketmq] homeguess commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-11 Thread GitBox
homeguess commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274146785 > Could this be the place? (I don't know much about it) > > ![image](https://user-images.githubusercontent.com/72536832/195000540-c0226cb9-d89a-4ae7-9656-3d39a840b0fd.png)

[GitHub] [rocketmq] xdkxlk commented on issue #5267: Start Broker failed to load the configuration file broker.conf

2022-10-11 Thread GitBox
xdkxlk commented on issue #5267: URL: https://github.com/apache/rocketmq/issues/5267#issuecomment-1274139996 I have submitted a PR to fix this. Could you please review my PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [rocketmq-client-go] jackedelic opened a new issue, #937: Offset - ConsumeFromWhere does not take effect

2022-10-11 Thread GitBox
jackedelic opened a new issue, #937: URL: https://github.com/apache/rocketmq-client-go/issues/937 **BUG REPORT** 1. Please describe the issue you observed: We initialize a consumer by specifying ConsumeFromWhere to specify where in the partition to consumer the message from.

[GitHub] [rocketmq] xdkxlk opened a new pull request, #5269: [ISSUE #5267] fix command line arguments parse error in mqbroker

2022-10-11 Thread GitBox
xdkxlk opened a new pull request, #5269: URL: https://github.com/apache/rocketmq/pull/5269 **Make sure set the target branch to `develop`** ## What is the purpose of the change close #5267 ## Brief changelog XX ## Verifying this change

[GitHub] [rocketmq-site] zhiliatom commented on issue #294: Translation for "订阅关系一致" Section in the v4.x & 5.0 Document (CN -> EN)

2022-10-10 Thread GitBox
zhiliatom commented on issue #294: URL: https://github.com/apache/rocketmq-site/issues/294#issuecomment-1274094432 I am willing to complete this task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [rocketmq] nowinkeyy commented on issue #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-10 Thread GitBox
nowinkeyy commented on issue #5268: URL: https://github.com/apache/rocketmq/issues/5268#issuecomment-1274090192 Could this be the place? (I don't know much about it) ![image](https://user-images.githubusercontent.com/72536832/195000540-c0226cb9-d89a-4ae7-9656-3d39a840b0fd.png)

[GitHub] [rocketmq] homeguess opened a new issue, #5268: Pop request mode . Cosume message orderly is work or not ?

2022-10-10 Thread GitBox
homeguess opened a new issue, #5268: URL: https://github.com/apache/rocketmq/issues/5268 I read the source code about ConsumeMessagePopOrderlyService.class. There's not any logic about cosume orderly . Does pop message orderly not work ? -- This is an automated message from the Apache

[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #5264: fix(sec): upgrade org.yaml:snakeyaml to 1.32

2022-10-10 Thread GitBox
aaron-ai commented on code in PR #5264: URL: https://github.com/apache/rocketmq/pull/5264#discussion_r991782156 ## pom.xml: ## @@ -217,8 +215,8 @@ - - +

[GitHub] [rocketmq] lizhanhui closed issue #5265: Nested logic may cause more if check

2022-10-10 Thread GitBox
lizhanhui closed issue #5265: Nested logic may cause more if check URL: https://github.com/apache/rocketmq/issues/5265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [rocketmq] lizhanhui merged pull request #5266: [ISSUE #5265] Adjust nested logic to reduce nums of check queryMsg

2022-10-10 Thread GitBox
lizhanhui merged PR #5266: URL: https://github.com/apache/rocketmq/pull/5266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [rocketmq-client-go] 0daypwn opened a new pull request, #936: [ISSUE #935]fix consumer option validate

2022-10-10 Thread GitBox
0daypwn opened a new pull request, #936: URL: https://github.com/apache/rocketmq-client-go/pull/936 ## What is the purpose of the change close #935 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5260: [ISSUE 3799] add compaction delete policy

2022-10-10 Thread GitBox
lizhanhui commented on code in PR #5260: URL: https://github.com/apache/rocketmq/pull/5260#discussion_r991779595 ## .gitignore: ## @@ -13,6 +13,7 @@ devenv .DS_Store localbin nohup.out +docker/ Review Comment: If this ignore entry applies to your local development only,

[GitHub] [rocketmq] lizhanhui commented on a diff in pull request #5260: [ISSUE 3799] add compaction delete policy

2022-10-10 Thread GitBox
lizhanhui commented on code in PR #5260: URL: https://github.com/apache/rocketmq/pull/5260#discussion_r991777670 ## common/src/main/java/org/apache/rocketmq/common/attribute/DeletePolicy.java: ## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

<    3   4   5   6   7   8   9   10   11   12   >