[GitHub] vongosling commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero
vongosling commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#issuecomment-341332092 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero
coveralls commented on issue #189: [ROCKETMQ-270] Move flush position forward to first MappedFile whose start offset is non-zero URL: https://github.com/apache/rocketmq/pull/189#issuecomment-341332822 [](https://coveralls.io/builds/14001009) Coverage decreased (-0.1%) to 39.118% when pulling **f18dc03809a36bf14f6d911a3813cf6d4f606ae2 on zhouxinyu:ROCKETMQ-270** into **1a88fe09757969a0c8e53b8ddb793ff449aeae25 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes
zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341335627 Hi, sorry for late. I have last two questions: 1. What's the default value `MetaspaceSize` and `MaxMetaspaceSize` in JDK8, and are these new value reasonable? 2. Will these two parameters influence the low version JDK? like JDK7? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vongosling commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes
vongosling commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341334478 RocektMQ's master branch is not master, could you switch merge branch to develop :-) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] johnsonyang commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes
johnsonyang commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341602398 Hi, zhou thanks you feedback quickly! 1. From the jvm arguments view, the `MetaspaceSize` and `MaxMetaspaceSize` in JDK8 used to replace the `-XX:PermSize` and `-XX:MaxPermSize`, in JDK8, Metaspace?JEP 122?used to replace the PermGen space to improve GC performance. The Metaspace used the direct memory, as I know, the default value is no limit if NOT set a value, it will use all memory. 2. The `MetaspaceSize` and `MaxMetaspaceSize` be introduced from JDK8, I also check the rocketMQ [releases note](https://rocketmq.apache.org/dowloading/releases/), the rocket recommend used the JDK8 on the Broker and NameServer, below info for your check quickly! Version Client Broker NameServer 4.0.0-incubating >=1.7 >=1.8 >=1.8 4.1.0-incubating >=1.6 >=1.8 >=1.8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhouxinyu commented on issue #190: add new consumer implement
zhouxinyu commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341608762 Did you mean `CONSUME_FROM_LAST_OFFSET` don't take effect for the broadcast model? BTW, could you please report a JIRA issue before submitting a pull request? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes
zhouxinyu commented on issue #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes URL: https://github.com/apache/rocketmq/pull/186#issuecomment-341608562 Thanks, I will merge this PR soon, and please submit PR to `develop` branch next time~ ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lyy4j commented on issue #190: add new consumer implement
lyy4j commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341610628 @zhouxinyu ,sorry I have modify my commented again . This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lyy4j commented on issue #190: add new consumer implement
lyy4j commented on issue #190: add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341611982 I have report JIRA ISSUE(309), would you have check ? @zhouxinyu This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhouxinyu closed pull request #186: [ROCKETMQ-307] Polish the JVM parameters in start scriptes
zhouxinyu closed pull request #186: [ROCKETMQ-307] Polish the JVM parameters in
start scriptes
URL: https://github.com/apache/rocketmq/pull/186
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/distribution/bin/runbroker.cmd b/distribution/bin/runbroker.cmd
index 033d8225..eab7e30f 100644
--- a/distribution/bin/runbroker.cmd
+++ b/distribution/bin/runbroker.cmd
@@ -29,7 +29,7 @@ rem
rem JVM Configuration
rem
===
set "JAVA_OPT=%JAVA_OPT% -server -Xms2g -Xmx2g -Xmn1g"
-set "JAVA_OPT=%JAVA_OPT% -XX:+UseG1GC -XX:G1HeapRegionSize=16m
-XX:G1ReservePercent=25 -XX:InitiatingHeapOccupancyPercent=30
-XX:SoftRefLRUPolicyMSPerMB=0 -XX:SurvivorRatio=8 -XX:+DisableExplicitGC"
+set "JAVA_OPT=%JAVA_OPT% -XX:+UseG1GC -XX:G1HeapRegionSize=16m
-XX:G1ReservePercent=25 -XX:InitiatingHeapOccupancyPercent=30
-XX:SoftRefLRUPolicyMSPerMB=0 -XX:SurvivorRatio=8"
set "JAVA_OPT=%JAVA_OPT% -verbose:gc -Xloggc:%USERPROFILE%\mq_gc.log
-XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintGCApplicationStoppedTime
-XX:+PrintAdaptiveSizePolicy"
set "JAVA_OPT=%JAVA_OPT% -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5
-XX:GCLogFileSize=30m"
set "JAVA_OPT=%JAVA_OPT% -XX:-OmitStackTraceInFastThrow"
diff --git a/distribution/bin/runbroker.sh b/distribution/bin/runbroker.sh
index b0c490e9..f9c7fcb8 100644
--- a/distribution/bin/runbroker.sh
+++ b/distribution/bin/runbroker.sh
@@ -37,7 +37,7 @@ export CLASSPATH=.:${BASE_DIR}/conf:${CLASSPATH}
# JVM Configuration
#===
JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
-JAVA_OPT="${JAVA_OPT} -XX:+UseG1GC -XX:G1HeapRegionSize=16m
-XX:G1ReservePercent=25 -XX:InitiatingHeapOccupancyPercent=30
-XX:SoftRefLRUPolicyMSPerMB=0 -XX:SurvivorRatio=8 -XX:+DisableExplicitGC"
+JAVA_OPT="${JAVA_OPT} -XX:+UseG1GC -XX:G1HeapRegionSize=16m
-XX:G1ReservePercent=25 -XX:InitiatingHeapOccupancyPercent=30
-XX:SoftRefLRUPolicyMSPerMB=0 -XX:SurvivorRatio=8"
JAVA_OPT="${JAVA_OPT} -verbose:gc -Xloggc:/dev/shm/mq_gc_%p.log
-XX:+PrintGCDetails -XX:+PrintGCDateStamps -XX:+PrintGCApplicationStoppedTime
-XX:+PrintAdaptiveSizePolicy"
JAVA_OPT="${JAVA_OPT} -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=5
-XX:GCLogFileSize=30m"
JAVA_OPT="${JAVA_OPT} -XX:-OmitStackTraceInFastThrow"
diff --git a/distribution/bin/runserver.cmd b/distribution/bin/runserver.cmd
index e157d55f..48e32bf2 100644
--- a/distribution/bin/runserver.cmd
+++ b/distribution/bin/runserver.cmd
@@ -26,8 +26,8 @@ for %%d in (%BASE_DIR%) do set BASE_DIR=%%~dpd
set CLASSPATH=.;%BASE_DIR%conf;%CLASSPATH%
-set "JAVA_OPT=%JAVA_OPT% -server -Xms2g -Xmx2g -Xmn1g -XX:PermSize=128m
-XX:MaxPermSize=320m"
-set "JAVA_OPT=%JAVA_OPT% -XX:+UseConcMarkSweepGC
-XX:+UseCMSCompactAtFullCollection -XX:CMSInitiatingOccupancyFraction=70
-XX:+CMSParallelRemarkEnabled -XX:SoftRefLRUPolicyMSPerMB=0
-XX:+CMSClassUnloadingEnabled -XX:SurvivorRatio=8 -XX:+DisableExplicitGC
-XX:-UseParNewGC"
+set "JAVA_OPT=%JAVA_OPT% -server -Xms2g -Xmx2g -Xmn1g -XX:MetaspaceSize=128m
-XX:MaxMetaspaceSize=320m"
+set "JAVA_OPT=%JAVA_OPT% -XX:+UseConcMarkSweepGC
-XX:+UseCMSCompactAtFullCollection -XX:CMSInitiatingOccupancyFraction=70
-XX:+CMSParallelRemarkEnabled -XX:SoftRefLRUPolicyMSPerMB=0
-XX:+CMSClassUnloadingEnabled -XX:SurvivorRatio=8 -XX:-UseParNewGC"
set "JAVA_OPT=%JAVA_OPT% -verbose:gc -Xloggc:"%USERPROFILE%\rmq_srv_gc.log"
-XX:+PrintGCDetails"
set "JAVA_OPT=%JAVA_OPT% -XX:-OmitStackTraceInFastThrow"
set "JAVA_OPT=%JAVA_OPT% -XX:-UseLargePages"
diff --git a/distribution/bin/runserver.sh b/distribution/bin/runserver.sh
index 7c41b0c2..7bbfb73a 100644
--- a/distribution/bin/runserver.sh
+++ b/distribution/bin/runserver.sh
@@ -36,8 +36,8 @@ export CLASSPATH=.:${BASE_DIR}/conf:${CLASSPATH}
#===
# JVM Configuration
#===
-JAVA_OPT="${JAVA_OPT} -server -Xms4g -Xmx4g -Xmn2g -XX:PermSize=128m
-XX:MaxPermSize=320m"
-JAVA_OPT="${JAVA_OPT} -XX:+UseConcMarkSweepGC
-XX:+UseCMSCompactAtFullCollection -XX:CMSInitiatingOccupancyFraction=70
-XX:+CMSParallelRemarkEnabled -XX:SoftRefLRUPolicyMSPerMB=0
-XX:+CMSClassUnloadingEnabled -XX:SurvivorRatio=8 -XX:+DisableExplicitGC
-XX:-UseParNewGC"
+JAVA_OPT="${JAVA_OPT} -server -Xms4g -Xmx4g -Xmn2g -XX:MetaspaceSize=128m
-XX:MaxMetaspaceSize=320m"
+JAVA_OPT="${JAVA_OPT} -XX:+UseConcMarkSweepGC
-XX:+UseCMSCompactAtFullCollection
[GitHub] zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement
zhouxinyu commented on issue #190: [ROCKETMQ-309] Add new consumer implement URL: https://github.com/apache/rocketmq/pull/190#issuecomment-341612261 Thanks, let's discuss in ROCKETMQ-309 first~ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lyy4j opened a new pull request #190: Tag 20171102
lyy4j opened a new pull request #190: Tag 20171102 URL: https://github.com/apache/rocketmq/pull/190 When user use consume client in Broadcast model ,we can pull message only from fist offset. However, we only want to pull message from last offset sometimes, and we can use MQBroadcastFromLastConsumer in this case. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
