[GitHub] ShannonDing merged pull request #869: [RIP-10]fix-bug: ScheduleMessageServiceTest
ShannonDing merged pull request #869: [RIP-10]fix-bug: ScheduleMessageServiceTest URL: https://github.com/apache/rocketmq/pull/869 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hdchen commented on issue #869: [RIP-10]fix-bug: ScheduleMessageServiceTest
hdchen commented on issue #869: [RIP-10]fix-bug: ScheduleMessageServiceTest URL: https://github.com/apache/rocketmq/pull/869#issuecomment-467321042 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #909: [RIP-10] Add test case for TopicConfigSerializeWrapper
coveralls commented on issue #909: [RIP-10] Add test case for TopicConfigSerializeWrapper URL: https://github.com/apache/rocketmq/pull/909#issuecomment-467319283 [](https://coveralls.io/builds/21849577) Coverage increased (+0.1%) to 47.904% when pulling **3a5c369176bb68f2e327971836e18f49ef697f62 on shanguichaofeng:develop** into **6eff504877e2924f76cd0b48f8daf7bfff4621c5 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shanguichaofeng opened a new pull request #909: [RIP-10] Add test case for TopicConfigSerializeWrapper
shanguichaofeng opened a new pull request #909: [RIP-10] Add test case for TopicConfigSerializeWrapper URL: https://github.com/apache/rocketmq/pull/909 ## What is the purpose of the change add test case for org.apache.rocketmq.common.protocol.body.TopicConfigSerializeWrapper.java ## Brief changelog add test case for org.apache.rocketmq.common.protocol.body.TopicConfigSerializeWrapper to test fromJson ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #906: [RIP-10] Add test case for ConsumeMessageOrderlyService
coveralls commented on issue #906: [RIP-10] Add test case for ConsumeMessageOrderlyService URL: https://github.com/apache/rocketmq/pull/906#issuecomment-467311675 [](https://coveralls.io/builds/21848898) Coverage increased (+0.3%) to 48.052% when pulling **4527b84ff3fad2eaec7ce5d671a370660e48286d on tandanzZ:TD-develop** into **6eff504877e2924f76cd0b48f8daf7bfff4621c5 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #907: Add TopicConfigSerializeWrapperTest
coveralls commented on issue #907: Add TopicConfigSerializeWrapperTest URL: https://github.com/apache/rocketmq/pull/907#issuecomment-467311500 [](https://coveralls.io/builds/21849009) Coverage increased (+0.1%) to 44.94% when pulling **af89a3ee8d956c4f9d3cde101a5e6c67bb111abd on shanguichaofeng:TCSWrapperTest** into **8f37ff27db02177a1e336c8d5ee1a089a4a23939 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #908: [RIP-9] Add English document for Design_Trancation.md
coveralls commented on issue #908: [RIP-9] Add English document for Design_Trancation.md URL: https://github.com/apache/rocketmq/pull/908#issuecomment-467311301 [](https://coveralls.io/builds/21849013) Coverage decreased (-0.006%) to 47.784% when pulling **e89b2ed8283c0d85e19f4946b6c5fbe750240799 on zx0825:develop** into **6eff504877e2924f76cd0b48f8daf7bfff4621c5 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DengTin commented on issue #756: Is there a schedule of OpenMessaging golang SDK?
DengTin commented on issue #756: Is there a schedule of OpenMessaging golang SDK? URL: https://github.com/apache/rocketmq/issues/756#issuecomment-467305635 @duhenglucky Thanks for the kindly reply, I would love to participate in it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tandanzZ closed pull request #905: [RIP-10] Add test case for ConsumeMessageOrderlyService
tandanzZ closed pull request #905: [RIP-10] Add test case for ConsumeMessageOrderlyService URL: https://github.com/apache/rocketmq/pull/905 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tandanzZ opened a new pull request #905: [RIP-10] Add test case for ConsumeMessageOrderlyService
tandanzZ opened a new pull request #905: [RIP-10] Add test case for ConsumeMessageOrderlyService URL: https://github.com/apache/rocketmq/pull/905 ## What is the purpose of the change Add test case for ConsumeMessageOrderlyService ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pigpdong opened a new pull request #904: [rip-10] add test case for PrintMessageByQueueCommand and bug fix issure 903
pigpdong opened a new pull request #904: [rip-10] add test case for PrintMessageByQueueCommand and bug fix issure 903 URL: https://github.com/apache/rocketmq/pull/904 bug fix https://github.com/apache/rocketmq/issues/903 and add test case for PrintMessageByQueueCommand This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pigpdong opened a new issue #903: PrintMessageByQueueCommand may not print the right msgs
pigpdong opened a new issue #903: PrintMessageByQueueCommand may not print the right msgs URL: https://github.com/apache/rocketmq/issues/903 **BUG REPORT** 1. Please describe the issue you observed: * What did you do (The steps to reproduce)? PrintMessageByQueueCommand with the option -d -e * What did you expect to see? print the right msglist * What did you see instead? the -e may get a max offset,but consumer.pull(mq, subExpression, offset, 32); this code may return the msg which bigger than the maxoffset and the option -d -d describe as a string like End timestamp[currentTimeMillis|-MM-dd#HH:mm:ss:SSS] but acturally it need a long timestamp = Long.parseLong(value); 1. Please tell us about your environment: None. 2. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): None This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bears111 opened a new pull request #902: 修改2.1 为1
bears111 opened a new pull request #902: 修改2.1 为1 URL: https://github.com/apache/rocketmq/pull/902 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #33: remote codec
ShannonDing merged pull request #33: remote codec URL: https://github.com/apache/rocketmq-client-go/pull/33 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #901: [RIP-9] Add English document to Design_Query
coveralls commented on issue #901: [RIP-9] Add English document to Design_Query URL: https://github.com/apache/rocketmq/pull/901#issuecomment-467281889 [](https://coveralls.io/builds/21846869) Coverage decreased (-0.04%) to 47.755% when pulling **0f03cc2e2b525ddcf47227745642162143c9d459 on olderwei:develop** into **6eff504877e2924f76cd0b48f8daf7bfff4621c5 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] olderwei opened a new pull request #901: [RIP-9] Add English document to Design_Query
olderwei opened a new pull request #901: [RIP-9] Add English document to Design_Query URL: https://github.com/apache/rocketmq/pull/901 ## What is the purpose of the change Add English document to Design_Query ## Brief changelog Add English document to Design_Query ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #900: feat test "add test case for ResetOffsetBodyForC"
coveralls commented on issue #900: feat test "add test case for ResetOffsetBodyForC" URL: https://github.com/apache/rocketmq/pull/900#issuecomment-467274593 [](https://coveralls.io/builds/21846421) Coverage increased (+0.08%) to 47.872% when pulling **e91a19b6d048819ce282cf07680cd0945c769d96 on bianlz:feature_test_ResetOffsetBodyForC** into **6eff504877e2924f76cd0b48f8daf7bfff4621c5 on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wenfengwang commented on issue #33: remote codec
wenfengwang commented on issue #33: remote codec URL: https://github.com/apache/rocketmq-client-go/pull/33#issuecomment-467274339 Good job! LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wenfengwang removed a comment on issue #33: remote codec
wenfengwang removed a comment on issue #33: remote codec URL: https://github.com/apache/rocketmq-client-go/pull/33#issuecomment-467272652 Good job! LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wenfengwang commented on issue #33: remote codec
wenfengwang commented on issue #33: remote codec URL: https://github.com/apache/rocketmq-client-go/pull/33#issuecomment-467272652 Good job! LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] bianlz opened a new pull request #900: feat test "add test case for ResetOffsetBodyForC"
bianlz opened a new pull request #900: feat test "add test case for ResetOffsetBodyForC" URL: https://github.com/apache/rocketmq/pull/900 feat test "add test case for ResetOffsetBodyForC" ## What is the purpose of the change add test case for "org.apache.rocketmq.common.protocol.body.ResetOffsetBodyForC"。 ## Brief changelog add test case for ResetOffsetBodyForC。 ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #893: [RIP-9]Change the project number to a solid black dot
ShannonDing merged pull request #893: [RIP-9]Change the project number to a solid black dot URL: https://github.com/apache/rocketmq/pull/893 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #891: [RIP-9] Modify the wrong architecture diagram.
ShannonDing merged pull request #891: [RIP-9] Modify the wrong architecture diagram. URL: https://github.com/apache/rocketmq/pull/891 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #890: [RIP-9](best practice) within deleted title
ShannonDing merged pull request #890: [RIP-9](best practice) within deleted title URL: https://github.com/apache/rocketmq/pull/890 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #867: [RIP-9] enhance description about the state "SLAVE_NOT_AVAILABLE" in the chinese version of "best_practice.md"
ShannonDing merged pull request #867: [RIP-9] enhance description about the state "SLAVE_NOT_AVAILABLE" in the chinese version of "best_practice.md" URL: https://github.com/apache/rocketmq/pull/867 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ceusan opened a new pull request #899: Add test cases for SubscriptionGroupWrapper
ceusan opened a new pull request #899: Add test cases for SubscriptionGroupWrapper URL: https://github.com/apache/rocketmq/pull/899 ## What is the purpose of the change Add test cases for SubscriptionGroupWrapper ## Brief changelog Add test cases for SubscriptionGroupWrapper ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ro9er opened a new pull request #898: [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody
ro9er opened a new pull request #898: [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody URL: https://github.com/apache/rocketmq/pull/898 ## What is the purpose of the change Add test case for org.apache.rocketmq.common.protocol.body.QueryCorrectionOffsetBody.java and org.apache.rocketmq.common.protocol.body.ResetOffsetBody.java ## Brief changelog Add test case for QueryCorrectionOffsetBody & ResetOffsetBody to test the correction of the serialization and deserialization. ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] huyanfu opened a new pull request #897: [RIP-9] Add the introduction of the Operations_Consumer in RocketMQ
huyanfu opened a new pull request #897: [RIP-9] Add the introduction of the Operations_Consumer in RocketMQ URL: https://github.com/apache/rocketmq/pull/897 ## What is the purpose of the change Add description section for the Operations_Consumer to RocketMQ Develop Guide: ## Brief changelog * Add description section for Operations_Consumer to English RocketMQ Develop Guide ## Verifying this change Browse the section 1 in the best_practice.md Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ro9er commented on issue #855: [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody
ro9er commented on issue #855: [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody URL: https://github.com/apache/rocketmq/pull/855#issuecomment-467251618 I will open another pr for develop branch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ro9er closed pull request #855: [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody
ro9er closed pull request #855: [RIP-10] Add test case for QueryCorrectionOffsetBody & ResetOffsetBody URL: https://github.com/apache/rocketmq/pull/855 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ly641921791 opened a new pull request #896: [RIP-9] Modify Chinese punctuation to English
ly641921791 opened a new pull request #896: [RIP-9] Modify Chinese punctuation to English URL: https://github.com/apache/rocketmq/pull/896 ## What is the purpose of the change Modify Chinese punctuation to English ## Brief changelog Modify Chinese punctuation to English ## Verifying this change Modify Chinese punctuation to English Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] powerfulsnail commented on issue #96: broker中某个队列不消费，什么情况会触发？
powerfulsnail commented on issue #96: broker中某个队列不消费，什么情况会触发？ URL: https://github.com/apache/rocketmq-client-cpp/issues/96#issuecomment-467045301 用的是rc1，这个问题应该与版本没关系，我想知道这个问题是什么原因触发的。 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ly641921791 closed pull request #892: [RIP-9] Change the Chinese punctuation in the Configuration_client.md document to English punctuation
ly641921791 closed pull request #892: [RIP-9] Change the Chinese punctuation in the Configuration_client.md document to English punctuation URL: https://github.com/apache/rocketmq/pull/892 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] javaday2014 opened a new pull request #895: [RIP-10] Add test cases for OffsetMovedEvent
javaday2014 opened a new pull request #895: [RIP-10] Add test cases for OffsetMovedEvent URL: https://github.com/apache/rocketmq/pull/895 ## What is the purpose of the change [RIP-10] Add test cases for OffsetMovedEvent ## Brief changelog [RIP-10] Add test cases for OffsetMovedEvent ## Verifying this change ConsistentHashRouterTest Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. * [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. * [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. * [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. * [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). * [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. * [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanc619 opened a new pull request #894: Develop
hanc619 opened a new pull request #894: Develop URL: https://github.com/apache/rocketmq/pull/894 ## What is the purpose of the change add test cases for ConsumerOffsetSerializeWrapper ## Brief changelog add test cases for ConsumerOffsetSerializeWrapper ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #886: [RIP-9] update incorrect symbol
ShannonDing merged pull request #886: [RIP-9] update incorrect symbol URL: https://github.com/apache/rocketmq/pull/886 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ShannonDing merged pull request #887: [RIP-9] Delete the number on the title
ShannonDing merged pull request #887: [RIP-9] Delete the number on the title URL: https://github.com/apache/rocketmq/pull/887 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ifplusor commented on issue #96: broker中某个队列不消费，什么情况会触发？
ifplusor commented on issue #96: broker中某个队列不消费，什么情况会触发？ URL: https://github.com/apache/rocketmq-client-cpp/issues/96#issuecomment-467022777 @powerfulsnail we have two versions, 1.2.1 and 1.2.1-rc1. notice tag, not title in release. 1.2.1 have some bugs, we fixed them in rc1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] powerfulsnail commented on issue #96: broker中某个队列不消费，什么情况会触发？
powerfulsnail commented on issue #96: broker中某个队列不消费，什么情况会触发？ URL: https://github.com/apache/rocketmq-client-cpp/issues/96#issuecomment-467017112 最新的rocketmq-cpp1.2.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ifplusor commented on issue #96: broker中某个队列不消费，什么情况会触发？
ifplusor commented on issue #96: broker中某个队列不消费，什么情况会触发？ URL: https://github.com/apache/rocketmq-client-cpp/issues/96#issuecomment-467016407 @powerfulsnail what's version you use? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #893: [RIP-9]Change the project number to a solid black dot
coveralls commented on issue #893: [RIP-9]Change the project number to a solid black dot URL: https://github.com/apache/rocketmq/pull/893#issuecomment-466998667 [](https://coveralls.io/builds/21829400) Coverage decreased (-0.03%) to 47.807% when pulling **560e228b4aaafc9121a999c646c6cbe199d1 on 888tyhj:develop** into **90e0c4b3e625ae2d98448155b91bea359c54af7d on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaufung opened a new pull request #33: remote codec
gaufung opened a new pull request #33: remote codec URL: https://github.com/apache/rocketmq-client-go/pull/33 ## What is the purpose of the change remote's codec and unit test and benchmark test ## Brief changelog finish remote codec encode and decode feather ## Verifying this change Yes Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 888tyhj opened a new pull request #893: [RIP-9]Change the project number to a solid black dot
888tyhj opened a new pull request #893: [RIP-9]Change the project number to a solid black dot URL: https://github.com/apache/rocketmq/pull/893 ## What is the purpose of the change hange the project number to a solid black dot ## Brief changelog hange the project number to a solid black dot ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Failed: apache/rocketmq#2100 (develop - ac62ce9)
Build Update for apache/rocketmq - Build: #2100 Status: Failed Duration: 5 mins and 13 secs Commit: ac62ce9 (develop) Author: 东陆之滇 Message: [RIP-9]Add the client configuration section of the RocketMQ documentation best practices. (#799) [RIP-9]Add the client configuration section of the RocketMQ documentation best practices. View the changeset: https://github.com/apache/rocketmq/compare/1dd9f1697cd5...ac62ce91597a View the full build log and details: https://travis-ci.org/apache/rocketmq/builds/498001596?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/rocketmq repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=11128502_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[GitHub] githublaohu commented on issue #888: [RIP-20] Add test cases for ConsumeMessageConcurrentlyService consume success status
githublaohu commented on issue #888: [RIP-20] Add test cases for ConsumeMessageConcurrentlyService consume success status URL: https://github.com/apache/rocketmq/pull/888#issuecomment-466978699 Deal with CI failure first This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ly641921791 opened a new pull request #892: [RIP-9] Change the Chinese punctuation in the Configuration_client.md document to English punctuation
ly641921791 opened a new pull request #892: [RIP-9] Change the Chinese punctuation in the Configuration_client.md document to English punctuation URL: https://github.com/apache/rocketmq/pull/892 Change the Chinese punctuation in the Configuration_client.md document to English punctuation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #890: (best practice) within deleted title
coveralls commented on issue #890: (best practice) within deleted title URL: https://github.com/apache/rocketmq/pull/890#issuecomment-466974160 [](https://coveralls.io/builds/21828082) Coverage decreased (-0.01%) to 47.83% when pulling **1ee6080d8ebdc8bb69e1cd139dff44251ce318aa on a337928:develop** into **90e0c4b3e625ae2d98448155b91bea359c54af7d on apache:develop**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] love-xu opened a new pull request #891: [RIP-9] Modify the wrong architecture diagram.
love-xu opened a new pull request #891: [RIP-9] Modify the wrong architecture diagram. URL: https://github.com/apache/rocketmq/pull/891 ## What is the purpose of the change Modify the wrong architecture diagram. ## Brief changelog Modify the wrong architecture diagram. ## Verifying this change -- Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] a337928 opened a new pull request #890: (best practice) within deleted title
a337928 opened a new pull request #890: (best practice) within deleted title URL: https://github.com/apache/rocketmq/pull/890 ## What is the purpose of the change "(best practice)" within deleted title ## Brief changelog "(best practice)" within deleted title ## Verifying this change "(best practice)" within deleted title Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 888tyhj closed pull request #889: [RIP-9]Change the item number to solid black dot
888tyhj closed pull request #889: [RIP-9]Change the item number to solid black dot URL: https://github.com/apache/rocketmq/pull/889 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] love-xu closed pull request #861: [RIP-9] Modify the wrong architecture diagram
love-xu closed pull request #861: [RIP-9] Modify the wrong architecture diagram URL: https://github.com/apache/rocketmq/pull/861 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] 888tyhj opened a new pull request #889: [RIP-9]Change the item number to solid black dot
888tyhj opened a new pull request #889: [RIP-9]Change the item number to solid black dot URL: https://github.com/apache/rocketmq/pull/889 ## What is the purpose of the change Change the item number to solid black dot ## Brief changelog Change the item number to solid black dot ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
