[GitHub] [rocketmq-client-go] ShannonDing merged pull request #214: doc(Readme):modify the install method of c library

2019-09-17 Thread GitBox 
ShannonDing merged pull request #214: doc(Readme):modify the install method of 
c library
URL: https://github.com/apache/rocketmq-client-go/pull/214
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] ShannonDing opened a new pull request #214: doc(Readme):modify the install method of c library

2019-09-17 Thread GitBox 
ShannonDing opened a new pull request #214: doc(Readme):modify the install 
method of c library
URL: https://github.com/apache/rocketmq-client-go/pull/214
 
 
   ## What is the purpose of the change
   
   modify the install method of c library
   
   ## Brief changelog
   
   download package from apache site
   
   ## Verifying this change
   
   see the introduction page
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] apppur commented on a change in pull request #185: replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163

2019-09-17 Thread GitBox 
apppur commented on a change in pull request #185: replace boost log with 
spdlog, use this PR to replace 
https://github.com/apache/rocketmq-client-cpp/pull/163
URL: 
https://github.com/apache/rocketmq-client-cpp/pull/185#discussion_r325474802
 
 

 ##
 File path: src/common/UtilAll.h
 ##
 @@ -82,9 +87,9 @@ inline void deleteAndZero(Type& pointer) {
 }
 #define EMPTY_STR_PTR(ptr) (ptr == NULL || ptr[0] == '\0')
 #ifdef WIN32
-#define SIZET_FMT "%lu"
+#define SIZET_FMT "{}"
 
 Review comment:
   sorry, I ignored the previous changes. now I revert it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-spring] 18710103279 opened a new issue #146: 整合问题

2019-09-17 Thread GitBox 
18710103279 opened a new issue #146: 整合问题
URL: https://github.com/apache/rocketmq-spring/issues/146
 
 
   请问这个2.0.3版本可以在使用了springboot1.5.4的项目中引入吗？  如果不能，在不升级1.5.4的情况下，有什么其他解决方案吗？


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE][DISCUSS][RIP-17]RocketMQ HTTP Proxy Support

2019-09-17 Thread liqipeng 
+1
> 在 2019年9月16日，下午6:57，heng du  写道：
> 
> Hello RocketMQ Community,
> 
> This is the vote for the kickoff of RIP-17 RocketMQ HTTP Proxy Support
> 
> RocketMQ has different clients written in different languages. In order to 
> meet the needs of heterogeneous systems to access RocketMQ, this proposal 
> solves this problem by adding an HTTP proxy module. At the same time, some 
> logic such as flow control/ACL on the broker and some processing logic on the 
> client can be moved to the proxy, which makes the broker and client lighter.
> 
> 
> The vote will be open for at least 72 hours or until a necessary number of 
> votes are reached.
> 
> Please vote accordingly:
> 
> [ ] +1 approve 
> [ ] +0 no opinion 
> [ ] -1 disapprove with the reason
> 
> 
> Thanks,
> The Apache RocketMQ Team
> 
> heng du mailto:duhengfore...@gmail.com>> 
> 于2019年9月16日周一 下午6:55写道：
> @aliomaidi419
> 
> producer 跟 consumer端都可以使用http-proxy
> 
> huzongt...@cmss.chinamobile.com  
> mailto:huzongt...@cmss.chinamobile.com>> 
> 于2019年9月12日周四 上午10:47写道：
> This rip sounds very wonderful.It make RocketMQ may access clients written in 
> different languages.We can join in this rip together.
> 
> 
> 
> huzongt...@cmss.chinamobile.com 
> 
> From: heng du
> Date: 2019-09-12 09:41
> To: dev; users
> Subject: [DISCUSS][RIP-17]RocketMQ HTTP Proxy Support
> Dear Apache RocketMQ Community:
> 
> We would like to propose a RIP-17 about RocketMQ HTTP Proxy.
> 
> RocketMQ may access clients written in different languages. In order to meet 
> the needs of heterogeneous systems to access RocketMQ, this proposal solves 
> this problem by adding an HTTP proxy module. At the same time, some logic 
> such as flow control/ACL on the broker and some process logic on the client 
> can be moved to the proxy, which makes the broker and client lighter.
> 
> So we would like to provide an HTTP proxy to provide a proxy for HTTP so that 
> users can quickly access the RocketMQ with a lightweight HTTP client.
> 
> The following is the relevant information about this RIP and we are listed 
> directly below for your convenience, hope everyone can give more suggestions. 
> 
> Thanks,
> The Apache RocketMQ Team
> 
> Status
> ●  Current State: Proposed
> ●  Authors: qqeasonchen
> ●  Shepherds: duhengforever
> ●  Mailing List discussion: dev@rocketmq.apache.org 
> ; us...@rocketmq.apache.org 
> 
> ●  Pull Request: RIP-17
> ●  Released: 4.7.0（rocketmq-external first）
> Background & Motivation
> What do we need to do
> 
> RocketMQ may access clients written in different languages. In order to meet 
> the needs of heterogeneous systems to access RocketMQ, this proposal solve 
> this problem by adding HTTP proxy module. At the same time, some logic such 
> as flow control/ACL on broker and some process logic on client can be moved 
> to proxy, which makes the broker and client lighter.
> Goals
> ●  What problem is this proposal designed to solve?
> In the future, RocketMQ may access clients written in different languages. At 
> present, due to the complexity of the client logic, it takes a lot of effort 
> to rewrite the client in different languages. And the persistent connection 
> in RocketMQ is based on TCP, and the ability to resist network jitter is bad. 
> HTTP connection can better resist network jitter. In order to write and 
> access clients in different languages better, this proposal provides an HTTP 
> sending proxy, which simplifies the processing logic of the client and 
> implements a more lightweight client.
> Non-Goals
> ●  What problem is this proposal NOT designed to solve?
> Nothing specific
> ●Are there any limits of this proposal?
> User need deploy proxy before use it. It will add a little complexity for 
> operation and maintenance.
> Changes
> Adding a proxy module to achieve message proxy.
> 
> This RIP will be divided into two phases. 
> 
> The first phase will not have any impact on the existing architecture, 
> including the nameserver, depending on the service discovery configured to do 
> the proxy.
> 
> The second phase will decide whether to do proxy service discovery based on 
> community feedback or provide a lightweight http client.
> Architecture
> 
> 
> In our proposal, there are 3 features in the proxy:
> (1)   We realize group proxy in producer group/consumer group level
> (2)   The proxy receives HTTP packets sent by HTTP producer, which realizes 
> HTTP proxy and reduces the impact of network jitter.
> (3)   The proxy simplify processing logic in client and achieve lighter 
> client.
> 
> 
>

Re: [VOTE][DISCUSS][RIP-17]RocketMQ HTTP Proxy Support

2019-09-17 Thread heng du 
+1

liqipeng  于2019年9月18日周三 上午11:15写道：

> +1
>
> 在 2019年9月16日，下午6:57，heng du  写道：
>
> Hello RocketMQ Community,
>
> This is the vote for the kickoff of RIP-17 RocketMQ HTTP Proxy Support
>
> RocketMQ has different clients written in different languages. In order to
> meet the needs of heterogeneous systems to access RocketMQ, this proposal
> solves this problem by adding an HTTP proxy module. At the same time, some
> logic such as flow control/ACL on the broker and some processing logic on
> the client can be moved to the proxy, which makes the broker and client
> lighter.
>
>
> The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
>
> Thanks,
> The Apache RocketMQ Team
>
> heng du  于2019年9月16日周一 下午6:55写道：
>
>> @aliomaidi419
>>
>> producer 跟 consumer端都可以使用http-proxy
>>
>> huzongt...@cmss.chinamobile.com 
>> 于2019年9月12日周四 上午10:47写道：
>>
>>> This rip sounds very wonderful.It make RocketMQ may access clients
>>> written in different languages.We can join in this rip together.
>>>
>>>
>>>
>>> huzongt...@cmss.chinamobile.com
>>>
>>> From: heng du
>>> Date: 2019-09-12 09:41
>>> To: dev; users
>>> Subject: [DISCUSS][RIP-17]RocketMQ HTTP Proxy Support
>>> Dear Apache RocketMQ Community:
>>>
>>> We would like to propose a RIP-17 about RocketMQ HTTP Proxy.
>>>
>>> RocketMQ may access clients written in different languages. In order to
>>> meet the needs of heterogeneous systems to access RocketMQ, this proposal
>>> solves this problem by adding an HTTP proxy module. At the same time, some
>>> logic such as flow control/ACL on the broker and some process logic on the
>>> client can be moved to the proxy, which makes the broker and client lighter.
>>>
>>> So we would like to provide an HTTP proxy to provide a proxy for HTTP so
>>> that users can quickly access the RocketMQ with a lightweight HTTP client.
>>>
>>> The following is the relevant information about this RIP and we are
>>> listed directly below for your convenience, hope everyone can give more
>>> suggestions.
>>>
>>> Thanks,
>>> The Apache RocketMQ Team
>>>
>>> Status
>>> ●  Current State: Proposed
>>> ●  Authors: qqeasonchen
>>> ●  Shepherds: duhengforever
>>> ●  Mailing List discussion: dev@rocketmq.apache.org;
>>> us...@rocketmq.apache.org
>>> ●  Pull Request: RIP-17
>>> ●  Released: 4.7.0（rocketmq-external first）
>>> Background & Motivation
>>> What do we need to do
>>>
>>> RocketMQ may access clients written in different languages. In order to
>>> meet the needs of heterogeneous systems to access RocketMQ, this proposal
>>> solve this problem by adding HTTP proxy module. At the same time, some
>>> logic such as flow control/ACL on broker and some process logic on client
>>> can be moved to proxy, which makes the broker and client lighter.
>>> Goals
>>> ●  What problem is this proposal designed to solve?
>>> In the future, RocketMQ may access clients written in different
>>> languages. At present, due to the complexity of the client logic, it takes
>>> a lot of effort to rewrite the client in different languages. And the
>>> persistent connection in RocketMQ is based on TCP, and the ability to
>>> resist network jitter is bad. HTTP connection can better resist network
>>> jitter. In order to write and access clients in different languages better,
>>> this proposal provides an HTTP sending proxy, which simplifies the
>>> processing logic of the client and implements a more lightweight client.
>>> Non-Goals
>>> ●  What problem is this proposal NOT designed to solve?
>>> Nothing specific
>>> ●Are there any limits of this proposal?
>>> User need deploy proxy before use it. It will add a little complexity
>>> for operation and maintenance.
>>> Changes
>>> Adding a proxy module to achieve message proxy.
>>>
>>> This RIP will be divided into two phases.
>>>
>>> The first phase will not have any impact on the existing architecture,
>>> including the nameserver, depending on the service discovery configured to
>>> do the proxy.
>>>
>>> The second phase will decide whether to do proxy service discovery based
>>> on community feedback or provide a lightweight http client.
>>> Architecture
>>>
>>>
>>> In our proposal, there are 3 features in the proxy:
>>> (1)   We realize group proxy in producer group/consumer group level
>>> (2)   The proxy receives HTTP packets sent by HTTP producer, which
>>> realizes HTTP proxy and reduces the impact of network jitter.
>>> (3)   The proxy simplify processing logic in client and achieve lighter
>>> client.
>>>
>>>
>>>
>>>
>

[GitHub] [rocketmq] coveralls edited a comment on issue #1422: [RIP-16]Support request/response pattern

2019-09-17 Thread GitBox 
coveralls edited a comment on issue #1422: [RIP-16]Support request/response 
pattern
URL: https://github.com/apache/rocketmq/pull/1422#issuecomment-531618889
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/25775157/badge)](https://coveralls.io/builds/25775157)
   
   Coverage decreased (-0.4%) to 49.111% when pulling 
**ec1f9266d2bcd95c9ac41e049d15fec20c9d4afa on qqeasonchen:rocketmq-dev-rpc** 
into **faef36455e273f2a2e2ceedc9497e61b994f999d on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] qqeasonchen commented on a change in pull request #1422: [RIP-16]Support request/response pattern

2019-09-17 Thread GitBox 
qqeasonchen commented on a change in pull request #1422: [RIP-16]Support 
request/response pattern
URL: https://github.com/apache/rocketmq/pull/1422#discussion_r325462656
 
 

 ##
 File path: 
example/src/main/java/org/apache/rocketmq/example/rpc/RequestProducer.java
 ##
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.example.rpc;
+
+import org.apache.rocketmq.client.exception.MQClientException;
+import org.apache.rocketmq.client.log.ClientLogger;
+import org.apache.rocketmq.client.producer.DefaultMQProducer;
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.logging.InternalLogger;
+import org.apache.rocketmq.remoting.common.RemotingHelper;
+
+public class RequestProducer {
+private static final InternalLogger log = ClientLogger.getLog();
+
+public static void main(String[] args) throws MQClientException, 
InterruptedException {
+String producerGroup = "ProducerGroup-Name";
+String namesrvAddr = "10.255.2.37:9876;10.255.2.37:9875";
 
 Review comment:
   Ok. I'll optimize it and then re-commit it. Welcome any suggestion and 
feedback.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] coveralls edited a comment on issue #1405: [ISSUE #1397]Add abnormal recover for dleger modle

2019-09-17 Thread GitBox 
coveralls edited a comment on issue #1405: [ISSUE #1397]Add abnormal recover 
for dleger modle
URL: https://github.com/apache/rocketmq/pull/1405#issuecomment-523733517
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/25774855/badge)](https://coveralls.io/builds/25774855)
   
   Coverage decreased (-1.03%) to 49.505% when pulling 
**e073babdab4bd2c972a63d4dca67d5f04fd06e5a on 
duhenglucky:abnormal_recover_dleger** into 
**90ae1167981ad586e84dd433c08395aeb92a4111 on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Failed: duhenglucky/rocketmq#22 (abnormal_recover_polish - c000c64)

2019-09-17 Thread Travis CI 
Build Update for duhenglucky/rocketmq
-

Build: #22
Status: Failed

Duration: 13 mins and 26 secs
Commit: c000c64 (abnormal_recover_polish)
Author: duhenglucky
Message: feat(store) fix get dispath size error issue

View the changeset: https://github.com/duhenglucky/rocketmq/commit/c000c64bd3ec

View the full build log and details: 
https://travis-ci.org/duhenglucky/rocketmq/builds/586333464?utm_medium=notification_source=email

--

You can unsubscribe from build emails from the duhenglucky/rocketmq repository 
going to 
https://travis-ci.org/account/preferences/unsubscribe?repository=22557420_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

Still Failing: duhenglucky/rocketmq#24 (abnormal_recover_dleger - e073bab)

2019-09-17 Thread Travis CI 
Build Update for duhenglucky/rocketmq
-

Build: #24
Status: Still Failing

Duration: 17 mins and 17 secs
Commit: e073bab (abnormal_recover_dleger)
Author: duhenglucky
Message: chore(store) removed mismatched comments

View the changeset: 
https://github.com/duhenglucky/rocketmq/compare/c000c64bd3ec...e073babdab4b

View the full build log and details: 
https://travis-ci.org/duhenglucky/rocketmq/builds/586335299?utm_medium=notification_source=email

--

You can unsubscribe from build emails from the duhenglucky/rocketmq repository 
going to 
https://travis-ci.org/account/preferences/unsubscribe?repository=22557420_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

[GitHub] [rocketmq] coveralls edited a comment on issue #1405: [ISSUE #1397]Add abnormal recover for dleger modle

2019-09-17 Thread GitBox 
coveralls edited a comment on issue #1405: [ISSUE #1397]Add abnormal recover 
for dleger modle
URL: https://github.com/apache/rocketmq/pull/1405#issuecomment-523733517
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/25774806/badge)](https://coveralls.io/builds/25774806)
   
   Coverage decreased (-1.0%) to 49.577% when pulling 
**e073babdab4bd2c972a63d4dca67d5f04fd06e5a on 
duhenglucky:abnormal_recover_dleger** into 
**90ae1167981ad586e84dd433c08395aeb92a4111 on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Still Failing: duhenglucky/rocketmq#23 (abnormal_recover_dleger - c000c64)

2019-09-17 Thread Travis CI 
Build Update for duhenglucky/rocketmq
-

Build: #23
Status: Still Failing

Duration: 13 mins and 27 secs
Commit: c000c64 (abnormal_recover_dleger)
Author: duhenglucky
Message: feat(store) fix get dispath size error issue

View the changeset: 
https://github.com/duhenglucky/rocketmq/compare/811a235bb571...c000c64bd3ec

View the full build log and details: 
https://travis-ci.org/duhenglucky/rocketmq/builds/586333603?utm_medium=notification_source=email

--

You can unsubscribe from build emails from the duhenglucky/rocketmq repository 
going to 
https://travis-ci.org/account/preferences/unsubscribe?repository=22557420_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

Failed: duhenglucky/rocketmq#22 (abnormal_recover_polish - c000c64)

2019-09-17 Thread Travis CI 
Build Update for duhenglucky/rocketmq
-

Build: #22
Status: Failed

Duration: 8 mins and 24 secs
Commit: c000c64 (abnormal_recover_polish)
Author: duhenglucky
Message: feat(store) fix get dispath size error issue

View the changeset: https://github.com/duhenglucky/rocketmq/commit/c000c64bd3ec

View the full build log and details: 
https://travis-ci.org/duhenglucky/rocketmq/builds/586333464?utm_medium=notification_source=email

--

You can unsubscribe from build emails from the duhenglucky/rocketmq repository 
going to 
https://travis-ci.org/account/preferences/unsubscribe?repository=22557420_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

[GitHub] [rocketmq-client-cpp] ifplusor commented on a change in pull request #185: replace boost log with spdlog, use this PR to replace https://github.com/apache/rocketmq-client-cpp/pull/163

2019-09-17 Thread GitBox 
ifplusor commented on a change in pull request #185: replace boost log with 
spdlog, use this PR to replace 
https://github.com/apache/rocketmq-client-cpp/pull/163
URL: 
https://github.com/apache/rocketmq-client-cpp/pull/185#discussion_r325453245
 
 

 ##
 File path: src/common/UtilAll.h
 ##
 @@ -82,9 +87,9 @@ inline void deleteAndZero(Type& pointer) {
 }
 #define EMPTY_STR_PTR(ptr) (ptr == NULL || ptr[0] == '\0')
 #ifdef WIN32
-#define SIZET_FMT "%lu"
+#define SIZET_FMT "{}"
 
 Review comment:
   don't change SIZET_FMT.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] vongosling merged pull request #213: refactor(example): polish rocketmq go example

2019-09-17 Thread GitBox 
vongosling merged pull request #213: refactor(example): polish rocketmq go 
example
URL: https://github.com/apache/rocketmq-client-go/pull/213
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] duhenglucky opened a new pull request #213: (feat)polish rocketmq go example

2019-09-17 Thread GitBox 
duhenglucky opened a new pull request #213: (feat)polish rocketmq go example
URL: https://github.com/apache/rocketmq-client-go/pull/213
 
 
   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] vongosling opened a new issue #212: Introduce gopkg service in go

2019-09-17 Thread GitBox 
vongosling opened a new issue #212: Introduce gopkg service in go
URL: https://github.com/apache/rocketmq-client-go/issues/212
 
 
   Details see http://labix.org/gopkg.in


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-spring] zcwease opened a new issue #145: 集成问题

2019-09-17 Thread GitBox 
zcwease opened a new issue #145: 集成问题
URL: https://github.com/apache/rocketmq-spring/issues/145
 
 
   The issue tracker is **ONLY** used for bug report and feature request. 
   
   Any question or RocketMQ proposal please use our [mailing 
lists](http://rocketmq.apache.org/about/contact/).
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   springboot工程 版本：boot版本 2.1.3.RELEASE
   
   
org.apache.rocketmq
rocketmq-spring-boot-starter
2.0.3
true

   启动打印日志如下
   
   2019-09-17 20:38:44.808  INFO 11892 --- [   main] 
trationDelegate$BeanPostProcessorChecker : Bean 'rocketMQTemplate' of type 
[org.apache.rocketmq.spring.core.RocketMQTemplate] is not eligible for getting 
processed by all BeanPostProcessors (for example: not eligible for 
auto-proxying)
   2019-09-17 20:38:44.810  INFO 11892 --- [   main] 
trationDelegate$BeanPostProcessorChecker : Bean 'transactionHandlerRegistry' of 
type [org.apache.rocketmq.spring.config.TransactionHandlerRegistry] is not 
eligible for getting processed by all BeanPostProcessors (for example: not 
eligible for auto-proxying)
   
   导致postprocessor无法得到RocketMQTemplate类型的bean对象
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

回复：Re: Apache project meetup in ShangHai Sep 21st

2019-09-17 Thread Liu Ted 
OK, I originally plan to go but need to change my travel plan now. Wish you 
have a good meeting then.

Best regards,

Ted Liu, 
ASF Member, Sponsor Ambassador, Incubator PMC Member 
 
  2019 年 9 月 17 日周二 16:16，Willem Jiang 写道：   The time 
is around 1:30 PM to 4:00 PM, now it's about 20 people will join us.
We are just trying to find some place to hold this event.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Sep 17, 2019 at 6:14 AM Liu Ted  wrote:
>
> Hi Willem, What's the current status if the captioned meeting in Shanghai on 
> Seot. 21st? Has the venue and time been decided yet?
>
> Best regards,
>
> Ted Liu,
> ASF Member, Sponsor Ambassador, Incubator PMC Member
>
>
>  2019 年 8 月 21 日周三 10:55，Willem Jiang 写道：  Hi,
>
> We would like to hold a meetup in ShangHai Sep 21st by inviting some
> Apache members ( Craig Russell, Justin Mclean, Willem Jiang）and some
> apache projects committers in China like we did last year.
>
> We hold this meetup can help Apache projects to know each other in
> China. As there are lot of Apache project committers are based in east
> China,  we can leverage this opportunity to let Apache know better
> about the committers in China and give us some advice to build up
> health community.
>
> The discussion topic of meetup could be:
> How to be the TLP of ASF?
> How can we help ASF know better about China?
> How can we help more Chinese know better about ASF?
>
> If you are interested about this meetup, please drop an email to
> ningjiang AT apache.org with the information of your name, phone
> number and the project name before Sep 18th 12 PM. We will send you
> detail information of the meetup later.
>
> Please forward the mail to your friend who may be interested about this event.
>
> Willem
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
> For additional commands, e-mail: dev-h...@echarts.apache.org
>

[GitHub] [rocketmq] vongosling merged pull request #1438: fix typo

2019-09-17 Thread GitBox 
vongosling merged pull request #1438: fix typo
URL: https://github.com/apache/rocketmq/pull/1438
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] liangyuanpeng edited a comment on issue #204: use it with govendor

2019-09-17 Thread GitBox 
liangyuanpeng edited a comment on issue #204: use it with govendor
URL: 
https://github.com/apache/rocketmq-client-go/issues/204#issuecomment-532143214
 
 
   i run main.go from native branch
   
   
   but i got some error 
   
   ```
   lanrendeMacBook-Pro:examples lanren$ go run main.go
   # github.com/apache/rocketmq-client-go/core
   ../core/cfuns.go:22:10: fatal error: 'rocketmq/CMessageExt.h' file not found
   #include 
   ^~~~
   1 error generated.
   ```
   
   any help?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-go] liangyuanpeng commented on issue #204: use it with govendor

2019-09-17 Thread GitBox 
liangyuanpeng commented on issue #204: use it with govendor
URL: 
https://github.com/apache/rocketmq-client-go/issues/204#issuecomment-532143214
 
 
   i run main.go from native branch
   
   
   but i got some error 
   
   
   lanrendeMacBook-Pro:examples lanren$ go run main.go
   # github.com/apache/rocketmq-client-go/core
   ../core/cfuns.go:22:10: fatal error: 'rocketmq/CMessageExt.h' file not found
   #include 
   ^~~~
   1 error generated.
   
   any help?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] vongosling merged pull request #1455: [ISSUE #1456]Fix replica abnormal recover slow issue

2019-09-17 Thread GitBox 
vongosling merged pull request #1455: [ISSUE #1456]Fix replica abnormal recover 
slow issue
URL: https://github.com/apache/rocketmq/pull/1455
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] vongosling commented on a change in pull request #1458: [ISSUE #1457] Dynamically effective namesrvAddr for name server auto-scaling

2019-09-17 Thread GitBox 
vongosling commented on a change in pull request #1458: [ISSUE #1457] 
Dynamically effective namesrvAddr for name server auto-scaling
URL: https://github.com/apache/rocketmq/pull/1458#discussion_r325060772
 
 

 ##
 File path: 
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
 ##
 @@ -388,6 +388,20 @@ public void run() {
 }
 }, 1000 * 10, 1000 * 60, TimeUnit.MILLISECONDS);
 
+if (this.brokerConfig.isWatchNamesrvAddr()) {
+this.scheduledExecutorService.scheduleAtFixedRate(new 
Runnable() {
+
+@Override
+public void run() {
+try {
+
BrokerController.this.brokerOuterAPI.updateNameServerAddressList(brokerConfig.getNamesrvAddr());
 
 Review comment:
   Do we need to filter out unnecessary update operation?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] vongosling commented on a change in pull request #1458: [ISSUE #1457] Dynamically effective namesrvAddr for name server auto-scaling

2019-09-17 Thread GitBox 
vongosling commented on a change in pull request #1458: [ISSUE #1457] 
Dynamically effective namesrvAddr for name server auto-scaling
URL: https://github.com/apache/rocketmq/pull/1458#discussion_r325058853
 
 

 ##
 File path: 
broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java
 ##
 @@ -388,6 +388,20 @@ public void run() {
 }
 }, 1000 * 10, 1000 * 60, TimeUnit.MILLISECONDS);
 
+if (this.brokerConfig.isWatchNamesrvAddr()) {
+this.scheduledExecutorService.scheduleAtFixedRate(new 
Runnable() {
+
+@Override
+public void run() {
+try {
+
BrokerController.this.brokerOuterAPI.updateNameServerAddressList(brokerConfig.getNamesrvAddr());
 
 Review comment:
   scheduledExecutorService is a global SingleThreadScheduledExecutor, how do 
we make sure that we have a reasonable schedule, and that if the schedule 
fails, it really doesn't affect the other logic?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] vongosling commented on a change in pull request #1422: [RIP-16]Support request/response pattern

2019-09-17 Thread GitBox 
vongosling commented on a change in pull request #1422: [RIP-16]Support 
request/response pattern
URL: https://github.com/apache/rocketmq/pull/1422#discussion_r325053780
 
 

 ##
 File path: 
example/src/main/java/org/apache/rocketmq/example/rpc/RequestProducer.java
 ##
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.example.rpc;
+
+import org.apache.rocketmq.client.exception.MQClientException;
+import org.apache.rocketmq.client.log.ClientLogger;
+import org.apache.rocketmq.client.producer.DefaultMQProducer;
+import org.apache.rocketmq.common.message.Message;
+import org.apache.rocketmq.logging.InternalLogger;
+import org.apache.rocketmq.remoting.common.RemotingHelper;
+
+public class RequestProducer {
+private static final InternalLogger log = ClientLogger.getLog();
+
+public static void main(String[] args) throws MQClientException, 
InterruptedException {
+String producerGroup = "ProducerGroup-Name";
+String namesrvAddr = "10.255.2.37:9876;10.255.2.37:9875";
 
 Review comment:
   Examples of request/response need to polish further, let's continue to 
optimize this example, at least to keep it consistent. Users may copy code to 
their production environment directly.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Apache project meetup in ShangHai Sep 21st

2019-09-17 Thread Sheng Wu 
Enjoy the meetup. It will be a great chance to meet senior Apache
members/board, learning the Apache Way.
I wouldn't join as my schedule has been too crazy already.

If any of you will be Alibaba APSARA(云溪大会) next week, I will be there. :)

Sheng Wu 吴晟

Apache SkyWalking
Apache Incubator
Apache ShardingSphere, ECharts, DolphinScheduler podlings
Zipkin
Twitter, wusheng1108


Willem Jiang  于2019年9月17日周二 下午4:16写道：

> The time is around 1:30 PM to 4:00 PM, now it's about 20 people will join
> us.
> We are just trying to find some place to hold this event.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Tue, Sep 17, 2019 at 6:14 AM Liu Ted  wrote:
> >
> > Hi Willem, What's the current status if the captioned meeting in
> Shanghai on Seot. 21st? Has the venue and time been decided yet?
> >
> > Best regards,
> >
> > Ted Liu,
> > ASF Member, Sponsor Ambassador, Incubator PMC Member
> >
> >
> >   2019 年 8 月 21 日周三 10:55，Willem Jiang 写道：   Hi,
> >
> > We would like to hold a meetup in ShangHai Sep 21st by inviting some
> > Apache members ( Craig Russell, Justin Mclean, Willem Jiang）and some
> > apache projects committers in China like we did last year.
> >
> > We hold this meetup can help Apache projects to know each other in
> > China. As there are lot of Apache project committers are based in east
> > China,  we can leverage this opportunity to let Apache know better
> > about the committers in China and give us some advice to build up
> > health community.
> >
> > The discussion topic of meetup could be:
> > How to be the TLP of ASF?
> > How can we help ASF know better about China?
> > How can we help more Chinese know better about ASF?
> >
> > If you are interested about this meetup, please drop an email to
> > ningjiang AT apache.org with the information of your name, phone
> > number and the project name before Sep 18th 12 PM. We will send you
> > detail information of the meetup later.
> >
> > Please forward the mail to your friend who may be interested about this
> event.
> >
> > Willem
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
> > For additional commands, e-mail: dev-h...@echarts.apache.org
> >
>

Re: Apache project meetup in ShangHai Sep 21st

2019-09-17 Thread Willem Jiang 
The time is around 1:30 PM to 4:00 PM, now it's about 20 people will join us.
We are just trying to find some place to hold this event.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Tue, Sep 17, 2019 at 6:14 AM Liu Ted  wrote:
>
> Hi Willem, What's the current status if the captioned meeting in Shanghai on 
> Seot. 21st? Has the venue and time been decided yet?
>
> Best regards,
>
> Ted Liu,
> ASF Member, Sponsor Ambassador, Incubator PMC Member
>
>
>   2019 年 8 月 21 日周三 10:55，Willem Jiang 写道：   Hi,
>
> We would like to hold a meetup in ShangHai Sep 21st by inviting some
> Apache members ( Craig Russell, Justin Mclean, Willem Jiang）and some
> apache projects committers in China like we did last year.
>
> We hold this meetup can help Apache projects to know each other in
> China. As there are lot of Apache project committers are based in east
> China,  we can leverage this opportunity to let Apache know better
> about the committers in China and give us some advice to build up
> health community.
>
> The discussion topic of meetup could be:
> How to be the TLP of ASF?
> How can we help ASF know better about China?
> How can we help more Chinese know better about ASF?
>
> If you are interested about this meetup, please drop an email to
> ningjiang AT apache.org with the information of your name, phone
> number and the project name before Sep 18th 12 PM. We will send you
> detail information of the meetup later.
>
> Please forward the mail to your friend who may be interested about this event.
>
> Willem
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@echarts.apache.org
> For additional commands, e-mail: dev-h...@echarts.apache.org
>

[GitHub] [rocketmq] coveralls edited a comment on issue #1412: [issue #670]change the way to create newGroupChannelTable

2019-09-17 Thread GitBox 
coveralls edited a comment on issue #1412: [issue #670]change the way to create 
newGroupChannelTable
URL: https://github.com/apache/rocketmq/pull/1412#issuecomment-523870615
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/25753128/badge)](https://coveralls.io/builds/25753128)
   
   Coverage decreased (-1.03%) to 49.507% when pulling 
**91024267f233024a44b4bc0b82a83cdc7af1bc3b on 
qqeasonchen:concurrent_motify_exception** into 
**90ae1167981ad586e84dd433c08395aeb92a4111 on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] bean326 commented on issue #1288: Consume failed with different system time between producer and consumer.

2019-09-17 Thread GitBox 
bean326 commented on issue #1288: Consume failed with different system time 
between producer and consumer.
URL: https://github.com/apache/rocketmq/issues/1288#issuecomment-532084085
 
 
   > @ bean326我很想重现和探索它，请你提供更多信息，例如生产者机器和消费者机器之间的时差是多少？无法正常消耗时是否打印错误消息？
   
   应该是时差超过1分钟还是3分钟以上就没法收消息了


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] apppur opened a new pull request #185: Logs

2019-09-17 Thread GitBox 
apppur opened a new pull request #185: Logs
URL: https://github.com/apache/rocketmq-client-cpp/pull/185
 
 
   ## What is the purpose of the change
   
   X
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when a cross-module dependency exists.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-externals] xujianhai666 commented on a change in pull request #414: [ISSUE #399]Topic rename.

2019-09-17 Thread GitBox 
xujianhai666 commented on a change in pull request #414: [ISSUE #399]Topic 
rename.
URL: https://github.com/apache/rocketmq-externals/pull/414#discussion_r324997938
 
 

 ##
 File path: 
rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/config/TaskTopicInfo.java
 ##
 @@ -16,16 +16,20 @@
  */
 package org.apache.rocketmq.replicator.config;
 
+import org.apache.rocketmq.common.message.MessageQueue;
+
 public class TaskTopicInfo {
 
 Review comment:
   @duhenglucky done


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services