[GitHub] [rocketmq-client-go] jonnxu merged pull request #141: [ISSUE#120] update strategy and add offset_store test

2019-08-15 Thread GitBox
jonnxu merged pull request #141: [ISSUE#120] update strategy and add offset_store test URL: https://github.com/apache/rocketmq-client-go/pull/141 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [rocketmq-client-go] jonnxu commented on issue #141: [ISSUE#120] update strategy and add offset_store test

2019-08-15 Thread GitBox
jonnxu commented on issue #141: [ISSUE#120] update strategy and add offset_store test URL: https://github.com/apache/rocketmq-client-go/pull/141#issuecomment-521906145 LGTM This is an automated message from the Apache Git Se

[GitHub] [rocketmq-ons-cpp] ShannonDing commented on a change in pull request #1: Add licenses and notice for 3rd-party dependencies

2019-08-15 Thread GitBox
ShannonDing commented on a change in pull request #1: Add licenses and notice for 3rd-party dependencies URL: https://github.com/apache/rocketmq-ons-cpp/pull/1#discussion_r314600958 ## File path: licenses/LICENSE-BIN ## @@ -0,0 +1,281 @@ + A

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new issue #177: The License and NOTICE should be packaged in releases.

2019-08-15 Thread GitBox
ShannonDing opened a new issue #177: The License and NOTICE should be packaged in releases. URL: https://github.com/apache/rocketmq-client-cpp/issues/177 **BUG REPORT** 1. Please describe the issue you observed: - What did you do (The steps to reproduce)? Review the deploy

[GitHub] [rocketmq] coveralls edited a comment on issue #1365: Update concept.md

2019-08-15 Thread GitBox
coveralls edited a comment on issue #1365: Update concept.md URL: https://github.com/apache/rocketmq/pull/1365#issuecomment-518306612 [![Coverage Status](https://coveralls.io/builds/25168915/badge)](https://coveralls.io/builds/25168915) Coverage increased (+0.03%) to 50.609% when

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #176: Add license and notice binary to prepare release

2019-08-15 Thread GitBox
ShannonDing opened a new pull request #176: Add license and notice binary to prepare release URL: https://github.com/apache/rocketmq-client-cpp/pull/176 ## What is the purpose of the change Add license for 3-rd party code ## Brief changelog add binary licenses. #

[GitHub] [rocketmq-client-go] wenfengwang commented on issue #141: [ISSUE#120] update strategy and add offset_store test

2019-08-15 Thread GitBox
wenfengwang commented on issue #141: [ISSUE#120] update strategy and add offset_store test URL: https://github.com/apache/rocketmq-client-go/pull/141#issuecomment-521898789 LGTM This is an automated message from the Apache G

[GitHub] [rocketmq-client-go] codecov-io commented on issue #141: [ISSUE#120] update strategy and add offset_store test

2019-08-15 Thread GitBox
codecov-io commented on issue #141: [ISSUE#120] update strategy and add offset_store test URL: https://github.com/apache/rocketmq-client-go/pull/141#issuecomment-521882656 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/141?src=pr&el=h1) Report > :exclamation: No cove

[GitHub] [rocketmq] areyouok opened a new issue #1390: Slave crash break HA of transaction message

2019-08-15 Thread GitBox
areyouok opened a new issue #1390: Slave crash break HA of transaction message URL: https://github.com/apache/rocketmq/issues/1390 Setup a cluster with 4 brokers: (master1/slave1), (master2/slave2) Kill master1, RocketMQ producer client will send all message to master2 after a while.

[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #158: [ISSUE #151] Optimize PullConsumer API

2019-08-15 Thread GitBox
codecov-io edited a comment on issue #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158#issuecomment-521868994 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr&el=h1) Report > Merging [#158](https://codec

[GitHub] [rocketmq-client-go] wenfengwang commented on issue #158: [ISSUE #151] Optimize PullConsumer API

2019-08-15 Thread GitBox
wenfengwang commented on issue #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158#issuecomment-521869637 aligin https://github.com/apache/rocketmq/pull/1386 This is an auto

[GitHub] [rocketmq-client-go] codecov-io commented on issue #158: [ISSUE #151] Optimize PullConsumer API

2019-08-15 Thread GitBox
codecov-io commented on issue #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158#issuecomment-521868994 # [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/158?src=pr&el=h1) Report > Merging [#158](https://codecov.io/gh

[GitHub] [rocketmq-client-go] wenfengwang opened a new pull request #158: [ISSUE #151] Optimize PullConsumer API

2019-08-15 Thread GitBox
wenfengwang opened a new pull request #158: [ISSUE #151] Optimize PullConsumer API URL: https://github.com/apache/rocketmq-client-go/pull/158 ## What is the purpose of the change Optimize PullConsumer API ## Brief changelog align LiteConsumer of RocektMQ ## Verif

[GitHub] [rocketmq-spring] RongtongJin commented on issue #99: the message was consumed twice because of the same instanceName

2019-08-15 Thread GitBox
RongtongJin commented on issue #99: the message was consumed twice because of the same instanceName URL: https://github.com/apache/rocketmq-spring/issues/99#issuecomment-521865669 @xiaotanxingchen Currently, you can temporarily solve this issue by implementing RocketMQPushConsumerLifecycle

[GitHub] [rocketmq-client-go] jonnxu merged pull request #145: [ISSUE #144] Fix nil pointer when file not exist

2019-08-15 Thread GitBox
jonnxu merged pull request #145: [ISSUE #144] Fix nil pointer when file not exist URL: https://github.com/apache/rocketmq-client-go/pull/145 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [rocketmq-spring] RongtongJin commented on issue #107: Two consumer instances consume the same message, and some messages are not consumed

2019-08-15 Thread GitBox
RongtongJin commented on issue #107: Two consumer instances consume the same message, and some messages are not consumed URL: https://github.com/apache/rocketmq-spring/issues/107#issuecomment-521865529 @whoamigodson Currently, you can temporarily solve this issue by implementing RocketMQPu

[GitHub] [rocketmq-spring] RongtongJin commented on issue #108: How to send SQL92 filter msg in RocketMQTemplate?

2019-08-15 Thread GitBox
RongtongJin commented on issue #108: How to send SQL92 filter msg in RocketMQTemplate? URL: https://github.com/apache/rocketmq-spring/issues/108#issuecomment-521864156 @whoamigodson Sorry, it is not supported yet. This is an

[GitHub] [rocketmq-externals] yiliuchen closed issue #345: [RocketMQ-Connect-Runtime] When the namesrv environment is different,create different rmq client by setInstanceName

2019-08-15 Thread GitBox
yiliuchen closed issue #345: [RocketMQ-Connect-Runtime] When the namesrv environment is different,create different rmq client by setInstanceName URL: https://github.com/apache/rocketmq-externals/issues/345 This is an automat

[GitHub] [rocketmq-externals] yiliuchen closed issue #349: [RocketMQ-Connect-Runtime] merge rmq task client

2019-08-15 Thread GitBox
yiliuchen closed issue #349: [RocketMQ-Connect-Runtime] merge rmq task client URL: https://github.com/apache/rocketmq-externals/issues/349 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [rocketmq-externals] duhenglucky merged pull request #348: [ISSUE #345]merge rmq client

2019-08-15 Thread GitBox
duhenglucky merged pull request #348: [ISSUE #345]merge rmq client URL: https://github.com/apache/rocketmq-externals/pull/348 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [rocketmq-externals] duhenglucky commented on a change in pull request #370: [ISSUE #371]Develop Jdbc Source Connector

2019-08-15 Thread GitBox
duhenglucky commented on a change in pull request #370: [ISSUE #371]Develop Jdbc Source Connector URL: https://github.com/apache/rocketmq-externals/pull/370#discussion_r314552921 ## File path: rocketmq-connect-jdbc/src/test/java/org/apache/rocketmq/connect/jdbc/connector/JdbcSource

[GitHub] [rocketmq] coveralls edited a comment on issue #1352: [RIP-15]Add Ipv6 support for RocketMQ

2019-08-15 Thread GitBox
coveralls edited a comment on issue #1352: [RIP-15]Add Ipv6 support for RocketMQ URL: https://github.com/apache/rocketmq/pull/1352#issuecomment-516737962 [![Coverage Status](https://coveralls.io/builds/25152730/badge)](https://coveralls.io/builds/25152730) Coverage increased (+0.

[GitHub] [rocketmq-externals] yiliuchen closed issue #351: [rocketmq-replicator] sourceTask and sinkTask rmq client must setInstanceName

2019-08-15 Thread GitBox
yiliuchen closed issue #351: [rocketmq-replicator] sourceTask and sinkTask rmq client must setInstanceName URL: https://github.com/apache/rocketmq-externals/issues/351 This is an automated message from the Apache Git Servi

[GitHub] [rocketmq-externals] yiliuchen opened a new issue #386: [rocketmq-replicator] sourceTaskTopicList can not be empty

2019-08-15 Thread GitBox
yiliuchen opened a new issue #386: [rocketmq-replicator] sourceTaskTopicList can not be empty URL: https://github.com/apache/rocketmq-externals/issues/386 The issue tracker is **ONLY** used for bug report and feature request. Any question or RocketMQ proposal please use our [mailing

[GitHub] [rocketmq-spring] RongtongJin commented on issue #119: fix #117

2019-08-15 Thread GitBox
RongtongJin commented on issue #119: fix #117 URL: https://github.com/apache/rocketmq-spring/pull/119#issuecomment-521610351 @vongosling @ShannonDing Could you help merge this pr? This is an automated message from the Apache G

[GitHub] [rocketmq-spring] RongtongJin commented on issue #118: consumer.subscribe is not valid

2019-08-15 Thread GitBox
RongtongJin commented on issue #118: consumer.subscribe is not valid URL: https://github.com/apache/rocketmq-spring/issues/118#issuecomment-521609443 You can set filter expression by setting selectorExpression like this: ```@RocketMQMessageListener (topic = “xxx”, selectorExpression =

[GitHub] [rocketmq] vongosling commented on issue #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ

2019-08-15 Thread GitBox
vongosling commented on issue #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ URL: https://github.com/apache/rocketmq/pull/1386#issuecomment-521582716 The unit test coverage does not meet the commit checklist, please do not tick it.

[GitHub] [rocketmq] vongosling commented on a change in pull request #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ

2019-08-15 Thread GitBox
vongosling commented on a change in pull request #1386: [ISSUE #1388]Add lite pull consumer support for RocketMQ URL: https://github.com/apache/rocketmq/pull/1386#discussion_r314216890 ## File path: example/src/main/java/org/apache/rocketmq/example/simple/LitePullConsumer.java ###

[GitHub] [rocketmq] wutongpeng opened a new pull request #1389: Merge pull request #1 from apache/master

2019-08-15 Thread GitBox
wutongpeng opened a new pull request #1389: Merge pull request #1 from apache/master URL: https://github.com/apache/rocketmq/pull/1389 更新代码 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow

[GitHub] [rocketmq] wutongpeng closed pull request #1389: Merge pull request #1 from apache/master

2019-08-15 Thread GitBox
wutongpeng closed pull request #1389: Merge pull request #1 from apache/master URL: https://github.com/apache/rocketmq/pull/1389 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [rocketmq-client-go] zongtanghu merged pull request #156: update defaultConsumer.client init AND add push_consumer testing

2019-08-15 Thread GitBox
zongtanghu merged pull request #156: update defaultConsumer.client init AND add push_consumer testing URL: https://github.com/apache/rocketmq-client-go/pull/156 This is an automated message from the Apache Git Service. To re