[GitHub] [rocketmq] duhenglucky edited a comment on issue #1119: set run property storePathRootDir , then you will not startup

2020-01-14 Thread GitBox
duhenglucky edited a comment on issue #1119: set run property storePathRootDir 
, then you will not startup
URL: https://github.com/apache/rocketmq/issues/1119#issuecomment-574537000
 
 
   @18575531337 same with other the latest 
[issue](https://github.com/apache/rocketmq/issues/1715), welcome to join and 
try again.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] vongosling closed issue #756: Is there a schedule of OpenMessaging golang SDK?

2020-01-14 Thread GitBox
vongosling closed issue #756: Is there a schedule of OpenMessaging golang SDK?
URL: https://github.com/apache/rocketmq/issues/756
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #618: DefaultMQPullConsumer

2020-01-14 Thread GitBox
duhenglucky closed issue #618: DefaultMQPullConsumer
URL: https://github.com/apache/rocketmq/issues/618
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #1106: There is a incorrect comment of maxMessageSize in MessageStoreConfig.java

2020-01-14 Thread GitBox
duhenglucky closed issue #1106: There is a incorrect comment of maxMessageSize 
in MessageStoreConfig.java
URL: https://github.com/apache/rocketmq/issues/1106
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] vongosling commented on issue #1180: How to learn rocketmq

2020-01-14 Thread GitBox
vongosling commented on issue #1180: How to learn  rocketmq
URL: https://github.com/apache/rocketmq/issues/1180#issuecomment-574538043
 
 
   Unit Test is a good choice for learning internals for RocketMQ.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #678: StoreCheckpoint setLogicsMsgTimestamp dont work right , may cause message loss

2020-01-14 Thread GitBox
duhenglucky closed issue #678: StoreCheckpoint setLogicsMsgTimestamp dont work 
right , may cause message loss 
URL: https://github.com/apache/rocketmq/issues/678
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] vongosling closed issue #1180: How to learn rocketmq

2020-01-14 Thread GitBox
vongosling closed issue #1180: How to learn  rocketmq
URL: https://github.com/apache/rocketmq/issues/1180
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] vongosling closed issue #1204: Alibaba Summer of Code 2019

2020-01-14 Thread GitBox
vongosling closed issue #1204: Alibaba Summer of Code 2019
URL: https://github.com/apache/rocketmq/issues/1204
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #1105: Support messages timed delivery

2020-01-14 Thread GitBox
duhenglucky closed issue #1105: Support  messages timed delivery
URL: https://github.com/apache/rocketmq/issues/1105
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] coveralls edited a comment on issue #1684: Producer manager channel

2020-01-14 Thread GitBox
coveralls edited a comment on issue #1684: Producer manager channel
URL: https://github.com/apache/rocketmq/pull/1684#issuecomment-569213927
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/28117260/badge)](https://coveralls.io/builds/28117260)
   
   Coverage decreased (-0.1%) to 50.861% when pulling 
**ff499ca7eed306c48891e3eb172b66af6532c9b3 on 
rushsky518:producerManager_channel** into 
**881f7675060bf889306adf695c65a02da057d8ff on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky commented on issue #1119: set run property storePathRootDir , then you will not startup

2020-01-14 Thread GitBox
duhenglucky commented on issue #1119: set run property storePathRootDir , then 
you will not startup
URL: https://github.com/apache/rocketmq/issues/1119#issuecomment-574537000
 
 
   @18575531337 same with other the latest 
[issue](https://github.com/apache/rocketmq/issues/1715)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #1118: slave broker frequently lose connection to master when no msg producing

2020-01-14 Thread GitBox
duhenglucky closed issue #1118: slave broker frequently lose connection to 
master when no msg producing
URL: https://github.com/apache/rocketmq/issues/1118
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky commented on issue #1118: slave broker frequently lose connection to master when no msg producing

2020-01-14 Thread GitBox
duhenglucky commented on issue #1118: slave broker frequently lose connection 
to master when no msg producing
URL: https://github.com/apache/rocketmq/issues/1118#issuecomment-574536685
 
 
   fixed!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #1036: Can one message is both an order message and transactional message?

2020-01-14 Thread GitBox
duhenglucky closed issue #1036: Can one message is both an order message and 
transactional message?
URL: https://github.com/apache/rocketmq/issues/1036
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #1119: set run property storePathRootDir , then you will not startup

2020-01-14 Thread GitBox
duhenglucky closed issue #1119: set run property storePathRootDir , then you 
will not startup
URL: https://github.com/apache/rocketmq/issues/1119
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] coveralls edited a comment on issue #1684: Producer manager channel

2020-01-14 Thread GitBox
coveralls edited a comment on issue #1684: Producer manager channel
URL: https://github.com/apache/rocketmq/pull/1684#issuecomment-569213927
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/28116713/badge)](https://coveralls.io/builds/28116713)
   
   Coverage decreased (-0.2%) to 50.82% when pulling 
**06852b2ef0bb2379c20c606804c777048bef6874 on 
rushsky518:producerManager_channel** into 
**881f7675060bf889306adf695c65a02da057d8ff on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-cpp] ShannonDing commented on issue #205: push-consumer start failed and coredump when one namesrv host cannot be resolve

2020-01-14 Thread GitBox
ShannonDing commented on issue #205: push-consumer start failed and coredump 
when one namesrv host cannot be resolve
URL: 
https://github.com/apache/rocketmq-client-cpp/issues/205#issuecomment-574524289
 
 
   it is better to keep the hostname right and try to catch exceptions on the 
instance starting.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-cpp] ShannonDing closed issue #205: push-consumer start failed and coredump when one namesrv host cannot be resolve

2020-01-14 Thread GitBox
ShannonDing closed issue #205: push-consumer start failed and coredump when one 
namesrv host cannot be resolve
URL: https://github.com/apache/rocketmq-client-cpp/issues/205
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #232: feat(callback): use start pointer to manager callbacks

2020-01-14 Thread GitBox
ShannonDing merged pull request #232: feat(callback): use start pointer to 
manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-nodejs] phantomk commented on issue #12: Can't compile with node12

2020-01-14 Thread GitBox
phantomk commented on issue #12: Can't compile with node12
URL: 
https://github.com/apache/rocketmq-client-nodejs/issues/12#issuecomment-574519542
 
 
   还维护吗?大佬们


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #232: feat(callback): use start pointer to manager callbacks

2020-01-14 Thread GitBox
ShannonDing opened a new pull request #232: feat(callback): use start pointer 
to manager callbacks
URL: https://github.com/apache/rocketmq-client-cpp/pull/232
 
 
   ## What is the purpose of the change
   
   feat(callback): use start pointer to manager callbacks
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] a13707331174 commented on issue #1726: consumer cant be started if it started after another consumer which dont have access to a topic.

2020-01-14 Thread GitBox
a13707331174 commented on issue #1726: consumer cant be started if it started 
after another consumer which dont have access to a topic.
URL: https://github.com/apache/rocketmq/issues/1726#issuecomment-574481323
 
 
   The version i used is 4.6.0


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] a13707331174 opened a new issue #1726: consumer cant be started if it started after another consumer which dont have access to a topic.

2020-01-14 Thread GitBox
a13707331174 opened a new issue #1726: consumer cant be started if it started 
after another consumer which dont have access to a topic.
URL: https://github.com/apache/rocketmq/issues/1726
 
 
   When acl is enabled, I defined only one topic can be subscribed as the 
follow :
   ``` 
   globalWhiteRemoteAddresses:
   accounts:
   - accessKey: accessId123
 secretKey: accessKey123
 whiteRemoteAddress:
 admin: false
 defaultTopicPerm: DENY
 defaultGroupPerm: SUB
 topicPerms:
 - topicA=SUB
 groupPerms:
   ```
   Then I defined two consumers named ConsumerA that subscribed TopicA and 
ConsumerB that subscribed TopicB. Obviously ConsumerB dont have access to 
subscribe TopicB.
   if I started ConsumerA before ConsumerB  :
   ```
   //will subscribe TopicA
   Consumer consumerA = new ConsumerA();
   //will subscribe TopicB
   Consumer consumerB = new ConsumerB();
   consumerA.start();
   consumerB.start();
   ```  
   Though there would be an AclException in the remoting.log that shows no 
default permission for topicB, consumerA could start successfully.
   However if I started ConsumerB before ConsumerA:
   ```
   //will subscribe TopicA
   Consumer consumerA = new ConsumerA();
   //will subscribe TopicB
   Consumer consumerB = new ConsumerB();
   //consumerB starts first
   consumerB.start();
   consumerA.start();
   ``` 
   There also would be an AclExcpetion in the remoting.log that shows no 
default permission for topicB, **consumerA can not be started either**.
   Even though I can see the linux connect was established by command netstat,  
consumer was offline and can not consume any message. 
   Is this a bug?
   
   如果我只在 plain_acl.yml中只定义了TopicA的订阅权限,
   然后我封装了两个消费者类,ConsumerA和ConsumerB,他们分别订阅TopicA和TopicB.
   很明显ConsumerB将无权订阅TopicB. 当我先启动ConsumerA,后启动ConsumerB时, ConsumerA启动正常,并可以消费消息.
   但是如果我先启动ConsumerB,后启动ConsumerA, 那么不仅ConsumerB无法消费消息,ConsumerA也没法消费消息,
   并且这时候,如果我用netstat看的话,ConsumerA是有连接建立的, 
但是我通过mqadmin的consumeProgress命令,显示的是消费者处于OffLine状态, 通过rocketmq-console也看不到消费者在线.
   这是个bug吗


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] Aaron-He commented on issue #1718: Switching from CMS to G1

2020-01-14 Thread GitBox
Aaron-He commented on issue #1718: Switching from CMS to G1
URL: https://github.com/apache/rocketmq/issues/1718#issuecomment-574474185
 
 
   @duhenglucky Glad to.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] a13707331174 commented on issue #1711: An AclException was throwed when I used mqadmin command to updateTopic

2020-01-14 Thread GitBox
a13707331174 commented on issue #1711: An AclException was throwed when I used 
mqadmin command to updateTopic
URL: https://github.com/apache/rocketmq/issues/1711#issuecomment-574472925
 
 
   @zongtanghu Only plain_acl.yml. I have solved by add local host ip under 
_globalWhiteRemoteAddresses_ , thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] a13707331174 closed issue #1711: An AclException was throwed when I used mqadmin command to updateTopic

2020-01-14 Thread GitBox
a13707331174 closed issue #1711: An AclException was throwed when I used 
mqadmin command to updateTopic
URL: https://github.com/apache/rocketmq/issues/1711
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-go] wenfengwang merged pull request #387: fix: consume type compatible with protocol

2020-01-14 Thread GitBox
wenfengwang merged pull request #387: fix: consume type compatible with protocol
URL: https://github.com/apache/rocketmq-client-go/pull/387
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-go] wenfengwang merged pull request #390: [ISSUE #389] feat(consumer): move updatePullFromWhichNode ahead of result check

2020-01-14 Thread GitBox
wenfengwang merged pull request #390: [ISSUE #389] feat(consumer): move 
updatePullFromWhichNode ahead of result check
URL: https://github.com/apache/rocketmq-client-go/pull/390
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-go] wenfengwang closed issue #389: [Native] updatePullFromWhichNode should not only when processPullResult

2020-01-14 Thread GitBox
wenfengwang closed issue #389: [Native] updatePullFromWhichNode should not only 
when processPullResult
URL: https://github.com/apache/rocketmq-client-go/issues/389
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-go] wenfengwang commented on issue #389: [Native] updatePullFromWhichNode should not only when processPullResult

2020-01-14 Thread GitBox
wenfengwang commented on issue #389: [Native] updatePullFromWhichNode should 
not only when processPullResult
URL: 
https://github.com/apache/rocketmq-client-go/issues/389#issuecomment-574469632
 
 
   close due to #390 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky commented on issue #1684: Producer manager channel

2020-01-14 Thread GitBox
duhenglucky commented on issue #1684: Producer manager channel
URL: https://github.com/apache/rocketmq/pull/1684#issuecomment-574469032
 
 
   @rushsky518 thanks for your PR, and could you resolve conflict first?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky commented on issue #1718: Switching from CMS to G1

2020-01-14 Thread GitBox
duhenglucky commented on issue #1718: Switching from CMS to G1
URL: https://github.com/apache/rocketmq/issues/1718#issuecomment-574467581
 
 
   @Aaron-He good suggestion, could you pull a request to polish this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky commented on issue #1715: broker start error, after set storePathRootDir

2020-01-14 Thread GitBox
duhenglucky commented on issue #1715: broker start error,after set 
storePathRootDir
URL: https://github.com/apache/rocketmq/issues/1715#issuecomment-574467419
 
 
   @zhaijw ping


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] 542928492 commented on issue #1725: checkTransaction一直循环回查版本4.6.0

2020-01-14 Thread GitBox
542928492 commented on issue #1725: checkTransaction一直循环回查版本4.6.0
URL: https://github.com/apache/rocketmq/issues/1725#issuecomment-574465614
 
 
   我使用的集群是mq451和mq460混合的版本。使用同一个注册中心。使用如下步骤操作,
   最终是可以解决问题:
1. 启动所有新版本 new-broker-460  
2.迁移topic 到new-broker 
3.关闭所有old-broker-451  
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] 542928492 closed issue #1725: checkTransaction一直循环回查版本4.6.0

2020-01-14 Thread GitBox
542928492 closed issue #1725: checkTransaction一直循环回查版本4.6.0
URL: https://github.com/apache/rocketmq/issues/1725
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky closed issue #1724: typo in org.apache.rocketmq.client.impl.consumer.DefaultLitePullConsumerImpl#seekToEnd

2020-01-14 Thread GitBox
duhenglucky closed issue #1724: typo in
org.apache.rocketmq.client.impl.consumer.DefaultLitePullConsumerImpl#seekToEnd
URL: https://github.com/apache/rocketmq/issues/1724
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] duhenglucky merged pull request #1723: [ISSUE # 1724]typo fix

2020-01-14 Thread GitBox
duhenglucky merged pull request #1723: [ISSUE # 1724]typo fix
URL: https://github.com/apache/rocketmq/pull/1723
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #390: [ISSUE #389] feat(consumer): move updatePullFromWhichNode ahead of result check

2020-01-14 Thread GitBox
xujianhai666 opened a new pull request #390: [ISSUE #389] feat(consumer): move 
updatePullFromWhichNode ahead of result check
URL: https://github.com/apache/rocketmq-client-go/pull/390
 
 
   - consistent with java
   
   Closes #389


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-client-go] xujianhai666 opened a new issue #389: [Native] updatePullFromWhichNode should not only when processPullResult

2020-01-14 Thread GitBox
xujianhai666 opened a new issue #389: [Native] updatePullFromWhichNode should 
not only when processPullResult
URL: https://github.com/apache/rocketmq-client-go/issues/389
 
 
   The issue tracker is **ONLY** used for the go client (feature request of 
RocketMQ need to follow [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)).
 Keep in mind, please check whether there is an existing same report before 
your raise a new one.
   
   Alternately (especially if your communication is not a bug report), you can 
send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We 
welcome any friendly suggestions, bug fixes, collaboration, and other 
improvements.
   
   Please ensure that your bug report is clear and that it is complete. 
Otherwise, we may be unable to understand it or to reproduce it, either of 
which would prevent us from fixing the bug. We strongly recommend the 
report(bug report or feature request) could include some hints as to the 
following:
   
   **BUG REPORT**  
   **Please add the branch name [Native]/[Master] at the header of the Isssue 
title.**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What did you expect to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
- What is your OS?
   
- What is your client version?
   
- What is your RocketMQ version?
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions on how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


Add as Contributor

2020-01-14 Thread Atri Sharma
Hi,

I am trying to post a comment on JIRA but unable to do so. Can someone
please add me as a contributor? My JIRA ID is atri

Atri
-- 
Regards,

Atri
Apache Concerted


[GitHub] [rocketmq] 542928492 opened a new issue #1725: checkTransaction一直循环回查版本4.6.0

2020-01-14 Thread GitBox
542928492 opened a new issue #1725: checkTransaction一直循环回查版本4.6.0
URL: https://github.com/apache/rocketmq/issues/1725
 
 
   The issue tracker is **ONLY** used for bug report(feature request need to 
follow [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)).
 Keep in mind, please check whether there is an existing same report before 
your raise a new one.
   
   Alternately (especially if your communication is not a bug report), you can 
send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We 
welcome any friendly suggestions, bug fixes, collaboration and other 
improvements.
   
   Please ensure that your bug report is clear and that it is complete. 
Otherwise, we may be unable to understand it or to reproduce it, either of 
which would prevent us from fixing the bug. We strongly recommend the 
report(bug report or feature request) could include some hints as the following:
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What did you expect to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   
   -生产一条消息消息一直在RMQ_SYS_TRANS_HALF_TOPIC  中 ,无法正常推送。使用arthas查看已经返回
   COMMIT_MESSAGE了,但是还是一直在回查
   MQ服务端4.6.0版本 namerserver 4.2.0 。
   
![image](https://user-images.githubusercontent.com/25193123/72337813-2b0bad00-36fe-11ea-901b-2119e8cb40ce.png)
   
![image](https://user-images.githubusercontent.com/25193123/72337867-4676b800-36fe-11ea-88ff-6ffaa34dc96f.png)
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] 542928492 commented on issue #1183: checkLocalTransaction不断循环回查

2020-01-14 Thread GitBox
542928492 commented on issue #1183: checkLocalTransaction不断循环回查
URL: https://github.com/apache/rocketmq/issues/1183#issuecomment-574113346
 
 
   我broker 已经升级到4.6.0 了。还是出现此现象。broker就不断的循环回查本地事务的状态。明明返回
   COMMIT_MESSAGE了,但是还是一直在回查。
   nameserver 使用4.2.0 ,broker 版本4.6.0 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-operator] Will-JZH edited a comment on issue #15: Cannot access rocketmq from outside the k8s

2020-01-14 Thread GitBox
Will-JZH edited a comment on issue #15: Cannot access rocketmq from outside the 
k8s
URL: 
https://github.com/apache/rocketmq-operator/issues/15#issuecomment-574091912
 
 
   Can RocketMq-Operator use the node IP as the pod IP of broker cluster. When 
I use `kubectl get pods -owide`:
   
![image](https://user-images.githubusercontent.com/25976014/72333102-38bd3480-36f6-11ea-8587-b2fb876a6258.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-operator] Will-JZH edited a comment on issue #15: Cannot access rocketmq from outside the k8s

2020-01-14 Thread GitBox
Will-JZH edited a comment on issue #15: Cannot access rocketmq from outside the 
k8s
URL: 
https://github.com/apache/rocketmq-operator/issues/15#issuecomment-574082950
 
 
   @liuruiyiyang Client process and node running broker are not on the same 
network
   
![image](https://user-images.githubusercontent.com/25976014/72333009-07446900-36f6-11ea-94d1-210339a6f2f4.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-operator] Will-JZH edited a comment on issue #15: Cannot access rocketmq from outside the k8s

2020-01-14 Thread GitBox
Will-JZH edited a comment on issue #15: Cannot access rocketmq from outside the 
k8s
URL: 
https://github.com/apache/rocketmq-operator/issues/15#issuecomment-574091912
 
 
   When I use `kubectl get pods -owide`:
   
![image](https://user-images.githubusercontent.com/25976014/72333102-38bd3480-36f6-11ea-8587-b2fb876a6258.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-operator] Will-JZH commented on issue #15: Cannot access rocketmq from outside the k8s

2020-01-14 Thread GitBox
Will-JZH commented on issue #15: Cannot access rocketmq from outside the k8s
URL: 
https://github.com/apache/rocketmq-operator/issues/15#issuecomment-574091912
 
 
   When I user `kubectl get pods -owide`:
   
![image](https://user-images.githubusercontent.com/25976014/72333102-38bd3480-36f6-11ea-8587-b2fb876a6258.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] coveralls commented on issue #1723: typo fix

2020-01-14 Thread GitBox
coveralls commented on issue #1723: typo fix
URL: https://github.com/apache/rocketmq/pull/1723#issuecomment-574088722
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/28091852/badge)](https://coveralls.io/builds/28091852)
   
   Coverage decreased (-0.05%) to 50.882% when pulling 
**b279cd620163ef121b774f993e65f0c753c29c7d on uglycow:develop** into 
**678cab39e123078e118fbd7eb4bb5b8c8e630ab5 on apache:develop**.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq-operator] Will-JZH commented on issue #15: Cannot access rocketmq from outside the k8s

2020-01-14 Thread GitBox
Will-JZH commented on issue #15: Cannot access rocketmq from outside the k8s
URL: 
https://github.com/apache/rocketmq-operator/issues/15#issuecomment-574082950
 
 
   Client process and node running broker are not on the same network


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] uglycow commented on issue #1724: typo in org.apache.rocketmq.client.impl.consumer.DefaultLitePullConsumerImpl#seekToEnd

2020-01-14 Thread GitBox
uglycow commented on issue #1724: typo in
org.apache.rocketmq.client.impl.consumer.DefaultLitePullConsumerImpl#seekToEnd
URL: https://github.com/apache/rocketmq/issues/1724#issuecomment-574066431
 
 
   ```java
   public void seekToEnd(MessageQueue messageQueue) throws 
MQClientException {
   long begin = maxOffset(messageQueue);
   this.seek(messageQueue, begin);
   }
   ```
   
   the variable "begin"  might be named "end"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] uglycow opened a new issue #1724: typo in

2020-01-14 Thread GitBox
uglycow opened a new issue #1724: typo in
URL: https://github.com/apache/rocketmq/issues/1724
 
 
   The issue tracker is **ONLY** used for bug report(feature request need to 
follow [RIP 
process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal)).
 Keep in mind, please check whether there is an existing same report before 
your raise a new one.
   
   Alternately (especially if your communication is not a bug report), you can 
send mail to our [mailing lists](http://rocketmq.apache.org/about/contact/). We 
welcome any friendly suggestions, bug fixes, collaboration and other 
improvements.
   
   Please ensure that your bug report is clear and that it is complete. 
Otherwise, we may be unable to understand it or to reproduce it, either of 
which would prevent us from fixing the bug. We strongly recommend the 
report(bug report or feature request) could include some hints as the following:
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What did you expect to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, 
suggestions how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, 
should-have, nice-to-have). Are you currently using any workarounds to address 
this issue?
   
   4. If there are some sub-tasks using -[] for each subtask and create a 
corresponding issue to map to the sub task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 
description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 
description here,
   - ...
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [rocketmq] uglycow opened a new pull request #1723: typo fix

2020-01-14 Thread GitBox
uglycow opened a new pull request #1723: typo fix
URL: https://github.com/apache/rocketmq/pull/1723
 
 
   ## What is the purpose of the change
   
   fix typo
   
   ## Brief changelog
   
   fix typo 
   
   ## Verifying this change
   
   
   
   Follow this checklist to help us incorporate your contribution quickly and 
easily. Notice, `it would be helpful if you could finish the following 5 
checklist(the last one is not necessary)before request the community to review 
your PR`.
   
   - [x] Make sure there is a [Github 
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually 
before you start working on it). Trivial changes like typos do not require a 
Github issue. Your pull request should address just this issue, without pulling 
in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException 
when host config not exist`. Each commit in the pull request should have a 
meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic 
correction, more mock a little better when cross module dependency exist. If 
the new feature or significant change is committed, please remember to add 
integration-test in [test 
module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs 
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install 
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile 
failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual 
Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services