[GitHub] [rocketmq-client-cpp] ThreeAndTwo edited a comment on issue #355: Failed to build Boost.Build build engine
ThreeAndTwo edited a comment on issue #355: URL: https://github.com/apache/rocketmq-client-cpp/issues/355#issuecomment-896474315 I try to change boost version to 1.76.0, It's worked! and then I find the default c++ compiler is clang, I already switch c++ compiler to gcc-11 but doesn't seem to work.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] AbelSara commented on a change in pull request #3239: use the StringBuilder another method can reduce impact on array copy performance
AbelSara commented on a change in pull request #3239:
URL: https://github.com/apache/rocketmq/pull/3239#discussion_r686472902
##
File path: store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java
##
@@ -71,6 +72,9 @@ public void load() {
this.indexHeader.load();
}
+/**
+ * 头部文件刷盘 时间戳 msgId 物理偏移量..
Review comment:
Why do you use so many annotations, and it is in Chinese?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq-client-cpp] ThreeAndTwo commented on issue #355: Failed to build Boost.Build build engine
ThreeAndTwo commented on issue #355: URL: https://github.com/apache/rocketmq-client-cpp/issues/355#issuecomment-896487979 @WanZixin @ifplusor I found another case and it's worked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-cpp] ThreeAndTwo edited a comment on issue #355: Failed to build Boost.Build build engine
ThreeAndTwo edited a comment on issue #355: URL: https://github.com/apache/rocketmq-client-cpp/issues/355#issuecomment-896487979 @WanZixin @ifplusor I found another case and it's worked! ``` mkdir cppsdk cd cppsdk wget https://github.com/apache/rocketmq-client-cpp/releases/download/2.0.1/rocketmq-client-cpp-2.0.1-bin-release-darwin.tar.gz tar -xzf rocketmq-client-cpp-2.0.1-bin-release-darwin.tar.gz cp rocketmq-client-cpp/lib/* /usr/local/lib/ mkdir -p /usr/local/include/rocketmq/ cp rocketmq-client-cpp/include/* /usr/local/include/rocketmq/ install_name_tool -id "@rpath/librocketmq.dylib" /usr/local/lib/librocketmq.dylib ``` more info: https://help.aliyun.com/document_detail/157155.html?spm=a2c4g.11186623.6.702.313a5b06QfVEYE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ltamber commented on pull request #3246: Use df's algorithm to calculate the disk used ratio
ltamber commented on pull request #3246: URL: https://github.com/apache/rocketmq/pull/3246#issuecomment-896490924 nice work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] gylang commented on issue #3243: use the StringBuilder another method can reduce impact on array copy performance
gylang commented on issue #3243: URL: https://github.com/apache/rocketmq/issues/3243#issuecomment-896493545  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] chengshanbin commented on pull request #3246: Use df's algorithm to calculate the disk used ratio
chengshanbin commented on pull request #3246: URL: https://github.com/apache/rocketmq/pull/3246#issuecomment-896553051 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] gylang commented on a change in pull request #3239: use the StringBuilder another method can reduce impact on array copy performance
gylang commented on a change in pull request #3239:
URL: https://github.com/apache/rocketmq/pull/3239#discussion_r686560208
##
File path: store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java
##
@@ -71,6 +72,9 @@ public void load() {
this.indexHeader.load();
}
+/**
+ * 头部文件刷盘 时间戳 msgId 物理偏移量..
Review comment:
sory, I don't know why this code was submitted here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] gylang commented on a change in pull request #3239: use the StringBuilder another method can reduce impact on array copy performance
gylang commented on a change in pull request #3239:
URL: https://github.com/apache/rocketmq/pull/3239#discussion_r686567859
##
File path: store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java
##
@@ -71,6 +72,9 @@ public void load() {
this.indexHeader.load();
}
+/**
+ * 头部文件刷盘 时间戳 msgId 物理偏移量..
Review comment:
this code just my study comment. i do'not want to pr the "3eee57d"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] gylang commented on a change in pull request #3239: use the StringBuilder another method can reduce impact on array copy performance
gylang commented on a change in pull request #3239:
URL: https://github.com/apache/rocketmq/pull/3239#discussion_r686568525
##
File path: store/src/main/java/org/apache/rocketmq/store/index/IndexFile.java
##
@@ -71,6 +72,9 @@ public void load() {
this.indexHeader.load();
}
+/**
+ * 头部文件刷盘 时间戳 msgId 物理偏移量..
Review comment:
this code just my study comment. i don't want to pr "3eee57d"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
coveralls edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-880750487 [](https://coveralls.io/builds/42057643) Coverage increased (+0.1%) to 54.183% when pulling **f646fcc57f8f9100bd1ce4ed1935ddeb4b551f36 on panzhi33:develop** into **e4daba5ff5e4b51a81ad690b678370adb3d00632 on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
codecov-commenter edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-889850553 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3149](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f646fcc) into [develop](https://codecov.io/gh/apache/rocketmq/commit/30058cffa5a2512894a61b5c5eb97a58ce6681ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30058cf) will **increase** coverage by `0.10%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3149 +/- ## = + Coverage 47.82% 47.93% +0.10% + Complexity 4551 4331 -220 = Files552 514 -38 Lines 3664334972-1671 Branches4846 4661 -185 = - Hits 1752616763 -763 + Misses 1688116027 -854 + Partials2236 2182 -54 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: | | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: | | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `71.11% <0.00%> (-4.45%)` | :arrow_down: | | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: | | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `16.32% <0.00%> (-2.73%)` | :arrow_down: | | [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `48.52% <0.00%> (-2.22%)` | :arrow_down: | | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
[GitHub] [rocketmq-spring] RongtongJin merged pull request #372: [ISSUE #371] Add some asynchronous API for batch messages in RocketMQ…
RongtongJin merged pull request #372: URL: https://github.com/apache/rocketmq-spring/pull/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #1710: [ISSUE #1709] Call doAfterRpcHooks when request is asynchronous
coveralls commented on pull request #1710: URL: https://github.com/apache/rocketmq/pull/1710#issuecomment-896674316 [](https://coveralls.io/builds/42051586) Coverage increased (+0.1%) to 54.022% when pulling **e4298bb5bbd1f64c9dee771686f589351b6f6c14 on aaron-ai:pr** into **a20f31bb3de242756542c552d7212a7a4ba4 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] pirateskipper opened a new pull request #3247: Safely delete parameters and variables that have never been used
pirateskipper opened a new pull request #3247: URL: https://github.com/apache/rocketmq/pull/3247 **Make sure set the target branch to `develop`** ## What is the purpose of the change - Streamline code and increase readability ## Brief changelog - Safely delete parameters and variables that have never been used - Related change files：DefaultRequestProcessor && KVConfigManager ## Verifying this change - Verified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-cpp] ThreeAndTwo commented on issue #355: Failed to build Boost.Build build engine
ThreeAndTwo commented on issue #355: URL: https://github.com/apache/rocketmq-client-cpp/issues/355#issuecomment-896687235 Now it does not work! How should to resolve it??? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] pirateskipper closed pull request #3247: Safely delete parameters and variables that have never been used
pirateskipper closed pull request #3247: URL: https://github.com/apache/rocketmq/pull/3247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] pirateskipper opened a new pull request #3248: Safely delete parameters and variables that have never been used
pirateskipper opened a new pull request #3248: URL: https://github.com/apache/rocketmq/pull/3248 **Make sure set the target branch to `develop`** ## What is the purpose of the change - Streamline code and increase readability ## Brief changelog - Safely delete parameters and variables that have never been used - Related change files：DefaultRequestProcessor && KVConfigManager ## Verifying this change - Verified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] liumaomaoqwer opened a new pull request #778: [ISSUE #777]change wrong variable name clinetId to clientId
liumaomaoqwer opened a new pull request #778: URL: https://github.com/apache/rocketmq-externals/pull/778 ## What is the purpose of the change change wrong variable name clinetId to clientId ## Brief changelog The variable clinetId in Class ConsumerServiceImpl and MqttSampleConsumer is not correct, so i changed clinetId to clientId. ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3248: Safely delete parameters and variables that have never been used
coveralls commented on pull request #3248: URL: https://github.com/apache/rocketmq/pull/3248#issuecomment-896714408 [](https://coveralls.io/builds/42060241) Coverage increased (+0.1%) to 54.212% when pulling **e52fc184773b63d343cfbbfc1342eb5dd1d75d72 on pirateskipper:r-issues** into **44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #3248: Safely delete parameters and variables that have never been used
codecov-commenter commented on pull request #3248: URL: https://github.com/apache/rocketmq/pull/3248#issuecomment-896714532 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3248](https://codecov.io/gh/apache/rocketmq/pull/3248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e52fc18) into [develop](https://codecov.io/gh/apache/rocketmq/commit/5203d52f1bab431ada236ba279c80e62778f8a15?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5203d52) will **increase** coverage by `1.79%`. > The diff coverage is `31.25%`. [](https://codecov.io/gh/apache/rocketmq/pull/3248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3248 +/- ## = + Coverage 47.93% 49.72% +1.79% - Complexity 4564 5012 +448 = Files552 552 Lines 3662840169+3541 Branches4844 5813 +969 = + Hits 1755819975+2417 - Misses 1685017815 +965 - Partials2220 2379 +159 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...tmq/namesrv/processor/DefaultRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9wcm9jZXNzb3IvRGVmYXVsdFJlcXVlc3RQcm9jZXNzb3IuamF2YQ==) | `35.93% <26.66%> (ø)` | | | [...che/rocketmq/namesrv/kvconfig/KVConfigManager.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9rdmNvbmZpZy9LVkNvbmZpZ01hbmFnZXIuamF2YQ==) | `59.18% <100.00%> (ø)` | | | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `22.58% <0.00%> (-10.76%)` | :arrow_down: | | [...a/org/apache/rocketmq/logging/inner/SysLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9TeXNMb2dnZXIuamF2YQ==) | `28.57% <0.00%> (-5.72%)` | :arrow_down: | | [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | :arrow_down: | | [...java/org/apache/rocketmq/logging/inner/Logger.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnZXIuamF2YQ==) | `52.15% <0.00%> (-3.83%)` | :arrow_down: | | [...ava/org/apache/rocketmq/test/util/VerifyUtils.java](https://codecov.io/gh/apache/rocketmq/pull/3248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bX
[GitHub] [rocketmq-client-cpp] ThreeAndTwo opened a new issue #366: EventLoop.h:112:15: error: field 'm_peerAddrPort' has incomplete type 'std::string'
ThreeAndTwo opened a new issue #366: URL: https://github.com/apache/rocketmq-client-cpp/issues/366 relation issues: - https://github.com/apache/rocketmq-client-cpp/issues/355 - https://github.com/apache/rocketmq-client-cpp/issues/361 when boost update to 1.72.0 os: macos  if use default boost, there will happen [355](https://github.com/apache/rocketmq-client-cpp/issues/355) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3247: Safely delete parameters and variables that have never been used
coveralls commented on pull request #3247: URL: https://github.com/apache/rocketmq/pull/3247#issuecomment-896979957 [](https://coveralls.io/builds/42059840) Coverage decreased (-0.1%) to 53.992% when pulling **e52fc184773b63d343cfbbfc1342eb5dd1d75d72 on pirateskipper:r-issues** into **5203d52f1bab431ada236ba279c80e62778f8a15 on apache:release-4.9.0**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] StyleTang merged pull request #777: [ISSUE #673]Add unit tests to improve code coverage
StyleTang merged pull request #777: URL: https://github.com/apache/rocketmq-externals/pull/777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] StyleTang merged pull request #90: Add new committer styletang
StyleTang merged pull request #90: URL: https://github.com/apache/rocketmq-site/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] zongtanghu commented on issue #297: Not eligible for auto-proxying info
zongtanghu commented on issue #297: URL: https://github.com/apache/rocketmq-spring/issues/297#issuecomment-897274352 @zhangjidi2016 can you submit a pr to fix this issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] zongtanghu closed issue #371: Add some asynchronous API for batch messages in RocketMQTemplate.
zongtanghu closed issue #371: URL: https://github.com/apache/rocketmq-spring/issues/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] zongtanghu commented on issue #371: Add some asynchronous API for batch messages in RocketMQTemplate.
zongtanghu commented on issue #371: URL: https://github.com/apache/rocketmq-spring/issues/371#issuecomment-897274950 The related pr has already been merged, so I closed this issues! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] vongosling commented on issue #371: Add some asynchronous API for batch messages in RocketMQTemplate.
vongosling commented on issue #371: URL: https://github.com/apache/rocketmq-spring/issues/371#issuecomment-897276732 @zongtanghu you could not close pr by yourself. just link the pr with the issue. when merging to the main branch, it will automatically close. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] vongosling commented on pull request #372: [ISSUE #371] Add some asynchronous API for batch messages in RocketMQ…
vongosling commented on pull request #372: URL: https://github.com/apache/rocketmq-spring/pull/372#issuecomment-897276923 Linked issues @zongtanghu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] zongtanghu commented on issue #371: Add some asynchronous API for batch messages in RocketMQTemplate.
zongtanghu commented on issue #371: URL: https://github.com/apache/rocketmq-spring/issues/371#issuecomment-897278311 ok! 原始邮件 发件人: von ***@***.***> 收件人: ***@***.***> 抄送: Hu ***@***.***>; ***@***.***> 发送时间: 2021年8月12日(周四) 09:30 主题: Re: [apache/rocketmq-spring] Add some asynchronous API for batchmessages in RocketMQTemplate. (#371) @zongtanghu you could not close pr by yourself. just link the pr with the issue. when merging to the main branch, it will automatically close. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] vongosling opened a new issue #91: Remove issues colunm in contact page
vongosling opened a new issue #91: URL: https://github.com/apache/rocketmq-site/issues/91 Consider we have migrated from Jira to issues[1]. this mail list has lost its value. Anybody would like to remove it ? [1] https://rocketmq.apache.org/about/contact/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] 88888-IT opened a new issue #3249: Why does rocketMq store data on a file system instead of Redis
8-IT opened a new issue #3249: URL: https://github.com/apache/rocketmq/issues/3249 Why does rocketMq store data on a file system instead of Redis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] 88888-IT opened a new issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
8-IT opened a new issue #3250: URL: https://github.com/apache/rocketmq/issues/3250 RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] zongtanghu commented on issue #696: pull consumer has not supported
zongtanghu commented on issue #696: URL: https://github.com/apache/rocketmq-client-go/issues/696#issuecomment-897289169 I think you can write an design document, and then I and my workmates can participate into coding.And then we can splite this issues into serveral prs. @wenfengwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
ni-ze commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897299435 tag is decided by use, broker can not control how many tags users use. if we design consume queues by tag, that is a disaster for broker stability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze edited a comment on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
ni-ze edited a comment on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897299435 tag is decided by user, broker can not control how many tags users use. if we design consume queues by tag, that is a disaster for broker stability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] 88888-IT commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
8-IT commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897303372 > tag is decided by user, broker can not control how many tags users use. if we design consume queues by tag, that is a disaster for broker stability. What if the user defines the tag and creates it in the broker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] yuz10 opened a new pull request #92: [ISSUE #91] remove issues from mailing list
yuz10 opened a new pull request #92: URL: https://github.com/apache/rocketmq-site/pull/92 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change #91 ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] novayoung opened a new issue #3251: Does the lower version of rocketmq client support failover?
novayoung opened a new issue #3251: URL: https://github.com/apache/rocketmq/issues/3251 My client version is 4.5.1，but server version is 4.6 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] yuz10 merged pull request #709: [ISSUE #710] Fix send duplicate message in trace interceptor
yuz10 merged pull request #709: URL: https://github.com/apache/rocketmq-client-go/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
coveralls edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-880750487 [](https://coveralls.io/builds/42085950) Coverage increased (+0.02%) to 54.195% when pulling **064a3b80e6c4fcdbb611ac376dc59a5f2c8537e9 on panzhi33:develop** into **ec985ee67354a55607c3b5fde2e110dfb1268fea on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
codecov-commenter edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-889850553 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3149](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (064a3b8) into [develop](https://codecov.io/gh/apache/rocketmq/commit/30058cffa5a2512894a61b5c5eb97a58ce6681ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30058cf) will **increase** coverage by `0.11%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3149 +/- ## = + Coverage 47.82% 47.94% +0.11% + Complexity 4551 4333 -218 = Files552 514 -38 Lines 3664334972-1671 Branches4846 4661 -185 = - Hits 1752616768 -758 + Misses 1688116026 -855 + Partials2236 2178 -58 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: | | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: | | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: | | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `16.32% <0.00%> (-2.73%)` | :arrow_down: | | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `77.72% <0.00%> (-1.49%)` | :arrow_down: | | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `47.57% <0.00%> (-0.98%)` | :arrow_down: | | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache
[GitHub] [rocketmq] zhxjdwh opened a new issue #3252: the rocketmq_client.log file spent to mush cache/buffer
zhxjdwh opened a new issue #3252: URL: https://github.com/apache/rocketmq/issues/3252 **BUG REPORT** the rocketmq_client.log file spent to mush cache/buffer ! These log files really consume too much cache/buffer. The jvm memory usage of my container is only 500M, but the log buffer/cache of Rocketmq consumes 2G of memory. 这几个日志文件实在消耗了太多cache/buffer了，我容器的jvm内存使用才500M，但是rocketmq的日志buffer/cache就消耗了2G的内存 ``` [root@node135 f914151fc9ae5ce5f477a8d0d69ed9b0ebbb2ea45be3aec0f0acbde859d3e3b1]# /usr/local/bin/vmtouch ./diff/root/logs/rocketmqlogs/**rocketmq_client.log** Files: 1 Directories: 0 **Resident Pages: 198301/198301 774M/774M 100%** Elapsed: 0.03113 seconds [root@node135 f914151fc9ae5ce5f477a8d0d69ed9b0ebbb2ea45be3aec0f0acbde859d3e3b1]# /usr/local/bin/vmtouch ./diff/root/logs/rocketmqlogs/**rocketmq_client.log.1** Files: 1 Directories: 0 **Resident Pages: 262145/262145 1G/1G 100%** Elapsed: 0.042067 seconds [root@node135 f914151fc9ae5ce5f477a8d0d69ed9b0ebbb2ea45be3aec0f0acbde859d3e3b1]# /usr/local/bin/vmtouch **./diff/root/logs/rocketmqlogs/rocketmq_client.log.2** Files: 1 Directories: 0 **Resident Pages: 120207/262145 469M/1G 45.9%** Elapsed: 0.020819 seconds ``` **FEATURE REQUEST** Reduce the buffer/cache memory usage of log files 减少log文件的buffer/cache内存占用 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] novayoung closed issue #3251: Does the lower version of rocketmq client support failover?
novayoung closed issue #3251: URL: https://github.com/apache/rocketmq/issues/3251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
coveralls edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-880750487 [](https://coveralls.io/builds/42086837) Coverage decreased (-0.03%) to 54.146% when pulling **b61009195c85d407e2c1b8fc6d0691a0be938b1a on panzhi33:develop** into **ec985ee67354a55607c3b5fde2e110dfb1268fea on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
codecov-commenter edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-889850553 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3149](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b610091) into [develop](https://codecov.io/gh/apache/rocketmq/commit/30058cffa5a2512894a61b5c5eb97a58ce6681ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30058cf) will **increase** coverage by `0.05%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3149 +/- ## = + Coverage 47.82% 47.88% +0.05% + Complexity 4551 4326 -225 = Files552 514 -38 Lines 3664334972-1671 Branches4846 4661 -185 = - Hits 1752616746 -780 + Misses 1688116048 -833 + Partials2236 2178 -58 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: | | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: | | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: | | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `16.32% <0.00%> (-2.73%)` | :arrow_down: | | [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `48.52% <0.00%> (-2.22%)` | :arrow_down: | | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `77.72% <0.00%> (-1.49%)` | :arrow_down: | | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Founda
[GitHub] [rocketmq] ni-ze commented on issue #3252: the rocketmq_client.log file spent to mush cache/buffer
ni-ze commented on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897371476 can you give a way to repeat this? or just it will appear anyway? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
ni-ze commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897372515 > > tag is decided by user, broker can not control how many tags users use. if we design consume queues by tag, that is a disaster for broker stability. > > What if the user defines the tag and creates it in the broker You can not do that. Tag is define by user when send a message in producer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] 88888-IT commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
8-IT commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897375677 > What if the user defines the tag and creates it in the broker > You can not do that. Tag is define by user when send a message in producer. 我的意思是如果生产者提前在broker中创建好tag再去使用，这个时候是不是就可以根据tag来区分consumequeue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] odbozhou commented on issue #3249: Why does rocketMq store data on a file system instead of Redis
odbozhou commented on issue #3249: URL: https://github.com/apache/rocketmq/issues/3249#issuecomment-897376226 What is the problem with the file system? Why should it be stored in redis? Please describe your problem in detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
ni-ze commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897381697 why you need distinguish consumer queue by tag? It is topic dimension right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] duhenglucky closed issue #3249: Why does rocketMq store data on a file system instead of Redis
duhenglucky closed issue #3249: URL: https://github.com/apache/rocketmq/issues/3249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhxjdwh commented on issue #3252: the rocketmq_client.log file spent to mush cache/buffer
zhxjdwh commented on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897402857 @ni-ze -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhxjdwh removed a comment on issue #3252: the rocketmq_client.log file spent to mush cache/buffer
zhxjdwh removed a comment on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897402857 @ni-ze -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] 88888-IT commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
8-IT commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897408116 > why you need distinguish consumer queue by tag? It is topic dimension right now. If the consumer subscribes to the tag under the topic, the consumer needs to traverse the queue and compare the tagHashCode to fetch the item -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] vongosling closed issue #710: [Master] message will be send twice in trace interceptor
vongosling closed issue #710: URL: https://github.com/apache/rocketmq-client-go/issues/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] maqingxiang commented on issue #671: get subscribed topic list for PushConsumer
maqingxiang commented on issue #671: URL: https://github.com/apache/rocketmq-client-go/issues/671#issuecomment-897427487 The business only needs to provide the latest topic subscription list, and then the platform can dynamically adjust the topic subscription list according to the latest requirements of the business. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-externals] SteNicholas opened a new pull request #779: [#715] Support the RocketMQ TableSource based on the legacy Source implementation
SteNicholas opened a new pull request #779: URL: https://github.com/apache/rocketmq-externals/pull/779 ## What is the purpose of the change At present, RocketMQ connector supports the implementation of legacy SourceFunction interface, which needs the `ScanTableSource` implementation to expand Table/SQL capabilities. RocketMQ connector should support the RocketMQ TableSource based on the legacy SourceFunction interface. ## Brief changelog - Support `RocketMQScanTableSource` based on the implementation `RocketMQSourceFunction` of legacy `SourceFunction` interface. ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] maqingxiang opened a new issue #711: [bug] The Unsubscribe() interface influence retrytopic
maqingxiang opened a new issue #711:
URL: https://github.com/apache/rocketmq-client-go/issues/711
BUG REPORT
// push_consumer.go
func (pc *DefaultPushConsumer) Unsubscribe(topic string) error {
...
retryTopic := internal.GetRetryTopic(pc.consumerGroup)
pc.subscriptionDataTable.Delete(retryTopic)
...
}
There's a scene where the same ConsumerGroup subscries to T1, subscries to
T2, and unsubscribe T1. Is that a problem?
the client version is github.com/apache/rocketmq-client-go/v2 v2.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq-site] vongosling merged pull request #84: Use .asf.yaml for publishing
vongosling merged pull request #84: URL: https://github.com/apache/rocketmq-site/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhaohai1299002788 commented on issue #3252: the rocketmq_client.log file spent too much cache/buffer memory
zhaohai1299002788 commented on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897436932 If it is a log file, you can write a timer to delete the old log file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] yuz10 opened a new pull request #93: Add new committer yuz10
yuz10 opened a new pull request #93: URL: https://github.com/apache/rocketmq-site/pull/93 Please do not create a Pull Request without creating an issue first. ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai commented on issue #711: [bug] The Unsubscribe() interface influence retrytopic
maixiaohai commented on issue #711: URL: https://github.com/apache/rocketmq-client-go/issues/711#issuecomment-897458107 @maqingxiang agree with you, welcome to submit a pr to fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai merged pull request #706: [ISSUE #595] Update go.mod
maixiaohai merged pull request #706: URL: https://github.com/apache/rocketmq-client-go/pull/706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] maixiaohai closed issue #595: There is a vulnerability in gjson v1.2.1,upgrade recommended
maixiaohai closed issue #595: URL: https://github.com/apache/rocketmq-client-go/issues/595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] kingmax-yu opened a new issue #3253: RockerMQ-4.7.1 storeerror.log reprot too many errorlog "WARN FlushConsumeQueueService - Offset not matched"
kingmax-yu opened a new issue #3253: URL: https://github.com/apache/rocketmq/issues/3253 WARN FlushConsumeQueueService - Offset not matched. Request offset: 31800, firstOffset: 31200, lastOffset: 31800, mappedFileSize: 600, mappedFiles count: 1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on issue #3243: use the StringBuilder another method can reduce impact on array copy performance
lizhiboo commented on issue #3243: URL: https://github.com/apache/rocketmq/issues/3243#issuecomment-897463732 @gylang Good catch, can u submit a pr to optimize it？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] lizhiboo commented on issue #3253: RockerMQ-4.7.1 storeerror.log reprot too many errorlog "WARN FlushConsumeQueueService - Offset not matched"
lizhiboo commented on issue #3253: URL: https://github.com/apache/rocketmq/issues/3253#issuecomment-897477077 > WARN FlushConsumeQueueService - Offset not matched. Request offset: 31800, firstOffset: 31200, lastOffset: 31800, mappedFileSize: 600, mappedFiles count: 1 It seems that no new message produced, do not find message by Request offset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
coveralls edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-880750487 [](https://coveralls.io/builds/42094499) Coverage decreased (-0.04%) to 54.129% when pulling **d47f051a56bc21b29663c9fe9bdbc031e9fad3b0 on panzhi33:develop** into **ec985ee67354a55607c3b5fde2e110dfb1268fea on apache:develop**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] codecov-commenter edited a comment on pull request #3149: [ISSUE #3148]Support metadata export
codecov-commenter edited a comment on pull request #3149: URL: https://github.com/apache/rocketmq/pull/3149#issuecomment-889850553 # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#3149](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d47f051) into [develop](https://codecov.io/gh/apache/rocketmq/commit/30058cffa5a2512894a61b5c5eb97a58ce6681ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (30058cf) will **increase** coverage by `0.12%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## develop#3149 +/- ## = + Coverage 47.82% 47.95% +0.12% + Complexity 4551 4336 -215 = Files552 514 -38 Lines 3664334972-1671 Branches4846 4661 -185 = - Hits 1752616771 -755 + Misses 1688116026 -855 + Partials2236 2175 -61 ``` | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/3149?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rocketmq/broker/pagecache/ManyMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL01hbnlNZXNzYWdlVHJhbnNmZXIuamF2YQ==) | `36.36% <0.00%> (-9.80%)` | :arrow_down: | | [.../rocketmq/broker/pagecache/OneMessageTransfer.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvcGFnZWNhY2hlL09uZU1lc3NhZ2VUcmFuc2Zlci5qYXZh) | `24.00% <0.00%> (-9.34%)` | :arrow_down: | | [...ketmq/common/protocol/body/ConsumerConnection.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9Db25zdW1lckNvbm5lY3Rpb24uamF2YQ==) | `95.83% <0.00%> (-4.17%)` | :arrow_down: | | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `16.32% <0.00%> (-2.73%)` | :arrow_down: | | [...pl/consumer/ConsumeMessageConcurrentlyService.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZUNvbmN1cnJlbnRseVNlcnZpY2UuamF2YQ==) | `47.57% <0.00%> (-0.98%)` | :arrow_down: | | [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `59.06% <0.00%> (-0.94%)` | :arrow_down: | | [...ocketmq/broker/processor/SendMessageProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/3149/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache
[GitHub] [rocketmq] ni-ze opened a new pull request #3254: add new allocate MessageQueue strategy
ni-ze opened a new pull request #3254: URL: https://github.com/apache/rocketmq/pull/3254 add new strategy: AllocateMessageQueueByMachine allocate message queue to client which local in the same machine preferentially, if the result is null, use the second strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze opened a new issue #3255: add new allocate MessageQueue strategy
ni-ze opened a new issue #3255: URL: https://github.com/apache/rocketmq/issues/3255 add new strategy: AllocateMessageQueueByMachine allocate message queue to client which local in the same machine preferentially, if the result is null, use the second strategy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze removed a comment on issue #3252: the rocketmq_client.log file spent too much cache/buffer memory
ni-ze removed a comment on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897371476 can you give a way to repeat this? or just it will appear anyway? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze commented on issue #3252: the rocketmq_client.log file spent too much cache/buffer memory
ni-ze commented on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897586883 here cache/buffer has nothing to do with your jvm, it manage by os use it to to accelerate read/write. It would not affect rocketmq client work. Just ignore it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] ni-ze edited a comment on issue #3252: the rocketmq_client.log file spent too much cache/buffer memory
ni-ze edited a comment on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-897586883 here cache/buffer has nothing to do with your jvm, it manage by os, use it to accelerate read/write. It would not affect rocketmq client work. Just ignore it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-site] vongosling merged pull request #93: Add new committer yuz10
vongosling merged pull request #93: URL: https://github.com/apache/rocketmq-site/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] schnell18 opened a new pull request #3256: Ignore irrelevant commit log files on startup
schnell18 opened a new pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256 - Prevent irrelevant files under $storePathCommitLog failing startup - Make RocketMQ easy to operate and bring less surprise to average administrators **Make sure set the target branch to `develop`** ## What is the purpose of the change Make RocketMQ more tolerant to minor administrator mistake and reduce service outage in case less experienced admin create irrelevant files under $storePathCommitLog directory. ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test). - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] schnell18 opened a new issue #3257: Ignore irrelevant commit log files on startup
schnell18 opened a new issue #3257: URL: https://github.com/apache/rocketmq/issues/3257 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? Create an empty file under $storePathCommitLog directory. Say, you have commit log store under /data0/rocketmq/commitlogs/, then you create a file named 'the-bad-empty-file-fails-rocketmq-startup". Restart broker. Then the broker will not be able to startup normal. You may see error message like "the-bad-empty-file-fails-rocketmq-startup 0 length not matched message store value. please check it manually" in the storeerror.log. - What did you expect to see? Even in this case, RocketMQ broker should startup normally and log a warning message. - What did you see instead? RocketMQ broker does not startup and does not explain the reason clearly. 2. Please tell us about your environment: It's an ordinary CentOS 7.5 running Intel x86 chip on bare metal. 3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc): This suggestion is to ignore file length is not same as mappedFileSize which is 1G by default. Log a warning and continue to start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] francisoliverlee commented on issue #3257: Ignore irrelevant commit log files on startup
francisoliverlee commented on issue #3257: URL: https://github.com/apache/rocketmq/issues/3257#issuecomment-897773215 checked it on 4.8.0 , you are right. but data file not right is a FATAL ERROR, manually-check needed  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] francisoliverlee commented on issue #3255: add new allocate MessageQueue strategy
francisoliverlee commented on issue #3255: URL: https://github.com/apache/rocketmq/issues/3255#issuecomment-897784608 nice work. and what circumstanceses it used for you ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #3256: [ISSUE #3257] Ignore irrelevant commit log files on startup
coveralls commented on pull request #3256: URL: https://github.com/apache/rocketmq/pull/3256#issuecomment-897788933 [](https://coveralls.io/builds/42102638) Coverage increased (+0.09%) to 54.01% when pulling **c43e99c3a6318a474431fc88707f7fa393b5546f on schnell18:master** into **a20f31bb3de242756542c552d7212a7a4ba4 on apache:master**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] francisoliverlee commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
francisoliverlee commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-897795234 interesting idea and how do you want to do this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] francisoliverlee commented on issue #711: [bug] The Unsubscribe() interface influence retrytopic
francisoliverlee commented on issue #711: URL: https://github.com/apache/rocketmq-client-go/issues/711#issuecomment-897860121 ### as java client does in following files, client no need to Unsubscribe retry topic. > https://github.com/apache/rocketmq/blob/a20f31bb3de242756542c552d7212a7a4ba4/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java#L792 > https://github.com/apache/rocketmq/blob/a20f31bb3de242756542c552d7212a7a4ba4/client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java#L932 ## as checked broker codes, subscribtion for retry topic would never delete. broker update subscribtions on heartbeat: > https://github.com/apache/rocketmq/blob/a20f31bb3de242756542c552d7212a7a4ba4/broker/src/main/java/org/apache/rocketmq/broker/processor/ClientManageProcessor.java#L75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] francisoliverlee opened a new pull request #713: [fix issue 711] The Unsubscribe() interface influence retrytopic
francisoliverlee opened a new pull request #713: URL: https://github.com/apache/rocketmq-client-go/pull/713 ## What is the purpose of the change X ## Brief changelog XX ## Verifying this change Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`. - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists. - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] duhenglucky merged pull request #21: Try to remove branch protect
duhenglucky merged pull request #21: URL: https://github.com/apache/rocketmq-streams/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] 88888-IT commented on issue #3250: RocketMq is currently designed to have one or more consumequeues for each topic. Why not one or more consumequeues for each topic and tag
8-IT commented on issue #3250: URL: https://github.com/apache/rocketmq/issues/3250#issuecomment-898095819 > interesting idea and how do you want to do this ? If the producer registers the topic and tag with the broker before sending messages, the broker can create four queues for the topic and tag. Is it possible to load balance a queue when a producer sends a message and then send the message to it? I don't know if that's feasible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] wuyuan0717 commented on issue #3222: [question] Meaning of stats.log log output
wuyuan0717 commented on issue #3222: URL: https://github.com/apache/rocketmq/issues/3222#issuecomment-898099978 > 控制台上面的值是准确的，昨天一天的消息发送量。`BROKER_PUT_NUMS`你是用接口查询的嘛，如果是的话，那他是以当前时间为基础，过去24个小时的。是相对的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] zhxjdwh commented on issue #3252: the rocketmq_client.log file spent too much cache/buffer memory
zhxjdwh commented on issue #3252: URL: https://github.com/apache/rocketmq/issues/3252#issuecomment-898128055 @ni-ze I have 400 jvm processes running in k8s, and each pod that uses Rocketmq consumes 2-6 times more memory than other pods (k8s counts buffer/cache into the used memory), and excessive memory consumption leads to frequent pods Killed by k8s. I can only adjust logLevel to ERROR, so that it consumes less memory 我有400个jvm进程运行在k8s,每个有用到rocketmq的pod都会比其他pod多消耗2-6倍的内存(k8s把buffer/cache算到已用内存里面),内存消耗过多导致pod频繁被k8s杀死。 我现在只能把logLevel调整为ERROR，这样消耗内存就会少一点 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-spring] RongtongJin commented on issue #375: Transaction messages is not triggered
RongtongJin commented on issue #375: URL: https://github.com/apache/rocketmq-spring/issues/375#issuecomment-898131861 What version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] RonzL opened a new pull request #22: add module db-operator、transport-minio
RonzL opened a new pull request #22: URL: https://github.com/apache/rocketmq-streams/pull/22 Author:ronzl <1158402...@qq.com> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-client-go] RongtongJin commented on a change in pull request #712: (fix): fix push_consumer#unsubscribe unsubscribe retry
RongtongJin commented on a change in pull request #712:
URL: https://github.com/apache/rocketmq-client-go/pull/712#discussion_r688211430
##
File path: consumer/push_consumer.go
##
@@ -119,6 +119,9 @@ func NewPushConsumer(opts ...Option) (*pushConsumer, error)
{
p.interceptor = primitive.ChainInterceptors(p.option.Interceptors...)
+ retryTopic := internal.GetRetryTopic(p.consumerGroup)
+ sub := buildSubscriptionData(retryTopic, MessageSelector{TAG, _SubAll})
+ p.subscriptionDataTable.Store(retryTopic, sub)
Review comment:
Broadcast mode does not need to subscribe to retry topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [rocketmq] kingmax-yu commented on issue #3253: RockerMQ-4.7.1 storeerror.log reprot too many errorlog "WARN FlushConsumeQueueService - Offset not matched"
kingmax-yu commented on issue #3253: URL: https://github.com/apache/rocketmq/issues/3253#issuecomment-898157709 WARN FlushConsumeQueueService - Offset not matched. Request offset: 31800, firstOffset: 31200, lastOffset: 31800, mappedFileSize: 600, mappedFiles count: 1 2021-01-26 02:53:24 WARN ScheduleMessageTimerThread - Offset not matched. Request offset: 17928800, firstOffset: 1800, lastOffset: 2400, mappedFileSize: 600, mappedFiles count: 1 2021-01-27 22:50:07 WARN AdminBrokerThread_11 - Offset not matched. Request offset: 0, firstOffset: 1200, lastOffset: 1800, mappedFileSize: 600, mappedFiles count: 1 我统计了一下，一共有三种  也看了下源码，大致的意思就是 当前的offset超出了最后一个mappedfile的最大偏移量，或者是比第一个mappedfile的最大偏移量还要小，也就是说如果比第一个文件的最大偏移量小的话，就说明已经在这个文件中被写过了，那么超出第二个文件的最大偏移量会怎么样呢？不知道我理解的对不对。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-dashboard] vongosling opened a new issue #1: Are you using RocketMQ Dashboard?
vongosling opened a new issue #1: URL: https://github.com/apache/rocketmq-dashboard/issues/1 ## Are you using RocketMQ Dashboard? The state-of-the-art Dashboard of Apache RoccketMQ provides excellent monitoring capability. Various graphs and statistics of events, performance and system information of clients and application is evidently made available to the user. If you are using RocketMQ Dashboard, first we would like to Thank You. Here, we sincerely invite you to take a minute to feedback on your usage scenario. ## What we expect from you Pls. submit a comment in this issue to include the following information: • your company, school, or organization • your country and city • your contact info, such as email, WeChat, and Twitter (optional). • usage scenario • expectations(optional) You can refer to the following sample answer for the format: ``` * Organization: XX Company * Location: Seoul, South Korea * Contact: foo...@gmail.org * Version: v1.0.0 * Status: production * Expectations(optional): Integrated with RocketMQ Operator, support ``` Thanks again for your participation! Apache RocketMQ Community -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq-streams] vongosling opened a new issue #23: Are you using RocketMQ Streams?
vongosling opened a new issue #23: URL: https://github.com/apache/rocketmq-streams/issues/23 ## Are you using RocketMQ Streams? If you are using RocketMQ Streams, first we would like to Thank You. Here, we sincerely invite you to take a minute to feedback on your usage scenario. ## The purpose of this issue We are always interested in finding out who is using Streams, what attracted you to use it, how we can listen to your needs, and if you are interested, help promote your organization. ## What we would like from you Pls. submit a comment in this issue to include the following information: * your company, school, or organization * your country and city * your contact info, such as email, WeChat, and Twitter (optional). * usage scenario * expectations(optional) You can refer to the following sample answer for the format: ``` * Organization: XX Company * Location: Seoul, South Korea * Contact: foo...@gmail.org * Version: v1.0.0 * Status: production * Expectations(optional): Data ingest service ``` Thanks again for your participation! Apache RocketMQ Community -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Phoebus888 opened a new issue #3258: 生产关闭消息轨迹无效,
Phoebus888 opened a new issue #3258: URL: https://github.com/apache/rocketmq/issues/3258 traceTopicEnable=false traceOn=false 上面两个值我都改为false了,但是产生的主题RMQ_SYS_TRACE_TOPIC还是会产生大量消息造成集群压力负载 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] pirateskipper commented on issue #3258: 生产关闭消息轨迹无效,
pirateskipper commented on issue #3258: URL: https://github.com/apache/rocketmq/issues/3258#issuecomment-898199042 Please describe the version and related environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Phoebus888 commented on issue #3258: 生产关闭消息轨迹无效,
Phoebus888 commented on issue #3258: URL: https://github.com/apache/rocketmq/issues/3258#issuecomment-898200016 版本为V4_7_1 集群是双主双从 RMQ_SYS_TRACE_TOPIC路由到了一个节点上去,自动创建的  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Phoebus888 commented on issue #3258: 生产关闭消息轨迹无效,
Phoebus888 commented on issue #3258: URL: https://github.com/apache/rocketmq/issues/3258#issuecomment-898200222 > Please describe the version and related environment. 现在消息轨迹产生的tps很高 影响了生产环境了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [rocketmq] Phoebus888 commented on issue #3258: 生产关闭消息轨迹无效,
Phoebus888 commented on issue #3258: URL: https://github.com/apache/rocketmq/issues/3258#issuecomment-898201232 ./mqadmin updateBrokerConfig -b 10.44.1.251:11011 -k traceOn -v false 使用这个命令把所有节点都关闭了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@rocketmq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
