[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

2017-01-05 Thread shroman
Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 @zhouxinyu @iskl's concerns are valid indeed. My major concern is the logs can be lost when the system crashes. I think it's a good idea to discuss it in another JIRA issue. I

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

2017-01-05 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 It's our mistake. As @iskl says, we print gc logs to tmpfs in order to eliminate long time latency brought by disk I/O competition. IMO, we can merge this PR at current state,

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-rocketmq-site/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-rocketmq-site issue #3: Split 'Git setup' for contributors and com...

2017-01-05 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/3 Thanks, @shroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: Podling Report Reminder - January 2017

2017-01-05 Thread Justin Mclean
Hi, > 2) I don't believe that all mentors are required to sign off on the podling > report, but I'm not exactly sure. Mentor sign off is mostly in the low numbers particularly at this time of year. I wouldn’t be too concerned if you don’t get all the mentors signing off. 2 or 3 is a good

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

2017-01-05 Thread shroman
Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 yes, I see, you want to reduce disk I/O by placing the file into `/dev/shm`. Well, GC logging has a minimal overhead. And to get a high-performance broker, I would tune my JVM to

Re: Podling Report Reminder - January 2017

2017-01-05 Thread John D. Ament
Willem, Just added you. John On Thu, Jan 5, 2017 at 8:58 PM Willem Jiang wrote: > Hi Bruce, > > Could you grant the edit right to my wiki account (willemjiang)? > > Thanks, > > Willem Jiang > > Blog: http://willemjiang.blogspot.com (English) >

Re: Podling Report Reminder - January 2017

2017-01-05 Thread Willem Jiang
Hi Bruce, Could you grant the edit right to my wiki account (willemjiang)? Thanks, Willem Jiang Blog: http://willemjiang.blogspot.com (English) http://jnn.iteye.com (Chinese) Twitter: willemjiang Weibo: 姜宁willem On Tue, Jan 3, 2017 at 11:23 PM, Bruce Snyder

[GitHub] incubator-rocketmq issue #29: [ROCKETMQ-31] Fix "No such file or directory" ...

2017-01-05 Thread shroman
Github user shroman commented on the issue: https://github.com/apache/incubator-rocketmq/pull/29 I would fix `-Xloggc:/dev/shm/mq_gc_%p.log` to point to `$HOME` instead of removing these two lines ;) --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-rocketmq issue #8: [ROCKETMQ-32] Improve concision - Reuse local v...

2017-01-05 Thread naughtybear
Github user naughtybear commented on the issue: https://github.com/apache/incubator-rocketmq/pull/8 @vongosling Hi, new JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-32 Is that be Ok? --- If your project is set up for it, you can reply to this email and

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94743138 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified:

[GitHub] incubator-rocketmq pull request #28: [ROCKETMQ-27]Add store commitlog path o...

2017-01-05 Thread lizhanhui
GitHub user lizhanhui opened a pull request: https://github.com/apache/incubator-rocketmq/pull/28 [ROCKETMQ-27]Add store commitlog path online RocketMQ broker stores all messages before they are expired, which requires pretty much storage for a high load system. For now, the

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94738341 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94734427 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified:

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94733211 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94732917 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,45 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94732806 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified:

[GitHub] incubator-rocketmq issue #27: [ROCKETMQ-30] Fixed method signature for Messa...

2017-01-05 Thread zhouxinyu
Github user zhouxinyu commented on the issue: https://github.com/apache/incubator-rocketmq/pull/27 Cool, thanks @shroman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730828 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730662 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified:

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94730295 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified:

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread shroman
Github user shroman commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94729784 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: 2016-12-24T15:01:43-04:00

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread lizhanhui
Github user lizhanhui commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94729360 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified:

[GitHub] incubator-rocketmq-site issue #3: Split 'Git setup' for contributors and com...

2017-01-05 Thread vongosling
Github user vongosling commented on the issue: https://github.com/apache/incubator-rocketmq-site/pull/3 Alright. please @zhouxinyu @lizhanhui review again:-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-rocketmq-site pull request #3: Split 'Git setup' for contributors ...

2017-01-05 Thread vongosling
Github user vongosling commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq-site/pull/3#discussion_r94728311 --- Diff: _docs/06-best-practice-pull-request.md --- @@ -4,23 +4,40 @@ permalink: /docs/pull-request/ modified: